Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

Wire resetKey to tab refresh inputs, not a hard-coded tab name

Blue Mousef550463a3c80
diff --git a/web/app/pages/Project/tabs/Errors/ErrorsView.tsx b/web/app/pages/Project/tabs/Errors/ErrorsView.tsx
index 230e24acd..274e92ceb 100644
--- a/web/app/pages/Project/tabs/Errors/ErrorsView.tsx
+++ b/web/app/pages/Project/tabs/Errors/ErrorsView.tsx
@@ -568,8 +568,15 @@ function ErrorsDataResolver({
}
function ErrorsViewWrapper() {
+ const [searchParams] = useSearchParams()
+ const { errorsRefreshTrigger } = useRefreshTriggers()
+ const resetKey = `errors:${searchParams.toString()}:${errorsRefreshTrigger}`
+
return (
- <TabErrorBoundary titleKey='dashboard.failedToLoadErrors' resetKey='errors'>
+ <TabErrorBoundary
+ titleKey='dashboard.failedToLoadErrors'
+ resetKey={resetKey}
+ >
<Suspense fallback={<LoaderView />}>
<ErrorsDataResolver>
{(deferredData) => <ErrorsViewInner deferredData={deferredData} />}
diff --git a/web/app/pages/Project/tabs/Funnels/FunnelsView.tsx b/web/app/pages/Project/tabs/Funnels/FunnelsView.tsx
index 8a630d5e2..482f0749b 100644
--- a/web/app/pages/Project/tabs/Funnels/FunnelsView.tsx
+++ b/web/app/pages/Project/tabs/Funnels/FunnelsView.tsx
@@ -99,6 +99,7 @@ const FunnelsView = ({ tnMapping }: FunnelsViewProps) => {
const funnelActionLoading = fetcher.state !== 'idle'
const analyticsLoading = revalidator.state === 'loading'
const hasFunnels = !_isEmpty(project?.funnels)
+ const resetKey = `funnels:${searchParams.toString()}:${funnelsRefreshTrigger}`
const clearActiveFunnel = useCallback(() => {
const nextSearchParams = new URLSearchParams(searchParams.toString())
@@ -260,7 +261,7 @@ const FunnelsView = ({ tnMapping }: FunnelsViewProps) => {
return (
<TabErrorBoundary
titleKey='dashboard.failedToLoadFunnels'
- resetKey='funnels'
+ resetKey={resetKey}
>
<DashboardHeader
showLiveVisitors
diff --git a/web/app/pages/Project/tabs/Performance/PerformanceView.tsx b/web/app/pages/Project/tabs/Performance/PerformanceView.tsx
index 8d910b597..b00d5db8e 100644
--- a/web/app/pages/Project/tabs/Performance/PerformanceView.tsx
+++ b/web/app/pages/Project/tabs/Performance/PerformanceView.tsx
@@ -119,10 +119,14 @@ function PerfDataResolver({
}
function PerformanceViewWrapper(props: PerformanceViewProps) {
+ const [searchParams] = useSearchParams()
+ const { performanceRefreshTrigger } = useRefreshTriggers()
+ const resetKey = `performance:${searchParams.toString()}:${performanceRefreshTrigger}`
+
return (
<TabErrorBoundary
titleKey='dashboard.failedToLoadPerformance'
- resetKey='performance'
+ resetKey={resetKey}
>
<Suspense fallback={<LoaderView />}>
<PerfDataResolver>
diff --git a/web/app/pages/Project/tabs/Replays/ReplaysView.tsx b/web/app/pages/Project/tabs/Replays/ReplaysView.tsx
index c799ed3f8..751d3657b 100644
--- a/web/app/pages/Project/tabs/Replays/ReplaysView.tsx
+++ b/web/app/pages/Project/tabs/Replays/ReplaysView.tsx
@@ -80,10 +80,14 @@ const getReplayMetadata = (
})
function ReplaysViewWrapper(props: ReplaysViewProps) {
+ const [searchParams] = useSearchParams()
+ const { replaysRefreshTrigger } = useRefreshTriggers()
+ const resetKey = `replays:${searchParams.toString()}:${replaysRefreshTrigger}`
+
return (
<TabErrorBoundary
titleKey='dashboard.failedToLoadReplays'
- resetKey='replays'
+ resetKey={resetKey}
>
<Suspense fallback={<LoaderView />}>
<ReplaysDataResolver>
diff --git a/web/app/pages/Project/tabs/SEO/SEOView.tsx b/web/app/pages/Project/tabs/SEO/SEOView.tsx
index 4f9bbe95f..1eec0264e 100644
--- a/web/app/pages/Project/tabs/SEO/SEOView.tsx
+++ b/web/app/pages/Project/tabs/SEO/SEOView.tsx
@@ -1179,8 +1179,12 @@ const SEOViewInner = ({ projectId, tnMapping }: SEOViewProps) => {
}
const SEOView = ({ projectId, tnMapping }: SEOViewProps) => {
+ const [searchParams] = useSearchParams()
+ const { seoRefreshTrigger } = useRefreshTriggers()
+ const resetKey = `seo:${projectId}:${searchParams.toString()}:${seoRefreshTrigger}`
+
return (
- <TabErrorBoundary titleKey='dashboard.failedToLoadSeo' resetKey='seo'>
+ <TabErrorBoundary titleKey='dashboard.failedToLoadSeo' resetKey={resetKey}>
<React.Suspense
fallback={
<div className='flex min-h-[400px] items-center justify-center'>
diff --git a/web/app/pages/Project/tabs/Sessions/SessionsView.tsx b/web/app/pages/Project/tabs/Sessions/SessionsView.tsx
index da8c4e474..c3d9e8763 100644
--- a/web/app/pages/Project/tabs/Sessions/SessionsView.tsx
+++ b/web/app/pages/Project/tabs/Sessions/SessionsView.tsx
@@ -86,10 +86,14 @@ function SessionsDataResolver({
}
function SessionsViewWrapper(props: SessionsViewProps) {
+ const [searchParams] = useSearchParams()
+ const { sessionsRefreshTrigger } = useRefreshTriggers()
+ const resetKey = `sessions:${searchParams.toString()}:${sessionsRefreshTrigger}`
+
return (
<TabErrorBoundary
titleKey='dashboard.failedToLoadSessions'
- resetKey='sessions'
+ resetKey={resetKey}
>
<Suspense fallback={<LoaderView />}>
<SessionsDataResolver>
diff --git a/web/app/pages/Project/tabs/Traffic/TrafficView.tsx b/web/app/pages/Project/tabs/Traffic/TrafficView.tsx
index 98ebeac45..656886671 100644
--- a/web/app/pages/Project/tabs/Traffic/TrafficView.tsx
+++ b/web/app/pages/Project/tabs/Traffic/TrafficView.tsx
@@ -216,10 +216,14 @@ function HasImportedIndicator() {
}
function TrafficViewWrapper(props: TrafficViewProps) {
+ const [searchParams] = useSearchParams()
+ const { trafficRefreshTrigger } = useRefreshTriggers()
+ const resetKey = `traffic:${searchParams.toString()}:${trafficRefreshTrigger}`
+
return (
<TabErrorBoundary
titleKey='dashboard.failedToLoadTraffic'
- resetKey='traffic'
+ resetKey={resetKey}
>
<Suspense fallback={<LoaderView />}>
<TrafficDataResolver>