Skip to content

📈 Open source, privacy-first web analytics — a cookie-less Google Analytics alternative with built-in error tracking and performance monitoring. Self-host it or use our cloud. Get started for free!

fix: Relax .zip file checks

Blue Mousefbb7ac7a6df8
diff --git a/backend/apps/cloud/src/data-import/mappers/umami.mapper.ts b/backend/apps/cloud/src/data-import/mappers/umami.mapper.ts
index 99fc7a3fd..038ce257f 100644
--- a/backend/apps/cloud/src/data-import/mappers/umami.mapper.ts
+++ b/backend/apps/cloud/src/data-import/mappers/umami.mapper.ts
@@ -207,18 +207,10 @@ export class UmamiMapper implements ImportMapper {
foundEntry = true
if (
- typeof file.originalSize !== 'number' ||
- !Number.isFinite(file.originalSize)
+ typeof file.originalSize === 'number' &&
+ Number.isFinite(file.originalSize) &&
+ file.originalSize > MAX_UMAMI_CSV_BYTES
) {
- fail(
- new ImportError(
- `Unable to validate ${WEBSITE_EVENT_CSV} size in the ZIP archive.`,
- ),
- )
- return
- }
-
- if (file.originalSize > MAX_UMAMI_CSV_BYTES) {
fail(
new ImportError(
`${WEBSITE_EVENT_CSV} exceeds the ${MAX_UMAMI_CSV_BYTES} byte limit.`,
diff --git a/backend/apps/community/src/data-import/mappers/umami.mapper.ts b/backend/apps/community/src/data-import/mappers/umami.mapper.ts
index a1158230b..aa152e8aa 100644
--- a/backend/apps/community/src/data-import/mappers/umami.mapper.ts
+++ b/backend/apps/community/src/data-import/mappers/umami.mapper.ts
@@ -203,18 +203,10 @@ export class UmamiMapper implements ImportMapper {
foundEntry = true
if (
- typeof file.originalSize !== 'number' ||
- !Number.isFinite(file.originalSize)
+ typeof file.originalSize === 'number' &&
+ Number.isFinite(file.originalSize) &&
+ file.originalSize > MAX_UMAMI_CSV_BYTES
) {
- fail(
- new Error(
- `Unable to validate ${WEBSITE_EVENT_CSV} size in the ZIP archive.`,
- ),
- )
- return
- }
-
- if (file.originalSize > MAX_UMAMI_CSV_BYTES) {
fail(
new Error(
`${WEBSITE_EVENT_CSV} exceeds the ${MAX_UMAMI_CSV_BYTES} byte limit.`,