Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

Let the Helm chart put switch-core on chosen nodes (CHOO-3667) (#1190)

Abel Dantas092590eee672
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fd3831dba..0763b72ce 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -85,6 +85,11 @@ version of their own to them without also giving them a release of their own.
Now a room the runner cannot read reads as missing.
#### Added
+- **The Helm chart can put switch-core on chosen nodes.**
+ `switchCore.nodeSelector` and `switchCore.tolerations` go onto the
+ switch-core pods as written, so they can run on a node group of their own,
+ such as one kept for load tests. Both are empty by default, which places the
+ pods as before.
- **The `[CONN]` log lines say when a client fell back to the event stream.**
`/events` takes optional `fallback` and `fallback_close_code` parameters,
and the `[CONN] opened` and `[CONN] reattached` lines end with
diff --git a/deploy/remote/helm/switch/templates/switch-core/deployment.yaml b/deploy/remote/helm/switch/templates/switch-core/deployment.yaml
index 3ef838d76..1506772a6 100644
--- a/deploy/remote/helm/switch/templates/switch-core/deployment.yaml
+++ b/deploy/remote/helm/switch/templates/switch-core/deployment.yaml
@@ -57,6 +57,14 @@ spec:
matchLabels:
{{- include "switch.selectorLabels" (dict "Release" .Release "component" "switch-core") | nindent 14 }}
{{- end }}
+ {{- with .Values.switchCore.nodeSelector }}
+ nodeSelector:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
+ {{- with .Values.switchCore.tolerations }}
+ tolerations:
+ {{- toYaml . | nindent 8 }}
+ {{- end }}
initContainers:
{{- include "switch.waitFor" (dict "name" "postgres" "host" (include "switch.postgresHost" .) "port" (include "switch.postgresPort" .)) | nindent 8 }}
# Migrates and re-issues grants as the schema owner, so the serving
diff --git a/deploy/remote/helm/switch/values.yaml b/deploy/remote/helm/switch/values.yaml
index 0924b8e26..6fd033211 100644
--- a/deploy/remote/helm/switch/values.yaml
+++ b/deploy/remote/helm/switch/values.yaml
@@ -714,6 +714,15 @@ switchCore:
maxSkew: 1
topologyKey: kubernetes.io/hostname
whenUnsatisfiable: ScheduleAnyway
+ # Which nodes the switch-core pods may run on. Empty, they go wherever the
+ # cluster has room. To keep them to nodes of their own, label and taint those
+ # nodes and match both here, e.g. a load test on a node group that carries
+ # `workload: loadtest` and the taint `loadtest=true:NoSchedule`:
+ # nodeSelector: {workload: loadtest}
+ # tolerations:
+ # - {key: loadtest, operator: Equal, value: "true", effect: NoSchedule}
+ nodeSelector: {}
+ tolerations: []
# How long the kubelet waits after SIGTERM before killing the pod. On SIGTERM
# switch-core hands the bridges and readers it owns to the other
# pods (up to 10s), releases its lease (up to 1s), keeps serving for 5s while