Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

Merge remote-tracking branch 'origin/recheck-connections' into scale-core

Abel Dantas295ef8519447
diff --cc CHANGELOG.md
index a3e85e489,d9e0c9c23..904939300
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@@ -315,34 -236,24 +315,52 @@@ version of their own to them without al
group whose subgroup would move up next to a namesake is refused too, and
the dashboard now shows why. Names can no longer contain `/` or be blank.
Existing duplicates are left as they are and can be reached by id.
+- **Delivering an event to an agent behind a controller no longer reads the
+ agent's head first.** The notification of a new agent event already carries
+ its number, and the controller's stream now keeps it as the agent's head, so
+ a delivery costs the agent's own read alone, where it read the heads of all
+ the controller's agents first. The heads are still read after each idle
+ interval, when an agent is attached, and after the listener reconnects.
+- **Delivering an event to an agent costs three statements, where it cost
+ seven.** The rooms dropped after the agent's cursor are read with its
+ events, and the unread count reads the agent's baseline, the room's window
+ and the agent's user id in the statement that counts.
+- **Writing a message no longer costs four statements for each agent it is
+ for.** The agents' own events are stored together, in two statements and
+ one savepoint, where each agent's event took a savepoint, a numbering, an
+ insert and a release of its own.
+- **A controller's stream waits on three events, where it waited on one per
+ agent and two more.** Every attached agent's doorbell now rings the stream's
+ one bell.
+- **Reading an agent's own events no longer builds its query each time.**
+ Each shape of the read is built once and run with bind parameters.
+- **A message addressed to a connected agent no longer reads the agent's
+ membership after it commits.** That read stops an agent removed from the
+ room in the meantime from saying anything there, and a connected agent has
+ nothing to say about a message addressed to it, so the read is now made only
+ before a refusal or an offline notice is posted, or a machine woken.
+- **Message telemetry reads a workspace's rooms, clients and agents at once.**
+ The first lookup that misses reads all of them, where each room, sender and
+ agent was read on its own, so in a large workspace most messages no longer
+ cost a lookup.
+ - **Registering, renaming or deleting an agent no longer makes every process
+ read every client and agent.** The change now names the clients it touched,
+ and each process reads only those, where it read every client of the
+ workspace and, with a messaging app connected, every agent as well. The
+ 30-second re-check reads every client only when a fingerprint of the
+ workspace's clients and agents has changed since its last full read, where
+ it read them all every time.
+ - **The 30-second re-check of which controller runs each agent reads one
+ query, and nothing when no placement changed.** Every process read every
+ placed agent's definition, document included, then each controller with a
+ query of its own. It now reads the columns a binding is made of in one
+ query per workspace, and only when a fingerprint of the placements has
+ changed since its last full read.
+ - **The 30-second re-check of who holds each controller's socket no longer
+ reads every controller each time.** It compares a fingerprint of their
+ connections and of the live processes first, and when it reads, reads only
+ the connection columns, where it read every row with its status and
+ platform, and the rooms of every agent on a controller another process held.
#### Fixed
- **On Slack, the 👀 and the activity card no longer arrive after the agent's
diff --cc core/switch_core/clients/client_lifecycle_service.py
index aa30e13e5,03553a872..245e91cac
--- a/core/switch_core/clients/client_lifecycle_service.py
+++ b/core/switch_core/clients/client_lifecycle_service.py
@@@ -433,10 -515,9 +523,10 @@@ class ClientLifecycleService
actor = self._register(record)
if agent is not None and isinstance(actor, _PreloadsAgent):
actor.preload_agent(agent)
+ self._agent_seen(record.id, agent.id)
- agents_changed |= agent is not None
- if agents_changed:
- self._agents_changed(tenant_id)
+ if agent is not None:
+ changed.add(record.id)
+ return changed
async def _agents_by_client_id(self, records: list[Client]) -> dict[str, Agent]:
"""The agent row behind each client, one query per tenant.
diff --cc core/switch_core/management/signals.py
index 023054199,c1850800a..d3315a7c0
--- a/core/switch_core/management/signals.py
+++ b/core/switch_core/management/signals.py
@@@ -316,15 -361,18 +361,15 @@@ class ControllerSignals
here, and the stream that loads them runs over there."""
if self._held_elsewhere(controller, leases) is None:
return {}
- return {
- agent_id: {
- room.id
- for room in await self._rooms.get_rooms_for_agent(
- session, agent_id, include_archived=True
- )
- }
- for agent_id in sorted(self._presence.agents_of(controller.id))
- }
+ # One query for all of them: every process re-reads this for every
+ # controller another process holds at each re-check, so a query per
+ # agent would grow with processes times agents.
+ return await self._rooms.room_ids_by_agent(
+ session, self._presence.agents_of(controller.id)
+ )
def _held_elsewhere(
- self, controller: AgentController, leases: ProcessLeases
+ self, controller: AgentController | ControllerConnection, leases: ProcessLeases
) -> str | None:
"""The other process holding the controller's live socket, if any."""
process_id = controller.connection_process_id