Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

fix(console): forget a moved agent once its server no longer lists it

raullopez-sandbox3b5ce6ebb6b5
diff --git a/console/apps/switch-console-desktop/src/main/core/managed-agents/controller.ts b/console/apps/switch-console-desktop/src/main/core/managed-agents/controller.ts
index e9bff4e4e..e982a62ff 100644
--- a/console/apps/switch-console-desktop/src/main/core/managed-agents/controller.ts
+++ b/console/apps/switch-console-desktop/src/main/core/managed-agents/controller.ts
@@ -6,6 +6,8 @@ import {
vertexLoginCredential,
} from '@switch-console/agent-providers';
import { agentMigrationService } from '@main/core/agent-migration/agent-migration';
+import { listManagedAgentRecords } from '@main/core/agent-migration/managed-agents-store';
+import { deleteAgent as deleteConsoleAgent } from '@main/core/agents/deleteAgent';
import { embeddedControllerService } from '@main/core/embedded-controller/embedded-controllers';
import { hostControllerService } from '@main/core/host-controllers/host-controllers';
import {
@@ -44,6 +46,7 @@ import type {
} from '@shared/core/managed-agents/managed-agents';
import type { AgentProviderId } from '@shared/core/providers/agent-provider-registry';
import { createRPCController } from '@shared/lib/ipc/rpc';
+import { forgetDeletedManagedAgents } from './forget-deleted';
import { ownedMachines, preferredFirst, thisComputerReport } from './owned-machines';
async function machinesOn(serverId: string): Promise<OwnedMachine[] | null> {
@@ -91,6 +94,22 @@ export const managedAgentsController = createRPCController({
if (error instanceof AgentManagementUnavailableError) return null;
throw error;
}
+ // The list came back: a moved agent missing from it was deleted on the server.
+ await forgetDeletedManagedAgents(
+ workspace.id,
+ new Set(agents.map((agent) => agent.agentId)),
+ {
+ records: listManagedAgentRecords,
+ forget: (consoleAgentId) =>
+ deleteConsoleAgent(consoleAgentId, {
+ deleteInSwitch: false,
+ removeProvisionedFiles: false,
+ trigger: 'server_teardown',
+ }),
+ warn: (message, context) => log.warn(message, context),
+ now: Date.now,
+ }
+ );
return agents.map((agent): ManagedAgentView => {
const machine =
agent.machine !== undefined
diff --git a/console/apps/switch-console-desktop/src/main/core/managed-agents/forget-deleted.test.ts b/console/apps/switch-console-desktop/src/main/core/managed-agents/forget-deleted.test.ts
new file mode 100644
index 000000000..301f4f403
--- /dev/null
+++ b/console/apps/switch-console-desktop/src/main/core/managed-agents/forget-deleted.test.ts
@@ -0,0 +1,68 @@
+import { describe, expect, it, vi } from 'vitest';
+import type { ManagedAgentRecord } from '@main/core/agent-migration/managed-agents-store';
+import { forgetDeletedManagedAgents, RECENT_MOVE_GRACE_MS } from './forget-deleted';
+
+const NOW = Date.parse('2026-10-27T12:00:00Z');
+
+const record = (
+ agentId: string,
+ switchAgentId: string,
+ movedAgoMs: number,
+ workspaceId = 'ws'
+): ManagedAgentRecord => ({
+ agentId,
+ workspaceId,
+ controllerId: 'controller',
+ placement: { kind: 'this-computer', serverId: 'srv' },
+ identities: [
+ {
+ switchAgentId,
+ slug: agentId,
+ subagent: null,
+ credentialsStashed: false,
+ controllerRoot: '~/agents',
+ },
+ ],
+ movedAt: new Date(NOW - movedAgoMs).toISOString(),
+});
+
+function deps(records: ManagedAgentRecord[]) {
+ return {
+ records: async () => records,
+ forget: vi.fn(async () => {}),
+ warn: vi.fn(),
+ now: () => NOW,
+ };
+}
+
+describe('forgetDeletedManagedAgents', () => {
+ it('forgets a moved agent the server no longer lists, and keeps the listed ones', async () => {
+ const calls = deps([
+ record('console-gone', 'switch-gone', 60 * 60_000),
+ record('console-kept', 'switch-kept', 60 * 60_000),
+ ]);
+ await forgetDeletedManagedAgents('ws', new Set(['switch-kept']), calls);
+ expect(calls.forget).toHaveBeenCalledTimes(1);
+ expect(calls.forget).toHaveBeenCalledWith('console-gone');
+ });
+
+ it('leaves another workspace’s agents and one moved moments ago', async () => {
+ const calls = deps([
+ record('other-ws', 'switch-a', 60 * 60_000, 'ws-2'),
+ record('just-moved', 'switch-b', RECENT_MOVE_GRACE_MS / 2),
+ ]);
+ await forgetDeletedManagedAgents('ws', new Set(), calls);
+ expect(calls.forget).not.toHaveBeenCalled();
+ });
+
+ it('logs one that cannot be forgotten and goes on with the rest', async () => {
+ const calls = deps([
+ record('a', 'switch-a', 60 * 60_000),
+ record('b', 'switch-b', 60 * 60_000),
+ ]);
+ calls.forget.mockRejectedValueOnce(new Error('locked'));
+ await forgetDeletedManagedAgents('ws', new Set(), calls);
+ expect(calls.forget).toHaveBeenCalledTimes(2);
+ expect(calls.warn).toHaveBeenCalledOnce();
+ });
+});
diff --git a/console/apps/switch-console-desktop/src/main/core/managed-agents/forget-deleted.ts b/console/apps/switch-console-desktop/src/main/core/managed-agents/forget-deleted.ts
new file mode 100644
index 000000000..f91ffab26
--- /dev/null
+++ b/console/apps/switch-console-desktop/src/main/core/managed-agents/forget-deleted.ts
@@ -0,0 +1,53 @@
+import type { ManagedAgentRecord } from '@main/core/agent-migration/managed-agents-store';
+
+/** How long after a move an agent may be missing from the list without being forgotten. */
+export const RECENT_MOVE_GRACE_MS = 2 * 60_000;
+
+/**
+ * The Console agents moved to management in a workspace that its server no
+ * longer lists: deleted there, from another device or while this Console was
+ * closed. Only a list the server actually returned counts as proof; an agent
+ * moved moments ago may not be listed yet and is left alone.
+ */
+export function goneManagedRecords(
+ records: readonly ManagedAgentRecord[],
+ workspaceId: string,
+ listedAgentIds: ReadonlySet<string>,
+ now: number
+): ManagedAgentRecord[] {
+ return records.filter(
+ (record) =>
+ record.workspaceId === workspaceId &&
+ !listedAgentIds.has(record.identities[0].switchAgentId) &&
+ now - Date.parse(record.movedAt) > RECENT_MOVE_GRACE_MS
+ );
+}
+
+/**
+ * Forgets the moved agents the server no longer lists, so their old Console
+ * rows stop showing as agents. A failure to forget one is logged by the caller
+ * and leaves the rest to be tried.
+ */
+export async function forgetDeletedManagedAgents(
+ workspaceId: string,
+ listedAgentIds: ReadonlySet<string>,
+ deps: {
+ records: () => Promise<ManagedAgentRecord[]>;
+ forget: (consoleAgentId: string) => Promise<void>;
+ warn: (message: string, context: Record<string, unknown>) => void;
+ now: () => number;
+ }
+): Promise<void> {
+ const gone = goneManagedRecords(await deps.records(), workspaceId, listedAgentIds, deps.now());
+ for (const record of gone) {
+ try {
+ await deps.forget(record.agentId);
+ } catch (error) {
+ deps.warn('Could not forget an agent its server no longer lists', {
+ event: 'managed_agent_forget_failed',
+ agentId: record.agentId,
+ error: String(error),
+ });
+ }
+ }
+}
diff --git a/console/apps/switch-console-desktop/src/main/core/managed-agents/give-machine-login.test.ts b/console/apps/switch-console-desktop/src/main/core/managed-agents/give-machine-login.test.ts
index ff5853a5f..8ec053fad 100644
--- a/console/apps/switch-console-desktop/src/main/core/managed-agents/give-machine-login.test.ts
+++ b/console/apps/switch-console-desktop/src/main/core/managed-agents/give-machine-login.test.ts
@@ -21,6 +21,10 @@ const mocks = vi.hoisted(() => ({
}));
vi.mock('@main/core/agent-migration/agent-migration', () => ({ agentMigrationService: {} }));
+vi.mock('@main/core/agent-migration/managed-agents-store', () => ({
+ listManagedAgentRecords: async () => [],
+}));
+vi.mock('@main/core/agents/deleteAgent', () => ({ deleteAgent: vi.fn() }));
vi.mock('@main/lib/logger', () => ({ log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() } }));
vi.mock('@main/core/embedded-controller/embedded-controllers', () => ({
embeddedControllerService: {},
diff --git a/console/apps/switch-console-desktop/src/main/core/managed-agents/list-reconcile.test.ts b/console/apps/switch-console-desktop/src/main/core/managed-agents/list-reconcile.test.ts
new file mode 100644
index 000000000..ba324ae61
--- /dev/null
+++ b/console/apps/switch-console-desktop/src/main/core/managed-agents/list-reconcile.test.ts
@@ -0,0 +1,108 @@
+import { beforeEach, describe, expect, it, vi } from 'vitest';
+
+const mocks = vi.hoisted(() => ({
+ fetchManagedAgents: vi.fn(),
+ deleteConsoleAgent: vi.fn(async () => {}),
+ records: vi.fn(),
+}));
+
+vi.mock('@main/core/agent-migration/agent-migration', () => ({ agentMigrationService: {} }));
+vi.mock('@main/core/agent-migration/managed-agents-store', () => ({
+ listManagedAgentRecords: mocks.records,
+}));
+vi.mock('@main/core/agents/deleteAgent', () => ({ deleteAgent: mocks.deleteConsoleAgent }));
+vi.mock('@main/lib/logger', () => ({ log: { warn: vi.fn(), error: vi.fn(), info: vi.fn() } }));
+vi.mock('@main/core/embedded-controller/embedded-controllers', () => ({
+ embeddedControllerService: {},
+}));
+vi.mock('@main/core/host-controllers/host-controllers', () => ({ hostControllerService: {} }));
+vi.mock('@main/core/workspaces/workspaces-store', () => ({
+ requireWorkspaceForServer: async () => ({ id: 'ws' }),
+}));
+vi.mock('@main/core/workspaces/workspace-session', () => ({
+ withReachableServerWorkspaceSession: (_serverId: string, run: (server: unknown) => unknown) =>
+ run({ id: 'server-1', url: 'https://switch.example.com' }),
+}));
+vi.mock('@main/core/switch-servers/local-provider-sign-in', () => ({
+ localProviderAuthPath: () => '',
+ readLocalProviderSignIn: vi.fn(),
+}));
+vi.mock('@main/core/switch-servers/gateway-client', () => ({
+ AgentManagementUnavailableError: class extends Error {},
+ GatewayError: class extends Error {},
+ deleteAgent: vi.fn(),
+ deleteManagedAgent: vi.fn(),
+ fetchAdvancedConfigSchema: vi.fn(),
+ fetchManagedAgents: mocks.fetchManagedAgents,
+ managementErrorMessage: vi.fn(),
+ setManagedAgentDesiredState: vi.fn(),
+ updateManagedAgent: vi.fn(),
+ fetchManagementControllers: vi.fn(async () => []),
+ giveMachineLogin: vi.fn(),
+ fetchMachineOperation: vi.fn(),
+}));
+
+const { managedAgentsController } = await import('./controller');
+
+const moved = (agentId: string, switchAgentId: string) => ({
+ agentId,
+ workspaceId: 'ws',
+ controllerId: 'controller',
+ placement: { kind: 'this-computer', serverId: 'server-1' },
+ identities: [
+ {
+ switchAgentId,
+ slug: agentId,
+ subagent: null,
+ credentialsStashed: false,
+ controllerRoot: '~',
+ },
+ ],
+ movedAt: '2026-01-01T00:00:00Z',
+});
+
+const listed = (agentId: string) => ({
+ agentId,
+ name: agentId,
+ displayName: null,
+ iconUrl: null,
+ description: '',
+ machine: null,
+ controllerId: null,
+ desiredState: 'running',
+ revision: 1,
+ provider: 'claude',
+ model: null,
+ advancedConfig: {},
+ instructions: '',
+ autoMode: false,
+ autoApprove: false,
+ directory: null,
+ isolation: 'shared',
+ status: null,
+});
+
+beforeEach(() => {
+ vi.clearAllMocks();
+ mocks.records.mockResolvedValue([moved('console-gone', 'gone'), moved('console-kept', 'kept')]);
+});
+
+describe('listing managed agents', () => {
+ it('forgets on load a moved agent deleted on the server, and only that one', async () => {
+ mocks.fetchManagedAgents.mockResolvedValue([listed('kept')]);
+ const agents = await managedAgentsController.list('server-1');
+ expect(agents?.map((agent) => agent.agentId)).toEqual(['kept']);
+ expect(mocks.deleteConsoleAgent).toHaveBeenCalledTimes(1);
+ expect(mocks.deleteConsoleAgent).toHaveBeenCalledWith('console-gone', {
+ deleteInSwitch: false,
+ removeProvisionedFiles: false,
+ trigger: 'server_teardown',
+ });
+ });
+
+ it('forgets nothing when the list could not be read', async () => {
+ mocks.fetchManagedAgents.mockRejectedValue(new Error('unreachable'));
+ await expect(managedAgentsController.list('server-1')).rejects.toThrow('unreachable');
+ expect(mocks.deleteConsoleAgent).not.toHaveBeenCalled();
+ });
+});