Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

Room resources: a package opens its page only for a viewer who may open it

Simon Flack5cc93727e32d
diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-resources-panel.tsx b/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-resources-panel.tsx
index aaa00b7d4..30b2b1d74 100644
--- a/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-resources-panel.tsx
+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-resources-panel.tsx
@@ -205,8 +205,11 @@ const ResourceSection = observer(function ResourceSection({
? () => void openExternalUrl(resource.urls[0]!, 'Could not open the link')
: kind === 'documents'
? () => setReading(resource)
- : // A package has nothing to read here: its page shows what it holds.
- kind === 'packages' && serverId !== null
+ : // A package has nothing to read here: its page shows what it holds,
+ // when the viewer may open it (the server says per package).
+ kind === 'packages' &&
+ serverId !== null &&
+ opensInResources(resource, viewer)
? () =>
navigate('libraryItem', {
serverId,
diff --git a/console/apps/switch-console-desktop/src/renderer/tests/browser/room-resources-panel.test.tsx b/console/apps/switch-console-desktop/src/renderer/tests/browser/room-resources-panel.test.tsx
index feab8aea7..60cca7db3 100644
--- a/console/apps/switch-console-desktop/src/renderer/tests/browser/room-resources-panel.test.tsx
+++ b/console/apps/switch-console-desktop/src/renderer/tests/browser/room-resources-panel.test.tsx
@@ -301,4 +301,16 @@ describe('the Resources tab', () => {
expect(row).toBeUndefined();
expect(navigate).not.toHaveBeenCalled();
});
+
+ it('opens no page for a package its owner keeps private', async () => {
+ listRoomResources.mockImplementation(async ({ kind }: { kind: keyof typeof RESOURCES }) =>
+ kind === 'packages' ? [{ ...RESOURCES.packages[0], canRead: false }] : RESOURCES[kind]
+ );
+ const el = await renderPanel();
+ const row = [...el.querySelectorAll('[aria-label="Packages"] button')].find((b) =>
+ b.textContent?.includes('Onboarding')
+ );
+ expect(row).toBeUndefined();
+ expect(el.querySelector('[aria-label="Packages"]')?.textContent).toContain('Onboarding');
+ });
});