Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.
Python agent-orchestrationaiai-agentschatopsdiscordlangchainmcpmicrosoft-teamsmulti-agentopen-sourceopenaiself-hostedslack
fix(console): keep the bundled-chat sign-in dialog on screen, and stop pointing at a deleted server (#259)
Louis Amaudruz6b9149cf6038
diff --git a/CHANGELOG.md b/CHANGELOG.mdindex d8d75f60e..e01c6107d 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -659,6 +659,18 @@ version of their own to them without also giving them a release of their own.### [Unreleased]+#### Fixed++- **Sign-in details** for a managed server's bundled chat now stays open. The+ dialog was rendered inside the messaging app's dropdown menu, so the same+ click that opened it closed the menu — and the menu took the dialog with it,+ before anyone could read a credential off it.+- Deleting a Switch server no longer leaves the app pointed at it. The deleted+ server's id survived in the saved page state, so the app could return to a+ page for a server that no longer exists and keep asking its gateway for a+ sign-in configuration nothing could answer. The page now falls back to home+ and the dead id is discarded.+### [0.27.2] - 2026-08-18#### Addeddiff --git a/console/apps/switch-console-desktop/src/renderer/app/modal-registry.ts b/console/apps/switch-console-desktop/src/renderer/app/modal-registry.tsindex 907badd86..ee1720368 100644--- a/console/apps/switch-console-desktop/src/renderer/app/modal-registry.ts+++ b/console/apps/switch-console-desktop/src/renderer/app/modal-registry.ts@@ -11,6 +11,7 @@ import { AddAgentToRoomsModal } from '@renderer/features/switch-rooms/AddAgentToimport { DeleteRoomModal } from '@renderer/features/switch-rooms/DeleteRoomModal';import { AddServerModal } from '@renderer/features/switch-servers/AddServerModal';import { AssignServerModal } from '@renderer/features/switch-servers/assign-server-modal';+import { BundledChatSignInModal } from '@renderer/features/switch-servers/BundledChatSignIn';import { ClaimIdentityModal } from '@renderer/features/switch-servers/ClaimIdentityModal';import { ConnectMessagingAppModal } from '@renderer/features/switch-servers/ConnectMessagingAppModal';import { CreateRoomModal } from '@renderer/features/switch-servers/CreateRoomModal';@@ -76,6 +77,7 @@ export const modalRegistry = {size: 'md',dismissOnOutsideClick: false,}),+ bundledChatSignInModal: createModal(BundledChatSignInModal, { size: 'sm' }),disconnectMessagingAppModal: createModal(DisconnectMessagingAppModal, {size: 'sm',dismissOnOutsideClick: false,diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/BundledChatSignIn.tsx b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/BundledChatSignIn.tsxindex ddc4f6314..a3c20cc77 100644--- a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/BundledChatSignIn.tsx+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/BundledChatSignIn.tsx@@ -1,22 +1,19 @@import { useQuery } from '@tanstack/react-query';-import { Check, Copy, ExternalLink, Eye, EyeOff, KeyRound } from 'lucide-react';+import { Check, Copy, ExternalLink, Eye, EyeOff } from 'lucide-react';import { useCallback, useState } from 'react';import { BridgeIcon } from '@renderer/lib/components/bridge-icon';import { failureText } from '@renderer/lib/errors/describe-failure';import { rpc } from '@renderer/lib/ipc';+import { type BaseModalProps } from '@renderer/lib/modal/modal-provider';import { openExternalUrl } from '@renderer/lib/open-external';import { Button } from '@renderer/lib/ui/button';import {- Dialog,- DialogClose,- DialogContent,DialogContentArea,DialogDescription,DialogFooter,DialogHeader,DialogTitle,} from '@renderer/lib/ui/dialog';-import { DropdownMenuItem } from '@renderer/lib/ui/dropdown-menu';import { Spinner } from '@renderer/lib/ui/spinner';function CopyButton({ value, label }: { value: string; label: string }) {@@ -81,6 +78,13 @@ function CredentialRow({);}+type BundledChatSignInModalArgs = {+ serverId: string;+ bridgeDisplayName: string;+};++type Props = BaseModalProps<void> & BundledChatSignInModalArgs;+/*** The bundled chat's address and sign-in, for signing in outside Switch Console —* a browser or the desktop Mattermost client (CHOO-1787).@@ -89,31 +93,22 @@ function CredentialRow({* so it is never exposed to the LAN, so the copy must not invite the user to* try a device that cannot reach it.*+ * It goes through the modal registry rather than owning a `Dialog` of its own,+ * because the only thing that opens it is an item in the messaging app's+ * dropdown menu. A dialog rendered there is a child of the menu's popup, which+ * base-ui unmounts the moment the menu closes — so the same click that opened+ * it took it away again.+ ** The values are only fetched once the dialog is opened: the password should* not cross into the renderer for everyone who merely looks at the server page.* When Switch Console cannot read the real values it says which one is missing* and why, and shows nothing else — a template password would only send the* user round a login loop.*/-export function BundledChatSignIn({- serverId,- bridgeDisplayName,- asMenuItem = false,-}: {- serverId: string;- bridgeDisplayName: string;- /** Render the opener as a dropdown entry rather than a standalone icon- * button, for the row menu that now carries this action. */- asMenuItem?: boolean;-}) {- const [open, setOpen] = useState(false);-+export function BundledChatSignInModal({ serverId, bridgeDisplayName, onClose }: Props) {const signInQuery = useQuery({queryKey: ['bundled-chat-sign-in', serverId],queryFn: () => rpc.switchServers.getBundledChatSignIn(serverId),- // The password only crosses into the renderer once the dialog is actually- // opened, so merely listing the app never fetches it.- enabled: open,});const signIn = signInQuery.data;@@ -121,69 +116,47 @@ export function BundledChatSignIn({return (<>- {asMenuItem ? (- // `closeOnClick={false}` would leave the menu over the dialog; letting- // it close and opening the dialog from the same click is what keeps one- // surface on screen at a time.- <DropdownMenuItem onClick={() => setOpen(true)}>- <KeyRound className="size-4" />- Sign-in details…- </DropdownMenuItem>- ) : (- <Button- variant="ghost"- size="icon-xs"- aria-label={`${bridgeDisplayName} sign-in details`}- title={`${bridgeDisplayName} sign-in details`}- onClick={() => setOpen(true)}- >- <KeyRound className="size-3" />- </Button>- )}+ <DialogHeader>+ <BridgeIcon bridgeType="mattermost" size={16} />+ <DialogTitle>{bridgeDisplayName} sign-in details</DialogTitle>+ </DialogHeader>+ <DialogContentArea className="space-y-3">+ <DialogDescription>+ Use these to sign in to this chat in a browser or the {bridgeDisplayName} desktop app on+ this computer.+ </DialogDescription>- <Dialog open={open} onOpenChange={setOpen}>- <DialogContent>- <DialogHeader>- <BridgeIcon bridgeType="mattermost" size={16} />- <DialogTitle>{bridgeDisplayName} sign-in details</DialogTitle>- </DialogHeader>- <DialogContentArea className="space-y-3">- <DialogDescription>- Use these to sign in to this chat in a browser or the {bridgeDisplayName} desktop app- on this computer.- </DialogDescription>-- {signInQuery.isLoading ? (- <Spinner className="size-3.5" />- ) : signInQuery.isError ? (- <p className="text-destructive text-xs">- {failureText(signInQuery.error, 'Could not read the sign-in details.')}- </p>- ) : signIn?.kind === 'unavailable' ? (- <p className="text-xs text-foreground-muted">{signIn.reason}</p>- ) : signIn?.kind === 'available' ? (- <>- <CredentialRow label="Server" value={signIn.url} />- <CredentialRow label="Username" value={signIn.username} />- <CredentialRow label="Password" value={signIn.password} secret />- </>- ) : null}- </DialogContentArea>- <DialogFooter>- {url && (- <Button- variant="outline"- size="sm"- onClick={() => void openExternalUrl(url, `Could not open ${bridgeDisplayName}`)}- >- <ExternalLink className="size-4" />- Open in browser- </Button>- )}- <DialogClose render={<Button size="sm" />}>Done</DialogClose>- </DialogFooter>- </DialogContent>- </Dialog>+ {signInQuery.isLoading ? (+ <Spinner className="size-3.5" />+ ) : signInQuery.isError ? (+ <p className="text-destructive text-xs">+ {failureText(signInQuery.error, 'Could not read the sign-in details.')}+ </p>+ ) : signIn?.kind === 'unavailable' ? (+ <p className="text-xs text-foreground-muted">{signIn.reason}</p>+ ) : signIn?.kind === 'available' ? (+ <>+ <CredentialRow label="Server" value={signIn.url} />+ <CredentialRow label="Username" value={signIn.username} />+ <CredentialRow label="Password" value={signIn.password} secret />+ </>+ ) : null}+ </DialogContentArea>+ <DialogFooter>+ {url && (+ <Button+ variant="outline"+ size="sm"+ onClick={() => void openExternalUrl(url, `Could not open ${bridgeDisplayName}`)}+ >+ <ExternalLink className="size-4" />+ Open in browser+ </Button>+ )}+ <Button size="sm" onClick={onClose}>+ Done+ </Button>+ </DialogFooter></>);}diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/MessagingAppsCard.tsx b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/MessagingAppsCard.tsxindex cfefc480e..b3c80d5cc 100644--- a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/MessagingAppsCard.tsx+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/MessagingAppsCard.tsx@@ -3,6 +3,7 @@ import {CircleAlert,ExternalLink,Info,+ KeyRound,Link2,MessageSquare,MoreVertical,@@ -34,7 +35,6 @@ import { Spinner } from '@renderer/lib/ui/spinner';import { Tooltip, TooltipContent, TooltipTrigger } from '@renderer/lib/ui/tooltip';import { log } from '@renderer/utils/logger';import type { LinkedIdentity, RemoteBridge } from '@shared/core/switch-servers/switch-servers';-import { BundledChatSignIn } from './BundledChatSignIn';import { orderBridges } from './messaging-apps-order';import {hasUnlinkedMessagingApp,@@ -355,6 +355,7 @@ export function MessagingAppRow({onDisconnect: () => void;}) {const showClaimIdentity = useShowModal('claimIdentityModal');+ const showBundledChatSignIn = useShowModal('bundledChatSignInModal');const [releasing, setReleasing] = useState(false);const [releaseError, setReleaseError] = useState<string | null>(null);@@ -510,11 +511,14 @@ export function MessagingAppRow({{(showBundledSignIn || bridge.homeUrl) && <DropdownMenuSeparator />}{showBundledSignIn && (- <BundledChatSignIn- serverId={serverId}- bridgeDisplayName={bridge.displayName}- asMenuItem- />+ <DropdownMenuItem+ onClick={() =>+ showBundledChatSignIn({ serverId, bridgeDisplayName: bridge.displayName })+ }+ >+ <KeyRound className="size-4" />+ Sign-in details…+ </DropdownMenuItem>)}{/* Offered only when the link resolves — an older server, or a bridgethat is down, reports none. */}diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.test.ts b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.test.tsindex 190719d3c..cdc3dd99b 100644--- a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.test.ts+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.test.ts@@ -28,6 +28,10 @@ vi.mock('@renderer/lib/ipc', () => ({vi.mock('@renderer/features/remote-hosts/host-reachability-store', () => ({hostReachabilityStore: { isBlocked: (sshHost: string) => blockedHosts.has(sshHost) },}));+const revalidate = vi.hoisted(() => vi.fn());+vi.mock('@renderer/lib/stores/app-state', () => ({+ appState: { navigation: { revalidate } },+}));const { SwitchServersStore } = await import('./switch-servers-store');@@ -170,6 +174,31 @@ describe('recovering when connectivity returns', () => {});});+describe('a page left on a server that is gone', () => {+ it('is revalidated when the server is removed', async () => {+ const store = newStore([server('srv-a')]);+ listServers.mockResolvedValue([]);+ getActiveServerId.mockResolvedValue(null);+ removeServer.mockResolvedValue(undefined);++ await store.removeServer('srv-a');++ expect(revalidate).toHaveBeenCalled();+ });++ it('is revalidated once the list is known, not before', async () => {+ const store = new SwitchServersStore();+ expect(store.loaded).toBe(false);++ listServers.mockResolvedValue([server('srv-a')]);+ getActiveServerId.mockResolvedValue('srv-a');+ await store.init();++ expect(store.loaded).toBe(true);+ expect(revalidate).toHaveBeenCalled();+ });+});+describe('a server on an unreachable host', () => {it('skips the doomed fetch without raising the error banner', async () => {blockedHosts.add('host-1');diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.ts b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.tsindex 3fbdae62f..958970581 100644--- a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.ts+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/switch-servers-store.ts@@ -2,6 +2,7 @@ import { makeAutoObservable, runInAction } from 'mobx';import { hostReachabilityStore } from '@renderer/features/remote-hosts/host-reachability-store';import { describeFailure } from '@renderer/lib/errors/describe-failure';import { rpc } from '@renderer/lib/ipc';+import { appState } from '@renderer/lib/stores/app-state';import type {ServerConnectionStatus,SwitchAuthConfig,@@ -38,6 +39,11 @@ export class SwitchServersStore {readonly unreachable = new Set<string>();loadingServers = false;+ /** Whether the list has been read at least once. Until it has, an empty+ * `servers` means "not asked yet", not "no such server" — the difference+ * matters to the server view's guard, which runs at startup before anything+ * has mounted to call {@link init}. */+ loaded = false;/** Server ids with an in-flight status refresh. */readonly refreshing = new Set<string>();/** The sentence the page leads with. Never raw exception text. */@@ -98,7 +104,12 @@ export class SwitchServersStore {runInAction(() => {this.servers = servers;this.activeServerId = activeServerId;+ this.loaded = true;});+ // A page restored onto a server that has since been deleted can only be+ // judged once the list is known, and startup restores navigation before+ // anything asks for it.+ appState.navigation.revalidate();await this.ensureActiveServer();await this.refreshAllStatuses();} catch (cause) {@@ -330,6 +341,10 @@ export class SwitchServersStore {this.authConfigWanted.delete(serverId);this.unreachable.delete(serverId);});+ // The removed id also sits in the server view's saved params, where it+ // outlives the record and would be read back — as a page for a server+ // that is gone, and as gateway calls for an id nothing can resolve.+ appState.navigation.revalidate();await this.ensureActiveServer();} catch (cause) {this.setError(cause, 'Could not remove the server.');diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/view.tsx b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/view.tsxindex bfd73fcab..bd5715109 100644--- a/console/apps/switch-console-desktop/src/renderer/features/switch-servers/view.tsx+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-servers/view.tsx@@ -135,11 +135,15 @@ const ServerMainPanel = observer(function ServerMainPanel() {// effect re-runs and finally fetches what it skipped (CHOO-2042).const hostBlocked = store.isHostBlocked(serverId);+ // An id naming no server resolves to nothing on the main side, so both reads+ // would fail — and mark the server unreachable, which is a different claim+ // from the truth that it is gone. The page says so below instead.+ const serverExists = server !== undefined;useEffect(() => {- if (!detailsVisible || hostBlocked) return;+ if (!serverExists || !detailsVisible || hostBlocked) return;void store.refreshStatus(serverId);void store.ensureAuthConfig(serverId);- }, [serverId, store, detailsVisible, hostBlocked]);+ }, [serverId, store, serverExists, detailsVisible, hostBlocked]);if (!server) {return (@@ -486,6 +490,13 @@ export const serverView = {if (typeof serverId !== 'string') {return { ok: false, redirect: 'home' };}+ // Saved params outlive the server they name: deleting one leaves its id+ // here, and a page restored onto it reads a gateway nothing can resolve.+ // Until the list has been read, an absent server means "not asked yet" —+ // the store revalidates once it knows.+ if (switchServersStore.loaded && !switchServersStore.servers.some((s) => s.id === serverId)) {+ return { ok: false, redirect: 'home', discardParams: true };+ }return { ok: true };},} satisfies ViewDefinition<{ serverId: string }>;