Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

Address review: revert chart check placeholders, set a late admin password, surface flag errors

Petr Bauch7143df1ee066
diff --git a/core/switch_core/main.py b/core/switch_core/main.py
index 4c688941c..df07dcf97 100644
--- a/core/switch_core/main.py
+++ b/core/switch_core/main.py
@@ -1945,6 +1945,14 @@ async def _seed_admin_user(
)
else:
logger.info("Admin user already exists: %s", existing.id)
+ if existing.password_hash is None and config.gateway_admin_password:
+ existing.password_hash = hash_password(config.gateway_admin_password)
+ await session.commit()
+ logger.warning(
+ "Admin user %s was seeded without a password; set it from "
+ "GATEWAY_ADMIN_PASSWORD.",
+ existing.id,
+ )
return
admin = User(
diff --git a/core/tests/switch_core/test_seed_admin_without_password.py b/core/tests/switch_core/test_seed_admin_without_password.py
index f50e6eee8..d63ea43ab 100644
--- a/core/tests/switch_core/test_seed_admin_without_password.py
+++ b/core/tests/switch_core/test_seed_admin_without_password.py
@@ -75,6 +75,20 @@ class TestSeeding:
assert admin.role == "admin"
assert admin.password_hash is None
+ async def test_a_password_set_later_reaches_an_admin_seeded_without_one(
+ self, session_factory: async_sessionmaker[AsyncSession]
+ ) -> None:
+ await _seed_admin_user(
+ session_factory, UserStore(), _config(password=None, password_login=False)
+ )
+ await _seed_admin_user(
+ session_factory,
+ UserStore(),
+ _config(password="s3cret-pw", password_login=True),
+ )
+
+ assert (await _admin(session_factory)).password_hash is not None
+
async def test_the_first_oidc_sign_in_links_to_the_seeded_admin(
self, session_factory: async_sessionmaker[AsyncSession]
) -> None:
diff --git a/deploy/remote/helm/switch/values.yaml b/deploy/remote/helm/switch/values.yaml
index 42512985c..cdfc8a9cf 100644
--- a/deploy/remote/helm/switch/values.yaml
+++ b/deploy/remote/helm/switch/values.yaml
@@ -5,7 +5,7 @@ global:
# "standard-rwo" on GKE) only if your cluster has no default or you need a
# specific class.
storageClass: ""
- imageRegistry: "ghcr.io/render-check"
+ imageRegistry: ""
# Names of pre-existing dockerconfigjson Secrets used to pull images from a
# private registry (e.g. a private GHCR namespace). Applied to every pod. Leave
# empty for public images.
@@ -225,7 +225,7 @@ switchCore:
hostedLaunchCapacity: 0
hostedDiskRetentionDays: 7
hostedIdleStopMinutes: 30
- image: "switch-core:0.0.0-check@sha256:0000000000000000000000000000000000000000000000000000000000000000"
+ image: switch-core:latest
# Empty: IfNotPresent when the image is pinned by digest (as in a published
# chart), Always otherwise. Set it to override.
imagePullPolicy: ""
@@ -801,7 +801,7 @@ switchCore:
# switchCore's to different releases and those pages load blank.
gateway:
enabled: true
- image: "gateway:0.0.0-check@sha256:0000000000000000000000000000000000000000000000000000000000000000"
+ image: gateway:latest
# Empty: IfNotPresent when the image is pinned by digest (as in a published
# chart), Always otherwise. Set it to override.
imagePullPolicy: ""
@@ -1052,7 +1052,7 @@ decision:
# ── Setup Job ─────────────────────────────────────────────────────────────────
setup:
- image: "setup:0.0.0-check@sha256:0000000000000000000000000000000000000000000000000000000000000000"
+ image: setup:latest
# Empty: IfNotPresent when the image is pinned by digest (as in a published
# chart), Always otherwise. Set it to override.
imagePullPolicy: ""
diff --git a/gateway/src/pages/connector-apps/ConnectorAppsPage.tsx b/gateway/src/pages/connector-apps/ConnectorAppsPage.tsx
index 66c32333c..d3c37c1cd 100644
--- a/gateway/src/pages/connector-apps/ConnectorAppsPage.tsx
+++ b/gateway/src/pages/connector-apps/ConnectorAppsPage.tsx
@@ -27,7 +27,8 @@ function Heading({ publicUrl }: { publicUrl: string | null }) {
}
/** Every app of `scope`, a card each, under `heading`. A 404 means the
- * routes are not mounted, and shows `notEnabled`. */
+ * routes are not mounted, and shows `notEnabled`. Parents must check the
+ * server's feature flags before rendering it. */
export function ConnectorAppsList({
scope,
notEnabled,
diff --git a/gateway/src/pages/organization/OrganizationPage.tsx b/gateway/src/pages/organization/OrganizationPage.tsx
index f11ffa468..5a6033f4c 100644
--- a/gateway/src/pages/organization/OrganizationPage.tsx
+++ b/gateway/src/pages/organization/OrganizationPage.tsx
@@ -24,7 +24,7 @@ export default function OrganizationPage() {
() => (isAdmin ? fetchFeatureFlags() : Promise.resolve(null)),
[isAdmin],
);
- const { data: flags } = useLoad(loadFlags);
+ const { data: flags, error: flagsError } = useLoad(loadFlags);
// The server mounts the routes behind Services and Connectors only with
// both flags on; asking a server without them would only be refused.
const organizationApps =
@@ -54,6 +54,11 @@ export default function OrganizationPage() {
</Typography>
</Stack>
{error && <Alert severity="error">{error}</Alert>}
+ {flagsError && (
+ <Alert severity="error" sx={{ mb: 2 }}>
+ Could not tell whether Services and Connectors are available: {flagsError}
+ </Alert>
+ )}
<Stack spacing={4}>
{(isAdmin || session.user.is_operator) && <OrganizationIssuesNotice key={membersChanged} />}
<WorkspacesSection currentId={tenant.id} canAdd={session.can_add_workspace} />