Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

Room settings say only what is true

Simon Flack8cdfe93af0c5
diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-configuration-panel.tsx b/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-configuration-panel.tsx
index ecd0db860..febc3f15a 100644
--- a/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-configuration-panel.tsx
+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-configuration-panel.tsx
@@ -168,7 +168,7 @@ export const RoomConfigurationPanel = observer(function RoomConfigurationPanel({
<RoomHeading serverId={switchRoomsStore.roomServerId(roomId)} room={room} />
{room.archived && (
<Notice icon={<Archive className="size-3.5" />}>
- This room is archived. It is out of the room lists and agents cannot join it.
+ This room is archived, so it is hidden from room lists. Everything in it is kept.
</Notice>
)}
{!permissions.canWrite && (
diff --git a/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-settings-sections.tsx b/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-settings-sections.tsx
index 5f338edf0..884f6029d 100644
--- a/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-settings-sections.tsx
+++ b/console/apps/switch-console-desktop/src/renderer/features/switch-rooms/room-settings-sections.tsx
@@ -32,10 +32,16 @@ function detailKey(workspaceId: string, roomId: string) {
return ['remote-room-detail', workspaceId, roomId] as const;
}
+/**
+ * The room's read and write access as people read them. Write access is who
+ * may change the room in Switch — its settings, who is in it, its resources —
+ * not who may post: posting in a bridged room is up to its channel. A room
+ * nobody else may read is still readable by whoever takes part in it.
+ */
export const ACCESS_LABELS: Record<RoomAccess, string> = {
- public: 'Everyone in the workspace can see and post',
- read_only: 'Everyone can see it; only the owner and admins post',
- private: 'Only the owner and admins',
+ public: 'Everyone in the workspace can see and change it',
+ read_only: 'Everyone can see it; only the owner and admins can change it',
+ private: 'Only those taking part and admins can see it; only the owner and admins can change it',
};
const ACCESS_ORDER: RoomAccess[] = ['public', 'read_only', 'private'];
@@ -54,7 +60,7 @@ function WriteStatus({ state }: { state: WriteState }) {
}
/**
- * Who may see and post in the room, and the group it is filed under. Each
+ * Who may see and change the room, and the group it is filed under. Each
* saves as soon as it is picked: a choice from a list is already a decision,
* unlike half-typed text, so there is nothing to confirm.
*
@@ -98,7 +104,7 @@ export const AccessAndGroupFields = observer(function AccessAndGroupFields({
return (
<div className="grid grid-cols-2 gap-4">
<div className="flex flex-col gap-1.5">
- <span className="text-sm text-foreground-muted">Who can see and post</span>
+ <span className="text-sm text-foreground-muted">Who can see and change it</span>
{permissions.canManage ? (
<Select
value={access}
@@ -116,7 +122,7 @@ export const AccessAndGroupFields = observer(function AccessAndGroupFields({
)
}
>
- <SelectTrigger className="w-full" aria-label="Who can see and post">
+ <SelectTrigger className="w-full" aria-label="Who can see and change it">
<SelectValue>{ACCESS_LABELS[access]}</SelectValue>
</SelectTrigger>
<SelectContent>
@@ -533,8 +539,8 @@ export const ArchiveRoomSection = observer(function ArchiveRoomSection({
</h3>
<p className="text-xs text-foreground-muted">
{room.archived
- ? 'Puts the room back in the room lists, with everything in it.'
- : 'Takes the room out of the room lists and stops agents joining it. Nothing in it is deleted, and you can unarchive it from Your Rooms.'}
+ ? 'Puts the room back in the room lists.'
+ : 'Hides the room from room lists, yours and its agents’. Everything else stays as it is: who is in it, its history and its channel. You can unarchive it from Your Rooms.'}
</p>
{error !== null && <p className="text-xs text-destructive">{error}</p>}
</div>
diff --git a/console/apps/switch-console-desktop/src/renderer/tests/browser/room-settings-sections.test.tsx b/console/apps/switch-console-desktop/src/renderer/tests/browser/room-settings-sections.test.tsx
index 5a6cbab6d..91ee3106b 100644
--- a/console/apps/switch-console-desktop/src/renderer/tests/browser/room-settings-sections.test.tsx
+++ b/console/apps/switch-console-desktop/src/renderer/tests/browser/room-settings-sections.test.tsx
@@ -175,7 +175,7 @@ async function type(field: HTMLInputElement | HTMLTextAreaElement, value: string
describe('room settings for someone who may write to the room', () => {
it('shows access as a control for its manager, and leaves who is in the room to the side', async () => {
const el = await renderPanel();
- expect(el.querySelector('[aria-label="Who can see and post"]')).not.toBeNull();
+ expect(el.querySelector('[aria-label="Who can see and change it"]')).not.toBeNull();
expect(el.textContent).toContain('C123');
expect(el.textContent).not.toContain('Notify on join');
});
@@ -242,7 +242,7 @@ describe('room settings for someone who may only read the room', () => {
expect(el.textContent).toContain(
'Only Ada or a workspace admin can change this room’s settings.'
);
- expect(el.querySelector('[aria-label="Who can see and post"]')).toBeNull();
+ expect(el.querySelector('[aria-label="Who can see and change it"]')).toBeNull();
expect(button(el, /^Add agent$/)).toBeUndefined();
expect(button(el, /^Archive$/)).toBeUndefined();
expect(el.querySelector<HTMLInputElement>('input[aria-label="Name"]')!.disabled).toBe(true);