Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

Stop the bundled Mattermost calling Mattermost Inc. (#733)

Paul Abbaziab2da799eb6db
diff --git a/console/apps/switch-console-desktop/src/main/core/managed-switch-server/resources/standalone-docker-compose.pinned.yml b/console/apps/switch-console-desktop/src/main/core/managed-switch-server/resources/standalone-docker-compose.pinned.yml
index a4497b725..761bc62ae 100644
--- a/console/apps/switch-console-desktop/src/main/core/managed-switch-server/resources/standalone-docker-compose.pinned.yml
+++ b/console/apps/switch-console-desktop/src/main/core/managed-switch-server/resources/standalone-docker-compose.pinned.yml
@@ -192,6 +192,12 @@ services:
MM_SERVICESETTINGS_ALLOWEDUNTRUSTEDINTERNALCONNECTIONS: switch
MM_TEAMSETTINGS_ENABLEOPENSERVER: "true"
MM_TEAMSETTINGS_TEAMMATENAMEDISPLAY: "full_name"
+ MM_LOGSETTINGS_ENABLEDIAGNOSTICS: "false"
+ MM_LOGSETTINGS_ENABLESENTRY: "false"
+ MM_SERVICESETTINGS_ENABLESECURITYFIXALERT: "false"
+ MM_ANNOUNCEMENTSETTINGS_ADMINNOTICESENABLED: "false"
+ MM_ANNOUNCEMENTSETTINGS_USERNOTICESENABLED: "false"
+ MM_PLUGINSETTINGS_ENABLEREMOTEMARKETPLACE: "false"
# Neither plugin is usable in a bundled Switch deployment: Copilot has no
# configured provider and throws a 404 looking up its bot on every page
# load, and Calls ships a WebRTC service nothing here can reach.
diff --git a/core/tests/switch_core/test_deploy_mattermost_phone_home.py b/core/tests/switch_core/test_deploy_mattermost_phone_home.py
new file mode 100644
index 000000000..f8da00c76
--- /dev/null
+++ b/core/tests/switch_core/test_deploy_mattermost_phone_home.py
@@ -0,0 +1,52 @@
+"""Every Mattermost that Switch launches is told not to call Mattermost Inc.
+
+Left at its defaults, Mattermost fetches in-product notices from
+notices.mattermost.com and reports its server id, version, user and team
+counts to securityupdatecheck.mattermost.com on boot and daily after that.
+Its admin plugin marketplace calls api.integrations.mattermost.com, and with
+diagnostics on, its crash reports go to Sentry. A bundled Mattermost is
+Switch's to keep patched, so none of that is the operator's to discover.
+"""
+
+import re
+from pathlib import Path
+
+import pytest
+import yaml
+
+_REPO = Path(__file__).resolve().parents[3]
+
+_NO_PHONE_HOME = {
+ "MM_LOGSETTINGS_ENABLEDIAGNOSTICS": "false",
+ "MM_LOGSETTINGS_ENABLESENTRY": "false",
+ "MM_SERVICESETTINGS_ENABLESECURITYFIXALERT": "false",
+ "MM_ANNOUNCEMENTSETTINGS_ADMINNOTICESENABLED": "false",
+ "MM_ANNOUNCEMENTSETTINGS_USERNOTICESENABLED": "false",
+ "MM_PLUGINSETTINGS_ENABLEREMOTEMARKETPLACE": "false",
+}
+
+
+ "compose",
+ [
+ "deploy/local/docker-compose.yml",
+ "deploy/local/standalone-docker-compose.yml",
+ "console/apps/switch-console-desktop/src/main/core/managed-switch-server/resources/standalone-docker-compose.pinned.yml",
+ ],
+)
+def test_compose_mattermost_does_not_phone_home(compose: str) -> None:
+ services = yaml.safe_load((_REPO / compose).read_text())["services"]
+ environment = services["mattermost"]["environment"]
+ assert {key: environment.get(key) for key in _NO_PHONE_HOME} == _NO_PHONE_HOME
+
+
+def test_helm_mattermost_does_not_phone_home() -> None:
+ template = (
+ _REPO / "deploy/remote/helm/switch/templates/mattermost/deployment.yaml"
+ ).read_text()
+ found = {
+ key: match.group(1)
+ for key in _NO_PHONE_HOME
+ if (match := re.search(rf'- name: {key}\n\s+value: "([^"]*)"', template))
+ }
+ assert found == _NO_PHONE_HOME
diff --git a/deploy/local/docker-compose.yml b/deploy/local/docker-compose.yml
index 02aa39126..6b5b6cdee 100644
--- a/deploy/local/docker-compose.yml
+++ b/deploy/local/docker-compose.yml
@@ -84,6 +84,12 @@ services:
# unclickable text. Kept in step with the standalone compose.
MM_SERVICESETTINGS_ENABLEONBOARDINGFLOW: "false"
MM_DISPLAYSETTINGS_CUSTOMURLSCHEMES: switchdash
+ MM_LOGSETTINGS_ENABLEDIAGNOSTICS: "false"
+ MM_LOGSETTINGS_ENABLESENTRY: "false"
+ MM_SERVICESETTINGS_ENABLESECURITYFIXALERT: "false"
+ MM_ANNOUNCEMENTSETTINGS_ADMINNOTICESENABLED: "false"
+ MM_ANNOUNCEMENTSETTINGS_USERNOTICESENABLED: "false"
+ MM_PLUGINSETTINGS_ENABLEREMOTEMARKETPLACE: "false"
depends_on:
init-db:
condition: service_completed_successfully
diff --git a/deploy/local/standalone-docker-compose.yml b/deploy/local/standalone-docker-compose.yml
index 33aa71bb5..1bb382553 100644
--- a/deploy/local/standalone-docker-compose.yml
+++ b/deploy/local/standalone-docker-compose.yml
@@ -185,6 +185,12 @@ services:
MM_SERVICESETTINGS_ALLOWEDUNTRUSTEDINTERNALCONNECTIONS: switch
MM_TEAMSETTINGS_ENABLEOPENSERVER: "true"
MM_TEAMSETTINGS_TEAMMATENAMEDISPLAY: "full_name"
+ MM_LOGSETTINGS_ENABLEDIAGNOSTICS: "false"
+ MM_LOGSETTINGS_ENABLESENTRY: "false"
+ MM_SERVICESETTINGS_ENABLESECURITYFIXALERT: "false"
+ MM_ANNOUNCEMENTSETTINGS_ADMINNOTICESENABLED: "false"
+ MM_ANNOUNCEMENTSETTINGS_USERNOTICESENABLED: "false"
+ MM_PLUGINSETTINGS_ENABLEREMOTEMARKETPLACE: "false"
# Neither plugin is usable in a bundled Switch deployment: Copilot has no
# configured provider and throws a 404 looking up its bot on every page
# load, and Calls ships a WebRTC service nothing here can reach.
diff --git a/deploy/remote/helm/switch/templates/mattermost/deployment.yaml b/deploy/remote/helm/switch/templates/mattermost/deployment.yaml
index ecb519849..3e42f2cff 100644
--- a/deploy/remote/helm/switch/templates/mattermost/deployment.yaml
+++ b/deploy/remote/helm/switch/templates/mattermost/deployment.yaml
@@ -64,6 +64,18 @@ spec:
value: "switchdash"
- name: MM_TEAMSETTINGS_MAXUSERSPERTEAM
value: {{ .Values.mattermost.maxUsersPerTeam | default 1000 | quote }}
+ - name: MM_LOGSETTINGS_ENABLEDIAGNOSTICS
+ value: "false"
+ - name: MM_LOGSETTINGS_ENABLESENTRY
+ value: "false"
+ - name: MM_SERVICESETTINGS_ENABLESECURITYFIXALERT
+ value: "false"
+ - name: MM_ANNOUNCEMENTSETTINGS_ADMINNOTICESENABLED
+ value: "false"
+ - name: MM_ANNOUNCEMENTSETTINGS_USERNOTICESENABLED
+ value: "false"
+ - name: MM_PLUGINSETTINGS_ENABLEREMOTEMARKETPLACE
+ value: "false"
{{- if .Values.switchCore.collaborationCallback.enabled }}
{{- $core := include "switch.switchCoreHost" . }}
# Mattermost will not call a private address unless it is named