Skip to content

Open-source AI teammates in Slack, Teams, Discord, Telegram and Mattermost. Self-host it, with any agent harness and any model.

fix(console): restore the publisherName Azure signing requires (CHOO-1468) (#256)

Louis Amaudruzfbd12326490f
diff --git a/.github/workflows/switch-console-release.yml b/.github/workflows/switch-console-release.yml
index 308bdf95b..3a8041732 100644
--- a/.github/workflows/switch-console-release.yml
+++ b/.github/workflows/switch-console-release.yml
@@ -569,6 +569,11 @@ jobs:
')"
if [ "$signed" != "0" ]; then
echo "Authenticode signature present ($signed bytes)."
+ # The subject's CN is the string `publisherName` has to match before
+ # verifyUpdateCodeSignature can be turned on, and the certificate is
+ # the only authoritative source for it.
+ powershell -NoProfile -Command \
+ '$s = Get-AuthenticodeSignature "release\switch-console-x64.exe"; Write-Host "status: $($s.Status)"; Write-Host "subject: $($s.SignerCertificate.Subject)"'
elif [ -n "$AZURE_CLIENT_ID" ]; then
echo "::error::Azure credentials were present but the installer is unsigned."
exit 1
diff --git a/console/apps/switch-console-desktop/electron-builder.config.ts b/console/apps/switch-console-desktop/electron-builder.config.ts
index a18d62b7e..df0b9729f 100644
--- a/console/apps/switch-console-desktop/electron-builder.config.ts
+++ b/console/apps/switch-console-desktop/electron-builder.config.ts
@@ -160,26 +160,36 @@ const config: Configuration = {
rpm: {
packageName: APP_NAME_LOWER,
},
- // `publisherName` is deliberately unset. electron-updater verifies a downloaded
- // installer's Authenticode signature against the publisher named in
- // app-update.yml, and the name has to match the certificate subject exactly —
- // a wrong value rejects every update rather than failing at build time. Until
- // the certificate's common name is known verbatim, leaving it unset writes no
- // publisher into app-update.yml, which makes the updater skip that check.
- // Signing itself is unaffected; setting the real string later strengthens it.
win: {
icon: 'src/assets/images/switch-console/app-icon-beta.png',
target: [
{ target: 'nsis', arch: ['x64'] },
{ target: 'msi', arch: ['x64'] },
],
- azureSignOptions: hasAzureSigning
+ // Off until the certificate's subject common name is known verbatim. This
+ // flag is what decides whether `publisherName` below is copied into
+ // app-update.yml, and electron-updater rejects any update whose signature
+ // does not match the name it finds there. A wrong name therefore breaks
+ // updating for everyone already installed, and does so silently and later —
+ // whereas leaving the field out of the manifest merely skips the check.
+ // Turn this on in the same change that sets the real name.
+ verifyUpdateCodeSignature: false,
+ ...(hasAzureSigning
? {
- endpoint: 'https://eus.codesigning.azure.net/',
- codeSigningAccountName: 'cg-asa-basic-eastus',
- certificateProfileName: 'cg-public',
+ azureSignOptions: {
+ endpoint: 'https://eus.codesigning.azure.net/',
+ codeSigningAccountName: 'cg-asa-basic-eastus',
+ certificateProfileName: 'cg-public',
+ // Required by electron-builder's schema, so it cannot be omitted, but
+ // it is stripped before the signing call and never reaches the
+ // certificate — the signature's real publisher comes from the
+ // certificate itself. Its only effect is on app-update.yml, which
+ // verifyUpdateCodeSignature: false above suppresses. Treat it as
+ // unverified until a signed build confirms the actual subject.
+ publisherName: 'SandboxAQ',
+ },
}
- : undefined,
+ : {}),
},
msi: {
oneClick: false,