TypeScript
perf(release): fetch the nightly Android APK in a background step (#31949)
Theo Browne05b72267769f
diff --git a/.github/workflows/release.yml b/.github/workflows/release.ymlindex 9c3c5949723..a74ef08c5ae 100644--- a/.github/workflows/release.yml+++ b/.github/workflows/release.yml@@ -806,6 +806,24 @@ jobs:with:install-args: --filter=@t3tools/scripts...+ # Overlaps the artifact downloads. The wait below ends it before any+ # workspace script runs, so the Play key lives only in this process.+ # `exec` lets the runner's stop signals reach node directly.+ - id: android_apk+ name: Download nightly Android APK+ if: needs.preflight.outputs.release_channel == 'nightly'+ background: true+ continue-on-error: true+ timeout-minutes: 5+ env:+ GOOGLE_PLAY_SERVICE_ACCOUNT_JSON: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}+ PACKAGE_NAME: com.t3tools.t3code+ APK_OUTPUT_DIR: ${{ runner.temp }}/android-apk+ run: |+ if [ -n "$GOOGLE_PLAY_SERVICE_ACCOUNT_JSON" ]; then+ exec node .github/scripts/mirror-play-apk.cjs+ fi+- name: Download all desktop artifactsuses: actions/download-artifact@v8with:@@ -820,18 +838,6 @@ jobs:merge-multiple: truepath: release-assets- - name: Download internal Android APK for Nightly- if: needs.preflight.outputs.release_channel == 'nightly'- continue-on-error: true- env:- GOOGLE_PLAY_SERVICE_ACCOUNT_JSON: ${{ secrets.GOOGLE_PLAY_SERVICE_ACCOUNT_JSON }}- PACKAGE_NAME: com.t3tools.t3code- APK_OUTPUT_DIR: release-assets- run: |- if [ -n "$GOOGLE_PLAY_SERVICE_ACCOUNT_JSON" ]; then- node .github/scripts/mirror-play-apk.cjs- fi-# Installers verify archives against this file, so it is written from the# signed bytes that get uploaded, never from an earlier stage.- name: Write CLI archive checksums@@ -848,6 +854,10 @@ jobs:sha256sum "${archives[@]}" > SHA256SUMScat SHA256SUMS+ # Always runs, even after a failed step, and keeps that failure.+ - name: Wait for nightly Android APK+ wait: android_apk+# The desktop build omits the publish config for preview versions, so# electron-builder emits no updater manifests for them. Refuse to publish# if one shows up anyway: a `latest*.yml` or `nightly*.yml` on a preview@@ -913,10 +923,13 @@ jobs:echo 'release-assets/*.yml'fiecho 'release-assets/*.tar.gz'- # Only list APKs when Play has a processed internal build available.- for apk in release-assets/*.apk; do- [[ -f "$apk" ]] && echo "$apk"- done+ # A failed or timed-out fetch can leave partial bytes, so list the APK+ # only when this attempt's fetch succeeded and Play had one ready.+ if [[ "${{ steps.android_apk.outcome }}" == "success" ]]; then+ for apk in "$RUNNER_TEMP"/android-apk/*.apk; do+ [[ -f "$apk" ]] && echo "$apk"+ done+ fiecho 'release-assets/SHA256SUMS'echo 'EOF'} >> "$GITHUB_OUTPUT"diff --git a/docs/operations/release.md b/docs/operations/release.mdindex 4dd489bfde0..d7581d3c08a 100644--- a/docs/operations/release.md+++ b/docs/operations/release.md@@ -342,9 +342,9 @@ uploads resume on the next check.Normal Nightly releases include the newest processed internal-testing APK availablewhen the release publishes. Internal builds do not create separate Android releases.-If Play credentials or a processed APK are unavailable, the Nightly can still publish-without an APK. Android submissions continue to go to internal testing; promote a-build to Alpha to publish it as a beta.+If Play credentials or a processed APK are unavailable, or the download takes more+than five minutes, the Nightly can still publish without an APK. Android submissions+continue to go to internal testing; promote a build to Alpha to publish it as a beta.The APK is the universal APK Play generates and signs from theuploaded bundle, so no signing key lives in GitHub. The job skips itself until