TypeScript
fix(shared): CSV and TSV attachments keep their table under generic file types (#30601)
tiliakoos09647d188dcd
diff --git a/packages/shared/src/delimitedPreview.test.ts b/packages/shared/src/delimitedPreview.test.tsindex a2464eef2b0..1f571b94051 100644--- a/packages/shared/src/delimitedPreview.test.ts+++ b/packages/shared/src/delimitedPreview.test.ts@@ -1,7 +1,11 @@import { describe, expect, it } from "vite-plus/test";-import { parseDelimitedPreview } from "./delimitedPreview.ts";+import { filePreviewDelimiter, parseDelimitedPreview } from "./delimitedPreview.ts";describe("delimited file previews", () => {+ it("falls back to the file name under generic MIME types", () => {+ expect(filePreviewDelimiter({ name: "a.csv", mimeType: "binary/octet-stream" })).toBe(",");+ expect(filePreviewDelimiter({ name: "a.tsv", mimeType: "application/unknown" })).toBe("\t");+ });it("preserves quoted separators, escaped quotes, blank cells and line breaks", () => {expect(parseDelimitedPreview('\ufeffname,notes,empty\r\n"A, B","say ""hi""\nagain",\r\n', ","),diff --git a/packages/shared/src/delimitedPreview.ts b/packages/shared/src/delimitedPreview.tsindex 07703482bf8..b9698ca7a0b 100644--- a/packages/shared/src/delimitedPreview.ts+++ b/packages/shared/src/delimitedPreview.ts@@ -1,8 +1,10 @@+import { GENERIC_MIME_TYPES } from "./image.ts";+export function filePreviewDelimiter(file: { name: string; mimeType?: string }): "," | "\t" | null {const mime = file.mimeType?.split(";", 1)[0]?.trim().toLowerCase();if (mime === "text/csv") return ",";if (mime === "text/tab-separated-values") return "\t";- if (mime && mime !== "text/plain" && mime !== "application/octet-stream") return null;+ if (mime && mime !== "text/plain" && !GENERIC_MIME_TYPES.has(mime)) return null;if (/\.csv$/i.test(file.name)) return ",";if (/\.tsv$/i.test(file.name)) return "\t";return null;