TypeScript
perf(pr): pull requests paint from data already held, on web, desktop and mobile (#27798)
Bilal Bakr0ea3c0243fb5
diff --git a/apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx b/apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsxindex 354d6413549..02c18801445 100644--- a/apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx+++ b/apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx@@ -58,6 +58,7 @@ import type { ThreadListFilters } from "../../persistence/mobile-preferences";import { appAtomRegistry } from "../../state/atom-registry";import { useProjects } from "../../state/entities";import { environmentThreadShells } from "../../state/threads";+import { withKnownPullRequestSummary } from "../../state/use-thread-pr";import { mobilePreferencesAtom } from "../../state/preferences";import {DEFAULT_MOBILE_PROJECT_GROUPING_SETTINGS,@@ -589,6 +590,7 @@ function AdaptiveWorkspaceLayoutContent(columns: workspaceTabColumns(Platform.OS, tab, options?.columns ?? layout.usesSplitView),check: workspaceSelectionCheck,overlays,+ seedPullRequest: withKnownPullRequestSummary,},);if (layout.variant === "medium") {diff --git a/apps/mobile/src/features/pull-requests/PullRequestOverviewLoading.tsx b/apps/mobile/src/features/pull-requests/PullRequestOverviewLoading.tsxindex 647aa26e463..2494dd93ea0 100644--- a/apps/mobile/src/features/pull-requests/PullRequestOverviewLoading.tsx+++ b/apps/mobile/src/features/pull-requests/PullRequestOverviewLoading.tsx@@ -1,6 +1,6 @@import { Chip } from "../../components/ui/Chip";import { PullRequestSectionHeading } from "./PullRequestSectionHeading";-import type { PullRequestListEntry } from "@t3tools/contracts";+import type { PullRequestListEntry, PullRequestSummary } from "@t3tools/contracts";import { View } from "react-native";import { PullRequestCardGroup, PullRequestCardRow } from "./PullRequestControls";import { PullRequestStackCard } from "./PullRequestStackCard";@@ -14,11 +14,14 @@ export function PullRequestOverviewLoading({params,stack,}: {- readonly summary: PullRequestListEntry;+ readonly summary: PullRequestListEntry | PullRequestSummary;readonly params: PullRequestParams;readonly stack: PullRequestStackState;}) {- const review = pullRequestListReviewStatus(summary);+ const review = pullRequestListReviewStatus({+ reviewDecision: summary.reviewDecision ?? undefined,+ viewerReviewRequested: "viewerReviewRequested" in summary && summary.viewerReviewRequested,+ });const conflicting = summary.mergeability === "conflicting";const clean = summary.mergeability === "mergeable";return (@@ -89,7 +92,7 @@ export function PullRequestOverviewLoading({<View className="h-11 rounded-xl bg-subtle-strong" /></View></PullRequestCardGroup>- {summary.labels.length ? (+ {"labels" in summary && summary.labels.length ? (<View className="flex-row flex-wrap gap-2">{summary.labels.map((label) => (<Chip key={label.name} label={label.name} size="small" />diff --git a/apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx b/apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsxindex 522a5eaf9a7..306864ecd23 100644--- a/apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx+++ b/apps/mobile/src/features/pull-requests/PullRequestRouteScreen.tsx@@ -47,7 +47,11 @@ import { useFocusEffect, useNavigation, type StaticScreenProps } from "@react-naimport type { NativeStackNavigationProp } from "@react-navigation/native-stack";import { RegistryContext, useAtomRefresh, useAtomValue } from "@effect/atom-react";import { pullRequestReviewKey } from "./pullRequestReviewDrafts";-import { type PullRequestDetail, type PullRequestListEntry } from "@t3tools/contracts";+import {+ type PullRequestDetail,+ type PullRequestListEntry,+ type PullRequestSummary,+} from "@t3tools/contracts";import { PullRequestOverviewLoading } from "./PullRequestOverviewLoading";import { copyPullRequestLink, sharePullRequestLink } from "./pullRequestLink";import { pullRequestStatus } from "./pullRequestStatus";@@ -180,11 +184,11 @@ function usePullRequestActivityRows(params: PullRequestParams, filter: ActivityF}function PullRequestIdentity(props: {- readonly pr: PullRequestDetail | PullRequestListEntry;+ readonly pr: PullRequestDetail | PullRequestListEntry | PullRequestSummary;readonly params: PullRequestParams;}) {const { pr } = props;- const status = pullRequestStatus(pr);+ const status = pullRequestStatus({ state: pr.state, isDraft: pr.isDraft === true });return (<View className="gap-3"><View className="flex-row flex-wrap items-center gap-2">@@ -196,8 +200,8 @@ function PullRequestIdentity(props: {<Text className={`text-xs font-t3-medium ${status.text}`}>{status.label}</Text></View>)}- <PullRequestDiffStats additions={pr.additions} deletions={pr.deletions} compact />- {"changedFiles" in pr ? (+ <PullRequestDiffStats additions={pr.additions ?? 0} deletions={pr.deletions ?? 0} compact />+ {"changedFiles" in pr && pr.changedFiles !== undefined ? (<Text className="text-2xs text-foreground-muted">{pr.changedFiles} {pr.changedFiles === 1 ? "file" : "files"}</Text>@@ -209,7 +213,7 @@ function PullRequestIdentity(props: {{pr.title}</Text><View className="flex-row items-center gap-2">- <PullRequestAvatar actor={pr.author} size={20} />+ <PullRequestAvatar actor={pr.author ?? null} size={20} /><Text className="min-w-0 flex-1 text-xs font-t3-medium" numberOfLines={1}>{pr.author?.login ?? "Unknown author"}</Text>diff --git a/apps/mobile/src/features/pull-requests/PullRequestStackCard.tsx b/apps/mobile/src/features/pull-requests/PullRequestStackCard.tsxindex cbb751c74c4..bdf4399f1e6 100644--- a/apps/mobile/src/features/pull-requests/PullRequestStackCard.tsx+++ b/apps/mobile/src/features/pull-requests/PullRequestStackCard.tsx@@ -9,6 +9,7 @@ import { pullRequestStatus } from "./pullRequestStatus";import type { PullRequestParams } from "./usePullRequestDiff";import type { PullRequestStackState } from "./usePullRequestStack";import { PullRequestGlyph } from "./pullRequestGlyphs";+import { withKnownPullRequestSummary } from "../../state/use-thread-pr";export function PullRequestStackCard(props: {readonly params: PullRequestParams;@@ -67,7 +68,9 @@ export function PullRequestStackCard(props: {selected? undefined: () => {- const params = pullRequestLayerParams(props.params, layer.number);+ const params = withKnownPullRequestSummary(+ pullRequestLayerParams(props.params, layer.number),+ );if (Platform.OS === "android")selectDetail({ name: "PullRequest", params });else navigation.dispatch(StackActions.push("PullRequest", params));diff --git a/apps/mobile/src/features/pull-requests/usePullRequestDiff.ts b/apps/mobile/src/features/pull-requests/usePullRequestDiff.tsindex 92e36f44869..6f5180d8ab6 100644--- a/apps/mobile/src/features/pull-requests/usePullRequestDiff.ts+++ b/apps/mobile/src/features/pull-requests/usePullRequestDiff.ts@@ -1,5 +1,10 @@import type { ChangeRequestTerminology } from "@t3tools/client-runtime/source-control-clients";-import { EnvironmentId, ProjectId, type PullRequestListEntry } from "@t3tools/contracts";+import {+ EnvironmentId,+ ProjectId,+ type PullRequestListEntry,+ type PullRequestSummary,+} from "@t3tools/contracts";import { useAtomRefresh } from "@effect/atom-react";import { useLayoutEffect, useMemo, useState } from "react";@@ -18,7 +23,7 @@ export type PullRequestParams = {readonly repository: string;readonly number: number;readonly host?: string;- readonly initialSummary?: PullRequestListEntry;+ readonly initialSummary?: PullRequestListEntry | PullRequestSummary;};export type PullRequestDiffParams = PullRequestParams & { readonly commit?: string };diff --git a/apps/mobile/src/features/workspace/workspace-tab-navigation.ts b/apps/mobile/src/features/workspace/workspace-tab-navigation.tsindex 3674c52972e..bee1efc005f 100644--- a/apps/mobile/src/features/workspace/workspace-tab-navigation.ts+++ b/apps/mobile/src/features/workspace/workspace-tab-navigation.ts@@ -150,6 +150,7 @@ function detailRoute(tab: "threads" | "pullRequests",selections: WorkspaceSelections,check: WorkspaceSelectionCheck,+ seedPullRequest?: (identity: Omit<PullRequestSelection, "key">) => object,): RouteLike | undefined {if (tab === "threads") {const draft = selections.threadsDraft;@@ -184,7 +185,11 @@ function detailRoute((route) =>route.name === "PullRequest" &&samePullRequest(pullRequestSelection(route.params), pullRequest),- ) ?? { key: pullRequest.key, name: "PullRequest", params: identityOf(pullRequest) }+ ) ?? {+ key: pullRequest.key,+ name: "PullRequest",+ params: seedPullRequest?.(identityOf(pullRequest)) ?? identityOf(pullRequest),+ });}@@ -204,6 +209,7 @@ export function workspaceTabNavigationState<readonly columns: boolean;readonly check: WorkspaceSelectionCheck;readonly overlays?: readonly RouteLike[];+ readonly seedPullRequest?: (identity: Omit<PullRequestSelection, "key">) => object;},) {const overlays = options.overlays ?? [];@@ -221,7 +227,7 @@ export function workspaceTabNavigationState<const home = state.routes.find((route) => route.name === "Home") ?? { name: "Home" };const detail =options.columns && tab !== "usage"- ? detailRoute(state, tab, selections, options.check)+ ? detailRoute(state, tab, selections, options.check, options.seedPullRequest): undefined;const routes = [...[home, ...(detail ? [detail] : [])].map(keyed), ...overlays];return { ...state, index: routes.length - 1, routes };diff --git a/apps/mobile/src/native/useOpenPullRequest.ts b/apps/mobile/src/native/useOpenPullRequest.tsindex 755f0b965ee..fa7d437155b 100644--- a/apps/mobile/src/native/useOpenPullRequest.ts+++ b/apps/mobile/src/native/useOpenPullRequest.ts@@ -7,6 +7,7 @@ import { useProjects, useThreadShell } from "../state/entities";import { tryOpenExternalUrl } from "../lib/openExternalUrl";import { appAtomRegistry } from "../state/atom-registry";import { environmentServerConfigsAtom } from "../state/server";+import { withKnownPullRequestSummary } from "../state/use-thread-pr";type PullRequestContext = { readonly environmentId: string; readonly projectId: string };@@ -19,10 +20,11 @@ export function useNavigateToPullRequest(options?: { readonly replace?: booleanreturn async (url: string, context: PullRequestContext | null) => {// Read at press time so a config push does not hand every link a new handler.const serverConfigs = appAtomRegistry.get(environmentServerConfigsAtom);- const params = nativePullRequestDestination(url, context, projects, (environmentId) =>+ const destination = nativePullRequestDestination(url, context, projects, (environmentId) =>serverConfigs.has(environmentId),);- if (!params) return tryOpenExternalUrl(url, "pull-request");+ if (!destination) return tryOpenExternalUrl(url, "pull-request");+ const params = withKnownPullRequestSummary(destination);// Android shows one page at a time; iOS opens it over the current page, so Back returns.if (Platform.OS === "android") selectDetail({ name: "PullRequest", params });else if (replace) navigation.dispatch(StackActions.replace("PullRequest", params));diff --git a/apps/mobile/src/state/thread-pr-presentation.ts b/apps/mobile/src/state/thread-pr-presentation.tsindex 2c151676f5c..a44f410b54c 100644--- a/apps/mobile/src/state/thread-pr-presentation.ts+++ b/apps/mobile/src/state/thread-pr-presentation.ts@@ -1,13 +1,20 @@import type { EnvironmentThreadShell } from "@t3tools/client-runtime/state/shell";-import type { ThreadPullRequestLink, VcsStatusResult } from "@t3tools/contracts";+import type {+ PullRequestSummary,+ ThreadPullRequestKey,+ ThreadPullRequestLink,+ VcsStatusResult,+} from "@t3tools/contracts";import {sourceControlClients,type ChangeRequestTerminology,} from "@t3tools/client-runtime/source-control-clients";import {+ legacyThreadPullRequestKey,resolveThreadCurrentPullRequestLink,resolveThreadPullRequestBadge,+ threadPullRequestKeyOf,} from "@t3tools/client-runtime/thread-pull-requests";export type ThreadPr = NonNullable<VcsStatusResult["pr"]>;@@ -142,3 +149,53 @@ export function rememberBounded<V>(}return next;}++/** The newest summary held for `pullRequest`, matched strictly by host, repository and number. */+export function knownPullRequestSummary(+ pullRequest: ThreadPullRequestKey,+ threads: Iterable<Pick<EnvironmentThreadShell, "projectId" | "pullRequests">>,+ summaries: Iterable<PullRequestSummary>,+): PullRequestSummary | undefined {+ const key = threadPullRequestKeyOf(pullRequest);+ let newest:+ | { readonly summary: PullRequestSummary; readonly updatedAt: number; readonly readAt: number }+ | undefined;+ // Checks and reviews change without moving `updatedAt`, so equal versions prefer the later read.+ const consider = (summary: PullRequestSummary, readAt = Number.NEGATIVE_INFINITY) => {+ const updatedAt = Date.parse(summary.updatedAt);+ if (+ newest === undefined ||+ updatedAt > newest.updatedAt ||+ (updatedAt === newest.updatedAt && readAt > newest.readAt)+ ) {+ newest = { summary, updatedAt, readAt };+ }+ };+ for (const summary of summaries) {+ if (threadPullRequestKeyOf(legacyThreadPullRequestKey(summary)) === key) {+ consider(summary, summary.observedAt);+ }+ }+ for (const thread of threads) {+ for (const link of thread.pullRequests) {+ const snapshot = link.snapshot;+ if (snapshot?.updatedAt == null || threadPullRequestKeyOf(link) !== key) continue;+ consider(+ {+ ...snapshot,+ updatedAt: snapshot.updatedAt,+ provider: (+ sourceControlClients.findByChangeRequestUrl(link.url) ??+ sourceControlClients.get(undefined)+ ).kind,+ projectId: thread.projectId,+ repository: link.repository,+ number: link.number,+ url: link.url,+ },+ Date.parse(snapshot.syncedAt),+ );+ }+ }+ return newest?.summary;+}diff --git a/apps/mobile/src/state/use-thread-pr.test.ts b/apps/mobile/src/state/use-thread-pr.test.tsindex 309953ddbdc..4edbb903dbe 100644--- a/apps/mobile/src/state/use-thread-pr.test.ts+++ b/apps/mobile/src/state/use-thread-pr.test.ts@@ -1,7 +1,13 @@-import { ProjectId, type ThreadPullRequestLink } from "@t3tools/contracts";+import {+ ProjectId,+ type PullRequestSummary,+ SourceControlProviderKind,+ type ThreadPullRequestLink,+} from "@t3tools/contracts";import { describe, expect, it } from "vite-plus/test";import {+ knownPullRequestSummary,presentThreadLinkedPullRequests,rememberBounded,resolveThreadPrSource,@@ -113,6 +119,49 @@ describe("resolveThreadPrSource compatibility", () => {});});+describe("knownPullRequestSummary", () => {+ it("seeds from the newest summary of the same pull request, never another's", () => {+ const projectId = ProjectId.make("project");+ const link = linkedPr(7);+ const threads = [+ {+ projectId,+ pullRequests: [+ { ...link, snapshot: { ...link.snapshot!, updatedAt: "2026-09-08T00:00:00.000Z" } },+ ],+ },+ ];+ const listed: PullRequestSummary = {+ provider: SourceControlProviderKind.make("github"),+ projectId,+ repository: "t3tools/t3code",+ number: 7,+ title: "Listed title",+ url: "https://github.com/t3tools/t3code/pull/7",+ state: "open",+ headBranch: "change-7",+ baseBranch: "main",+ updatedAt: "2026-09-09T00:00:00.000Z",+ };+ const lookup = (host: string, number: number, summaries = [listed]) =>+ knownPullRequestSummary({ host, repository: "t3tools/t3code", number }, threads, summaries);++ expect(lookup("github.com", 7, [])?.title).toBe("Change 7");+ expect(lookup("github.com", 7)?.title).toBe("Listed title");+ expect(lookup("github.com", 8)).toBeUndefined();+ expect(lookup("gitlab.com", 7)).toBeUndefined();++ const sameVersion = { ...listed, updatedAt: "2026-09-08T00:00:00.000Z" };+ const syncedAt = Date.parse(link.snapshot!.syncedAt);+ expect(lookup("github.com", 7, [{ ...sameVersion, observedAt: syncedAt - 1 }])?.title).toBe(+ "Change 7",+ );+ expect(lookup("github.com", 7, [{ ...sameVersion, observedAt: syncedAt + 1 }])?.title).toBe(+ "Listed title",+ );+ });+});+describe("rememberBounded", () => {it("moves a re-answered entry to the newest slot and evicts the oldest past the limit", () => {let snapshots: ReadonlyMap<string, number> = new Map();diff --git a/apps/mobile/src/state/use-thread-pr.ts b/apps/mobile/src/state/use-thread-pr.tsindex af14ce3827b..6c67e9f18f6 100644--- a/apps/mobile/src/state/use-thread-pr.ts+++ b/apps/mobile/src/state/use-thread-pr.ts@@ -10,10 +10,13 @@ import { Atom } from "effect/reactivity";import { use, useMemo } from "react";import { connectionAtomRuntime } from "../connection/runtime";+import { appAtomRegistry } from "./atom-registry";import { serverEnvironment } from "./server";+import { environmentThreadShells } from "./threads";import { useEnvironmentQuery } from "./query";import { ThreadPrDemandContext } from "./thread-pr-demand";import {+ knownPullRequestSummary,rememberBounded,resolveThreadPrSource,presentThreadPr,@@ -59,6 +62,21 @@ const pullRequestSummaryAtom = createLinkedPullRequestSummaryAtomFamily(export { type ThreadPr, type ThreadPrPresentation } from "./thread-pr-presentation";+/** Seeds a pull request page with a summary already in memory, never another pull request's. */+export function withKnownPullRequestSummary<+ Params extends { readonly host?: string; readonly repository: string; readonly number: number },+>(params: Params) {+ const initialSummary =+ params.host === undefined+ ? undefined+ : knownPullRequestSummary(+ { host: params.host, repository: params.repository, number: params.number },+ appAtomRegistry.get(environmentThreadShells.threadShellsAtom),+ appAtomRegistry.get(pullRequestSnapshotsAtom).values(),+ );+ return initialSummary === undefined ? params : { ...params, initialSummary };+}+export function useThreadPr(thread: EnvironmentThreadShell): ThreadPrPresentation | null {const demand = use(ThreadPrDemandContext);const supportsLinks = useAtomValue(diff --git a/apps/server/src/pullRequest/PullRequestService.test.ts b/apps/server/src/pullRequest/PullRequestService.test.tsindex 93aa60cd2c9..50581506ea1 100644--- a/apps/server/src/pullRequest/PullRequestService.test.ts+++ b/apps/server/src/pullRequest/PullRequestService.test.ts@@ -202,6 +202,73 @@ it.effect("does not wait for an in-flight detail read to display a preview", ()}),);+it.effect("shows a listed pull request's preview without asking the host again", () =>+ Effect.gen(function* () {+ let previewReads = 0;+ const service = yield* makeService({+ projects: [project({ id: "p1", title: "web", workspaceRoot: "/w", repository: "acme/web" })],+ providers: [+ fakePullRequestProvider(SourceControlProviderKind.make("github"), {+ listChangeRequests: () =>+ Effect.succeed({+ items: [changeRequest(1, "2026-07-02T00:00:00Z")],+ truncated: false,+ continues: false,+ }),+ getChangeRequestPreview: () =>+ Effect.sync(() => {+ previewReads++;+ return { ...changeRequest(1, "2026-07-02T00:00:00Z"), title: "Renamed" };+ }),+ }),+ ],+ });+ const ref = { projectId: "p1" as ProjectId, repository: "acme/web", number: 1 };+ yield* service.list({ state: "open" });+ assert.strictEqual((yield* service.preview(ref)).title, "Change request 1");+ assert.strictEqual(previewReads, 0);+ yield* service.refreshAfterTurn(ref.projectId);+ assert.strictEqual((yield* service.preview(ref)).title, "Renamed");+ assert.strictEqual(previewReads, 1);+ yield* service.list({ state: "open", limit: 1 });+ assert.strictEqual((yield* service.preview(ref)).title, "Renamed");+ }),+);++it.effect("a list read under a pinned account leaves the shared preview to the host", () =>+ Effect.gen(function* () {+ let previewReads = 0;+ const service = yield* makeService({+ projects: [project({ id: "p1", title: "web", workspaceRoot: "/w", repository: "acme/web" })],+ providers: [+ fakePullRequestProvider(SourceControlProviderKind.make("github"), {+ getRoutingIdentity: () => Effect.succeed({ accountId: "101", viewer: "octocat" }),+ withVerifiedCredential: (_, use) =>+ use({ accountId: "101", viewer: "octocat", credentialFingerprint: "pinned" }),+ listChangeRequests: () =>+ Effect.succeed({+ items: [{ ...changeRequest(1, "2026-07-02T00:00:00Z"), title: "Pinned view" }],+ truncated: false,+ continues: false,+ }),+ getChangeRequestPreview: () =>+ Effect.sync(() => {+ previewReads++;+ return changeRequest(1, "2026-07-02T00:00:00Z");+ }),+ }),+ ],+ });+ const ref = { projectId: "p1" as ProjectId, repository: "acme/web", number: 1 };+ yield* service.withRoutingCredential(+ { ...ref, host: "github.com", expectedAccountId: "101" },+ service.list({ state: "open" }),+ );+ assert.strictEqual((yield* service.preview(ref)).title, "Change request 1");+ assert.strictEqual(previewReads, 1);+ }),+);+function unusable(provider: SourceControlProviderKind, reason: "missing-tool" | "unauthenticated") {return new PullRequestProviderError({provider,diff --git a/apps/server/src/pullRequest/PullRequestService.ts b/apps/server/src/pullRequest/PullRequestService.tsindex e77434c1697..304ce2d3fa5 100644--- a/apps/server/src/pullRequest/PullRequestService.ts+++ b/apps/server/src/pullRequest/PullRequestService.ts@@ -1262,6 +1262,7 @@ export const make = Effect.gen(function* () {"PullRequestService.listUncached",)(function* (input) {const involvement = input.involvement ?? "all";+ const epochAtStart = epochCounter;const continuation = yield* decodeCursors(input.cursors);const { supported: projects, unimplemented, viewerRoots } = yield* listWorkspaceProjects(input);const projectCounts = new Map<string, number>();@@ -1549,13 +1550,25 @@ export const make = Effect.gen(function* () {for (const batch of batches) {if (batch.nextCursor !== null) nextCursors[batch.key] = batch.nextCursor;}+ const entries = batches+ .flatMap((batch) => batch.entries)+ .toSorted((left, right) => right.updatedAt.localeCompare(left.updatedAt));+ // Hover cards on listed rows read from here. A pinned account or a mid-read refresh is another+ // scope; half the cache stays free for previews read directly.+ if ((yield* routingCredential) === null && epochCounter === epochAtStart) {+ const seeds = entries+ .slice(0, DETAIL_CACHE_CAPACITY / 2)+ .map((entry) => [refCacheKey(entry), previewFields(entry)] as const)+ .toReversed();+ for (const [key, value] of seeds) {+ if (!(yield* Cache.has(previewCache, key))) yield* Cache.set(previewCache, key, value);+ }+ }return {viewers: viewers as PullRequestListResult["viewers"],providers,- entries: batches- .flatMap((batch) => batch.entries)- .toSorted((left, right) => right.updatedAt.localeCompare(left.updatedAt)),+ entries,errors: [...unreadable, ...batches.flatMap((batch) => batch.errors)],truncated: batches.some((batch) => batch.truncated),nextCursors,diff --git a/apps/web/src/components/pullRequest/PullRequestLinkPreview.browser.test.tsx b/apps/web/src/components/pullRequest/PullRequestLinkPreview.browser.test.tsxnew file mode 100644index 00000000000..29f0211eaef--- /dev/null+++ b/apps/web/src/components/pullRequest/PullRequestLinkPreview.browser.test.tsx@@ -0,0 +1,92 @@+import { EnvironmentId, ProjectId, type PullRequestSummary } from "@t3tools/contracts";+import { expect, it, vi } from "vite-plus/test";+import { page, userEvent } from "vite-plus/test/browser";++const known = vi.hoisted(+ () =>+ ({+ provider: "github",+ projectId: "project",+ repository: "owner/repo",+ number: 1,+ title: "Known title",+ url: "https://github.com/owner/repo/pull/1",+ state: "open",+ headBranch: "feature",+ baseBranch: "main",+ updatedAt: "2026-09-01T00:00:00Z",+ }) as PullRequestSummary,+);+const state = vi.hoisted(() => ({ restoredPreview: null as unknown }));+vi.mock(import("~/state/query"), async (original) => ({+ ...(await original()),+ // The host has not answered the preview read yet.+ useEnvironmentQuery: ((atom: unknown) => ({+ data: state.restoredPreview,+ dataUpdatedAt: 0,+ error: null,+ failure: null,+ isPending: atom !== null,+ isSuccess: false,+ refresh: () => undefined,+ })) as never,+}));+vi.mock(import("~/state/pullRequests"), async (original) => ({+ ...(await original()),+ useSharedPullRequestSummary: (() => known) as never,+}));++import { render } from "../../../test/render";+import { PullRequestLinkPreview } from "./PullRequestLinkPreview";++function renderPreview() {+ return render(+ <PullRequestLinkPreview+ link={<a href={known.url}>#1</a>}+ originalUrl={known.url}+ target={{+ environmentId: EnvironmentId.make("environment"),+ input: { projectId: ProjectId.make("project"), repository: "owner/repo", number: 1 },+ }}+ />,+ );+}++it("keeps a refreshing preview's state and title over an older known summary", async () => {+ state.restoredPreview = {+ projectId: "project",+ repository: "owner/repo",+ number: 1,+ title: "Renamed title",+ url: known.url,+ author: { login: "octocat" },+ state: "closed",+ isDraft: false,+ createdAt: "2026-08-01T00:00:00Z",+ };+ await using screen = await renderPreview();++ await userEvent.hover(screen.getByRole("link"));++ await expect.element(page.getByText("Renamed title")).toBeVisible();+ await expect.element(page.getByText("Closed", { exact: true })).toBeVisible();+ expect(page.getByText("Known title").query()).toBeNull();+});++it("shows the known summary while the preview loads", async () => {+ state.restoredPreview = null;+ await using screen = await render(+ <PullRequestLinkPreview+ link={<a href={known.url}>#1</a>}+ originalUrl={known.url}+ target={{+ environmentId: EnvironmentId.make("environment"),+ input: { projectId: ProjectId.make("project"), repository: "owner/repo", number: 1 },+ }}+ />,+ );++ await userEvent.hover(screen.getByRole("link"));++ await expect.element(page.getByText("Known title")).toBeVisible();+});diff --git a/apps/web/src/components/pullRequest/PullRequestLinkPreview.tsx b/apps/web/src/components/pullRequest/PullRequestLinkPreview.tsxindex f5ed4ea6553..8e3ee756023 100644--- a/apps/web/src/components/pullRequest/PullRequestLinkPreview.tsx+++ b/apps/web/src/components/pullRequest/PullRequestLinkPreview.tsx@@ -12,7 +12,7 @@ import {} from "react";import { RelativeTime } from "~/components/RelativeTime";-import { pullRequestEnvironment } from "~/state/pullRequests";+import { pullRequestEnvironment, useSharedPullRequestSummary } from "~/state/pullRequests";import { useAtomQueryRunner } from "~/state/use-atom-query-runner";import { useEnvironmentQuery } from "~/state/query";@@ -57,6 +57,10 @@ export function PullRequestLinkPreview({}): null,);+ const summary = useSharedPullRequestSummary(+ open ? target.environmentId : null,+ open ? target.input : null,+ );const readPreview = useAtomQueryRunner(pullRequestEnvironment.preview, {reportFailure: false,reportDefect: false,@@ -85,18 +89,19 @@ export function PullRequestLinkPreview({}): link;const preview = previewQuery.data;- const showCard = preview !== null || (previewQuery.error !== null && fallback !== undefined);+ const card = preview ?? summary;+ const showCard = card !== null || (previewQuery.error !== null && fallback !== undefined);const showUrlTooltip = open && previewQuery.error !== null && !showCard;const state =- preview === null+ card === null? null- : resolvePullRequestState({ state: preview.state, isDraft: preview.isDraft });+ : resolvePullRequestState({ state: card.state, isDraft: card.isDraft ?? false });const authorLabel =- preview?.author === null+ card?.author === null? "ghost"- : preview?.author.name && preview.author.name !== preview.author.login- ? `${preview.author.name} (@${preview.author.login})`- : (preview?.author.login ?? null);+ : card?.author?.name && card.author.name !== card.author.login+ ? `${card.author.name} (@${card.author.login})`+ : (card?.author?.login ?? null);return (<PreviewCard open={open} onOpenChange={setOpen} actionsRef={previewActionsRef}>@@ -116,13 +121,13 @@ export function PullRequestLinkPreview({{showCard ? (<PreviewCardPopup align="center" className="w-80 max-w-[calc(100vw-2rem)]"><div className="p-3">- {preview === null ? (+ {card === null ? (fallback) : (<div className="min-w-0"><div className="flex min-w-0 items-center gap-1.5 text-2xs text-muted-foreground">- <span className="min-w-0 truncate">{preview.repository}</span>- <span className="shrink-0">#{preview.number}</span>+ <span className="min-w-0 truncate">{card.repository}</span>+ <span className="shrink-0">#{card.number}</span><span aria-hidden>·</span>{state === null ? null : (<span className="inline-flex shrink-0 items-center gap-1">@@ -132,16 +137,22 @@ export function PullRequestLinkPreview({)}</div><p className="mt-1 text-sm font-medium leading-snug text-foreground text-pretty">- {preview.title}+ {card.title}</p>- <div className="mt-2 flex min-w-0 items-center gap-1.5 text-xs text-muted-foreground">- <PullRequestActorAvatar actor={preview.author} className="size-4" />- <span className="min-w-0 truncate">{authorLabel}</span>- <span aria-hidden>·</span>- <span className="shrink-0">- opened <RelativeTime timestamp={preview.createdAt} />- </span>- </div>+ {card.author === undefined ? null : (+ <div className="mt-2 flex min-w-0 items-center gap-1.5 text-xs text-muted-foreground">+ <PullRequestActorAvatar actor={card.author} className="size-4" />+ <span className="min-w-0 truncate">{authorLabel}</span>+ {preview === null ? null : (+ <>+ <span aria-hidden>·</span>+ <span className="shrink-0">+ opened <RelativeTime timestamp={preview.createdAt} />+ </span>+ </>+ )}+ </div>+ )}</div>)}</div>diff --git a/apps/web/src/components/pullRequest/PullRequestListGroups.tsx b/apps/web/src/components/pullRequest/PullRequestListGroups.tsxindex 7e8c4e3a26f..4eb994f7c66 100644--- a/apps/web/src/components/pullRequest/PullRequestListGroups.tsx+++ b/apps/web/src/components/pullRequest/PullRequestListGroups.tsx@@ -1,6 +1,6 @@import type { EnvironmentId, PullRequestAction } from "@t3tools/contracts";import { EyeIcon, LayersIcon, PenLineIcon, UsersIcon, type LucideIcon } from "lucide-react";-import type { RefCallback } from "react";+import { useDeferredValue, type RefCallback } from "react";import { cn } from "~/lib/utils";import { Separator } from "../ui/separator";@@ -23,18 +23,32 @@ const GROUP_ICONS: Record<string, LucideIcon> = {};const MATCHED_ELSEWHERE_SCORE = 10;+const FIRST_PAINT_ROWS = 24;++function firstPaintGroups<Group extends { entries: ReadonlyArray<unknown> }>(+ groups: ReadonlyArray<Group>,+): ReadonlyArray<Group> {+ let left = FIRST_PAINT_ROWS;+ return groups.flatMap((group) => {+ const entries = group.entries.slice(0, left);+ left -= entries.length;+ return entries.length === 0 ? [] : [{ ...group, entries }];+ });+}function PullRequestGroupHeader({group,+ count,}: {- group: { key: string; label: string; entries: ReadonlyArray<unknown> };+ group: { key: string; label: string };+ count: number;}) {const Icon = GROUP_ICONS[group.key] ?? LayersIcon;return (<div className="flex items-center gap-2 px-3 pb-1 text-xs font-medium text-muted-foreground/70"><Icon aria-hidden className="size-3.5 shrink-0" /><h2 className="shrink-0">{group.label}</h2>- <span className="shrink-0 tabular-nums text-muted-foreground/50">{group.entries.length}</span>+ <span className="shrink-0 tabular-nums text-muted-foreground/50">{count}</span><Separator className="min-w-2 flex-1" /></div>);@@ -48,6 +62,7 @@ export function PullRequestListGroups({showProvider,statsRef,onSelect,+ onIntent,hostActionsOf,onActed,closingKeys,@@ -67,18 +82,28 @@ export function PullRequestListGroups({showProvider: boolean;statsRef: RefCallback<HTMLDivElement>;onSelect: (entry: PullRequestRowTarget) => void;+ onIntent: (entry: PullRequestRowTarget | null) => void;hostActionsOf: (entry: EnvironmentPullRequestEntry) => ReadonlySet<PullRequestAction>;onActed: (result: PullRequestSpeedActionResult) => void;closingKeys: ReadonlySet<string>;sweepingKeys: ReadonlySet<string>;onCloseSweepStart: (entry: EnvironmentPullRequestEntry, event: PointerEvent) => void;}) {+ // Every row mounts tooltips and actions; painting a first screenful before the rest keeps+ // opening the page from blocking on the whole list.+ const shownGroups = useDeferredValue(groups, firstPaintGroups(groups));+ const counts = new Map(groups.map((group) => [group.key, group.entries.length]));return (<PullRequestSpeedModeProvider><div className={cn("space-y-3", sweepingKeys.size > 0 && "**:pointer-events-none")}>- {groups.map((group) => (+ {shownGroups.map((group) => (<div key={group.key} className="space-y-0.5">- {group.label ? <PullRequestGroupHeader group={group} /> : null}+ {group.label ? (+ <PullRequestGroupHeader+ group={group}+ count={counts.get(group.key) ?? group.entries.length}+ />+ ) : null}{group.entries.map((entry) => {const entryKey = pullRequestEntryKey(entry);const environmentLabel = environmentLabels?.get(entry.environmentId);@@ -102,6 +127,7 @@ export function PullRequestListGroups({selected.number === entry.number}onSelect={onSelect}+ onIntent={onIntent}hostActions={hostActionsOf(entry)}onActed={onActed}closing={closingKeys.has(entryKey)}diff --git a/apps/web/src/components/pullRequest/PullRequestRow.tsx b/apps/web/src/components/pullRequest/PullRequestRow.tsxindex 3b4d1f84c01..71fbf1100d5 100644--- a/apps/web/src/components/pullRequest/PullRequestRow.tsx+++ b/apps/web/src/components/pullRequest/PullRequestRow.tsx@@ -78,6 +78,7 @@ function PullRequestRowImpl({statsKey,statsRef,onSelect,+ onIntent,hostActions,onActed,closing = false,@@ -94,6 +95,8 @@ function PullRequestRowImpl({statsKey?: string;statsRef?: RefCallback<HTMLDivElement>;onSelect: (entry: PullRequestRowTarget) => void;+ /** The row the pointer or focus rests on, or null when it leaves. */+ onIntent?: (entry: PullRequestRowTarget | null) => void;hostActions: ReadonlySet<PullRequestAction>;onActed: (result: PullRequestSpeedActionResult) => void;closing?: boolean;@@ -115,6 +118,14 @@ function PullRequestRowImpl({type="button"aria-current={selected ? "true" : undefined}onClick={() => onSelect(entry)}+ onPointerEnter={() => onIntent?.(entry)}+ onPointerLeave={(event) => {+ if (event.currentTarget !== document.activeElement) onIntent?.(null);+ }}+ onFocus={() => onIntent?.(entry)}+ onBlur={(event) => {+ if (!event.currentTarget.matches(":hover")) onIntent?.(null);+ }}className={cn(PULL_REQUEST_ROW_CLASS,PAGE_ROW_CLASS,diff --git a/apps/web/src/components/pullRequest/PullRequestsPage.tsx b/apps/web/src/components/pullRequest/PullRequestsPage.tsxindex 1b3d1bc74c1..0fc32bce325 100644--- a/apps/web/src/components/pullRequest/PullRequestsPage.tsx+++ b/apps/web/src/components/pullRequest/PullRequestsPage.tsx@@ -64,6 +64,8 @@ import { PullRequestCompactFilterMenu } from "./PullRequestCompactFilterMenu";import { INVOLVEMENT_TABS, SORT_OPTIONS, STATE_TABS } from "./pullRequestListOptions";import { PullRequestsColumn } from "./PullRequestsColumn";import { PullRequestListGroups } from "./PullRequestListGroups";+import { pullRequestPanelReference } from "./usePullRequestDetail";+import { usePullRequestIntentPrefetch } from "./usePullRequestIntentPrefetch";import {usePullRequestDisplayGroups,usePullRequestQueryFilters,@@ -1080,6 +1082,9 @@ export function PullRequestsPage() {),);+ const prefetchEntry = usePullRequestIntentPrefetch((entry) =>+ listedPullRequestsBySurface.has(pullRequestListEntryId(entry)),+ );const selectEntry = (entry: PullRequestRowTarget) => {if (rightPanelRef === null) return;useRightPanelStore.getState().openPullRequest(rightPanelRef, entry);@@ -1184,6 +1189,7 @@ export function PullRequestsPage() {showProvider={showProvider}statsRef={registerStatsRow}onSelect={selectEntry}+ onIntent={prefetchEntry}hostActionsOf={hostActionsOf}onActed={onSpeedAction}closingKeys={closingKeys}@@ -1528,14 +1534,10 @@ export function PullRequestsPage() {selectedEnvironmentId: panelEnvironmentId,});}}- reference={{+ reference={pullRequestPanelReference({+ ...renderedPullRequestSurface,projectId: renderedPullRequestSurface.projectId as ProjectId,- repository: renderedPullRequestSurface.repository,- number: renderedPullRequestSurface.number,- ...(renderedPullRequestSurface.host- ? { host: renderedPullRequestSurface.host }- : {}),- }}+ })}listEntry={listedPullRequestsBySurface.get(pullRequestListEntryId(renderedPullRequestSurface),diff --git a/apps/web/src/components/pullRequest/usePullRequestDetail.ts b/apps/web/src/components/pullRequest/usePullRequestDetail.tsindex 7451ee38c5f..7d6ab0c7a61 100644--- a/apps/web/src/components/pullRequest/usePullRequestDetail.ts+++ b/apps/web/src/components/pullRequest/usePullRequestDetail.ts@@ -4,6 +4,7 @@ import {type EnvironmentId,type PullRequestListEntry,type PullRequestRef,+ type ProjectId,} from "@t3tools/contracts";import { useState } from "react";@@ -22,6 +23,21 @@ import {resolveDisplayedPullRequestDetail,} from "./pullRequestDetail.logic";+// Query atoms key on JSON order, so the panel and the row prefetch must build the ref here.+export function pullRequestPanelReference(target: {+ readonly projectId: ProjectId;+ readonly repository: string;+ readonly number: number;+ readonly host?: string | undefined;+}): PullRequestRef {+ return {+ projectId: target.projectId,+ repository: target.repository,+ number: target.number,+ ...(target.host ? { host: target.host } : {}),+ };+}+export function pullRequestRefKey(reference: PullRequestRef) {return `${reference.projectId}:${reference.host ?? ""}:${reference.repository}#${reference.number}`;}diff --git a/apps/web/src/components/pullRequest/usePullRequestIntentPrefetch.browser.test.tsx b/apps/web/src/components/pullRequest/usePullRequestIntentPrefetch.browser.test.tsxnew file mode 100644index 00000000000..366fb4cfe76--- /dev/null+++ b/apps/web/src/components/pullRequest/usePullRequestIntentPrefetch.browser.test.tsx@@ -0,0 +1,86 @@+import { EnvironmentId, ProjectId } from "@t3tools/contracts";+import { expect, it, vi } from "vite-plus/test";++const state = vi.hoisted(() => ({ reads: [] as Array<unknown> }));+vi.mock(import("~/state/pullRequests"), async (original) => {+ const actual = await original();+ return {+ ...actual,+ pullRequestEnvironment: {+ ...actual.pullRequestEnvironment,+ detail: ((target: unknown) => target) as never,+ },+ };+});+vi.mock(import("~/state/query"), async (original) => ({+ ...(await original()),+ useEnvironmentQuery: ((target: unknown) => {+ if (target !== null || state.reads.length > 0) state.reads.push(target);+ return {};+ }) as never,+}));++import { act, fakeTimers, render } from "../../../test/render";+import { usePullRequestIntentPrefetch } from "./usePullRequestIntentPrefetch";++const environmentId = EnvironmentId.make("environment");+const row = {+ environmentId,+ projectId: ProjectId.make("project"),+ host: "GitHub.com",+ repository: "owner/repo",+ number: 7,+};++function Rows() {+ const prefetch = usePullRequestIntentPrefetch(() => true);+ return (+ <>+ <button type="button" onClick={() => prefetch(row)}>+ rest+ </button>+ <button type="button" onClick={() => prefetch(null)}>+ leave+ </button>+ </>+ );+}++it("reads the panel's detail once intent rests on a row for 150 ms", async () => {+ state.reads = [];+ await using screen = await render(<Rows />, {+ // A bare hook probe; nothing here navigates.+ router: false,+ });+ using _timers = fakeTimers({ now: 0 });+ const rest = screen.getByRole("button", { name: "rest" }).element() as HTMLElement;+ const leave = screen.getByRole("button", { name: "leave" }).element() as HTMLElement;++ await act(() => {+ rest.click();+ leave.click();+ });+ await act(() => vi.advanceTimersByTime(1_000));+ expect(state.reads).toEqual([]);++ await act(() => rest.click());+ await act(() => vi.advanceTimersByTime(149));+ expect(state.reads).toEqual([]);+ await act(() => vi.advanceTimersByTime(1));+ // Query atoms key on JSON order: this is the order the PRs page panel reads.+ expect(JSON.stringify(state.reads.at(-1))).toBe(+ JSON.stringify({+ environmentId,+ input: {+ projectId: row.projectId,+ repository: "owner/repo",+ number: 7,+ host: "github.com",+ allowStale: false,+ },+ }),+ );++ await act(() => leave.click());+ expect(state.reads.at(-1)).toBeNull();+});diff --git a/apps/web/src/components/pullRequest/usePullRequestIntentPrefetch.ts b/apps/web/src/components/pullRequest/usePullRequestIntentPrefetch.tsnew file mode 100644index 00000000000..a078ce2c94f--- /dev/null+++ b/apps/web/src/components/pullRequest/usePullRequestIntentPrefetch.ts@@ -0,0 +1,51 @@+import type { EnvironmentId, ProjectId } from "@t3tools/contracts";+import { useRef, useState } from "react";++import { useStableCallback } from "~/hooks/useStableCallback";+import { pullRequestEnvironment } from "~/state/pullRequests";+import { useEnvironmentQuery } from "~/state/query";++import { pullRequestPanelReference } from "./usePullRequestDetail";++const INTENT_DELAY_MS = 150;++interface PullRequestIntentTarget {+ readonly environmentId: EnvironmentId;+ readonly projectId: ProjectId;+ readonly host: string;+ readonly repository: string;+ readonly number: number;+}++/**+ * Reads the detail a row's panel will ask for once the pointer or focus rests on it, so the+ * click paints from it. Passing over rows asks the host nothing, and leaving a row stops reading it.+ */+export function usePullRequestIntentPrefetch(+ isListed: (target: PullRequestIntentTarget) => boolean,+) {+ const [target, setTarget] = useState<PullRequestIntentTarget | null>(null);+ const timer = useRef<ReturnType<typeof setTimeout> | undefined>(undefined);+ // A removed row fires no leave event.+ const listed = target !== null && isListed(target);+ if (target !== null && !listed) setTarget(null);+ useEnvironmentQuery(+ target === null || !listed+ ? null+ : pullRequestEnvironment.detail({+ environmentId: target.environmentId,+ input: {+ ...pullRequestPanelReference({ ...target, host: target.host.toLowerCase() }),+ allowStale: false,+ },+ }),+ );+ return useStableCallback((next: PullRequestIntentTarget | null) => {+ clearTimeout(timer.current);+ if (next === null) {+ setTarget(null);+ return;+ }+ timer.current = setTimeout(() => setTarget(next), INTENT_DELAY_MS);+ });+}diff --git a/apps/web/src/connection/storage.browser.test.ts b/apps/web/src/connection/storage.browser.test.tsnew file mode 100644index 00000000000..2b36f9827c8--- /dev/null+++ b/apps/web/src/connection/storage.browser.test.ts@@ -0,0 +1,72 @@+import { Persistence } from "@t3tools/client-runtime/platform";+import { EnvironmentQueryStore } from "@t3tools/client-runtime/state/query-persistence";+import { EnvironmentId } from "@t3tools/contracts";+import { describe, expect, it } from "@effect/vitest";+import * as Context from "effect/Context";+import * as Effect from "effect/Effect";+import * as Layer from "effect/Layer";+import * as Option from "effect/Option";+import { TestClock } from "effect/testing";++import * as ConnectionStorage from "./storage";++describe("IndexedDB query cache", () => {+ it.effect("round trips per environment and clears with the environment", () =>+ Effect.gen(function* () {+ const store = (yield* EnvironmentQueryStore)!;+ const first = EnvironmentId.make("query-first");+ yield* store.save(first, "pr", "cached");+ expect(yield* store.load(first, "pr")).toEqual(Option.some("cached"));+ expect(yield* store.load(EnvironmentId.make("query-second"), "pr")).toEqual(Option.none());+ yield* (yield* Persistence.EnvironmentCacheStore).clear(first);+ expect(yield* store.load(first, "pr")).toEqual(Option.none());+ }).pipe(Effect.provide(ConnectionStorage.layer)),+ );++ it.effect("two tabs' bursts of saves end within 256 rows and 32 MiB", () =>+ Effect.gen(function* () {+ const openTab = Layer.build(Layer.fresh(ConnectionStorage.layer)).pipe(+ Effect.map((context) => Context.get(context, EnvironmentQueryStore)!),+ );+ const tabs = [yield* openTab, yield* openTab];+ const environmentId = EnvironmentId.make("query-bounded");+ const saveAll = (keys: ReadonlyArray<string>, payload: (key: string) => string) =>+ Effect.forEach(keys, (key, index) =>+ tabs[index % 2]!.save(environmentId, key, payload(key)).pipe(+ Effect.andThen(TestClock.adjust("1 millis")),+ ),+ );+ const loadAll = (keys: ReadonlyArray<string>) =>+ Effect.forEach(keys, (key) => tabs[0]!.load(environmentId, key)).pipe(+ Effect.map((loaded) => loaded.filter(Option.isSome).map((stored) => stored.value)),+ );++ const rows = Array.from({ length: 300 }, (_, index) => `row-${index}`);+ yield* saveAll(rows, (key) => key);+ const keptRows = yield* loadAll(rows);+ expect(keptRows.length).toBeLessThanOrEqual(256);+ expect(keptRows).not.toContain("row-0");+ expect(keptRows).toContain("row-299");++ const answer = "x".repeat(4 * 1024 * 1024);+ const large = Array.from({ length: 9 }, (_, index) => `large-${index}`);+ yield* saveAll(large, () => answer);+ const keptBytes = (yield* loadAll([...rows, ...large])).reduce(+ (total, payload) => total + payload.length,+ 0,+ );+ expect(keptBytes).toBeLessThanOrEqual(32 * 1024 * 1024);+ expect(yield* tabs[1]!.load(environmentId, "large-8")).toEqual(Option.some(answer));+ }).pipe(Effect.scoped),+ );++ it.effect("drops the older copy when an answer grows too large to keep", () =>+ Effect.gen(function* () {+ const store = (yield* EnvironmentQueryStore)!;+ const environmentId = EnvironmentId.make("query-oversize");+ yield* store.save(environmentId, "diff", "small");+ yield* store.save(environmentId, "diff", "x".repeat(4 * 1024 * 1024 + 1));+ expect(yield* store.load(environmentId, "diff")).toEqual(Option.none());+ }).pipe(Effect.provide(ConnectionStorage.layer)),+ );+});diff --git a/apps/web/src/connection/storage.ts b/apps/web/src/connection/storage.tsindex 7d9db4afdc4..78b01fc6d46 100644--- a/apps/web/src/connection/storage.ts+++ b/apps/web/src/connection/storage.ts@@ -28,7 +28,9 @@ import {pullRequestRoutingConnectionKey,pullRequestRoutingPermissionFor,} from "@t3tools/client-runtime/connection";+import { EnvironmentQueryStore } from "@t3tools/client-runtime/state/query-persistence";import { EnvironmentId, ServerConfig, ThreadId, VcsListRefsResult } from "@t3tools/contracts";+import * as Clock from "effect/Clock";import * as Context from "effect/Context";import * as Effect from "effect/Effect";import * as Layer from "effect/Layer";@@ -41,12 +43,23 @@ import * as Stream from "effect/Stream";import { projectFaviconCache } from "../assets/projectFaviconCache";const DATABASE_NAME = "t3code:connection-runtime";-const DATABASE_VERSION = 4;+const DATABASE_VERSION = 5;const CATALOG_STORE_NAME = "catalog";const SHELL_STORE_NAME = "shell";const THREAD_STORE_NAME = "thread";const SERVER_CONFIG_STORE_NAME = "server-config";const VCS_REFS_STORE_NAME = "vcs-refs";+const QUERY_STORE_NAME = "query";+const QUERY_UPDATED_INDEX_NAME = "environment-updated";+const QUERY_MAX_ROWS = 256;+const QUERY_MAX_BYTES = 32 * 1024 * 1024;+const QUERY_MAX_PAYLOAD_BYTES = 4 * 1024 * 1024;+const QUERY_MAX_AGE_MS = 30 * 24 * 60 * 60_000;+// A stats answer saves one row per listed PR, so the bounds index is walked once per batch of+// saves. Each walk trims a batch below the caps, so the caps hold between walks. The batch count+// lives in the database, so tabs sharing it share one count.+const QUERY_PRUNE_BATCH_ROWS = 32;+const QUERY_PRUNE_BATCH_BYTES = 1024 * 1024;const CATALOG_KEY = "document";const StoredShellSnapshot = StoredOrchestrationShellSnapshot;const StoredShellSnapshotJson = Schema.fromJsonString(StoredShellSnapshot);@@ -65,6 +78,10 @@ const StoredVcsRefs = Schema.Struct({refs: VcsListRefsResult,});const StoredVcsRefsJson = Schema.fromJsonString(StoredVcsRefs);+const isStoredQuery = Schema.is(+ Schema.Struct({ environmentId: Schema.String, payload: Schema.String, updatedAt: Schema.Number }),+);+const isQueryBatch = Schema.is(Schema.Struct({ rows: Schema.Number, bytes: Schema.Number }));const ConnectionCatalogDocumentJson = Schema.fromJsonString(ConnectionCatalogDocument);const decodeConnectionCatalogDocument = Schema.decodeUnknownEffect(ConnectionCatalogDocumentJson);const encodeConnectionCatalogDocument = Schema.encodeEffect(ConnectionCatalogDocumentJson);@@ -137,6 +154,11 @@ const openDatabase = Effect.fn("web.connectionStorage.openDatabase")(function* (if (!request.result.objectStoreNames.contains(VCS_REFS_STORE_NAME)) {request.result.createObjectStore(VCS_REFS_STORE_NAME);}+ if (!request.result.objectStoreNames.contains(QUERY_STORE_NAME)) {+ request.result+ .createObjectStore(QUERY_STORE_NAME)+ .createIndex(QUERY_UPDATED_INDEX_NAME, ["environmentId", "updatedAt", "bytes"]);+ }});request.addEventListener("error", () => {resume(Effect.fail(catalogError("open", request.error ?? "Unknown IndexedDB error")));@@ -326,6 +348,75 @@ function removeDatabaseValuesInRangeOnConnection(}).pipe(Effect.withSpan("web.connectionStorage.removeDatabaseValuesInRange"));}+// Mirrors mobile's pull-request cache bounds, per environment.+function saveQueryOnConnection(+ database: IDBDatabase,+ environmentId: EnvironmentId,+ key: string,+ payload: string,+ updatedAt: number,+) {+ return Effect.callback<void, ConnectionTransientError>((resume) => {+ try {+ const bytes = new TextEncoder().encode(payload).length;+ const transaction = database.transaction(QUERY_STORE_NAME, "readwrite");+ transaction.addEventListener("abort", () => {+ resume(+ Effect.fail(catalogError("write", transaction.error ?? "Unknown IndexedDB write error")),+ );+ });+ transaction.addEventListener("complete", () => {+ resume(Effect.void);+ });+ const store = transaction.objectStore(QUERY_STORE_NAME);+ // An answer too large to keep must not leave its older copy to paint on the next start.+ if (bytes > QUERY_MAX_PAYLOAD_BYTES) {+ store.delete(queryCacheKey(environmentId, key));+ return;+ }+ store.put({ environmentId, payload, updatedAt, bytes }, queryCacheKey(environmentId, key));+ const batchKey = queryBatchKey(environmentId);+ const batchRequest = store.get(batchKey);+ batchRequest.addEventListener("success", () => {+ const batch: unknown = batchRequest.result;+ const rows = (isQueryBatch(batch) ? batch.rows : 0) + 1;+ const written = (isQueryBatch(batch) ? batch.bytes : 0) + bytes;+ if (+ isQueryBatch(batch) &&+ rows < QUERY_PRUNE_BATCH_ROWS &&+ written < QUERY_PRUNE_BATCH_BYTES+ ) {+ store.put({ rows, bytes: written }, batchKey);+ return;+ }+ store.put({ rows: 0, bytes: 0 }, batchKey);+ const request = store+ .index(QUERY_UPDATED_INDEX_NAME)+ .openKeyCursor(IDBKeyRange.bound([environmentId], [environmentId, []]), "prev");+ let kept = 0;+ let totalBytes = 0;+ request.addEventListener("success", () => {+ const cursor = request.result;+ if (cursor === null) return;+ const [, rowUpdatedAt, rowBytes] = cursor.key as [string, number, number];+ kept += 1;+ totalBytes += rowBytes;+ if (+ kept > QUERY_MAX_ROWS - QUERY_PRUNE_BATCH_ROWS ||+ totalBytes > QUERY_MAX_BYTES - QUERY_PRUNE_BATCH_BYTES ||+ rowUpdatedAt < updatedAt - QUERY_MAX_AGE_MS+ ) {+ store.delete(cursor.primaryKey);+ }+ cursor.continue();+ });+ });+ } catch (cause) {+ resume(Effect.fail(catalogError("write", cause)));+ }+ }).pipe(Effect.withSpan("web.connectionStorage.saveQuery"));+}+function readDatabaseValue(database: DatabaseHandle, storeName: string, key: IDBValidKey) {return withDatabase(database, (opened) => readDatabaseValueOnConnection(opened, storeName, key));}@@ -361,6 +452,14 @@ function threadCacheKey(environmentId: EnvironmentId, threadId: ThreadId) {return `${environmentId}:${threadId}`;}+function queryCacheKey(environmentId: EnvironmentId, key: string) {+ return `${environmentId}:v1:${key}`;+}++function queryBatchKey(environmentId: EnvironmentId) {+ return `${environmentId}:batch`;+}+function vcsRefsCacheKey(environmentId: EnvironmentId, cwd: string) {return `${environmentId}:${cwd}`;}@@ -955,12 +1054,45 @@ export const layer = Layer.effectContext(VCS_REFS_STORE_NAME,IDBKeyRange.bound(`${environmentId}:`, `${environmentId}:\uffff`),),+ removeDatabaseValuesInRange(+ database,+ QUERY_STORE_NAME,+ IDBKeyRange.bound(`${environmentId}:`, `${environmentId}:\uffff`),+ ),],{ concurrency: "unbounded", discard: true },).pipe(Effect.mapError((cause) => persistenceError("clear-environment", cause)));}),});+ const queryStore: NonNullable<typeof EnvironmentQueryStore.Service> = {+ load: Effect.fn("EnvironmentQueryStore.load")(+ function* (environmentId, key) {+ const stored = yield* readDatabaseValue(+ database,+ QUERY_STORE_NAME,+ queryCacheKey(environmentId, key),+ );+ const now = yield* Clock.currentTimeMillis;+ return isStoredQuery(stored) &&+ stored.environmentId === environmentId &&+ stored.updatedAt >= now - QUERY_MAX_AGE_MS+ ? Option.some(stored.payload)+ : Option.none();+ },+ Effect.catch(() => Effect.succeedNone),+ ),+ save: (environmentId, key, payload) =>+ Clock.currentTimeMillis.pipe(+ Effect.flatMap((now) =>+ withDatabase(database, (opened) =>+ saveQueryOnConnection(opened, environmentId, key, payload, now),+ ),+ ),+ Effect.catch(() => Effect.logWarning("Offline query database save failed")),+ ),+ };+return Context.make(Persistence.ConnectionTargetStore, targetStore).pipe(Context.add(PullRequestRoutingPermissions, pullRequestRoutingPermissions),Context.add(Persistence.ConnectionRegistrationStore, registrationStore),@@ -968,6 +1100,7 @@ export const layer = Layer.effectContext(Context.add(CredentialStore.ConnectionCredentialStore, credentialStore),Context.add(TokenStore.RemoteDpopAccessTokenStore, remoteTokenStore),Context.add(Persistence.EnvironmentCacheStore, cacheStore),+ Context.add(EnvironmentQueryStore, queryStore),);}),);diff --git a/packages/client-runtime/src/state/pullRequestStatsPersistence.ts b/packages/client-runtime/src/state/pullRequestStatsPersistence.tsindex 2d97ce23d1c..75cba63031a 100644--- a/packages/client-runtime/src/state/pullRequestStatsPersistence.ts+++ b/packages/client-runtime/src/state/pullRequestStatsPersistence.ts@@ -19,8 +19,10 @@ export function persistPullRequestStats(): QueryPersistence<PullRequestListStatsload: Effect.fn("pullRequestStatsPersistence.load")(function* (environmentId, key) {const [, input] = yield* Schema.decodeEffect(requestKey)(key);- const rows = yield* Effect.forEach(input.refs, (ref) =>- row.load(environmentId, statKey(ref)),+ const rows = yield* Effect.forEach(+ input.refs,+ (ref) => row.load(environmentId, statKey(ref)),+ { concurrency: "unbounded" },);const stats = rows.flatMap((value) => (Option.isSome(value) ? [value.value] : []));return stats.length ? Option.some({ stats }) : Option.none();diff --git a/packages/client-runtime/src/state/pullRequests.ts b/packages/client-runtime/src/state/pullRequests.tsindex 64ae5ae3df5..b92f00c8a36 100644--- a/packages/client-runtime/src/state/pullRequests.ts+++ b/packages/client-runtime/src/state/pullRequests.ts@@ -21,7 +21,7 @@ import {type PullRequestRef,type PullRequestMergeMethod,PullRequestOperationError,- type PullRequestSummary,+ PullRequestSummary,type VcsStatusResult,} from "@t3tools/contracts";import * as Effect from "effect/Effect";@@ -147,6 +147,7 @@ export function createLinkedPullRequestSummaryAtomFamily<R, E>(const routedRequest = createPullRequestRouter();return createEnvironmentRpcQueryAtomFamily(runtime, {label: "environment-data:pull-requests:linked-summary",+ persistence: persistQuery(PullRequestSummary),tag: WS_METHODS.pullRequestsSummary,execute: (input) => routedRequest(WS_METHODS.pullRequestsSummary, input),staleTimeMs: 60_000,diff --git a/packages/client-runtime/src/state/runtime.test.ts b/packages/client-runtime/src/state/runtime.test.tsindex 381623f2320..f79f00cdaa8 100644--- a/packages/client-runtime/src/state/runtime.test.ts+++ b/packages/client-runtime/src/state/runtime.test.ts@@ -1370,19 +1370,20 @@ describe("persisted environment queries", () => {Effect.scoped(Effect.gen(function* () {let saved = Option.none<string>();+ const saves = yield* Queue.unbounded<string>();const persistence: QueryPersistence<string> = {load: () => Effect.sync(() => saved),save: (_environmentId, _key, value) =>Effect.sync(() => {saved = Option.some(value);- }),+ }).pipe(Effect.andThen(Queue.offer(saves, value))),};const first = yield* makeEnvironmentQueryHarness(Effect.succeed("first"), {persistence,});const firstRegistry = yield* mountEnvironmentQuery(first.atom);expect(yield* readEnvironmentQuery(firstRegistry, first.atom)).toBe("first");- expect(saved).toEqual(Option.some("first"));+ expect(yield* Queue.take(saves)).toBe("first");const restarted = yield* makeEnvironmentQueryHarness(Effect.succeed("updated"), {persistence,@@ -1393,11 +1394,36 @@ describe("persisted environment queries", () => {yield* SubscriptionRef.set(restarted.supervisorState, queryConnectionState());yield* Effect.yieldNow;expect(yield* readEnvironmentQuery(registry, restarted.atom)).toBe("updated");- expect(saved).toEqual(Option.some("updated"));+ expect(yield* Queue.take(saves)).toBe("updated");}),),);+ it.effect("answers readers while its save is pending, and ends the save with the query", () =>+ Effect.scoped(+ Effect.gen(function* () {+ const saveEnded = Latch.makeUnsafe();+ const harness = yield* makeEnvironmentQueryHarness(Effect.succeed("fresh"), {+ persistence: {+ load: () => Effect.succeedNone,+ // The registry's scheduler stops on dispose, so signal synchronously.+ save: () =>+ Effect.never.pipe(+ Effect.onInterrupt(() => Effect.sync(() => saveEnded.openUnsafe())),+ ),+ },+ });+ yield* Effect.scoped(+ Effect.gen(function* () {+ const registry = yield* mountEnvironmentQuery(harness.atom);+ expect(yield* readEnvironmentQuery(registry, harness.atom)).toBe("fresh");+ }),+ );+ yield* saveEnded.await;+ }),+ ),+ );+it.effect("hands each server answer to onAnswer before readers see it", () =>Effect.scoped(Effect.gen(function* () {diff --git a/packages/client-runtime/src/state/runtime.ts b/packages/client-runtime/src/state/runtime.tsindex 58c37070fd8..78e0cec6437 100644--- a/packages/client-runtime/src/state/runtime.ts+++ b/packages/client-runtime/src/state/runtime.ts@@ -781,8 +781,12 @@ export function createEnvironmentQueryAtomFamily<R, ER, Input, A, E>(return cached.value;}if (Option.isNone(previous) && Option.isSome(cached)) yield* emit(cached.value);+ // Readers must not wait on the disk: web saves one IndexedDB row per listed PR's stats.+ // The save ends with the query, so a removed environment's cache stays cleared.return yield* answer().pipe(- Effect.tap((value) => persistence.save(target.environmentId, cacheKey, value)),+ Effect.tap((value) =>+ persistence.save(target.environmentId, cacheKey, value).pipe(Effect.forkScoped),+ ),);});})diff --git a/packages/source-control-github/src/server/GitHubPullRequestApi.test.ts b/packages/source-control-github/src/server/GitHubPullRequestApi.test.tsindex 5a5c46f28d9..b676a91f0ca 100644--- a/packages/source-control-github/src/server/GitHubPullRequestApi.test.ts+++ b/packages/source-control-github/src/server/GitHubPullRequestApi.test.ts@@ -820,6 +820,74 @@ layer("GitHubPullRequestApi.layer", (it) => {}),);+ it.effect("reads commit stats alongside later activity pages", () =>+ Effect.gen(function* () {+ const laterPageStarted = yield* Deferred.make<void>();+ const statsStarted = yield* Deferred.make<void>();+ const activityPage = (head: boolean) => ({+ data: {+ repository: {+ pullRequest: {+ ...(head+ ? {+ author: null,+ commits: {+ nodes: [+ {+ commit: {+ id: "node-regular",+ oid: "regular",+ messageHeadline: "regular",+ committedDate: "2026-07-05T00:00:00Z",+ parents: { totalCount: 1 },+ authors: { nodes: [] },+ },+ },+ ],+ },+ }+ : {}),+ comments: {+ nodes: [],+ pageInfo: head ? { hasNextPage: true, endCursor: "c1" } : lastPage,+ },+ reviews: { nodes: [], pageInfo: lastPage },+ },+ },+ },+ });+ mockedExecute.mockImplementation((call) => {+ if (matches(call, "PullRequestCommitStats")) {+ return Deferred.succeed(statsStarted, undefined).pipe(+ Effect.andThen(Deferred.await(laterPageStarted)),+ Effect.as(+ output(+ encodeJson({+ data: {+ nodes: [{ __typename: "Commit", oid: "regular", additions: 3, deletions: 1 }],+ },+ }),+ ),+ ),+ );+ }+ const head = call.kind === "graphql" && call.variables?.["head"] === true;+ return head+ ? Effect.succeed(output(encodeJson(activityPage(true))))+ : Deferred.succeed(laterPageStarted, undefined).pipe(+ Effect.andThen(Deferred.await(statsStarted)),+ Effect.as(output(encodeJson(activityPage(false)))),+ );+ });+ const cli = yield* GitHubPullRequestApi.GitHubPullRequestApi;++ const activity = yield* cli.getPullRequestActivity(pullRequestInput);++ expect(activity.commits[0]).toMatchObject({ additions: 3, deletions: 1 });+ expect(mockedExecute).toHaveBeenCalledTimes(3);+ }),+ );+it.effect("loads the complete hover card with one GraphQL request", () =>Effect.gen(function* () {mockedExecute.mockReturnValueOnce(@@ -3299,7 +3367,10 @@ layer("GitHubPullRequestApi.layer", (it) => {Effect.succeed(output(reviewThreadsPage([thread("T3", "c3")], null))),);const cli = yield* GitHubPullRequestApi.GitHubPullRequestApi;- const read = cli.listReviewThreadComments(pullRequestInput);+ const read = cli.listReviewThreadComments({+ ...pullRequestInput,+ repository: `acme/refused-threads-${later}`,+ });const conversation = yield* read;expect(variablesOf("ReviewThreads").map((v) => [v["after"], v["requestedReviewers"]]),@@ -3327,7 +3398,7 @@ layer("GitHubPullRequestApi.layer", (it) => {yield* read;expect(variablesOf("ReviewThreads").at(-1)).toMatchObject({after: null,- requestedReviewers: 50,+ requestedReviewers: 0,});}),);@@ -3460,7 +3531,10 @@ layer("GitHubPullRequestApi.layer", (it) => {),);const cli = yield* GitHubPullRequestApi.GitHubPullRequestApi;- const read = cli.getPullRequestDetail(pullRequestInput);+ const read = cli.getPullRequestDetail({+ ...pullRequestInput,+ repository: `acme/refused-checks-${refused}`,+ });const detail = yield* read;expect(detail.reviewRequestLogins).toEqual([]);expect(detail.reviewRequestTeams).toEqual([]);@@ -3480,7 +3554,8 @@ layer("GitHubPullRequestApi.layer", (it) => {if (refused) {mockedExecute.mockReturnValueOnce(Effect.succeed(output(encodeJson(coreResponse()))));yield* read;- expect(variablesOf("PullRequestCore").at(-1)).toMatchObject({ requestedReviewers: 100 });+ expect(variablesOf("PullRequestCore").at(-1)).toMatchObject({ requestedReviewers: 0 });+ expect(mockedExecute).toHaveBeenCalledTimes(4);}}),);@@ -3514,7 +3589,7 @@ layer("GitHubPullRequestApi.layer", (it) => {const error = yield* Effect.flip(cli.getPullRequestDetail({cwd: "/w",- repository: "acme/web",+ repository: `acme/head-changed-${refused}`,host: "github.com",number: 7,}),diff --git a/packages/source-control-github/src/server/GitHubPullRequestApi.ts b/packages/source-control-github/src/server/GitHubPullRequestApi.tsindex 2defbb66849..cb96b97d855 100644--- a/packages/source-control-github/src/server/GitHubPullRequestApi.ts+++ b/packages/source-control-github/src/server/GitHubPullRequestApi.ts@@ -1422,6 +1422,31 @@ export const make = Effect.gen(function* () {};});+ // GitHub refuses a requested-reviewer list holding a team the viewer cannot see. Remember the+ // refusal so later reads of that pull request skip straight to the read without reviewers.+ const refusedReviewers = yield* Cache.make({+ capacity: 512,+ timeToLive: "10 minutes",+ lookup: (_key: string) => Effect.void,+ });+ const readRequestedReviewers = Effect.fn("GitHubPullRequestApi.readRequestedReviewers")(+ function* <A, E, R>(+ input: { readonly host: string; readonly repository: string; readonly number: number },+ wanted: number,+ read: (requestedReviewers: number) => Effect.Effect<A, E, R>,+ ) {+ const host = normalizeHost(input.host);+ const { fingerprint } = yield* api.credential(host);+ const key = `${fingerprint}\0${host}\0${input.repository.toLowerCase()}\0${input.number}`;+ if (yield* Cache.has(refusedReviewers, key)) return yield* read(0);+ return yield* read(wanted).pipe(+ Effect.catchIf(isRefusedRequestedReviewersOnly, () =>+ Cache.set(refusedReviewers, key, undefined).pipe(Effect.andThen(read(0))),+ ),+ );+ },+ );+const getPullRequestDetail: GitHubPullRequestApi["Service"]["getPullRequestDetail"] = (input) => {const { owner, name } = parseRepositorySelector(input.repository);const operation = "getPullRequestDetail";@@ -1436,8 +1461,7 @@ export const make = Effect.gen(function* () {});return SourceControlRateLimit.Interactive.pipe(Effect.flatMap((allowReserve) =>- read(100).pipe(- Effect.catchIf(isRefusedRequestedReviewersOnly, () => read(0)),+ readRequestedReviewers(input, 100, read).pipe(graphql({ ...input, operation, allowReserve }),Effect.map(toPullRequestCore),Effect.flatMap(found({ ...input, operation })),@@ -2031,7 +2055,9 @@ export const make = Effect.gen(function* () {let withComments = true;let withReviews = true;const target = { ...input, operation: "getPullRequestActivity" };- for (let page = 0; page < REVIEW_THREAD_PAGES && (withComments || withReviews); page++) {+ const readPage = Effect.fn("GitHubPullRequestApi.readActivityPage")(function* (+ page: number,+ ) {const read: GitHubPullRequestActivityPage = yield* client.PullRequestActivity({owner,@@ -2058,16 +2084,28 @@ export const make = Effect.gen(function* () {reviewsAfter = read.nextReviewsCursor;withComments = withComments && commentsAfter !== null;withReviews = withReviews && reviewsAfter !== null;- }+ });+ yield* readPage(0);+ const laterPages = Effect.gen(function* () {+ for (let page = 1; page < REVIEW_THREAD_PAGES; page++) {+ if (!withComments && !withReviews) return;+ yield* readPage(page);+ }+ });const emptyStats = toPullRequestCommitStats({ nodes: [] });- const commitStats =- nonMergeCommitIds.length === 0- ? emptyStats- : yield* client.PullRequestCommitStats({ ids: nonMergeCommitIds }).pipe(- graphql(target),- Effect.map(toPullRequestCommitStats),- Effect.orElseSucceed(() => emptyStats),- );+ const [, commitStats] = yield* Effect.all(+ [+ laterPages,+ nonMergeCommitIds.length === 0+ ? Effect.succeed(emptyStats)+ : client.PullRequestCommitStats({ ids: nonMergeCommitIds }).pipe(+ graphql(target),+ Effect.map(toPullRequestCommitStats),+ Effect.orElseSucceed(() => emptyStats),+ ),+ ],+ { concurrency: 2 },+ );return {author,comments: remarks.toSorted((left, right) =>@@ -2157,25 +2195,12 @@ export const make = Effect.gen(function* () {function* (input) {const { owner, name } = parseRepositorySelector(input.repository);const target = { ...input, operation: "listReviewThreadComments" };- let requestedReviewers = 50;const threadPage = (after: string | null,- ): Effect.Effect<GitHubReviewThreadPage, GitHubPullRequestApiError> => {- const read = () =>- client.ReviewThreads({ owner, name, number: input.number, after, requestedReviewers });- return read().pipe(- Effect.catchIf(- (error) => requestedReviewers > 0 && isRefusedRequestedReviewersOnly(error),- () => {- requestedReviewers = 0;- return read();- },- ),- graphql(target),- Effect.map(toReviewThreadPage),- Effect.flatMap(found(target)),- );- };+ ): Effect.Effect<GitHubReviewThreadPage, GitHubPullRequestApiError> =>+ readRequestedReviewers(input, 50, (requestedReviewers) =>+ client.ReviewThreads({ owner, name, number: input.number, after, requestedReviewers }),+ ).pipe(graphql(target), Effect.map(toReviewThreadPage), Effect.flatMap(found(target)));const entries: GitHubReviewThreadEntry[] = [];const avatarsByLogin = new Map<string, string>();const botLogins = new Set<string>();