Skip to content
TypeScript

fix(muse): the thread error banner no longer shows unredacted failure text (#29910)

Alex Southwell1f87f64bfd4e
diff --git a/packages/provider-muse/src/server/adapter.test.ts b/packages/provider-muse/src/server/adapter.test.ts
index da740b92d2e..847c2b4551c 100644
--- a/packages/provider-muse/src/server/adapter.test.ts
+++ b/packages/provider-muse/src/server/adapter.test.ts
@@ -767,12 +767,20 @@ describe("MuseAdapterV2", () => {
yield* fake.emit("turn/completed", {
turnId: nativeId,
terminal: "failed",
- error: { message: "Provider rejected this turn" },
+ error: { message: "Provider rejected this turn: api_key=abc123" },
});
const terminal = yield* harness.takeEvent("turn.terminal");
assert.strictEqual(terminal.status, "failed");
assert.strictEqual(terminal.threadDisposition, "reusable");
- assert.isNotNull(terminal.failure);
+ assert.strictEqual(
+ terminal.failure?.message,
+ "Provider rejected this turn: api_key=[REDACTED]",
+ );
+ assert.strictEqual(
+ harness.allEvents.findLast((event) => event.type === "provider_session.updated")
+ ?.providerSession.lastError,
+ terminal.failure?.message,
+ );
assert.isTrue(
harness.allEvents.some(
(event) =>
diff --git a/packages/provider-muse/src/server/adapter.ts b/packages/provider-muse/src/server/adapter.ts
index 575562948c9..354e457b2ca 100644
--- a/packages/provider-muse/src/server/adapter.ts
+++ b/packages/provider-muse/src/server/adapter.ts
@@ -395,7 +395,14 @@ export const makeMuseAdapterV2 = Effect.fn("makeMuseAdapterV2")(function* (
status: OrchestrationV2ProviderSession["status"],
lastError: string | null = null,
) {
- session = { ...session, status, lastError, updatedAt: yield* DateTime.now };
+ session = {
+ ...session,
+ status,
+ // lastError is the thread banner, so it gets the failure item's bounded, redacted text.
+ lastError:
+ lastError === null ? null : makeProviderFailure({ message: lastError }).message,
+ updatedAt: yield* DateTime.now,
+ };
yield* emit({
type: "provider_session.updated",
driver: MUSE_PROVIDER,