TypeScript
fix(pi): the T3 MCP extension file is written atomically (#32231)
Rishabh_t106257e4073c1c5
diff --git a/packages/provider-pi/src/server/mcpInjection.test.ts b/packages/provider-pi/src/server/mcpInjection.test.tsindex 4e776058a66..f1a8496bbfa 100644--- a/packages/provider-pi/src/server/mcpInjection.test.ts+++ b/packages/provider-pi/src/server/mcpInjection.test.ts@@ -1,4 +1,4 @@-import { assert, describe, it } from "@effect/vitest";+import { assert, describe, expect, it } from "@effect/vitest";import { EnvironmentId, ProviderInstanceId, ThreadId } from "@t3tools/contracts";import {@@ -7,7 +7,18 @@ import {T3_PI_RUNTIME_MODE_ENV,T3_PI_MCP_EXTENSION_PATH_ENV,} from "./mcpExtensionSource.ts";-import { buildPiRpcLaunch, resolvePiLaunchArgs } from "./mcpInjection.ts";+import * as Effect from "effect/Effect";+import * as Fiber from "effect/Fiber";+import * as Option from "effect/Option";+import * as NodePath from "effect/Path";+import * as NodeFS from "effect/FileSystem";+import * as NodeServices from "@effect/platform-node/NodeServices";+import {+ buildPiRpcLaunch,+ materializePiT3McpExtension,+ resolvePiLaunchArgs,+} from "./mcpInjection.ts";+import { PI_T3_MCP_EXTENSION_SOURCE } from "./mcpExtensionSource.ts";const threadId = ThreadId.make("thread-pi-t3-mcp");@@ -145,3 +156,53 @@ describe("pi T3 MCP injection", () => {assert.isTrue(resolvePiLaunchArgs("--model deepseek/v4").ok);});});++describe("materializePiT3McpExtension", () => {+ // A pi launch concurrent with the materialize reads the extension file from+ // disk; a truncate-then-write exposes an empty or partial file mid-write and+ // the launch loads a broken extension.+ it.live("never exposes a torn extension file to a concurrent reader", () =>+ Effect.gen(function* () {+ const fs = yield* NodeFS.FileSystem;+ const path = yield* NodePath.Path;+ const directory = yield* fs.makeTempDirectoryScoped({ prefix: "t3-pi-atomic-" });+ const anomalies: Array<string> = [];+ const stopAfter = 120;+ const writer = yield* Effect.forkChild(+ Effect.gen(function* () {+ for (let index = 0; index < stopAfter; index += 1) {+ yield* fs+ .remove(path.join(directory, "pi-t3-mcp-extension.ts"), { force: true })+ .pipe(Effect.ignore);+ yield* Effect.all(+ [materializePiT3McpExtension(directory), materializePiT3McpExtension(directory)],+ { concurrency: "unbounded" },+ );+ }+ }).pipe(Effect.scoped, Effect.provide(NodeServices.layer)),+ );+ const reader = yield* Effect.forkChild(+ Effect.forever(+ Effect.gen(function* () {+ const text = yield* fs+ .readFileString(path.join(directory, "pi-t3-mcp-extension.ts"))+ .pipe(Effect.option);+ if (Option.isNone(text)) return; // Missing between writes: legitimate.+ // A read that SUCCEEDS must return the full extension: an empty or+ // partial read means the writer truncated the file mid-write.+ if (text.value.length === 0) {+ anomalies.push("empty: truncated mid-write");+ } else if (text.value.length !== PI_T3_MCP_EXTENSION_SOURCE.length) {+ anomalies.push(+ `partial: ${text.value.length} of ${PI_T3_MCP_EXTENSION_SOURCE.length} chars`,+ );+ }+ }),+ ),+ );+ yield* Fiber.join(writer);+ yield* Fiber.interrupt(reader);+ expect(anomalies).toEqual([]);+ }).pipe(Effect.provide(NodeServices.layer)),+ );+});diff --git a/packages/provider-pi/src/server/mcpInjection.ts b/packages/provider-pi/src/server/mcpInjection.tsindex d88cdeb434c..679b81ac33b 100644--- a/packages/provider-pi/src/server/mcpInjection.ts+++ b/packages/provider-pi/src/server/mcpInjection.ts@@ -232,7 +232,16 @@ export const materializePiT3McpExtension = Effect.fn("materializePiT3McpExtensioconst dest = piT3McpExtensionDestPath(cacheDir);const existing = yield* fs.readFileString(dest).pipe(Effect.orElseSucceed(() => ""));if (existing !== PI_T3_MCP_EXTENSION_SOURCE) {- yield* fs.writeFileString(dest, PI_T3_MCP_EXTENSION_SOURCE);+ // Concurrent pi launches read this file: stage it in a per-call directory+ // and rename so readers and other writers never see a partial file.+ yield* Effect.scoped(+ Effect.gen(function* () {+ const stagingDir = yield* fs.makeTempDirectoryScoped({ directory: cacheDir });+ const staging = `${stagingDir.replace(/\\/g, "/")}/${PI_T3_MCP_EXTENSION_FILENAME}`;+ yield* fs.writeFileString(staging, PI_T3_MCP_EXTENSION_SOURCE);+ yield* fs.rename(staging, dest).pipe(Effect.retry({ times: 3 }));+ }),+ );}return dest;});