TypeScript
fix(forgejo): read author assignees once (#30686)
Johan Vaz8b9a95419377
diff --git a/packages/source-control-forgejo/src/server/ForgejoPullRequestProvider.ts b/packages/source-control-forgejo/src/server/ForgejoPullRequestProvider.tsindex d3b7cd6d4ba..3a089e65c04 100644--- a/packages/source-control-forgejo/src/server/ForgejoPullRequestProvider.ts+++ b/packages/source-control-forgejo/src/server/ForgejoPullRequestProvider.ts@@ -704,12 +704,11 @@ export const make = Effect.gen(function* () {// Before anything is typed the repository's own people stand in; a search reaches// contributors from forks, who are never assignable.if (query.length === 0) {- const users = yield* page(+ const users = yield* readArray({ ...input, path: `${repoPath(input)}/assignees` },ForgejoUser,- 100,);- return { items: actors(users.items), truncated: users.truncated };+ return { items: actors(users), truncated: false };}const found = yield* readLinked({diff --git a/packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.test.ts b/packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.test.tsindex 586ce19f28d..fbfe278b32b 100644--- a/packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.test.ts+++ b/packages/source-control-forgejo/src/server/ForgejoSourceControlProvider.test.ts@@ -708,6 +708,43 @@ it.effect("lists nothing for an author Forgejo has no account for", () =>),);+it.effect.each([+ { query: undefined, count: 3 },+ { query: "", count: 3 },+ { query: " \t ", count: 3 },+ { query: "", count: 101 },+])("reads all $count assignees once for author query '$query'", ({ query, count }) => {+ const paths: string[] = [];+ const users = Array.from({ length: count }, (_, index) => ({ login: `dev-${index}` }));+ return Effect.gen(function* () {+ const provider = yield* ForgejoPullRequestProvider.make;+ const search = provider.searchRepositoryAuthors;+ if (search === undefined) return yield* Effect.die("author search missing");+ const found = yield* search({+ cwd: "/repo",+ repository: "maria/project",+ host: "forgejo.test",+ ...(query === undefined ? {} : { query }),+ });+ assert.strictEqual(paths.length, 1);+ assert.deepStrictEqual(found, {+ items: users.map(({ login }) => ({ login, name: null, avatarUrl: null })),+ truncated: false,+ });+ }).pipe(+ Effect.provide(+ Layer.mock(ForgejoCli.ForgejoCli)({+ api: (input) => {+ paths.push(input.path);+ assert.strictEqual(input.path.split("?")[0], "repos/maria/project/assignees");+ // Forgejo ignores paging here: every page is the full list, with no Link header.+ return encodeJsonEffect(users).pipe(Effect.orDie, Effect.map(processOutput));+ },+ }),+ ),+ );+});+it.effect("says an author search was cut short by a server that pages below its limit", () =>Effect.gen(function* () {const provider = yield* ForgejoPullRequestProvider.make;