Skip to content
TypeScript

fix(web): the citation comment box opens at the quote instead of sliding in from the corner (#32141)

Julius Marminge8bf1b64cae37
diff --git a/apps/web/src/components/chat/AssistantCitationChip.browser.test.tsx b/apps/web/src/components/chat/AssistantCitationChip.browser.test.tsx
index deee8d7afa6..e1b66e1fed8 100644
--- a/apps/web/src/components/chat/AssistantCitationChip.browser.test.tsx
+++ b/apps/web/src/components/chat/AssistantCitationChip.browser.test.tsx
@@ -129,6 +129,26 @@ describe("citation comment source disappearance", () => {
});
describe("citation comment popup position", () => {
+ it("opens at its anchor instead of sliding in from the window corner", async () => {
+ using source = setup();
+ await using _screen = await mount(
+ source.sourceAnchor,
+ vi.fn(() => true),
+ );
+ const positioner = () =>
+ document.querySelector<HTMLElement>('[data-slot="popover-positioner"]');
+ await vi.waitFor(() => expect(positioner()?.style.opacity).not.toBe("0"));
+
+ const moves = positioner()!
+ .getAnimations()
+ .filter(
+ (animation) =>
+ animation instanceof CSSTransition &&
+ ["transform", "top", "left"].includes(animation.transitionProperty),
+ );
+ expect(moves).toEqual([]);
+ });
+
it("stays on screen when the cited text ends in a code block's hidden overflow", async () => {
using _source = setup();
const message = document.createElement("div");
diff --git a/apps/web/src/components/ui/popover.tsx b/apps/web/src/components/ui/popover.tsx
index 788c8a1043d..e03aee40115 100644
--- a/apps/web/src/components/ui/popover.tsx
+++ b/apps/web/src/components/ui/popover.tsx
@@ -78,7 +78,9 @@ function PopoverPopup({
collisionAvoidance={collisionAvoidance}
collisionPadding={variant === "panel" ? 0 : undefined}
className={cn(
- "h-(--positioner-height) max-h-(--available-height) w-(--positioner-width) max-w-(--available-width) transition-transform data-instant:transition-none",
+ "h-(--positioner-height) max-h-(--available-height) w-(--positioner-width) max-w-(--available-width)",
+ // Kept-mounted positioners first paint at the window origin, so a transform transition slides them in from there.
+ !keepMounted && "transition-transform data-instant:transition-none",
variant === "panel"
? "z-(--z-sheet) w-[min(calc(var(--thread-details-panel-width)+--spacing(4)),calc(var(--anchor-width)---spacing(2)))] transition-[top] duration-150 ease-out data-instant:transition-[top] motion-reduce:transition-none motion-reduce:data-instant:transition-none"
: "z-[130]",