TypeScript
fix(server): explain fake-IP DNS failures in HTML previews (#30318)
shivamb1f1731cabd5
diff --git a/apps/server/src/htmlRender/headlessChrome.ts b/apps/server/src/htmlRender/headlessChrome.tsindex 5e2a5bb0d58..ea50cce46cd 100644--- a/apps/server/src/htmlRender/headlessChrome.ts+++ b/apps/server/src/htmlRender/headlessChrome.ts@@ -105,6 +105,15 @@ const decodeLogEntryAdded = Schema.decodeUnknownOption(}),);+const clipConsoleText = (text: string) => {+ if (text.length <= MAX_CONSOLE_TEXT_CHARS) return text;+ // Half an emoji serializes to a lone surrogate escape, which provider JSON parsers reject.+ const last = text.charCodeAt(MAX_CONSOLE_TEXT_CHARS - 1);+ const end =+ last >= 0xd800 && last <= 0xdbff ? MAX_CONSOLE_TEXT_CHARS - 1 : MAX_CONSOLE_TEXT_CHARS;+ return `${text.slice(0, end)}…`;+};+const remoteObjectText = (value: typeof RemoteObject.Type) =>typeof value.value === "string"? value.value@@ -173,7 +182,7 @@ const launchBrowser = Effect.fnUntraced(function* (input: {readonly profileDirectory: string;}) {const spawner = yield* ChildProcessSpawner.ChildProcessSpawner;- const proxyPort = yield* publicProxy.pipe(+ const proxy = yield* publicProxy.pipe(Effect.mapError((cause) => new HtmlRenderBrowserError({ reason: "the preview proxy could not start", cause }),),@@ -192,7 +201,7 @@ const launchBrowser = Effect.fnUntraced(function* (input: {"--hide-scrollbars","--mute-audio","--block-new-web-contents",- `--proxy-server=socks5://127.0.0.1:${proxyPort}`,+ `--proxy-server=socks5://127.0.0.1:${proxy.port}`,// Loopback would otherwise skip the proxy."--proxy-bypass-list=<-loopback>",// WebRTC would otherwise send UDP, which no proxy carries.@@ -315,14 +324,9 @@ const launchBrowser = Effect.fnUntraced(function* (input: {page.omittedConsoleMessages += 1;return yield* Effect.void;}- const text = consoleMessage.text.replaceAll(PAGE_URL, PAGE_NAME);- // Half an emoji serializes to a lone surrogate escape, which provider JSON parsers reject.- const last = text.charCodeAt(MAX_CONSOLE_TEXT_CHARS - 1);- const end =- last >= 0xd800 && last <= 0xdbff ? MAX_CONSOLE_TEXT_CHARS - 1 : MAX_CONSOLE_TEXT_CHARS;page.consoleMessages.push({level: consoleMessage.level,- text: text.length > MAX_CONSOLE_TEXT_CHARS ? `${text.slice(0, end)}…` : text,+ text: clipConsoleText(consoleMessage.text.replaceAll(PAGE_URL, PAGE_NAME)),});return yield* Effect.void;});@@ -533,7 +537,16 @@ const launchBrowser = Effect.fnUntraced(function* (input: {return { load, screenshot, consoleMessages, close };});- return { openPage };+ // Each capture opens one page per browser, so this note belongs to that page alone.+ const fakeIpNote = (): ReadonlyArray<ConsoleMessage> =>+ [...proxy.fakeIpHosts].map(([host, address]) => ({+ level: "warning",+ text: clipConsoleText(+ `DNS returned blocked 198.18.0.0/15 addresses, which may come from Clash or Mihomo fake-IP DNS. Inline the resource, add its host to fake-ip-filter, or switch DNS to redir-host. Affected host: ${host} (${address})`,+ ),+ }));++ return { openPage, fakeIpNote };});const scratchDirectory = Effect.gen(function* () {@@ -569,7 +582,12 @@ export const captureHtmlScreenshot = Effect.fn("headlessChrome.captureHtmlScreenconst contentHeight = yield* page.load(pageBody(input.html), input.urlFragment);const capturedHeight = Math.max(1, Math.min(contentHeight, MAX_CAPTURE_HEIGHT));const png = yield* page.screenshot(capturedHeight);- return { png, contentHeight, capturedHeight, consoleMessages: page.consoleMessages() };+ return {+ png,+ contentHeight,+ capturedHeight,+ consoleMessages: [...page.consoleMessages(), ...browser.fakeIpNote()],+ };},Effect.scoped,Effect.timeoutOrElse({diff --git a/apps/server/src/htmlRender/publicProxy.test.ts b/apps/server/src/htmlRender/publicProxy.test.tsindex 12d0dd65ad3..f04b7fafb30 100644--- a/apps/server/src/htmlRender/publicProxy.test.ts+++ b/apps/server/src/htmlRender/publicProxy.test.ts@@ -2,6 +2,8 @@import { describe, expect, it } from "@effect/vitest";import { vi } from "vite-plus/test";import * as Effect from "effect/Effect";+import type * as NodeDns from "node:dns";+import * as NodeDnsPromises from "node:dns/promises";import * as NodeNet from "node:net";import * as NodeOS from "node:os";@@ -28,6 +30,23 @@ vi.mock("node:os", async (importOriginal) => {};});+// Clash and Mihomo answer every name from 198.18.0.0/16 in fake-IP mode.+const TEST_DNS: Record<string, ReadonlyArray<{ address: string; family: number }>> = {+ "cdn.fake-ip.test": [{ address: "198.18.2.40", family: 4 }],+ "mixed.fake-ip.test": [+ { address: "93.184.215.14", family: 4 },+ { address: "198.18.2.41", family: 4 },+ ],+};+vi.mock("node:dns/promises", async (importOriginal) => {+ const actual = await importOriginal<typeof NodeDnsPromises>();+ return {+ ...actual,+ lookup: (host: string, options: NodeDns.LookupOptions) =>+ TEST_DNS[host] ? Promise.resolve(TEST_DNS[host]) : actual.lookup(host, options),+ };+});+const connectThrough = (proxyPort: number, target: Buffer, version = 5) =>Effect.callback<{ readonly code: number; readonly socket: NodeNet.Socket }>((resume) => {const socket = NodeNet.connect(proxyPort, "127.0.0.1", () => {@@ -82,7 +101,7 @@ const domainTarget = (host: string, port: number) => {describe("publicProxy", () => {it.effect("refuses loopback and private targets, by address or by name", () =>Effect.gen(function* () {- const port = yield* publicProxy;+ const { port } = yield* publicProxy;for (const target of [ipv4Target("127.0.0.1", 80),ipv4Target("10.1.2.3", 80),@@ -105,9 +124,21 @@ describe("publicProxy", () => {}).pipe(Effect.scoped),);+ it.effect("refuses fake-IP names and records hosts whose every address is fake", () =>+ Effect.gen(function* () {+ const { port, fakeIpHosts } = yield* publicProxy;+ for (const host of ["cdn.fake-ip.test", "mixed.fake-ip.test"]) {+ const { code, socket } = yield* connectThrough(port, domainTarget(host, 443));+ socket.destroy();+ expect(code).toBe(2);+ }+ expect([...fakeIpHosts]).toEqual([["cdn.fake-ip.test", "198.18.2.40"]]);+ }).pipe(Effect.scoped),+ );+it.effect("refuses every address this machine holds, even a public one", () =>Effect.gen(function* () {- const port = yield* publicProxy;+ const { port } = yield* publicProxy;const own = Object.values(NodeOS.networkInterfaces()).flatMap((entries) => entries ?? []).filter((entry) => !entry.internal && !entry.address.startsWith("fe80"));@@ -132,7 +163,7 @@ describe("publicProxy", () => {Effect.gen(function* () {const socket = yield* Effect.scoped(Effect.gen(function* () {- const port = yield* publicProxy;+ const { port } = yield* publicProxy;return yield* Effect.callback<NodeNet.Socket>((resume) => {const client = NodeNet.connect(port, "127.0.0.1", () => {client.write(Buffer.from([5, 1, 0]));diff --git a/apps/server/src/htmlRender/publicProxy.ts b/apps/server/src/htmlRender/publicProxy.tsindex e73135e5a8f..c8e15c096ba 100644--- a/apps/server/src/htmlRender/publicProxy.ts+++ b/apps/server/src/htmlRender/publicProxy.ts@@ -31,6 +31,11 @@ for (const [network, prefix] of [LOCAL_ADDRESSES.addSubnet(network, prefix, "ipv6");}+// Clash and Mihomo fake-IP DNS answers from here, inside the blocked 198.18.0.0/15.+const FAKE_IP = new NodeNet.BlockList();+FAKE_IP.addSubnet("198.18.0.0", 15, "ipv4");+const MAX_FAKE_IP_HOSTS = 3;+const NAT64 = new NodeNet.BlockList();NAT64.addSubnet("64:ff9b::", 96, "ipv6");const SIX_TO_FOUR = new NodeNet.BlockList();@@ -77,13 +82,20 @@ const isLocal = (address: string, family: number): boolean => {};// Connect only to checked addresses to prevent DNS rebinding.-const publicAddresses = async (host: string) => {+const publicAddresses = async (host: string, fakeIpHosts: Map<string, string>) => {const addresses = NodeNet.isIP(host)? [{ address: host, family: NodeNet.isIP(host) }]: await NodeDnsPromises.lookup(host, { all: true, verbatim: true }).catch(() => []);if (addresses.length === 0) return undefined;const local = addresses.some(({ address, family }) => isLocal(address, family));- return local ? undefined : addresses;+ if (!local) return addresses;+ const fake =+ !NodeNet.isIP(host) &&+ addresses.every(({ address, family }) => family === 4 && FAKE_IP.check(address, "ipv4"));+ if (fake && fakeIpHosts.size < MAX_FAKE_IP_HOSTS && !fakeIpHosts.has(host)) {+ fakeIpHosts.set(host, addresses[0]!.address);+ }+ return undefined;};// SOCKS5 (RFC 1928) replies: success, refused by rule, host unreachable, command unsupported.@@ -116,10 +128,15 @@ const readRequest = (data: Buffer) => {/** Covers requests Chrome's Local Network Access misses, including speculation prefetches. */export const publicProxy = Effect.acquireRelease(Effect.callback<- { readonly server: NodeNet.Server; readonly sockets: Set<NodeNet.Socket> },+ {+ readonly server: NodeNet.Server;+ readonly sockets: Set<NodeNet.Socket>;+ readonly fakeIpHosts: ReadonlyMap<string, string>;+ },Error>((resume) => {const sockets = new Set<NodeNet.Socket>();+ const fakeIpHosts = new Map<string, string>();const track = (socket: NodeNet.Socket) => {sockets.add(socket);socket.on("close", () => sockets.delete(socket));@@ -155,7 +172,7 @@ export const publicProxy = Effect.acquireRelease(early.push(chunk);};client.on("data", holdEarly);- void publicAddresses(request.host).then((addresses) => {+ void publicAddresses(request.host, fakeIpHosts).then((addresses) => {if (client.destroyed) return;client.off("data", holdEarly);if (addresses === undefined) return refuse(client, 2);@@ -190,7 +207,7 @@ export const publicProxy = Effect.acquireRelease(});server.listen(0, "127.0.0.1", () => {listening = true;- resume(Effect.succeed({ server, sockets }));+ resume(Effect.succeed({ server, sockets, fakeIpHosts }));});}),({ server, sockets }) =>@@ -199,8 +216,9 @@ export const publicProxy = Effect.acquireRelease(server.close(() => resume(Effect.void));}),).pipe(- Effect.map(({ server }) => {+ Effect.map(({ server, fakeIpHosts }) => {const address = server.address();- return typeof address === "object" && address !== null ? address.port : 0;+ const port = typeof address === "object" && address !== null ? address.port : 0;+ return { port, fakeIpHosts };}),);diff --git a/docs/user/html-renders.md b/docs/user/html-renders.mdindex ee0b1111a65..09e8143caa9 100644--- a/docs/user/html-renders.md+++ b/docs/user/html-renders.md@@ -8,6 +8,8 @@ Agents can place local images in a page by file path. T3 Code embeds them when tBefore publishing, agents check their work with screenshots from a small headless browser that T3 Code keeps for itself; it never uses a browser you installed. The first preview on a machine downloads it once (about 120 MB) into T3 Code's data folder, so that preview can take a minute. Browser tabs on a remote environment use the same browser, so whichever comes first downloads it. Some Linux hosts need [setup](remote-access.md#browser-host-setup) before it can start. Pages publish without it.+Previews can load public resources such as CDN scripts, but nothing on your local network. The machine running the environment looks up each name, and previews block names that resolve to private or reserved addresses. Clash or Mihomo in fake-IP DNS mode can return these addresses, so external resources can fail there. The preview's console messages can identify affected hostnames. Inline the resource, add its host to `fake-ip-filter`, or switch that machine's proxy DNS to `redir-host`.+## MCP appsSome MCP servers return an interactive app with their tool results, following the [MCP Apps](https://github.com/modelcontextprotocol/ext-apps) standard. When an agent calls one of those tools, the app appears in the thread in place of the tool call, on web, desktop, and mobile. Codex and Claude support this today, for any MCP server you have configured for them. Claude needs Claude Code 2.1.301 or newer; older versions and other providers show these calls as ordinary tool calls.