TypeScript
perf(mobile): assemble HTML replacements in one pass (#25278)
Alex Southwellb5644426bf49
diff --git a/apps/mobile/src/lib/markdownDocument.ts b/apps/mobile/src/lib/markdownDocument.tsindex 6e5bc86cf77..c771813f176 100644--- a/apps/mobile/src/lib/markdownDocument.ts+++ b/apps/mobile/src/lib/markdownDocument.ts@@ -279,9 +279,7 @@ export function markdownWithHtml(markdown: string): string {}};visit(parser.parse(markdown), false, false);- for (const edit of edits.reverse())- markdown = markdown.slice(0, edit.start) + edit.content + markdown.slice(edit.end);- return markdown;+ return applyMarkdownEdits(markdown, edits);}// Start only at the beginning of a backtick run to avoid retrying every suffix.diff --git a/apps/mobile/src/lib/markdownHtml.test.ts b/apps/mobile/src/lib/markdownHtml.test.tsindex cd845f31497..911d6d46610 100644--- a/apps/mobile/src/lib/markdownHtml.test.ts+++ b/apps/mobile/src/lib/markdownHtml.test.ts@@ -116,6 +116,35 @@ describe("HTML in native Markdown", () => {it("keeps anchor text unlinked for unsafe hrefs", () => {expect(markdownWithHtml('Run <a href="javascript:alert(1)">this</a> now')).toBe("Run this now");});++ it("keeps anchor labels and escaped bangs intact across nested formatting and table cells", () => {+ const markdown =+ '> **!<a href="https://x.test">[one]</a>** and <span>tail</span>\n\n| A |\n| - |\n| !<a href="https://x.test">x[y]</a><br><img src="x.png"> |';+ expect(markdownWithHtml(markdown)).toBe(+ "> **\\![\\[one\\]](<https://x.test>)** and tail\n\n| A |\n| - |\n| \\![x\\[y\\]](<https://x.test>)  |",+ );+ expect(+ markdownWithHtml(+ String.raw`Before \!<a href="https://x.test">escaped</a> \\!<a href="mailto:a@b">even</a>`,+ ),+ ).toBe(String.raw`Before \ \\\`);+ });++ it("converts separated HTML without changing code examples or an unfinished tag", () => {+ const literal = '`<br>`\n\n```html\n<img src="literal.png">\n```\n\n<broken';+ expect(markdownWithHtml(literal)).toBe(literal);+ const rows = Array.from(+ { length: 100 },+ (_, index) => `row ${index} <span>text</span><br>!<a href="https://x.test/${index}">go</a>`,+ );+ const expected = Array.from(+ { length: 100 },+ (_, index) => `row ${index} text \n\\`,+ );+ expect(markdownWithHtml(rows.join("\n\n") + "\n\n" + literal)).toBe(+ expected.join("\n\n") + "\n\n" + literal,+ );+ });});describe("file embeds in native thread and file Markdown", () => {