Skip to content
TypeScript

fix(server): Antigravity Auto asks instead of approving every request (#23698)

parmartejasb6bd84d1217f
diff --git a/apps/server/src/orchestration-v2/RuntimePolicy.test.ts b/apps/server/src/orchestration-v2/RuntimePolicy.test.ts
index 21647ef49bf..ec610b093f7 100644
--- a/apps/server/src/orchestration-v2/RuntimePolicy.test.ts
+++ b/apps/server/src/orchestration-v2/RuntimePolicy.test.ts
@@ -15,6 +15,7 @@ import * as Layer from "effect/Layer";
import * as Stream from "effect/Stream";
import type { ProviderInstance } from "@t3tools/provider-core/server/driver";
+import { acpPermissionDisposition } from "@t3tools/provider-acp/server/clientPolicy";
import * as ServerSettings from "../serverSettings.ts";
import * as ProviderInstanceRegistry from "../provider/ProviderInstanceRegistry.ts";
import * as ProjectStore from "./ProjectStore.ts";
@@ -63,8 +64,10 @@ function makeThread(input: {
}
const grokInstanceId = ProviderInstanceId.make("grok");
+const antigravityInstanceId = ProviderInstanceId.make("antigravity");
const supportedRuntimeModesByInstance = new Map<ProviderInstanceId, ReadonlyArray<RuntimeMode>>([
[grokInstanceId, ["approval-required", "auto", "full-access"]],
+ [antigravityInstanceId, ["approval-required", "auto-accept-edits", "full-access"]],
]);
const providerInstanceFor = (instanceId: ProviderInstanceId) =>
({
@@ -113,6 +116,28 @@ const layerWithPolicy = (policy?: ManagedPolicySummary) =>
const layerTest = layerWithPolicy();
it.layer(layerTest)("RuntimePolicyV2", (it) => {
+ it.effect("asks for Antigravity command approval when a stored Auto thread falls back", () =>
+ Effect.gen(function* () {
+ const policy = yield* RuntimePolicy.RuntimePolicyV2;
+ const now = yield* DateTime.now;
+ const resolve = (runtimeMode: RuntimeMode) =>
+ policy.resolve({
+ thread: makeThread({ now, worktreePath: null, runtimeMode }),
+ modelSelection: { instanceId: antigravityInstanceId, model: "test-model" },
+ });
+ const request = {
+ sessionId: "session-1",
+ toolCall: { toolCallId: "command-1", title: "Run command", kind: "execute" as const },
+ options: [{ optionId: "allow", name: "Allow", kind: "allow_once" as const }],
+ };
+ const auto = yield* resolve("auto");
+ assert.equal(auto.runtimeMode, "approval-required");
+ assert.equal(acpPermissionDisposition(auto, request), "ask");
+ assert.equal(acpPermissionDisposition(yield* resolve("auto-accept-edits"), request), "ask");
+ assert.equal(acpPermissionDisposition(yield* resolve("full-access"), request), "allow");
+ }),
+ );
+
it.effect("runs a mode the provider does not offer in Supervised", () =>
Effect.gen(function* () {
const policy = yield* RuntimePolicy.RuntimePolicyV2;
diff --git a/apps/server/src/provider/AntigravityProvider.test.ts b/apps/server/src/provider/AntigravityProvider.test.ts
index 44f8842fd95..791ed748de2 100644
--- a/apps/server/src/provider/AntigravityProvider.test.ts
+++ b/apps/server/src/provider/AntigravityProvider.test.ts
@@ -348,6 +348,21 @@ it.layer(layerTest)("Antigravity provider snapshots", (it) => {
),
);
+ it.effect("does not offer Auto, so Auto threads fall back to Supervised", () =>
+ Effect.scoped(
+ Effect.gen(function* () {
+ const harness = yield* makeHarness();
+ yield* harness.initialize;
+ // Antigravity has no automatic review; the shared ACP policy would approve every request.
+ expect((yield* harness.provider.snapshot.getSnapshot).supportedRuntimeModes).toEqual([
+ "approval-required",
+ "auto-accept-edits",
+ "full-access",
+ ]);
+ }),
+ ),
+ );
+
it.effect("publishes session metadata and native commands without another health probe", () =>
Effect.scoped(
Effect.gen(function* () {
diff --git a/apps/server/src/provider/AntigravityProvider.ts b/apps/server/src/provider/AntigravityProvider.ts
index ff8805f43b3..ed047331e73 100644
--- a/apps/server/src/provider/AntigravityProvider.ts
+++ b/apps/server/src/provider/AntigravityProvider.ts
@@ -182,7 +182,12 @@ export const makeAntigravityProvider = Effect.fn("makeAntigravityProvider")(func
const checkedAt = DateTime.formatIso(yield* DateTime.now);
const initialDraft = {
...buildServerProvider({
- presentation: { displayName: "Antigravity", showInteractionModeToggle: false },
+ presentation: {
+ displayName: "Antigravity",
+ showInteractionModeToggle: false,
+ // No automatic review, so Auto falls back to Supervised instead of approving everything.
+ supportedRuntimeModes: ["approval-required", "auto-accept-edits", "full-access"],
+ },
enabled: settings.enabled,
checkedAt,
models: [],