TypeScript
fix(ui): snooze menu times match the menu's typography (#30596)
Ishaan Kotharibfb388415e8d
diff --git a/apps/web/src/components/sidebar/SidebarThreadRow.tsx b/apps/web/src/components/sidebar/SidebarThreadRow.tsxindex 7c9cc93f2b3..f0c45198774 100644--- a/apps/web/src/components/sidebar/SidebarThreadRow.tsx+++ b/apps/web/src/components/sidebar/SidebarThreadRow.tsx@@ -110,7 +110,7 @@ import { shouldShowInstanceBadge, type ProviderInstanceEntry } from "../../proviimport { useThreadRunningTerminalIds } from "../../state/terminalSessions";import { InlineButton } from "../ui/button";import { Kbd } from "../ui/kbd";-import { Menu, MenuItem, MenuPopup, MenuSeparator, MenuShortcut, MenuTrigger } from "../ui/menu";+import { Menu, MenuItem, MenuItemDetail, MenuPopup, MenuSeparator, MenuTrigger } from "../ui/menu";import { Tooltip, TooltipPopup, TooltipTrigger } from "../ui/tooltip";import { MiddleTruncate } from "../ui/middle-truncate";import { useThreadHasUnsentDraft } from "../../composerDraftStore";@@ -411,7 +411,7 @@ function SnoozeMenuButton(props: {}}>{preset.label}- <MenuShortcut>{preset.whenLabel}</MenuShortcut>+ <MenuItemDetail>{preset.whenLabel}</MenuItemDetail></MenuItem>))}{presets.length > 0 ? <MenuSeparator /> : null}diff --git a/apps/web/src/components/ui/menu.tsx b/apps/web/src/components/ui/menu.tsxindex 1c199afe446..e2706d0da21 100644--- a/apps/web/src/components/ui/menu.tsx+++ b/apps/web/src/components/ui/menu.tsx@@ -307,6 +307,18 @@ function MenuShortcut({ className, ...props }: React.ComponentProps<"kbd">) {);}+// Trailing value on a menu row, such as the time a snooze preset wakes at.+// Reads as text at the row's size; MenuShortcut is only for key chords.+function MenuItemDetail({ className, ...props }: React.ComponentProps<"span">) {+ return (+ <span+ className={cn("ms-auto shrink-0 ps-4 text-secondary-label tabular-nums", className)}+ data-slot="menu-item-detail"+ {...props}+ />+ );+}+function MenuSub(props: MenuPrimitive.SubmenuRoot.Props) {return <MenuPrimitive.SubmenuRoot data-slot="menu-sub" {...props} />;}@@ -390,6 +402,7 @@ export {MenuGroupLabel as DropdownMenuLabel,MenuSeparator,MenuSeparator as DropdownMenuSeparator,+ MenuItemDetail,MenuShortcut,MenuShortcut as DropdownMenuShortcut,MenuSub,