Skip to content
TypeScript

test(server): replay tests delete their temp directories (#23445)

Victorded4dacec19c
diff --git a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts
index 6151e57fb30..88f514c3018 100644
--- a/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts
+++ b/apps/server/src/orchestration-v2/Adapters/AcpRegistryAdapterV2.testkit.ts
@@ -48,7 +48,7 @@ function layerAcpRegistryProviderAdapterRegistryReplay(
const childProcessSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;
const replayGate = options.replayGate;
const replayDir = yield* fileSystem
- .makeTempDirectory({
+ .makeTempDirectoryScoped({
prefix: `t3-orchestration-v2-acp-registry-replay-${transcript.scenario}-`,
})
.pipe(Effect.orDie);
diff --git a/apps/server/src/orchestration-v2/Adapters/FxAdapterV2.testkit.ts b/apps/server/src/orchestration-v2/Adapters/FxAdapterV2.testkit.ts
index 68d3b2c30ff..2f7e85a9796 100644
--- a/apps/server/src/orchestration-v2/Adapters/FxAdapterV2.testkit.ts
+++ b/apps/server/src/orchestration-v2/Adapters/FxAdapterV2.testkit.ts
@@ -46,7 +46,7 @@ function layerFxProviderAdapterRegistryReplay(
const childProcessSpawner = yield* ChildProcessSpawner.ChildProcessSpawner;
const replayGate = options.replayGate;
const replayDir = yield* fileSystem
- .makeTempDirectory({
+ .makeTempDirectoryScoped({
prefix: `t3-orchestration-v2-fx-replay-${transcript.scenario}-`,
})
.pipe(Effect.orDie);
diff --git a/apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.testkit.ts b/apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.testkit.ts
index 477ebbf7f0f..0e770588227 100644
--- a/apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.testkit.ts
+++ b/apps/server/src/orchestration-v2/Adapters/GrokAdapterV2.testkit.ts
@@ -50,7 +50,7 @@ function layerGrokProviderAdapterRegistryReplay(
const continuationRequests = yield* ProviderContinuationRequests.ProviderContinuationRequests;
const replayGate = options.replayGate;
const replayDir = yield* fileSystem
- .makeTempDirectory({
+ .makeTempDirectoryScoped({
prefix: `t3-orchestration-v2-grok-replay-${transcript.scenario}-`,
})
.pipe(Effect.orDie);
diff --git a/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.test.ts b/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.test.ts
new file mode 100644
index 00000000000..a4c6fb3075a
--- /dev/null
+++ b/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.test.ts
@@ -0,0 +1,19 @@
+import * as NodeServices from "@effect/platform-node/NodeServices";
+import { assert, it } from "@effect/vitest";
+import * as Effect from "effect/Effect";
+import * as FileSystem from "effect/FileSystem";
+
+import { makeReplayServerConfig } from "./ProviderReplayHarness.ts";
+
+it.effect("deletes its temp state directory when the scenario scope closes", () =>
+ Effect.gen(function* () {
+ const fs = yield* FileSystem.FileSystem;
+ const baseDir = yield* Effect.gen(function* () {
+ const config = yield* makeReplayServerConfig("temp-cleanup");
+ assert.isTrue(yield* fs.exists(config.stateDir));
+ return config.baseDir;
+ }).pipe(Effect.scoped);
+
+ assert.isFalse(yield* fs.exists(baseDir));
+ }).pipe(Effect.provide(NodeServices.layer)),
+);
diff --git a/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.ts b/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.ts
index e4cac1bd4ad..ed51ee64241 100644
--- a/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.ts
+++ b/apps/server/src/orchestration-v2/testkit/ProviderReplayHarness.ts
@@ -12,6 +12,7 @@ import * as FileSystem from "effect/FileSystem";
import * as Layer from "effect/Layer";
import * as Path from "effect/Path";
import * as PlatformError from "effect/PlatformError";
+import type * as Scope from "effect/Scope";
import type * as SqlClient from "effect/sql/SqlClient";
import type { MigrationError } from "effect/sql/Migrator";
import type { SqlError } from "effect/sql/SqlError";
@@ -80,13 +81,13 @@ export function makeReplayServerConfig(
): Effect.Effect<
ServerConfig.ServerConfig["Service"],
PlatformError.PlatformError,
- FileSystem.FileSystem | Path.Path
+ FileSystem.FileSystem | Path.Path | Scope.Scope
> {
const safeScenario = scenario.replace(/[^a-z0-9_-]+/gi, "-");
return Effect.gen(function* () {
const fs = yield* FileSystem.FileSystem;
const path = yield* Path.Path;
- const baseDir = yield* fs.makeTempDirectory({
+ const baseDir = yield* fs.makeTempDirectoryScoped({
prefix: `t3-orchestration-v2-replay-${safeScenario}-`,
});
const stateDir = path.join(baseDir, "userdata");