TypeScript
fix(shared): accept whitespace after engine range operators (#29730)
Romile1cd7f0e1581
diff --git a/packages/shared/src/semver.test.ts b/packages/shared/src/semver.test.tsindex 57766584a04..824dd7d6f98 100644--- a/packages/shared/src/semver.test.ts+++ b/packages/shared/src/semver.test.ts@@ -56,6 +56,12 @@ describe("semver helpers", () => {it("supports comparison comparators", () => {expect(satisfiesSemverRange("24.9.0", ">=24.0 <24.10")).toBe(true);expect(satisfiesSemverRange("24.10.0", ">=24.0 <24.10")).toBe(false);+ for (const gap of [" ", "\t", "\n"]) {+ const range = `>=${gap}24.0 <${gap}24.10`;+ expect(satisfiesSemverRange("24.9.0", range)).toBe(true);+ expect(satisfiesSemverRange("24.10.0", range)).toBe(false);+ expect(satisfiesSemverRange("22.16.0", `^${gap}22.16 || >=${gap}24.10`)).toBe(true);+ }});it("honors caret range upper bounds for zero-major versions", () => {diff --git a/packages/shared/src/semver.ts b/packages/shared/src/semver.tsindex dc0e34f102d..720ea68a750 100644--- a/packages/shared/src/semver.ts+++ b/packages/shared/src/semver.ts@@ -156,7 +156,11 @@ export const satisfiesSemverRange: (rawVersion: string, range: string) => boolea};return range.split("||").some((group) => {- const comparators = group.trim().split(/\s+/).filter(Boolean);+ const comparators = group+ .trim()+ .replace(/(\^|>=|>|<=|<|=)\s+(?=v?\d)/g, "$1")+ .split(/\s+/)+ .filter(Boolean);if (comparators.length === 0) {return false;}