Skip to content

TagSpaces is an offline, open source, document manager with tagging support

chore: enable share files menu item only for object storage locations

Ilian Sapundshiev219e171f6555
diff --git a/release/app/package-lock.json b/release/app/package-lock.json
index ee8247711..4763432c9 100644
--- a/release/app/package-lock.json
+++ b/release/app/package-lock.json
@@ -11,7 +11,7 @@
"license": "AGPL-3.0",
"dependencies": {
"@elife/pm2": "3.6.1",
- "@tagspaces/extensions": "1.0.165",
+ "@tagspaces/extensions": "1.0.167",
"@tagspaces/tagspaces-common-node": "4.5.51",
"@tagspaces/tagspaces-ws": "4.5.51",
"sharp": "0.32.6",
@@ -147,9 +147,9 @@
}
},
"node_modules/@tagspaces/extensions": {
- "version": "1.0.165",
- "resolved": "https://registry.npmjs.org/@tagspaces/extensions/-/extensions-1.0.165.tgz",
- "integrity": "sha512-nLqwicLwfG9OtKbvk8CwJSOfgJyKwNfNHdBaKFAsalm2V58zXIbUgR0+QT7dJWzkisOpoLoaXaRtQAjbHbAYTQ==",
+ "version": "1.0.167",
+ "resolved": "https://registry.npmjs.org/@tagspaces/extensions/-/extensions-1.0.167.tgz",
+ "integrity": "sha512-n/tb/+hWG3rRUZlzWHmn2Skzq9ELn2ybn8mYMSAhUMb9XlgQY0dqa8UzMEVyJLxTZhTSHBmoP1utHhZOrB/l7g==",
"dependencies": {
"shelljs": "^0.8.5",
"shx": "^0.3.4"
@@ -1898,9 +1898,9 @@
}
},
"@tagspaces/extensions": {
- "version": "1.0.165",
- "resolved": "https://registry.npmjs.org/@tagspaces/extensions/-/extensions-1.0.165.tgz",
- "integrity": "sha512-nLqwicLwfG9OtKbvk8CwJSOfgJyKwNfNHdBaKFAsalm2V58zXIbUgR0+QT7dJWzkisOpoLoaXaRtQAjbHbAYTQ==",
+ "version": "1.0.167",
+ "resolved": "https://registry.npmjs.org/@tagspaces/extensions/-/extensions-1.0.167.tgz",
+ "integrity": "sha512-n/tb/+hWG3rRUZlzWHmn2Skzq9ELn2ybn8mYMSAhUMb9XlgQY0dqa8UzMEVyJLxTZhTSHBmoP1utHhZOrB/l7g==",
"requires": {
"shelljs": "^0.8.5",
"shx": "^0.3.4"
diff --git a/release/app/package.json b/release/app/package.json
index 747de2288..674d31443 100644
--- a/release/app/package.json
+++ b/release/app/package.json
@@ -18,7 +18,7 @@
},
"dependencies": {
"@elife/pm2": "3.6.1",
- "@tagspaces/extensions": "1.0.165",
+ "@tagspaces/extensions": "1.0.167",
"@tagspaces/tagspaces-common-node": "4.5.51",
"@tagspaces/tagspaces-ws": "4.5.51",
"sharp": "0.32.6",
diff --git a/src/renderer/components/menus/FileMenu.tsx b/src/renderer/components/menus/FileMenu.tsx
index 1190d8879..3d01248b1 100644
--- a/src/renderer/components/menus/FileMenu.tsx
+++ b/src/renderer/components/menus/FileMenu.tsx
@@ -16,59 +16,60 @@
*
*/
-import React, { useEffect, useReducer, useRef } from 'react';
-import ListItemIcon from '@mui/material/ListItemIcon';
-import ListItemText from '@mui/material/ListItemText';
-import ShareIcon from '@mui/icons-material/Share';
-import { Menu, MenuItem } from '@mui/material';
-import Divider from '@mui/material/Divider';
-import OpenFile from '@mui/icons-material/SubdirectoryArrowRight';
-import OpenFileNatively from '@mui/icons-material/Launch';
-import { ParentFolderIcon, DownloadIcon } from '-/components/CommonIcons';
-import OpenFolderInternally from '@mui/icons-material/Folder';
-import MoveCopy from '@mui/icons-material/FileCopy';
-import MoveToTopIcon from '@mui/icons-material/VerticalAlignTop';
-import MoveToBottomIcon from '@mui/icons-material/VerticalAlignBottom';
-import DuplicateFile from '@mui/icons-material/PostAdd';
-import ImageIcon from '@mui/icons-material/Image';
-import RenameFile from '@mui/icons-material/FormatTextdirectionLToR';
import AppConfig from '-/AppConfig';
import {
- extractContainingDirectoryPath,
- extractParentDirectoryPath,
- generateSharingLink,
- extractTitle,
-} from '@tagspaces/tagspaces-common/paths';
-import {
- createNewInstance,
- getRelativeEntryPath,
- openDirectoryMessage,
-} from '-/services/utils-io';
-import { getKeyBindingObject } from '-/reducers/settings';
-import { Pro } from '-/pro';
-import { useSelector } from 'react-redux';
-import { supportedImgs } from '-/services/thumbsgenerator';
-import {
- OpenNewWindowIcon,
DeleteIcon,
+ DownloadIcon,
LinkIcon,
+ OpenNewWindowIcon,
+ ParentFolderIcon,
TagIcon,
} from '-/components/CommonIcons';
-import PropertiesIcon from '@mui/icons-material/Info';
-import { useTranslation } from 'react-i18next';
-import { useOpenedEntryContext } from '-/hooks/useOpenedEntryContext';
-import { useDirectoryContentContext } from '-/hooks/useDirectoryContentContext';
+import TsMenuList from '-/components/TsMenuList';
+import { useDeleteMultipleEntriesDialogContext } from '-/components/dialogs/hooks/useDeleteMultipleEntriesDialogContext';
+import MenuKeyBinding from '-/components/menus/MenuKeyBinding';
+import { TabNames } from '-/hooks/EntryPropsTabsContextProvider';
import { useCurrentLocationContext } from '-/hooks/useCurrentLocationContext';
+import { useDirectoryContentContext } from '-/hooks/useDirectoryContentContext';
+import { useIOActionsContext } from '-/hooks/useIOActionsContext';
import { useNotificationContext } from '-/hooks/useNotificationContext';
-import { useSelectedEntriesContext } from '-/hooks/useSelectedEntriesContext';
+import { useOpenedEntryContext } from '-/hooks/useOpenedEntryContext';
import { usePlatformFacadeContext } from '-/hooks/usePlatformFacadeContext';
-import { useIOActionsContext } from '-/hooks/useIOActionsContext';
-import MenuKeyBinding from '-/components/menus/MenuKeyBinding';
+import { useSelectedEntriesContext } from '-/hooks/useSelectedEntriesContext';
+import { Pro } from '-/pro';
+import { getKeyBindingObject } from '-/reducers/settings';
+import { supportedImgs } from '-/services/thumbsgenerator';
+import {
+ createNewInstance,
+ getRelativeEntryPath,
+ openDirectoryMessage,
+} from '-/services/utils-io';
import { TS } from '-/tagspaces.namespace';
import { generateClipboardLink } from '-/utils/dom';
-import { useDeleteMultipleEntriesDialogContext } from '-/components/dialogs/hooks/useDeleteMultipleEntriesDialogContext';
-import TsMenuList from '-/components/TsMenuList';
-import { TabNames } from '-/hooks/EntryPropsTabsContextProvider';
+import MoveCopy from '@mui/icons-material/FileCopy';
+import OpenFolderInternally from '@mui/icons-material/Folder';
+import RenameFile from '@mui/icons-material/FormatTextdirectionLToR';
+import ImageIcon from '@mui/icons-material/Image';
+import PropertiesIcon from '@mui/icons-material/Info';
+import OpenFileNatively from '@mui/icons-material/Launch';
+import DuplicateFile from '@mui/icons-material/PostAdd';
+import ShareIcon from '@mui/icons-material/Share';
+import OpenFile from '@mui/icons-material/SubdirectoryArrowRight';
+import MoveToBottomIcon from '@mui/icons-material/VerticalAlignBottom';
+import MoveToTopIcon from '@mui/icons-material/VerticalAlignTop';
+import { Menu, MenuItem } from '@mui/material';
+import Divider from '@mui/material/Divider';
+import ListItemIcon from '@mui/material/ListItemIcon';
+import ListItemText from '@mui/material/ListItemText';
+import {
+ extractContainingDirectoryPath,
+ extractParentDirectoryPath,
+ extractTitle,
+ generateSharingLink,
+} from '@tagspaces/tagspaces-common/paths';
+import { useEffect, useReducer, useRef } from 'react';
+import { useTranslation } from 'react-i18next';
+import { useSelector } from 'react-redux';
interface Props {
anchorEl: Element;
@@ -482,7 +483,11 @@ function FileMenu(props: Props) {
);
}
- if (Pro && openShareFilesDialog) {
+ if (
+ Pro &&
+ currentLocation?.haveObjectStoreSupport() &&
+ openShareFilesDialog
+ ) {
menuItems.push(
<MenuItem
key="fileMenuShareFile"