Skip to content

TagSpaces is an offline, open source, document manager with tagging support

set default folder thumbnail (#2357)

Stanimir67c2bff18d0a
diff --git a/src/renderer/hooks/PlatformFacadeContextProvider.tsx b/src/renderer/hooks/PlatformFacadeContextProvider.tsx
index d54fd74ab..f72e43915 100644
--- a/src/renderer/hooks/PlatformFacadeContextProvider.tsx
+++ b/src/renderer/hooks/PlatformFacadeContextProvider.tsx
@@ -140,7 +140,10 @@ type PlatformFacadeContextData = {
reflect?: boolean | TS.ActionSource,
) => Promise<TS.FileSystemEntry>;
deleteEntriesPromise: (...paths: TS.FileSystemEntry[]) => Promise<boolean>;
- setFolderThumbnailPromise: (filePath: string) => Promise<string>;
+ setFolderThumbnailPromise: (
+ filePath: string,
+ force?: boolean,
+ ) => Promise<string>;
};
export const PlatformFacadeContext = createContext<PlatformFacadeContextData>({
@@ -215,8 +218,12 @@ export const PlatformFacadeContextProvider = ({
/**
* @param filePath
* return Promise<destThumbPath>
+ * @param force
*/
- function setFolderThumbnailPromise(filePath: string): Promise<string> {
+ function setFolderThumbnailPromise(
+ filePath: string,
+ force = true,
+ ): Promise<string> {
const currentLocation = findLocation();
const directoryPath = extractContainingDirectoryPath(
filePath,
@@ -241,27 +248,33 @@ export const PlatformFacadeContextProvider = ({
sourceThumbPath,
destThumbPath,
undefined,
- t('core:thumbAlreadyExists', { directoryName }),
- ).then(() => {
- // dispatch(AppActions.setLastThumbnailImageChange(destThumbPath));
- return destThumbPath;
- });
+ force ? t('core:thumbAlreadyExists', { directoryName }) : null,
+ )
+ .then(() => {
+ // dispatch(AppActions.setLastThumbnailImageChange(destThumbPath));
+ return destThumbPath;
+ })
+ .catch((e) => {
+ console.debug('set thumbnail for folder failed:', e);
+ return undefined;
+ });
}
function copyFilePromise(
sourceFilePath: string,
targetFilePath: string,
locationID: string,
- confirmMessage: string = 'File ' +
- targetFilePath +
- ' exist do you want to override it?',
+ confirmMessage?: string | null,
): Promise<any> {
return getLocation({ locationID })
.getPropertiesPromise(targetFilePath)
.then((isTargetExist) => {
if (isTargetExist) {
+ const defaultConfirm = `File "${targetFilePath}" exists. Do you want to overwrite it?`;
+ const text = confirmMessage ?? defaultConfirm;
// eslint-disable-next-line no-alert
- const confirmOverwrite = window && window.confirm(confirmMessage);
+ const confirmOverwrite =
+ confirmMessage !== null && window && window.confirm(text);
if (confirmOverwrite === true) {
return copyFilePromiseOverwrite(
sourceFilePath,
diff --git a/src/renderer/hooks/ThumbGenerationContextProvider.tsx b/src/renderer/hooks/ThumbGenerationContextProvider.tsx
index dd1605467..3b0344cf7 100644
--- a/src/renderer/hooks/ThumbGenerationContextProvider.tsx
+++ b/src/renderer/hooks/ThumbGenerationContextProvider.tsx
@@ -79,8 +79,11 @@ export const ThumbGenerationContextProvider = ({
loadCurrentDirMeta,
} = useDirectoryContentContext();
const { findLocation } = useCurrentLocationContext();
- const { saveBinaryFilePromise, createDirectoryPromise } =
- usePlatformFacadeContext();
+ const {
+ saveBinaryFilePromise,
+ createDirectoryPromise,
+ setFolderThumbnailPromise,
+ } = usePlatformFacadeContext();
const { metaActions } = useEditedEntryMetaContext();
const { getResentPageFiles } = usePaginationContext();
const { setGeneratingThumbs } = useNotificationContext();
@@ -137,6 +140,21 @@ export const ThumbGenerationContextProvider = ({
}
}, [currentDirectoryPath, page]); //, isMetaFolderExist]);*/
+ function pickByExtensionPriority(
+ entries: TS.FileSystemEntry[],
+ priority: string[] = ['jpg', 'jpeg', 'png', 'pdf'],
+ ): TS.FileSystemEntry | undefined {
+ if (!entries || entries.length === 0) return undefined;
+
+ for (const ext of priority) {
+ const found = entries.find((e) => e.extension === ext);
+ if (found) return found;
+ }
+
+ // fallback: first entry
+ return entries[0];
+ }
+
useEffect(() => {
if (metaActions && metaActions.length > 0) {
//!firstRender (skip firstRender: if switch from KanBan perspective to Gallery thumbGenerate missing)
@@ -161,7 +179,29 @@ export const ThumbGenerationContextProvider = ({
genEntries = currentDirectoryEntries;
}
if (genEntries) {
- generateThumbnails(genEntries).then(() => {
+ generateThumbnails(genEntries).then((success) => {
+ if (success) {
+ const entry = pickByExtensionPriority(
+ genEntries.filter((e) => e.isFile),
+ [
+ ...supportedImgs,
+ 'pdf',
+ 'html',
+ ...supportedVideos,
+ ...supportedText,
+ 'url',
+ ],
+ );
+ if (entry) {
+ setFolderThumbnailPromise(entry.path, false).then((success) => {
+ if (!success) {
+ console.debug(
+ 'set automatically thumbnail for folder failed: Thumb already exist',
+ );
+ }
+ });
+ }
+ }
return loadCurrentDirMeta(currentDirectoryPath, genEntries).then(
(ent) => {
updateCurrentDirEntries(ent);