Skip to content

TagSpaces is an offline, open source, document manager with tagging support

Fixing falsey bug for when settings.orderby == false (#1120)

jonathan-shahenc679cc9409ae
diff --git a/README.md b/README.md
index 901c392ce..0636a63f7 100644
--- a/README.md
+++ b/README.md
@@ -83,13 +83,17 @@ and install the project dependencies:
$ yarn install
+**Note:** If you experience any errors with the above command, please try this command first before filing a bug report:
+
+ $ yarn install --network-timeout 1000000
+
The last command will automatically build the application with webpack. Now it is time to install all the TagSpaces extensions:
$ yarn install-ext
-Now you are ready and can start the application with:
+Now you are ready and can build/start (bs) the application with:
- $ yarn start
+ $ yarn bs
If you want to try the development mode, you can start it by:
diff --git a/app/perspectives/grid-perspective/components/MainContainer.tsx b/app/perspectives/grid-perspective/components/MainContainer.tsx
index 22f5dd1ef..65e8ddc51 100644
--- a/app/perspectives/grid-perspective/components/MainContainer.tsx
+++ b/app/perspectives/grid-perspective/components/MainContainer.tsx
@@ -147,7 +147,10 @@ class GridPerspective extends React.Component<Props, State> {
optionsContextMenuAnchorEl: null,
selectedEntryPath: '',
sortBy: settings && settings.sortBy ? settings.sortBy : 'byName',
- orderBy: settings && settings.orderBy ? settings.orderBy : true,
+ orderBy:
+ settings && typeof settings.orderBy !== 'undefined'
+ ? settings.orderBy
+ : true,
layoutType:
settings && settings.layoutType ? settings.layoutType : 'grid',
singleClickAction: