TagSpaces is an offline, open source, document manager with tagging support
add e2e TST0114 TST0218 TST0219 TST0220
sytolkf57fa2d47275
diff --git a/src/renderer/components/EntryProperties.tsx b/src/renderer/components/EntryProperties.tsxindex a52571785..991863b7e 100644--- a/src/renderer/components/EntryProperties.tsx+++ b/src/renderer/components/EntryProperties.tsx@@ -910,6 +910,7 @@ function EntryProperties(props: Props) {<ProTooltip tooltip={t('changeBackgroundColor')}><IconButtonkey={cnt}+ data-tid={'backgroundTID' + cnt}aria-label="fingerprint"onClick={() => handleChangeColor(background)}style={{@@ -925,6 +926,7 @@ function EntryProperties(props: Props) {<ProTooltip tooltip={t('clearFolderColor')}><span><IconButton+ data-tid={'backgroundClearTID'}disabled={!Pro}aria-label="clear"size="small"diff --git a/src/renderer/components/menus/FileMenu.tsx b/src/renderer/components/menus/FileMenu.tsxindex 2d5b57f9f..db1fc86f8 100644--- a/src/renderer/components/menus/FileMenu.tsx+++ b/src/renderer/components/menus/FileMenu.tsx@@ -179,7 +179,7 @@ function FileMenu(props: Props) {...entry,meta: { id: entry.uuid, thumbPath },});- showNotification('Thumbnail created: ' + thumbPath);+ //showNotification('Thumbnail created: ' + thumbPath);return true;}).catch((error) => {diff --git a/src/renderer/perspectives/grid/components/GridPagination.tsx b/src/renderer/perspectives/grid/components/GridPagination.tsxindex 0de230772..9851313a9 100644--- a/src/renderer/perspectives/grid/components/GridPagination.tsx+++ b/src/renderer/perspectives/grid/components/GridPagination.tsx@@ -268,6 +268,7 @@ function GridPagination(props: Props) {)}</Box><div+ data-tid="folderThumbTID"style={{borderRadius: 10,height: 100,diff --git a/tests/e2e/folder.pw.e2e.js b/tests/e2e/folder.pw.e2e.jsindex c625c0e0f..39ab0bc5d 100644--- a/tests/e2e/folder.pw.e2e.js+++ b/tests/e2e/folder.pw.e2e.js@@ -17,6 +17,11 @@ import {takeScreenshot,selectorFile,setInputKeys,+ getGridFileSelector,+ getElementScreenshot,+ waitForNotification,+ expectAllFileSelected,+ selectAllFiles,} from './general.helpers';import { openContextEntryMenu, renameFolder } from './test-utils';import { createFile, startTestingApp, stopApp, testDataRefresh } from './hook';@@ -222,6 +227,44 @@ test.describe('TST01 - Folder management', () => {test.skip('TST0113 - Delete not empty folder to trashcan [electron]', async () => {});+ test('TST0114 - Use as thumbnail for parent folder [web,minio,electron,_pro]', async () => {+ const fileName = 'sample.jpg';+ await openContextEntryMenu(+ getGridFileSelector(fileName),+ 'fileMenuMoveCopyFile',+ );+ await clickOn('[data-tid=MoveTargetempty_folder]');+ await clickOn('[data-tid=confirmCopyFiles]');+ await clickOn('[data-tid=uploadCloseAndClearTID]');++ await openContextEntryMenu(+ getGridFileSelector('empty_folder'),+ 'showProperties',+ );+ await openContextEntryMenu(+ getGridFileSelector('empty_folder'),+ 'openDirectory',+ );+ const initScreenshot = await getElementScreenshot(+ '[data-tid=folderThumbTID]',+ );+ await openContextEntryMenu(getGridFileSelector(fileName), 'setAsThumbTID');++ const withThumbScreenshot = await getElementScreenshot(+ '[data-tid=folderThumbTID]',+ );+ expect(initScreenshot).not.toBe(withThumbScreenshot);++ // remove thumb+ await clickOn('[data-tid=changeThumbnailTID]');+ await clickOn('[data-tid=clearThumbnail]');+ //await clickOn('[data-tid=folderThumbTID]');+ const thumbRemovedScreenshot = await getElementScreenshot(+ '[data-tid=folderThumbTID]',+ );+ expect(initScreenshot).toBe(thumbRemovedScreenshot);+ });+test('TST0116 - Switch to Grid Perspective [web,minio,electron]', async () => {await clickOn('[data-tid=openListPerspective]');await expectElementExist('[data-tid=listPerspectiveContainer]', true, 5000);diff --git a/tests/e2e/folderprops.pw.e2e.js b/tests/e2e/folderprops.pw.e2e.jsindex 70577dba7..2b4c3ee2b 100644--- a/tests/e2e/folderprops.pw.e2e.js+++ b/tests/e2e/folderprops.pw.e2e.js@@ -17,6 +17,7 @@ import {createNewDirectory,dnd,setInputKeys,+ getElementScreenshot,} from './general.helpers';import { openContextEntryMenu } from './test-utils';import { createFile, startTestingApp, stopApp, testDataRefresh } from './hook';@@ -276,11 +277,43 @@ test.describe('TST02 - Folder properties', () => {);});+ test('TST0218 - Set and remove predefined background gradient for folder [web,minio,electron,_pro]', async () => {+ await openContextEntryMenu(+ getGridFileSelector('empty_folder'),+ 'showProperties',+ );+ await openContextEntryMenu(+ getGridFileSelector('empty_folder'),+ 'openDirectory',+ );+ const initScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );+ await clickOn('[data-tid=backgroundTID1]');++ const withBgnColorScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );+ expect(initScreenshot).not.toBe(withBgnColorScreenshot);++ // remove background+ await clickOn('[data-tid=backgroundClearTID]');+ await clickOn('[data-tid=confirmConfirmResetColorDialog]');++ const bgnRemovedScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );+ expect(initScreenshot).toBe(bgnRemovedScreenshot);+ });+test('TST0219 - Set and remove predefined folder thumbnail [web,minio,electron,_pro]', async () => {await openContextEntryMenu(getGridFileSelector('empty_folder'),'showProperties',);+ const initScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );await clickOn('[data-tid=changeThumbnailTID]');await clickOn('ul[data-tid=predefinedThumbnailsTID] > li');await clickOn('[data-tid=confirmCustomThumb]');@@ -290,6 +323,20 @@ test.describe('TST02 - Folder properties', () => {);const srcValue = await imgElement.getAttribute('src');expect(srcValue.indexOf('.ts/tst.jpg')).toBeGreaterThan(-1);++ const withThumbScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );+ expect(initScreenshot).not.toBe(withThumbScreenshot);++ // remove thumb+ await clickOn('[data-tid=changeThumbnailTID]');+ await clickOn('[data-tid=clearThumbnail]');++ const thumbRemovedScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );+ expect(initScreenshot).toBe(thumbRemovedScreenshot);});test('TST0220 - Set and remove predefined folder background [web,minio,electron,_pro]', async () => {@@ -297,6 +344,9 @@ test.describe('TST02 - Folder properties', () => {getGridFileSelector('empty_folder'),'openDirectory',);+ const initScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ ); //propsBgnImageTIDawait clickOn('[data-tid=changeBackgroundImageTID]');await clickOn('ul[data-tid=predefinedBackgroundsTID] > li');@@ -306,11 +356,17 @@ test.describe('TST02 - Folder properties', () => {5000,);await clickOn('[data-tid=colorPickerConfirm]');- // todo expects - background link is always the same- /*const imgElement = await global.client.$(- '[data-tid=propsBgnImageTID]',+ const withBgnScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',+ );+ expect(initScreenshot).not.toBe(withBgnScreenshot);++ // remove background+ await clickOn('[data-tid=changeBackgroundImageTID]');+ await clickOn('[data-tid=clearBackground]');+ const bgnRemovedScreenshot = await getElementScreenshot(+ '[data-tid=perspectiveGridFileTable]',);- const styleValue = await imgElement.getAttribute('style');- expect(styleValue.indexOf('.ts/tsb.jpg')).toBeGreaterThan(-1);*/+ expect(initScreenshot).toBe(bgnRemovedScreenshot);});});diff --git a/tests/e2e/general.helpers.js b/tests/e2e/general.helpers.jsindex 317b24204..69d42443d 100644--- a/tests/e2e/general.helpers.js+++ b/tests/e2e/general.helpers.js@@ -31,6 +31,24 @@ export async function takeScreenshot(testInfo, title = 'failure') {return await global.client.screenshot({ path: sPath });}+export async function getElementScreenshot(+ selector,+ options = {+ /*encoding: 'base64'*/+ },+) {+ try {+ const buffer = await global.client+ .locator(selector)+ .screenshot({ ...options });+ //const buffer = await el.screenshot({ ...options/*, clip: boundingBox*/ });+ return buffer.toString('base64');+ } catch (e) {+ console.log('getElementScreenshot ' + selector + ' error: ', e);+ }+ return undefined;+}+export async function clickOn(selector, options = { timeout: 15000 }) {try {await global.client.click(selector, options);diff --git a/tests/e2e/search.pw.e2e.js b/tests/e2e/search.pw.e2e.jsindex f9a96ec59..829924ea2 100644--- a/tests/e2e/search.pw.e2e.js+++ b/tests/e2e/search.pw.e2e.js@@ -136,7 +136,7 @@ test.describe('TST06 - Test Search in file structure:', () => {});*/test('TST0609 - Show thumbnails of image files in the search results [web,minio,electron]', async () => {- const searchQuery = 'jpg'; //'sample_exif.jpg';+ const searchQuery = 'sample_exif.jpg'; //'jpg';await addSearchCommand(searchQuery, true);await global.client.waitForSelector('img[alt="thumbnail image"]', {visible: true,