Skip to content

TagSpaces is an offline, open source, document manager with tagging support

fix: select all entries functionality

Ilian Sapundshievf8a5fda185af
diff --git a/app/perspectives/grid-perspective/components/MainContainer.tsx b/app/perspectives/grid-perspective/components/MainContainer.tsx
index 8086df2d1..5bbc468b0 100644
--- a/app/perspectives/grid-perspective/components/MainContainer.tsx
+++ b/app/perspectives/grid-perspective/components/MainContainer.tsx
@@ -113,7 +113,6 @@ const GridPerspective = (props: Props) => {
const [mouseX, setMouseX] = useState<number>(undefined);
const [mouseY, setMouseY] = useState<number>(undefined);
- const allFilesSelected = useRef<boolean>(false);
// const selectedEntry = useRef<FileSystemEntry>(undefined);
const selectedEntryPath = useRef<string>(undefined);
const selectedTag = useRef<TS.Tag | null>(null);
@@ -348,7 +347,6 @@ const GridPerspective = (props: Props) => {
const clearSelection = () => {
props.setSelectedEntries([]);
- allFilesSelected.current = false;
// props.setLastSelectedEntry(null);
// selectedEntry.current = undefined;
selectedEntryPath.current = undefined;
@@ -356,7 +354,6 @@ const GridPerspective = (props: Props) => {
const toggleSelectAllFiles = () => {
if (selectedEntries.length > 0) {
- // && allFilesSelected.current) {
clearSelection();
} else {
const selectedEntries = [];
@@ -367,7 +364,6 @@ const GridPerspective = (props: Props) => {
return true;
});
props.setSelectedEntries(selectedEntries);
- allFilesSelected.current = true;
}
};
@@ -742,9 +738,7 @@ const GridPerspective = (props: Props) => {
selectedEntries={selectedEntries}
loadParentDirectoryContent={loadParentDirectoryContent}
toggleSelectAllFiles={toggleSelectAllFiles}
- allFilesSelected={
- allFilesSelected.current && selectedEntries.length > 0
- }
+ someFileSelected={selectedEntries.length > 0}
handleLayoutSwitch={handleLayoutSwitch}
openAddRemoveTagsDialog={openAddRemoveTagsDialog}
fileOperationsEnabled={fileOperationsEnabled()}
diff --git a/app/perspectives/grid-perspective/components/MainToolbar.tsx b/app/perspectives/grid-perspective/components/MainToolbar.tsx
index fe2416259..62a6b410d 100644
--- a/app/perspectives/grid-perspective/components/MainToolbar.tsx
+++ b/app/perspectives/grid-perspective/components/MainToolbar.tsx
@@ -49,7 +49,7 @@ interface Props {
selectedEntries: Array<Object>;
loadParentDirectoryContent: () => void;
toggleSelectAllFiles: (event: any) => void;
- allFilesSelected: boolean;
+ someFileSelected: boolean;
handleLayoutSwitch: (event: Object) => void;
openAddRemoveTagsDialog: () => void;
fileOperationsEnabled: boolean;
@@ -69,7 +69,7 @@ const MainToolbar = (props: Props) => {
classes,
selectedEntries,
toggleSelectAllFiles,
- allFilesSelected,
+ someFileSelected,
loadParentDirectoryContent,
layoutType,
handleLayoutSwitch,
@@ -89,7 +89,7 @@ const MainToolbar = (props: Props) => {
data-tid="gridPerspectiveSelectAllFiles"
onClick={toggleSelectAllFiles}
>
- {allFilesSelected ? <SelectAllIcon /> : <DeSelectAllIcon />}
+ {someFileSelected ? <SelectAllIcon /> : <DeSelectAllIcon />}
</IconButton>
</Tooltip>
<Tooltip title={i18n.t('core:navigateToParentDirectory')}>