Skip to content

TagSpaces is an offline, open source, document manager with tagging support

Make the 500 tag limit configurable (#2204)

Stanimirff62c7cbcbe9
diff --git a/src/renderer/components/dialogs/components/SettingsAdvanced.tsx b/src/renderer/components/dialogs/components/SettingsAdvanced.tsx
index 94f96e00f..403043670 100644
--- a/src/renderer/components/dialogs/components/SettingsAdvanced.tsx
+++ b/src/renderer/components/dialogs/components/SettingsAdvanced.tsx
@@ -34,6 +34,7 @@ import {
getSettings,
getMapTileServers,
isDevMode,
+ getMaxCollectedTag,
} from '-/reducers/settings';
import { TS } from '-/tagspaces.namespace';
import MapTileServerDialog from '-/components/dialogs/MapTileServerDialog';
@@ -62,6 +63,7 @@ function SettingsAdvanced(props: Props) {
: undefined;
const dispatch: AppDispatch = useDispatch();
const settings = useSelector(getSettings);
+ const maxCollectedTag = useSelector(getMaxCollectedTag);
const tileServers: Array<TS.MapTileServer> = useSelector(getMapTileServers);
const devMode = useSelector(isDevMode);
const [tileServerDialog, setTileServerDialog] = useState<any>(undefined);
@@ -179,6 +181,25 @@ function SettingsAdvanced(props: Props) {
onChange={(event) => setPrefixTagContainer(event.target.value)}
/>
</ListItem>
+ <ListItem>
+ <ListItemText primary={t('core:maxCollectedTag')} />
+ <TsTextField
+ type="number"
+ inputProps={{ inputMode: 'numeric', pattern: '[0-9]*' }}
+ style={{ maxWidth: '92px' }}
+ data-tid="prefixTagContainerTID"
+ value={maxCollectedTag}
+ onChange={(event: React.ChangeEvent<HTMLInputElement>) =>
+ dispatch(
+ SettingsActions.setMaxCollectedTag(
+ event.target.value === ''
+ ? undefined
+ : Number(event.target.value),
+ ),
+ )
+ }
+ />
+ </ListItem>
{Pro && (
<>
<ListItem>
diff --git a/src/renderer/hooks/TaggingActionsContextProvider.tsx b/src/renderer/hooks/TaggingActionsContextProvider.tsx
index 0367e0eef..92f4f418b 100644
--- a/src/renderer/hooks/TaggingActionsContextProvider.tsx
+++ b/src/renderer/hooks/TaggingActionsContextProvider.tsx
@@ -33,6 +33,7 @@ import {
getAddTagsToLibrary,
getFileNameTagPlace,
getGeoTaggingFormat,
+ getMaxCollectedTag,
getPrefixTagContainer,
getSaveTagInLocation,
getTagColor,
@@ -184,6 +185,7 @@ export const TaggingActionsContextProvider = ({
const selectedTag = useRef<TS.Tag>(undefined);
const geoTaggingFormat = useSelector(getGeoTaggingFormat);
+ const maxCollectedTag = useSelector(getMaxCollectedTag);
const addTagsToLibrary = useSelector(getAddTagsToLibrary);
const tagBackgroundColor: string = useSelector(getTagColor);
const tagTextColor: string = useSelector(getTagTextColor);
@@ -1172,7 +1174,7 @@ export const TaggingActionsContextProvider = ({
);
if (indexForEditing > -1) {
const tags = [...tagGroups[indexForEditing].children, ...entry.children];
- tags.splice(0, tags.length - AppConfig.maxCollectedTag);
+ tags.splice(0, tags.length - maxCollectedTag);
saveTagLibrary([
...tagGroups.slice(0, indexForEditing),
{
diff --git a/src/renderer/locales/en/core.json b/src/renderer/locales/en/core.json
index 55233857c..69b668374 100644
--- a/src/renderer/locales/en/core.json
+++ b/src/renderer/locales/en/core.json
@@ -883,5 +883,6 @@
"defaultAImodelText": "Default model for text-based tasks",
"defaultAImodelImages": "Default model for image-based tasks",
"refreshServiceStatus": "Refresh service status",
+ "maxCollectedTag": "Max Collected Tag",
"-": "-"
}
diff --git a/src/renderer/reducers/settings.ts b/src/renderer/reducers/settings.ts
index ba5ddb2e4..0ccf00d90 100644
--- a/src/renderer/reducers/settings.ts
+++ b/src/renderer/reducers/settings.ts
@@ -63,6 +63,7 @@ export const types = {
SET_CALCULATETAGS: 'SETTINGS/SET_CALCULATETAGS',
SET_USETRASHCAN: 'SETTINGS/SET_USETRASHCAN',
SET_PERSISTTAGSINSIDECARFILE: 'SETTINGS/SET_PERSISTTAGSINSIDECARFILE',
+ SET_MAXCOLLECTEDTAG: 'SETTINGS/SET_MAXCOLLECTEDTAG',
SET_FILENAMETAGPLACEDATEND: 'SETTINGS/SET_FILENAMETAGPLACEDATEND',
SET_ADDTAGSTOLIBRARY: 'SETTINGS/SET_ADDTAGSTOLIBRARY',
SET_REVISIONS_ENABLED: 'SETTINGS/SET_REVISIONS_ENABLED',
@@ -235,6 +236,12 @@ export default (state: any = defaultSettings, action: any) => {
persistTagsInSidecarFile: action.persistTagsInSidecarFile,
};
}
+ case types.SET_MAXCOLLECTEDTAG: {
+ return {
+ ...state,
+ maxCollectedTag: action.maxCollectedTag,
+ };
+ }
case types.SET_FILENAMETAGPLACEDATEND: {
return {
...state,
@@ -645,6 +652,10 @@ export const actions = {
type: types.SET_PERSISTTAGSINSIDECARFILE,
persistTagsInSidecarFile,
}),
+ setMaxCollectedTag: (maxCollectedTag: number) => ({
+ type: types.SET_MAXCOLLECTEDTAG,
+ maxCollectedTag,
+ }),
setFileNameTagPlace: (filenameTagPlacedAtEnd: boolean) => ({
type: types.SET_FILENAMETAGPLACEDATEND,
filenameTagPlacedAtEnd,
@@ -911,6 +922,10 @@ export const getAppDataPath = (state: any) => state.settings.appDataPath;
export const getSupportedLanguages = (state: any) => state.settings.languages;
export const getCalculateTags = (state: any) => state.settings.calculateTags;
export const getUseTrashCan = (state: any) => state.settings.useTrashCan;
+export const getMaxCollectedTag = (state: any) =>
+ state.settings.maxCollectedTag
+ ? state.settings.maxCollectedTag
+ : AppConfig.maxCollectedTag;
export const getPersistTagsInSidecarFile = (state: any): boolean =>
AppConfig.useSidecarsForFileTaggingDisableSetting
? AppConfig.useSidecarsForFileTagging