Skip to content

TaskView is a self-hosted project and task management platform focused on clarity, ownership, and control. TaskView is built for teams that want a transparent, self-hosted alternative to SaaS task managers.

fix: oidc

Nikolai Giman1be3dac90eb0
diff --git a/api/src/tv-modules/sso/SsoController.ts b/api/src/tv-modules/sso/SsoController.ts
index 9ffc2a8..144253a 100644
--- a/api/src/tv-modules/sso/SsoController.ts
+++ b/api/src/tv-modules/sso/SsoController.ts
@@ -158,8 +158,16 @@ export class SsoController {
return res.status(400).send(out.summary)
}
+ const existing = await this.ssoRepo.findEnabledByDomain(out.emailDomainRestriction)
+ if (existing) {
+ return res.status(409).tvJson({ message: 'SSO config for this domain already exists' })
+ }
+
const config = await req.appUser.ssoManager.createConfig(out).catch(logError)
- return res.tvJson(config ?? null)
+ if (!config) {
+ return res.status(500).tvJson({ message: 'Failed to create SSO config' })
+ }
+ return res.tvJson(config)
}
updateConfig = async (req: Request, res: Response) => {
diff --git a/api/src/tv-modules/sso/providers/oidc.provider.ts b/api/src/tv-modules/sso/providers/oidc.provider.ts
index 3be1fb7..4a520db 100644
--- a/api/src/tv-modules/sso/providers/oidc.provider.ts
+++ b/api/src/tv-modules/sso/providers/oidc.provider.ts
@@ -13,10 +13,15 @@ export class OidcProvider implements SsoProvider {
private async getOidcConfig(): Promise<client.Configuration> {
if (!this.oidcConfig) {
+ const issuerUrl = new URL(this.config.oidcIssuer!)
+ const isDev = process.env.NODE_ENV !== 'production'
+
this.oidcConfig = await client.discovery(
- new URL(this.config.oidcIssuer!),
+ issuerUrl,
this.config.oidcClientId!,
this.config.oidcClientSecret!,
+ undefined,
+ isDev ? { execute: [client.allowInsecureRequests] } : undefined,
)
}
return this.oidcConfig
diff --git a/web/src/components/features/organizations/parts/OrgSsoSettings.vue b/web/src/components/features/organizations/parts/OrgSsoSettings.vue
index a37d4d7..778f643 100644
--- a/web/src/components/features/organizations/parts/OrgSsoSettings.vue
+++ b/web/src/components/features/organizations/parts/OrgSsoSettings.vue
@@ -416,9 +416,13 @@ async function saveConfig() {
isEditing.value = false
resetForm()
await fetchConfig()
- } catch (error) {
- console.error('SSO save failed:', error)
- toast.add({ title: t('sso.saveFailed'), color: 'error' })
+ } catch (error: unknown) {
+ const axiosError = error as { response?: { status?: number, data?: { response?: { message?: string } } } }
+ if (axiosError.response?.status === 409) {
+ toast.add({ title: t('sso.domainAlreadyExists'), color: 'error' })
+ } else {
+ toast.add({ title: t('sso.saveFailed'), color: 'error' })
+ }
} finally {
saving.value = false
}
diff --git a/web/src/locales/en.ts b/web/src/locales/en.ts
index 2dafdfe..fa1e394 100644
--- a/web/src/locales/en.ts
+++ b/web/src/locales/en.ts
@@ -525,6 +525,7 @@ export default {
created: 'SSO provider created',
updated: 'SSO provider updated',
deleted: 'SSO provider deleted',
+ domainAlreadyExists: 'SSO config for this domain already exists',
saveFailed: 'Failed to save SSO configuration',
deleteFailed: 'Failed to delete SSO configuration',
fillRequired: 'Please fill in all required fields',
diff --git a/web/src/locales/ru.ts b/web/src/locales/ru.ts
index e163fcc..7dad66d 100644
--- a/web/src/locales/ru.ts
+++ b/web/src/locales/ru.ts
@@ -497,6 +497,7 @@ export default {
created: 'SSO провайдер создан',
updated: 'SSO провайдер обновлён',
deleted: 'SSO провайдер удалён',
+ domainAlreadyExists: 'SSO для этого домена уже настроен',
saveFailed: 'Не удалось сохранить настройки SSO',
deleteFailed: 'Не удалось удалить SSO конфигурацию',
fillRequired: 'Заполните все обязательные поля',