TaskView is a self-hosted project and task management platform focused on clarity, ownership, and control. TaskView is built for teams that want a transparent, self-hosted alternative to SaaS task managers.
TypeScript graphviewkanban-boardnodejsproductivityproject-managementself-hostedtasktask-managementtask-managertodoapp
fix: #126
Nikolai Gimanba55a55e2ae2
diff --git a/api/src/tv-modules/ui-preferences/types.ts b/api/src/tv-modules/ui-preferences/types.tsindex 26a2a0f..c5fba36 100644--- a/api/src/tv-modules/ui-preferences/types.ts+++ b/api/src/tv-modules/ui-preferences/types.ts@@ -46,6 +46,8 @@ export const UiSettingsArkType = type({'firstDayOfWeek?': firstDayOfWeekArkType,'defaultProjectId?': 'number.integer >= 1','defaultView?': "'tasks' | 'kanban' | 'graph' | 'sprints'",+ 'taskSortBy?': "'date' | 'priority'",+ 'taskSortFirstNew?': '0 | 1',})export type UiSettings = typeof UiSettingsArkType.inferdiff --git a/taskview-packages/taskview-api/src/api/__tests__/ui-preferences.test.ts b/taskview-packages/taskview-api/src/api/__tests__/ui-preferences.test.tsnew file mode 100644index 0000000..35c5106--- /dev/null+++ b/taskview-packages/taskview-api/src/api/__tests__/ui-preferences.test.ts@@ -0,0 +1,46 @@+import { TvApi } from '@/tv'+import { UI_SETTINGS_KEY, type UiPreferences, type UiSettings } from '@/api/ui-preferences.types'+import { afterAll, beforeAll, describe, expect, it } from 'vitest'+import { initApi } from './init-api'+import { expectApiError } from './automations-test-helpers'++/**+ * Preferences are one blob per user, so the suite works as the second user+ * and puts the original blob back at the end.+ */+describe('UI preferences: remembered task sort', () => {+ let api: TvApi+ let original: UiPreferences++ beforeAll(async () => {+ api = (await initApi()).$tvApiForSecondUser+ original = (await api.uiPreferences.fetch()) ?? {}+ })++ afterAll(async () => {+ await api.uiPreferences.update(original)+ })++ const settingsOf = (prefs: UiPreferences | null) => (prefs?.[UI_SETTINGS_KEY] ?? {}) as UiSettings++ it('stores the sort field and direction next to the other settings', async () => {+ const saved = await api.uiPreferences.update({+ ...original,+ [UI_SETTINGS_KEY]: { ...settingsOf(original), defaultView: 'kanban', taskSortBy: 'priority', taskSortFirstNew: 0 },+ })+ expect(settingsOf(saved)).toMatchObject({ defaultView: 'kanban', taskSortBy: 'priority', taskSortFirstNew: 0 })++ expect(settingsOf(await api.uiPreferences.fetch())).toMatchObject({ taskSortBy: 'priority', taskSortFirstNew: 0 })+ })++ it('rejects a sort field or direction the task list does not support', async () => {+ await expectApiError({+ request: api.uiPreferences.update({ [UI_SETTINGS_KEY]: { taskSortBy: 'name' as never } }),+ status: 400,+ })+ await expectApiError({+ request: api.uiPreferences.update({ [UI_SETTINGS_KEY]: { taskSortFirstNew: 2 as never } }),+ status: 400,+ })+ })+})diff --git a/taskview-packages/taskview-api/src/api/ui-preferences.types.ts b/taskview-packages/taskview-api/src/api/ui-preferences.types.tsindex 4bb6adf..0d6fa68 100644--- a/taskview-packages/taskview-api/src/api/ui-preferences.types.ts+++ b/taskview-packages/taskview-api/src/api/ui-preferences.types.ts@@ -1,3 +1,5 @@+import type { TaskSortBy } from './tasks.api.types'+export type UiPreferencesItem = {id: stringorder: number@@ -13,6 +15,8 @@ export type UiSettings = {firstDayOfWeek?: FirstDayOfWeekdefaultProjectId?: numberdefaultView?: DefaultView+ taskSortBy?: TaskSortBy+ taskSortFirstNew?: 0 | 1}export const UI_SETTINGS_KEY = '__settings__'diff --git a/web/src/components/features/tasks/TasksPanel.vue b/web/src/components/features/tasks/TasksPanel.vueindex afdb61f..9e7d454 100644--- a/web/src/components/features/tasks/TasksPanel.vue+++ b/web/src/components/features/tasks/TasksPanel.vue@@ -77,6 +77,7 @@ import { useRoute } from 'vue-router'import { useI18n } from 'vue-i18n'import { useInfiniteScroll } from '@vueuse/core'import { useTasksStore } from '@/stores/tasks.store'+import { useUiPreferencesStore } from '@/stores/uiPreferences.store'import { ALL_TASKS_LIST_ID, type Task } from 'taskview-api'import TaskItem from '@/components/features/tasks/parts/TaskItem.vue'import TasksToolbar from '@/components/features/tasks/parts/TasksToolbar.vue'@@ -87,6 +88,7 @@ const route = useRoute()const toast = useToast()const { canViewTasks } = useGoalPermissions()const tasksStore = useTasksStore()+const uiPrefs = useUiPreferencesStore()const { tasks, loading, fetchRules } = storeToRefs(tasksStore)const scrollAreaRef = useTemplateRef('scrollAreaRef')@@ -108,11 +110,16 @@ watch(prevListId.value = numListIdtasksStore.resetTasks()+ await uiPrefs.ensureLoaded()+ if (prevProjectId.value !== numProjectId || prevListId.value !== numListId) return+tasksStore.updateFetchRules({goalId: numProjectId,currentListId: numListId,currentPage: 0,endOfTasks: false,+ sortBy: uiPrefs.settings.taskSortBy ?? 'date',+ firstNew: uiPrefs.settings.taskSortFirstNew ?? 1,})await tasksStore.fetchTasks()},diff --git a/web/src/components/features/tasks/parts/TasksToolbar.vue b/web/src/components/features/tasks/parts/TasksToolbar.vueindex 97a9b64..49a7a08 100644--- a/web/src/components/features/tasks/parts/TasksToolbar.vue+++ b/web/src/components/features/tasks/parts/TasksToolbar.vue@@ -38,6 +38,7 @@variant="subtle":disabled="loading":ui="{ base: 'min-w-32' }"+ data-testid="tasks-sort-select"/><UTooltip :text="sortTooltip"><UButton@@ -46,6 +47,7 @@variant="subtle":loading="loading":disabled="loading"+ data-testid="tasks-sort-direction"@click="toggleSort"/></UTooltip>@@ -122,11 +124,13 @@ import { useRoute } from 'vue-router'import { useI18n } from 'vue-i18n'import type { TaskSortBy } from 'taskview-api'import { useTasksStore } from '@/stores/tasks.store'+import { useUiPreferencesStore } from '@/stores/uiPreferences.store'import TasksFilterDrawer from './TasksFilterDrawer.vue'const { t } = useI18n()const route = useRoute()const tasksStore = useTasksStore()+const uiPrefs = useUiPreferencesStore()const { fetchRules } = storeToRefs(tasksStore)@@ -200,11 +204,18 @@ async function applySort(rules: Partial<typeof fetchRules.value>) {currentPage: 0,endOfTasks: false,})+ rememberSort()await tasksStore.fetchTasks()loading.value = false}+function rememberSort() {+ const { sortBy, firstNew } = fetchRules.value+ uiPrefs.setSetting('taskSortBy', sortBy === 'date' ? undefined : sortBy)+ uiPrefs.setSetting('taskSortFirstNew', firstNew === 1 ? undefined : firstNew)+}+function toggleSort() {return applySort({ firstNew: firstNew.value ? 0 : 1 })}diff --git a/web/src/stores/uiPreferences.store.ts b/web/src/stores/uiPreferences.store.tsindex 9cd2603..f841d25 100644--- a/web/src/stores/uiPreferences.store.ts+++ b/web/src/stores/uiPreferences.store.ts@@ -23,8 +23,9 @@ export const useUiPreferencesStore = defineStore('uiPreferences', () => {}}- async function fetch() {- if (loading.value) return+ let pending: Promise<void> | null = null++ async function load() {loading.value = truetry {const result = await $tvApi.uiPreferences.fetch()@@ -34,9 +35,20 @@ export const useUiPreferencesStore = defineStore('uiPreferences', () => {loaded.value = true} finally {loading.value = false+ pending = null}}+ function fetch(): Promise<void> {+ pending ??= load()+ return pending+ }++ async function ensureLoaded() {+ if (loaded.value) return+ await fetch().catch(() => undefined)+ }+const flush = useDebounceFn(async () => {saving.value = truetry {@@ -76,6 +88,7 @@ export const useUiPreferencesStore = defineStore('uiPreferences', () => {loading,saving,fetch,+ ensureLoaded,setSection,getSection,setSetting,