Skip to content

Linux + iPhone Continuity / iMessage / SMS

fix: bump min strict version for t-bird

Zack Bartel77a519310643
diff --git a/extension/manifest-mail.json b/extension/manifest-mail.json
index 73241e1..d7810a7 100644
--- a/extension/manifest-mail.json
+++ b/extension/manifest-mail.json
@@ -1,12 +1,12 @@
{
"manifest_version": 2,
"name": "Tether Mail Extension",
- "version": "1.0.4",
+ "version": "1.0.5",
"description": "Extracts OTPs from emails for Tether daemon",
"browser_specific_settings": {
"gecko": {
- "strict_min_version": "115.0"
+ "strict_min_version": "137.0"
}
},
"permissions": [
diff --git a/extension/src/mail/extractor.js b/extension/src/mail/extractor.js
index 4752eb7..396d18d 100644
--- a/extension/src/mail/extractor.js
+++ b/extension/src/mail/extractor.js
@@ -96,7 +96,7 @@ export function isFalsePositive(num, context) {
// ---------------------------------------------------------------------------
// FALLBACK text extraction: manually walk getFull() parts.
-// Used when listInlineTextParts() is unavailable (older Thunderbird builds).
+// Recovery path for messages whose MIME tree makes listInlineTextParts() throw.
// For HTML parts we use DOMParser to tag prominent elements for the scorer,
// then grab the full body plain text.
// ---------------------------------------------------------------------------
@@ -152,12 +152,12 @@ function extractTextFromParts(parts) {
}
// ---------------------------------------------------------------------------
-// PRIMARY text extraction: uses newer Thunderbird APIs (TB 102+).
+// PRIMARY text extraction. Both APIs set the manifest's strict_min_version:
//
-// messenger.messages.listInlineTextParts(id)
+// messenger.messages.listInlineTextParts(id) - TB 128+
// - gives us clean content without manually walking the MIME tree
//
-// messenger.messengerUtilities.convertToPlainText(html)
+// messenger.messengerUtilities.convertToPlainText(html) - TB 137+
// - Thunderbird's own HTML-to-plaintext converter; handles tables,
// encoded entities, and nested elements far better than a hand-rolled
// DOMParser tag-strip. Borrowed from thunderbird-vericode's approach.
@@ -165,7 +165,7 @@ function extractTextFromParts(parts) {
// We still run the DOMParser tagging pass on the raw HTML before
// converting, so the scorer's +25 bonus is preserved on this code path too.
//
-// Falls back to extractTextFromParts() for older Thunderbird/Betterbird builds.
+// extractTextFromParts() catches runtime failures, not missing APIs.
// ---------------------------------------------------------------------------
async function getEmailText(messageId) {
try {
@@ -218,9 +218,9 @@ async function getEmailText(messageId) {
return text;
} catch (e) {
- // listInlineTextParts or convertToPlainText not available
- // fall back to the manual DOMParser path.
- console.log("listInlineTextParts unavailable, falling back to getFull():", e.message);
+ // strict_min_version guarantees both APIs exist, so this is a message
+ // they choked on. Retry by walking the MIME tree ourselves.
+ console.log("listInlineTextParts failed, falling back to getFull():", e.message);
const full = await messenger.messages.getFull(messageId);
return extractTextFromParts(full.parts);
}