Skip to content

Open-source platform for 3D AI agents. Turn text or a photo into a rigged, animated GLB avatar, give it an LLM brain, memory and a wallet, and embed it anywhere with one web component. Remote MCP server, x402 payments, Three.js, browser-native.

fix(rate-limit): keep a daily counter alive until its day is actually over

nirholas4ab1b81545b4
diff --git a/api/_lib/rate-limit.js b/api/_lib/rate-limit.js
index bcbe0a124..50cb75b6a 100644
--- a/api/_lib/rate-limit.js
+++ b/api/_lib/rate-limit.js
@@ -399,15 +399,25 @@ function parseWindowMs(w) {
const PG_PRUNE_INTERVAL_MS = 600_000;
let pgPrunedAt = 0;
-// Drop windows that no live limiter can still be counting. `maxMemoryWindowMs`
-// tracks the widest window any limiter in this process uses (24h for the daily
-// payout/withdrawal caps), so 2× that is a conservative floor. Fire-and-forget:
-// a failed prune is a no-op that retries on the next interval, never an error
-// on the caller's request path.
+// The widest window any bucket in `limits` declares (the daily caps: '1 d' /
+// '24 h'). The prune floor below must be derived from this and NOT from
+// `maxMemoryWindowMs`: that counter only rises when a limiter is CONSTRUCTED in
+// the current process, so an instance whose first pg-backed bucket was, say,
+// '5 m' prunes with a 10-minute floor and deletes every OTHER instance's live
+// daily row. The table is shared, so one such instance silently resets the
+// 5/day and 3/day spend caps for everybody (observed live: six calls against a
+// 5/day bucket all succeeded, because a sibling process had wiped the row
+// mid-window). Raise this if a wider window is ever added.
+const PG_WIDEST_WINDOW_MS = 86_400_000;
+
+// Drop windows that no live limiter can still be counting: 2x the widest window
+// any bucket uses, so a row is only deleted once its window is long dead on
+// every instance. Fire-and-forget: a failed prune is a no-op that retries on the
+// next interval, never an error on the caller's request path.
function prunePgCounters(now) {
if (now - pgPrunedAt < PG_PRUNE_INTERVAL_MS) return;
pgPrunedAt = now;
- const cutoff = now - 2 * maxMemoryWindowMs;
+ const cutoff = now - 2 * Math.max(PG_WIDEST_WINDOW_MS, maxMemoryWindowMs);
sql`DELETE FROM rate_limit_counters WHERE window_start < ${cutoff}`.catch(() => {});
}
@@ -1487,7 +1497,8 @@ export const limits = {
personaInterview: (ip) => getLimiter('persona:interview', { limit: 30, window: '1 h' }).limit(ip),
personaInterviewAnon: (ip) =>
getLimiter('persona:interview:anon', { limit: 8, window: '1 h' }).limit(ip),
- // Persona preview: Claude API call on the server key. Looser than extract (it's
+ // Persona preview: a metered completion on the shared LLM chain (api/_lib/llm.js),
+ // same as extract, not a fixed Claude-only lane. Looser than extract (it's
// interactive) but still per-user critical so a free-signup loop can't run up an
// unbounded LLM bill. Anonymous shouldn't reach it (auth required), so per-user.
personaPreviewUser: (userId) =>
diff --git a/prompts/swarm-100/api-persona-01.md b/prompts/swarm-100/api-persona-01.md
deleted file mode 100644
index dddc760e8..000000000
--- a/prompts/swarm-100/api-persona-01.md
+++ /dev/null
@@ -1,102 +0,0 @@
-# API audit: api/persona batch 01 (2 files)
-
-How to run: paste this file's repo path into a fresh Claude Code chat in this
-repository and say "run this work order". This file is fully self-contained:
-it depends on no other prompt file anywhere. If neighboring files in
-prompts/swarm-100/ are gone, that work is done; if present, ignore them.
-Every claim below rots; step 0 re-measures, and what you measure wins.
-
-## Operating clause (binding)
-
-- Read CLAUDE.md first. Its rules override everything, including this file.
-- Finish 100% in this session. Never end the turn with a question, an option
- list, or an unexecuted plan. A judgment call goes in one line of the final
- report; it never becomes a question that halts work.
-- The only permitted stops are the CLAUDE.md stop-and-ask gates: spending real
- funds or any irreversible on-chain write, git push or a production deploy,
- committing content that references a crypto project other than $THREE, and
- destroying unrecoverable data.
-- No mocks, no fake data, no placeholder stubs, no unfinished-work markers, no
- commented-out code. Real APIs and real integrations only.
-- The em-dash and en-dash characters are banned in everything you write.
-- Concurrent agents share this worktree: stage explicit paths only (never a
- bare add-everything), and commit finished work promptly.
-- Before committing, run: npm run check:rules -- --paths <files you touched>.
- It must exit 0.
-
-## Step 0: re-derive the current state
-
-1. Confirm each file below still exists; deleted ones are done, skip them.
-2. For each, decide routability: grep its path in vercel.json and read how
- server/index.mjs maps filesystem handlers. Routed files get an endpoint
- audit; internal modules get a code and test audit.
-3. Start a local server for endpoint checks: node server/index.mjs with .env
- loaded, on a free PORT if 3000 is busy.
-
-## Task: audit these api files, then fix everything found
-
-Files in this batch:
-
-- api/persona/extract.js
-- api/persona/preview.js
-
-For every routed handler:
-
-1. Exercise it with curl against the local server: the success path returns
- real data with the correct status; malformed input returns a 4xx JSON
- error, never a stack trace or an HTML error page; auth is enforced where
- the code intends it; CORS matches neighboring handlers.
-2. Hard-rule scan: no mock fallbacks, no fake-data arrays, no stubbed
- responses, no unfinished markers. Errors are handled at the boundary and
- internal code trusts itself.
-3. Do not spend funds or sign anything on-chain while probing. Payment and
- trading handlers get their validation and error paths exercised, never a
- live settlement.
-
-For every internal (non-routed) module:
-
-4. Something must import it; if nothing does, delete it as dead code (verify
- with a repo-wide grep first).
-5. Its main path and one failure path must be covered in tests/; add the
- missing test if not.
-
-## Definition of done
-
-- [ ] Every listed file has recorded evidence: a curl transcript for routed
- handlers, a passing test or a deletion for internal modules.
-- [ ] Zero hard-rule violations remain in these files.
-- [ ] vitest run passes; npm run check:rules -- --paths <touched files>
- exits 0.
-
-## Never blocked
-
-| Blocker | Resolution (act, do not ask) |
-|---|---|
-| Missing env var or credential | Check .env and .env.local, then the Cloud Run service env, then Secret Manager (the CLAUDE.md self-unblock playbook has the exact commands). If it truly exists nowhere, wire the code fully behind the env var, prove the wiring with a dry run, and name the single missing var in the report. |
-| gcloud not on PATH | Run: export PATH="$HOME/google-cloud-sdk/bin:$PATH" |
-| Dev server port 3000 busy | Another agent may be serving this repo; probe it and reuse if so. Otherwise start your own on a free port: npx vite --port 3101 |
-| Playwright browser missing | npx playwright install chromium |
-| A surface needs a signed-in user | Register a fresh account through the real /register flow against the real API and use it. Never mock the session. |
-| A defect sits in code you did not touch | Fix it if it blocks a Definition of done line (root cause it, never mask it). Otherwise note it in the report and continue. |
-| An unrelated test is red | Same rule. Never pipe npm test through tail; it masks exit codes. |
-
-## Close out (required)
-
-1. Verify every Definition of done line with the actual command output in
- front of you. Never claim a line you did not verify.
-2. Commit with explicit paths and a subject that describes the diff (house
- style: type(scope): what changed and why a reader cares).
-3. Delete this prompt file in that same commit:
-
- git rm prompts/swarm-100/api-persona-01.md
-
- The shrinking directory is this campaign's only progress ledger; there is
- no progress log to update.
-4. Final report: what step 0 measured, what changed (file list), evidence per
- Definition of done line, and any one-line judgment calls. No trailing
- questions, no unexecuted plans.
-
-If a line genuinely cannot pass inside this session (an external party must
-respond, or an owner-gated action is the final step), finish everything else,
-leave this file in place, and state exactly which line remains and who owns
-it. Never delete this file on a partial.
diff --git a/tests/rate-limit-durable-fallback.test.js b/tests/rate-limit-durable-fallback.test.js
index 63b514947..9e5257fce 100644
--- a/tests/rate-limit-durable-fallback.test.js
+++ b/tests/rate-limit-durable-fallback.test.js
@@ -25,11 +25,12 @@ const QUOTA_ERROR = 'ERR max requests limit exceeded. Limit: 500000, Usage: 5000
// semantics: one atomic increment returning the post-increment count.
function makeSqlStub() {
const rows = new Map();
- const calls = { inserts: 0, deletes: 0 };
+ const calls = { inserts: 0, deletes: 0, deleteCutoffs: [] };
const sql = (strings, ...values) => {
const text = strings.join('?');
if (/DELETE FROM rate_limit_counters/i.test(text)) {
calls.deletes++;
+ calls.deleteCutoffs.push(values[0]);
return Promise.resolve([]);
}
if (/INSERT INTO rate_limit_counters/i.test(text)) {
@@ -140,6 +141,24 @@ describe('durable Postgres fallback (no Redis configured)', () => {
expect(voice.success).toBe(true);
});
+ it('prunes on the widest window any bucket can use, not the widest this process built', async () => {
+ // rate_limit_counters is shared by every instance, and the prune is a
+ // blind DELETE. It used to size its retention floor from the widest window
+ // a limiter had been CONSTRUCTED with in the current process, which starts
+ // at one minute. An instance whose first durable bucket was short-windowed
+ // therefore deleted every other instance's live daily row, silently
+ // resetting the 5/day and 3/day spend caps for everyone.
+ const stub = makeSqlStub();
+ const { limits } = await loadRateLimit({ redis: null, sqlStub: stub });
+
+ // inscribeIp: critical (so it lands on Postgres) with a 10-minute window.
+ const before = Date.now();
+ await limits.inscribeIp('203.0.113.9');
+
+ expect(stub.calls.deletes).toBe(1);
+ expect(before - stub.calls.deleteCutoffs[0]).toBeGreaterThanOrEqual(2 * 86_400_000);
+ });
+
it('cheap non-critical buckets never touch Postgres', async () => {
const stub = makeSqlStub();
const { limits } = await loadRateLimit({ redis: null, sqlStub: stub });