Skip to content

Open-source platform for 3D AI agents. Turn text or a photo into a rigged, animated GLB avatar, give it an LLM brain, memory and a wallet, and embed it anywhere with one web component. Remote MCP server, x402 payments, Three.js, browser-native.

fix(xss): escape user-written names and hosts on persona authorize, avatar pickers, Watch and Genesis

nirholas8de4c67420aa
diff --git a/public/persona/authorize.html b/public/persona/authorize.html
index 8b92e6024..e6c7b2e08 100644
--- a/public/persona/authorize.html
+++ b/public/persona/authorize.html
@@ -168,8 +168,12 @@
try { return new URL(origin).host; } catch (_) { return origin; }
}
+ function esc(s) {
+ return String(s ?? '').replace(/[&<>"']/g, (c) => ({ '&': '&amp;', '<': '&lt;', '>': '&gt;', '"': '&quot;', "'": '&#39;' })[c]);
+ }
+
function renderError(msg) {
- $content.innerHTML = `<div class="error">${msg}</div>`;
+ $content.innerHTML = `<div class="error">${esc(msg)}</div>`;
}
function renderEmpty() {
@@ -184,20 +188,20 @@
function renderConsent({ avatars, tenantOrigin }) {
const host = tenantHostLabel(tenantOrigin);
- $title.innerHTML = `Authorize <span class="tenant">${host}</span>`;
+ $title.innerHTML = `Authorize <span class="tenant">${esc(host)}</span>`;
$lede.textContent = `Choose the avatar to share. ${host} will receive its URL and thumbnail. Your other avatars stay private.`;
const cards = avatars.map((a, i) => `
- <div class="avatar-card ${i === 0 ? 'selected' : ''}" data-id="${a.id}">
- ${a.thumbnail_url ? `<img src="${a.thumbnail_url}" alt="">` : `<img alt="">`}
- <div class="name">${a.name || 'Untitled'}</div>
+ <div class="avatar-card ${i === 0 ? 'selected' : ''}" data-id="${esc(a.id)}">
+ ${a.thumbnail_url ? `<img src="${esc(a.thumbnail_url)}" alt="">` : `<img alt="">`}
+ <div class="name">${esc(a.name || 'Untitled')}</div>
</div>
`).join('');
$content.innerHTML = `
<div class="avatars">${cards}</div>
<div class="scopes">
- ${host} will be granted:
+ ${esc(host)} will be granted:
<ul>
<li>persona:read — your three.ws user id</li>
<li>avatar:read — selected avatar URL + thumbnail</li>
diff --git a/src/avatar-picker.js b/src/avatar-picker.js
index 28b7eb0ff..2e235650a 100644
--- a/src/avatar-picker.js
+++ b/src/avatar-picker.js
@@ -4,6 +4,8 @@
// const picker = createAvatarPicker({ onSelect: ({ id, url, name }) => { ... } });
// picker.open(currentAvatarId);
+import { escapeHtml } from './shared/coin-format.js';
+
const DEFAULT_AVATAR = {
id: null,
url: '/avatars/default.glb',
@@ -316,10 +318,10 @@ export function createAvatarPicker({ onSelect } = {}) {
card.innerHTML = `
<div class="avp-thumb">
${av.thumbnailUrl
- ? `<img src="${av.thumbnailUrl}" alt="${av.name}" loading="lazy">`
+ ? `<img src="${escapeHtml(av.thumbnailUrl)}" alt="${escapeHtml(av.name)}" loading="lazy">`
: thumbPlaceholderSvg()}
</div>
- <div class="avp-label">${av.name}</div>`;
+ <div class="avp-label">${escapeHtml(av.name)}</div>`;
if (!av.thumbnailUrl && av.url) {
setupThumb3d(card.querySelector('.avp-thumb'), av.url);
diff --git a/src/dashboard-next/pages/watch.js b/src/dashboard-next/pages/watch.js
index c2adcf4a7..4bfa93f98 100644
--- a/src/dashboard-next/pages/watch.js
+++ b/src/dashboard-next/pages/watch.js
@@ -8,6 +8,7 @@
import { mountWatchPanel } from '../../shared/agent-watch-panel.js';
import { mountShell as mountDashboardShell } from '../shell.js';
+import { esc } from '../api.js';
const params = new URLSearchParams(location.search);
const agentId = params.get('agentId');
@@ -45,11 +46,11 @@ async function init() {
content.innerHTML = `
<div class="watch-header">
${avatarImg
- ? `<img loading="lazy" decoding="async" class="watch-header-avatar" src="${avatarImg}" alt="${agent.name || 'Agent'}">`
+ ? `<img loading="lazy" decoding="async" class="watch-header-avatar" src="${esc(avatarImg)}" alt="${esc(agent.name || 'Agent')}">`
: `<div class="watch-header-avatar"></div>`}
<div>
- <div class="watch-header-name">${agent.name || 'Agent'}</div>
- <div class="watch-header-sub">Live screen · ${agentId.slice(0, 8)}…</div>
+ <div class="watch-header-name">${esc(agent.name || 'Agent')}</div>
+ <div class="watch-header-sub">Live screen · ${esc(agentId.slice(0, 8))}…</div>
</div>
<a class="watch-header-back" href="${backHref}">← Agent profile</a>
</div>
diff --git a/src/genesis.js b/src/genesis.js
index 4bbb5578e..92fa70fd6 100644
--- a/src/genesis.js
+++ b/src/genesis.js
@@ -256,13 +256,21 @@ async function loadRemixGallery() {
}
grid.innerHTML = '';
for (const a of avatars) {
- const thumb = a.thumbnail_url || a.thumbnail || a.poster_url;
+ const thumb = a.thumb_url || a.thumbnail_url || a.thumbnail || a.poster_url;
if (!thumb) continue;
const tile = document.createElement('button');
tile.type = 'button';
tile.className = 'gx-remix-tile';
tile.setAttribute('aria-pressed', 'false');
- tile.innerHTML = `<img loading="lazy" src="${thumb}" alt="${(a.name || 'Avatar').replace(/"/g, '')}" /><span>${a.name || 'Avatar'}</span>`;
+ // Avatar names are written by other users, so the tile is built as DOM
+ // nodes rather than an HTML string.
+ const img = document.createElement('img');
+ img.loading = 'lazy';
+ img.src = thumb;
+ img.alt = a.name || 'Avatar';
+ const label = document.createElement('span');
+ label.textContent = a.name || 'Avatar';
+ tile.append(img, label);
tile.addEventListener('click', () => {
state.remixAvatarId = a.id;
$$('.gx-remix-tile').forEach((t) => t.setAttribute('aria-pressed', 'false'));
diff --git a/tests/api-creations-gallery.test.js b/tests/api-creations-gallery.test.js
index 87d00262f..9a71e88ca 100644
--- a/tests/api-creations-gallery.test.js
+++ b/tests/api-creations-gallery.test.js
@@ -192,6 +192,24 @@ describe('/api/creations publish and remix lineage', () => {
});
});
+describe('/api/creations license vocabulary', () => {
+ it('treats an inherited Object key as no license and falls back to the default', async () => {
+ const res = await call({
+ method: 'POST',
+ body: {
+ op: 'publish',
+ prompt: 'a cute voxel lamp',
+ glbUrl: GLB('license-proto'),
+ author: 'audit-license',
+ license: 'constructor',
+ },
+ });
+ expect(res.statusCode).toBe(201);
+ expect(res.json.creation.license).toBe('remix-cc');
+ expect(res.json.creation.licenseInfo).toMatchObject({ label: 'Remix freely' });
+ });
+});
+
describe('/api/creations failure paths', () => {
it('rejects an unknown GET op', async () => {
const res = await call({ url: '/api/creations?op=bogus' });