Skip to content

Open-source platform for 3D AI agents. Turn text or a photo into a rigged, animated GLB avatar, give it an LLM brain, memory and a wallet, and embed it anywhere with one web component. Remote MCP server, x402 payments, Three.js, browser-native.

feat(x-content): let a reel scenario upload a repository file through the page's own picker, and void the proof if those bytes change

nirholase96474b477da
diff --git a/api/_lib/x-content/reel.js b/api/_lib/x-content/reel.js
index f40982314..8633083cb 100644
--- a/api/_lib/x-content/reel.js
+++ b/api/_lib/x-content/reel.js
@@ -84,10 +84,14 @@ const TYPE_FRAMES_PER_CHAR = 2;
// can carry as a modifier comes after the steps that use it that way: `hold`
// after `press` (a held key is `{ "press": "w", "hold": 2000 }`), and
// `caption` last, because any step may carry a caption as well as its action.
-export const STEP_KINDS = ['goto', 'click', 'hover', 'type', 'press', 'expect', 'read', 'drag', 'scroll', 'wait', 'hold', 'caption'];
+export const STEP_KINDS = ['goto', 'click', 'hover', 'upload', 'type', 'press', 'expect', 'read', 'drag', 'scroll', 'wait', 'hold', 'caption'];
// The steps that can cause a request, and so may carry `awaits`.
-const ACTIONS = ['click', 'press', 'type'];
+const ACTIONS = ['click', 'press', 'type', 'upload'];
+
+// A file a scenario hands to the page lives in the repository, under data/ or
+// public/, so every machine that reviews the post runs it with the same bytes.
+const UPLOAD_PATH = /^(?:data|public)\/(?!.*(?:^|\/)\.\.(?:\/|$))[\w./-]+\.(?:png|jpe?g|webp|gif|glb|gltf|obj|stl|mp3|wav|mp4)$/i;
export const stepKind = (step) => STEP_KINDS.find((kind) => step && Object.hasOwn(step, kind)) || null;
@@ -138,6 +142,10 @@ export function scenarioProblems(scenario) {
case 'hover':
if (!targetOf(step[kind])) problems.push(`${at}: ${kind} needs the visible text of the control, or { "selector": "..." }`);
break;
+ case 'upload':
+ if (!UPLOAD_PATH.test(String(step.upload))) problems.push(`${at}: upload needs a repository path under data/ or public/, such as "data/x-content/inputs/photo.png"`);
+ if (!targetOf(step.into)) problems.push(`${at}: upload needs "into": the visible text of the control that opens the file picker, or { "selector": "..." }`);
+ break;
case 'type':
if (typeof step.type !== 'string' || !step.type) problems.push(`${at}: type needs the text to type`);
if (!step.into) problems.push(`${at}: type needs "into": the placeholder, label, or selector of the field`);
@@ -207,6 +215,11 @@ export function proofProblems(item, root, now = Date.now()) {
const file = resolve(root, reel.path);
if (existsSync(file) && sha256File(file) !== proof.video.sha256) problems.push(`${reel.path} is not the file the proof filmed`);
}
+ for (const upload of proof.uploads || []) {
+ const file = resolve(root, upload.path);
+ if (!existsSync(file)) problems.push(`${upload.path}, the file the run uploaded, is missing`);
+ else if (sha256File(file) !== upload.sha256) problems.push(`${upload.path} is not the file the run uploaded; prove it again`);
+ }
if (proof.video && proof.video.motion < MIN_MOTION) {
problems.push(`only ${Math.round(proof.video.motion * 100)}% of the reel's frames change; film an action, or post a still instead`);
}
@@ -641,6 +654,28 @@ const STEPS = {
await take.pointer('rest');
return `clicked${await settleResponse(take, step, index, run, pending)}`;
},
+ // The pointer clicks the control that opens the file picker, on film, and
+ // the picker is answered with a file from the repository, exactly as a
+ // person choosing that file would. The bytes are recorded in the proof.
+ async upload(take, step, index, run) {
+ const file = resolve(run.root, step.upload);
+ if (!existsSync(file)) throw new Error(`${step.upload} does not exist`);
+ const at = await centreOf(await locate(take, step.into));
+ await take.moveTo(at.x, at.y);
+ const pending = armResponse(take, step);
+ const chooser = take.page.waitForEvent('filechooser', { timeout: 10_000 });
+ chooser.catch(() => {});
+ await take.pointer('ripple', at.x, at.y, RIPPLE_FRAMES * take.frameMs);
+ await take.page.mouse.click(at.x, at.y);
+ const picker = await chooser.catch(() => {
+ throw new Error(`clicking "${targetOf(step.into)}" opened no file picker`);
+ });
+ await picker.setFiles(file);
+ await take.frames(RIPPLE_FRAMES);
+ await take.pointer('rest');
+ run.uploads.push({ path: step.upload, sha256: sha256File(file) });
+ return `uploaded ${step.upload}${await settleResponse(take, step, index, run, pending)}`;
+ },
async hover(take, step) {
const at = await centreOf(await locate(take, step.hover));
await take.moveTo(at.x, at.y);
@@ -756,13 +791,13 @@ const BROWSER_ARGS = ['--use-gl=angle', '--use-angle=swiftshader', '--enable-uns
// Runs the scenario against the live product. With `film` false no frame is
// captured, which is the fast path a review uses to confirm the feature still
// works and still shows the facts the reel shows.
-export async function runScenario(scenario, { film = true, stamp = '', framesDir = null, failureShot = null } = {}) {
+export async function runScenario(scenario, { film = true, stamp = '', framesDir = null, failureShot = null, root = process.cwd() } = {}) {
const { chromium } = await import('playwright');
const format = FORMATS[scenario.format || 'landscape'];
const fps = scenario.fps || DEFAULT_FPS;
const size = { width: Math.round(format.width * format.scale), height: Math.round(format.height * format.scale), page: Math.round((format.height - format.bar) * format.scale) };
const browser = await chromium.launch({ args: BROWSER_ARGS });
- const run = { passed: true, steps: [], facts: {}, saw: [], responses: [], cuts: [], frames: 0, changes: 0, fps, width: size.width, height: size.height };
+ const run = { root, passed: true, steps: [], facts: {}, saw: [], responses: [], uploads: [], cuts: [], frames: 0, changes: 0, fps, width: size.width, height: size.height };
try {
const context = await browser.newContext({ viewport: { width: format.width, height: format.height - format.bar }, deviceScaleFactor: format.scale, reducedMotion: 'no-preference' });
const bar = await Bar.open(context, format, stamp);
@@ -873,7 +908,7 @@ export async function proveItem(item, { root, film = true, now = Date.now(), fai
const stamp = item.scenario.stamp === false ? '' : `live on ${host}${version?.commit ? ` @ ${version.commit}` : ''}, ${day}`;
const framesDir = film ? mkdtempSync(join(tmpdir(), `reel-${item.id}-`)) : null;
try {
- const run = await runScenario(item.scenario, { film, stamp, framesDir, failureShot });
+ const run = await runScenario(item.scenario, { film, stamp, framesDir, failureShot, root });
const proof = {
id: item.id,
scenarioHash: scenarioHash(item.scenario),
@@ -884,6 +919,7 @@ export async function proveItem(item, { root, film = true, now = Date.now(), fai
facts: run.facts,
saw: run.saw,
responses: run.responses,
+ ...(run.uploads.length ? { uploads: run.uploads } : {}),
cuts: run.cuts,
video: null,
};
diff --git a/api/_lib/x-content/verify.js b/api/_lib/x-content/verify.js
index 121bd7f07..bd184ca74 100644
--- a/api/_lib/x-content/verify.js
+++ b/api/_lib/x-content/verify.js
@@ -368,7 +368,7 @@ export function factDrift(item, proof, facts) {
async function scenarioProbe(item, root) {
const proof = loadProof(root, item.id);
- const run = await runScenario(item.scenario, { film: false });
+ const run = await runScenario(item.scenario, { film: false, root });
if (!run.passed) {
const failed = run.steps.find((step) => !step.ok);
return { ok: false, detail: `step ${failed.index} (${failed.kind} ${failed.target}): ${failed.detail}` };
diff --git a/tests/x-content-reel.test.js b/tests/x-content-reel.test.js
index 0de54158d..e7826a386 100644
--- a/tests/x-content-reel.test.js
+++ b/tests/x-content-reel.test.js
@@ -137,6 +137,17 @@ describe('scenario', () => {
expect(problems).toMatch(/step 12: needs one of/);
});
+ it('hands the page a file from the repository, never one from outside it', () => {
+ const upload = (step) => scenarioProblems({ steps: [{ goto: 'https://three.ws/image-to-3d' }, step, { expect: '1 of 6 views' }] }).join('\n');
+ expect(stepKind({ upload: 'data/x-content/inputs/photo.png', into: 'FRONT' })).toBe('upload');
+ expect(upload({ upload: 'data/x-content/inputs/photo.png', into: 'FRONT', awaits: '/api/forge-upload' })).toBe('');
+ expect(upload({ upload: 'public/x-media/a/photo.jpg', into: { selector: '.view-slot' } })).toBe('');
+ expect(upload({ upload: '/etc/passwd', into: 'FRONT' })).toMatch(/step 2: upload needs a repository path/);
+ expect(upload({ upload: 'data/../../secret.png', into: 'FRONT' })).toMatch(/step 2: upload needs a repository path/);
+ expect(upload({ upload: 'src/forge.js', into: 'FRONT' })).toMatch(/step 2: upload needs a repository path/);
+ expect(upload({ upload: 'data/x-content/inputs/photo.png' })).toMatch(/step 2: upload needs "into"/);
+ });
+
it('films every format at even dimensions with room for the bar', () => {
for (const format of Object.values(FORMATS)) {
expect((format.width * format.scale) % 2).toBe(0);
@@ -191,6 +202,18 @@ describe('proof', () => {
expect(proofProblems(item(), dir, NOW).join('\n')).toMatch(/is not the file the proof filmed/);
});
+ it('is void once the file the run uploaded is swapped', () => {
+ const photo = Buffer.from('the photo the run uploaded');
+ const uploaded = proof({ uploads: [{ path: 'data/x-content/inputs/photo.png', sha256: sha256(photo) }] });
+ const dir = sandbox(uploaded);
+ expect(proofProblems(item(), dir, NOW).join('\n')).toMatch(/the file the run uploaded, is missing/);
+ mkdirSync(join(dir, 'data/x-content/inputs'), { recursive: true });
+ writeFileSync(join(dir, 'data/x-content/inputs/photo.png'), photo);
+ expect(proofProblems(item(), dir, NOW)).toEqual([]);
+ writeFileSync(join(dir, 'data/x-content/inputs/photo.png'), Buffer.from('a different photo'));
+ expect(proofProblems(item(), dir, NOW).join('\n')).toMatch(/is not the file the run uploaded/);
+ });
+
it('refuses a reel in which almost nothing moves', () => {
const still = proof({ video: { ...proof().video, motion: MIN_MOTION - 0.05 } });
expect(proofProblems(item(), sandbox(still), NOW).join('\n')).toMatch(/only 10% of the reel's frames change/);