Skip to content

The only tool you need to know what is happening and how to fix it.

fixes: middleware filtering project id should be the only project id we trust + timezone fix +

ddux0c993c621bb2
diff --git a/CLAUDE.md b/CLAUDE.md
index 8c69ce05..4394a01a 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -627,6 +627,31 @@ query := `
`
```
+### Error Handling Pattern
+
+**IMPORTANT:** When handling errors in controllers, always use `c.AbortWithError` with `traceway.NewStackTraceErrorf` instead of `c.JSON` with a generic error message. This ensures proper error tracking with stack traces.
+
+```go
+// CORRECT - Use AbortWithError with descriptive reason
+projectId, err := middleware.GetProjectId(c)
+if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+}
+
+// WRONG - Do not use c.JSON for internal server errors
+if err != nil {
+ c.JSON(http.StatusInternalServerError, gin.H{"error": err.Error()})
+ return
+}
+```
+
+**Key points:**
+- The reason should describe the actual cause (e.g., "RequireProjectAccess middleware must be applied")
+- Use `%w` to wrap the original error for proper error chaining
+- This pattern applies to all 500 Internal Server Error responses
+- For client errors (400, 404), `c.JSON` with an error message is acceptable
+
---
## Go Client SDK
diff --git a/backend/app/controllers/clientcontrollers/client.controller.go b/backend/app/controllers/clientcontrollers/client.controller.go
index c099fafc..27bd7b12 100644
--- a/backend/app/controllers/clientcontrollers/client.controller.go
+++ b/backend/app/controllers/clientcontrollers/client.controller.go
@@ -26,7 +26,11 @@ type ReportRequest struct {
}
func (e clientController) Report(c *gin.Context) {
- projectId := middleware.GetProjectId(c)
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("UseClientAuth middleware must be applied: %w", err))
+ return
+ }
var request ReportRequest
if err := c.ShouldBindBodyWithJSON(&request); err != nil {
@@ -89,7 +93,7 @@ func (e clientController) Report(c *gin.Context) {
}
}
- err := repositories.ExceptionStackTraceRepository.InsertAsync(c, exceptionStackTraceToInsert)
+ err = repositories.ExceptionStackTraceRepository.InsertAsync(c, exceptionStackTraceToInsert)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error inserting exceptionStackTraceToInsert: %w", err))
diff --git a/backend/app/controllers/endpoint.controller.go b/backend/app/controllers/endpoint.controller.go
index a1c06790..e1c70372 100644
--- a/backend/app/controllers/endpoint.controller.go
+++ b/backend/app/controllers/endpoint.controller.go
@@ -1,6 +1,7 @@
package controllers
import (
+ "backend/app/middleware"
"backend/app/models"
"backend/app/repositories"
"net/http"
@@ -8,14 +9,12 @@ import (
"time"
"github.com/gin-gonic/gin"
- "github.com/google/uuid"
traceway "go.tracewayapp.com"
)
type endpointController struct{}
type EndpointSearchRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
FromDate time.Time `json:"fromDate"`
ToDate time.Time `json:"toDate"`
OrderBy string `json:"orderBy"`
@@ -24,7 +23,6 @@ type EndpointSearchRequest struct {
}
type EndpointInstancesRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
FromDate time.Time `json:"fromDate"`
ToDate time.Time `json:"toDate"`
OrderBy string `json:"orderBy"`
@@ -39,7 +37,6 @@ type EndpointInstancesResponse struct {
}
type EndpointStackedChartRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
FromDate time.Time `json:"fromDate"`
ToDate time.Time `json:"toDate"`
MetricType string `json:"metricType"` // total_time, p50, p95, p99
@@ -47,13 +44,19 @@ type EndpointStackedChartRequest struct {
}
func (e endpointController) FindAllEndpoints(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request EndpointSearchRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
- endpoints, total, err := repositories.EndpointRepository.FindAll(c, request.ProjectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy)
+ endpoints, total, err := repositories.EndpointRepository.FindAll(c, projectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading endpoints: %w", err))
return
@@ -71,13 +74,19 @@ func (e endpointController) FindAllEndpoints(c *gin.Context) {
}
func (e endpointController) FindGroupedByEndpoint(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request EndpointSearchRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
- stats, total, err := repositories.EndpointRepository.FindGroupedByEndpoint(c, request.ProjectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
+ stats, total, err := repositories.EndpointRepository.FindGroupedByEndpoint(c, projectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading stats: %w", err))
return
@@ -95,6 +104,12 @@ func (e endpointController) FindGroupedByEndpoint(c *gin.Context) {
}
func (e endpointController) FindByEndpoint(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
rawEndpoint := c.Query("endpoint")
if rawEndpoint == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "endpoint is required"})
@@ -113,19 +128,18 @@ func (e endpointController) FindByEndpoint(c *gin.Context) {
return
}
- endpoints, total, err := repositories.EndpointRepository.FindByEndpoint(c, request.ProjectId, endpoint, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
+ endpoints, total, err := repositories.EndpointRepository.FindByEndpoint(c, projectId, endpoint, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading endpoints: %w", err))
return
}
// Get aggregate stats for this endpoint
- stats, err := repositories.EndpointRepository.GetEndpointStats(c, request.ProjectId, endpoint, request.FromDate, request.ToDate)
+ stats, err := repositories.EndpointRepository.GetEndpointStats(c, projectId, endpoint, request.FromDate, request.ToDate)
if err != nil {
// Don't fail the request if stats fail, just return nil stats
stats = nil
}
-
c.JSON(http.StatusOK, EndpointInstancesResponse{
Data: endpoints,
Stats: stats,
@@ -139,6 +153,12 @@ func (e endpointController) FindByEndpoint(c *gin.Context) {
}
func (e endpointController) GetStackedChart(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request EndpointStackedChartRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
@@ -156,7 +176,7 @@ func (e endpointController) GetStackedChart(c *gin.Context) {
request.MetricType = "total_time" // default
}
- data, err := repositories.EndpointRepository.GetEndpointStackedChart(c, request.ProjectId, request.FromDate, request.ToDate, request.IntervalMinutes, request.MetricType)
+ data, err := repositories.EndpointRepository.GetEndpointStackedChart(c, projectId, request.FromDate, request.ToDate, request.IntervalMinutes, request.MetricType)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading stacked chart data: %w", err))
return
diff --git a/backend/app/controllers/endpoint_detail.controller.go b/backend/app/controllers/endpoint_detail.controller.go
index 33674360..30e8dc23 100644
--- a/backend/app/controllers/endpoint_detail.controller.go
+++ b/backend/app/controllers/endpoint_detail.controller.go
@@ -1,6 +1,7 @@
package controllers
import (
+ "backend/app/middleware"
"backend/app/models"
"backend/app/repositories"
"net/http"
@@ -12,10 +13,6 @@ import (
type endpointDetailController struct{}
-type EndpointDetailRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
-}
-
type EndpointExceptionInfo struct {
ExceptionHash string `json:"exceptionHash"`
StackTrace string `json:"stackTrace"`
@@ -39,27 +36,27 @@ type EndpointDetailResponse struct {
}
func (t endpointDetailController) GetEndpointDetail(c *gin.Context) {
- endpointId, err := uuid.Parse(c.Param("endpointId"))
+ projectId, err := middleware.GetProjectId(c)
if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": "invalid endpointId"})
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
return
}
- var request EndpointDetailRequest
- if err := c.ShouldBindJSON(&request); err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ endpointId, err := uuid.Parse(c.Param("endpointId"))
+ if err != nil {
+ c.JSON(http.StatusBadRequest, gin.H{"error": "invalid endpointId"})
return
}
// Get endpoint
- endpoint, err := repositories.EndpointRepository.FindById(c, request.ProjectId, endpointId)
+ endpoint, err := repositories.EndpointRepository.FindById(c, projectId, endpointId)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": "Endpoint not found"})
return
}
// Get segments (flat list ordered by start_time)
- segments, err := repositories.SegmentRepository.FindByTransactionId(c, request.ProjectId, endpointId)
+ segments, err := repositories.SegmentRepository.FindByTransactionId(c, projectId, endpointId)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading segments: %w", err))
return
@@ -69,7 +66,7 @@ func (t endpointDetailController) GetEndpointDetail(c *gin.Context) {
var exceptionInfo *EndpointExceptionInfo
var messages []EndpointMessageInfo
- allExceptions, err := repositories.ExceptionStackTraceRepository.FindAllByTransactionId(c, request.ProjectId, endpointId)
+ allExceptions, err := repositories.ExceptionStackTraceRepository.FindAllByTransactionId(c, projectId, endpointId)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading all exceptions: %w", err))
return
diff --git a/backend/app/controllers/exception_stack_trace.controller.go b/backend/app/controllers/exception_stack_trace.controller.go
index 1db4485e..bcd676c1 100644
--- a/backend/app/controllers/exception_stack_trace.controller.go
+++ b/backend/app/controllers/exception_stack_trace.controller.go
@@ -1,6 +1,7 @@
package controllers
import (
+ "backend/app/middleware"
"backend/app/models"
"backend/app/repositories"
"net/http"
@@ -15,7 +16,6 @@ import (
type exceptionStackTraceController struct{}
type ExceptionSearchRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
FromDate time.Time `json:"fromDate"`
ToDate time.Time `json:"toDate"`
OrderBy string `json:"orderBy"`
@@ -26,12 +26,10 @@ type ExceptionSearchRequest struct {
}
type ArchiveRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
- Hashes []string `json:"hashes"`
+ Hashes []string `json:"hashes"`
}
type ExceptionDetailRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
Pagination PaginationParams `json:"pagination"`
}
@@ -42,13 +40,19 @@ type ExceptionDetailResponse struct {
}
func (e exceptionStackTraceController) FindGrouppedExceptionStackTraces(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request ExceptionSearchRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
- exceptions, total, err := repositories.ExceptionStackTraceRepository.FindGrouped(c, request.ProjectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.Search, request.SearchType, request.IncludeArchived)
+ exceptions, total, err := repositories.ExceptionStackTraceRepository.FindGrouped(c, projectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.Search, request.SearchType, request.IncludeArchived)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading exceptions: %w", err))
return
@@ -65,7 +69,7 @@ func (e exceptionStackTraceController) FindGrouppedExceptionStackTraces(c *gin.C
now := time.Now()
start24h := now.Add(-24 * time.Hour)
- trends, err := repositories.ExceptionStackTraceRepository.GetHourlyTrendForHashes(c, request.ProjectId, hashes, start24h, now)
+ trends, err := repositories.ExceptionStackTraceRepository.GetHourlyTrendForHashes(c, projectId, hashes, start24h, now)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading trends: %w", err))
return
@@ -93,6 +97,12 @@ func (e exceptionStackTraceController) FindGrouppedExceptionStackTraces(c *gin.C
}
func (e exceptionStackTraceController) FindByHash(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
exceptionHash := c.Param("hash")
if exceptionHash == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "exception hash is required"})
@@ -105,7 +115,7 @@ func (e exceptionStackTraceController) FindByHash(c *gin.Context) {
request.Pagination = PaginationParams{Page: 1, PageSize: 20}
}
- group, occurrences, total, err := repositories.ExceptionStackTraceRepository.FindByHash(c, request.ProjectId, exceptionHash, request.Pagination.Page, request.Pagination.PageSize)
+ group, occurrences, total, err := repositories.ExceptionStackTraceRepository.FindByHash(c, projectId, exceptionHash, request.Pagination.Page, request.Pagination.PageSize)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading the group: %w", err))
return
@@ -129,6 +139,12 @@ func (e exceptionStackTraceController) FindByHash(c *gin.Context) {
}
func (e exceptionStackTraceController) ArchiveExceptions(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request ArchiveRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
@@ -140,7 +156,7 @@ func (e exceptionStackTraceController) ArchiveExceptions(c *gin.Context) {
return
}
- err := repositories.ExceptionStackTraceRepository.ArchiveByHashes(c, request.ProjectId, request.Hashes)
+ err = repositories.ExceptionStackTraceRepository.ArchiveByHashes(c, projectId, request.Hashes)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error archiving %s: %w", strings.Join(request.Hashes, ","), err))
return
@@ -150,6 +166,12 @@ func (e exceptionStackTraceController) ArchiveExceptions(c *gin.Context) {
}
func (e exceptionStackTraceController) UnarchiveExceptions(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request ArchiveRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
@@ -161,7 +183,7 @@ func (e exceptionStackTraceController) UnarchiveExceptions(c *gin.Context) {
return
}
- err := repositories.ExceptionStackTraceRepository.UnarchiveByHashes(c, request.ProjectId, request.Hashes)
+ err = repositories.ExceptionStackTraceRepository.UnarchiveByHashes(c, projectId, request.Hashes)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error unarchiving %s: %w", strings.Join(request.Hashes, ","), err))
return
@@ -171,21 +193,19 @@ func (e exceptionStackTraceController) UnarchiveExceptions(c *gin.Context) {
}
func (e exceptionStackTraceController) FindById(c *gin.Context) {
- exceptionId, err := uuid.Parse(c.Param("exceptionId"))
+ projectId, err := middleware.GetProjectId(c)
if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": "invalid exception id"})
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
return
}
- var request struct {
- ProjectId uuid.UUID `json:"projectId"`
- }
- if err := c.ShouldBindJSON(&request); err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ exceptionId, err := uuid.Parse(c.Param("exceptionId"))
+ if err != nil {
+ c.JSON(http.StatusBadRequest, gin.H{"error": "invalid exception id"})
return
}
- exception, err := repositories.ExceptionStackTraceRepository.FindById(c, request.ProjectId, exceptionId)
+ exception, err := repositories.ExceptionStackTraceRepository.FindById(c, projectId, exceptionId)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading the exception: %w", err))
return
diff --git a/backend/app/controllers/metric_record.controller.go b/backend/app/controllers/metric_record.controller.go
index a91e2a46..9f62ca67 100644
--- a/backend/app/controllers/metric_record.controller.go
+++ b/backend/app/controllers/metric_record.controller.go
@@ -1,31 +1,25 @@
package controllers
import (
+ "backend/app/middleware"
"backend/app/models"
"backend/app/repositories"
"net/http"
"time"
"github.com/gin-gonic/gin"
- "github.com/google/uuid"
traceway "go.tracewayapp.com"
)
type metricRecordController struct{}
-type HomepageStatsRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
-}
-
func (e metricRecordController) FindHomepageStats(c *gin.Context) {
- var request HomepageStatsRequest
- if err := c.ShouldBindJSON(&request); err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
return
}
- projectId := request.ProjectId
-
// requests in last 24h vs previous 24h
now := time.Now()
oneDayAgo := now.Add(-24 * time.Hour)
diff --git a/backend/app/controllers/task.controller.go b/backend/app/controllers/task.controller.go
index c93ae87e..8703ce57 100644
--- a/backend/app/controllers/task.controller.go
+++ b/backend/app/controllers/task.controller.go
@@ -1,6 +1,7 @@
package controllers
import (
+ "backend/app/middleware"
"backend/app/models"
"backend/app/repositories"
"net/http"
@@ -8,14 +9,12 @@ import (
"time"
"github.com/gin-gonic/gin"
- "github.com/google/uuid"
traceway "go.tracewayapp.com"
)
type taskController struct{}
type TaskSearchRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
FromDate time.Time `json:"fromDate"`
ToDate time.Time `json:"toDate"`
OrderBy string `json:"orderBy"`
@@ -24,7 +23,6 @@ type TaskSearchRequest struct {
}
type TaskInstancesRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
FromDate time.Time `json:"fromDate"`
ToDate time.Time `json:"toDate"`
OrderBy string `json:"orderBy"`
@@ -39,13 +37,19 @@ type TaskInstancesResponse struct {
}
func (e taskController) FindAllTasks(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request TaskSearchRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
- tasks, total, err := repositories.TaskRepository.FindAll(c, request.ProjectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy)
+ tasks, total, err := repositories.TaskRepository.FindAll(c, projectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading tasks: %w", err))
return
@@ -63,13 +67,19 @@ func (e taskController) FindAllTasks(c *gin.Context) {
}
func (e taskController) FindGroupedByTaskName(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
var request TaskSearchRequest
if err := c.ShouldBindJSON(&request); err != nil {
c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
return
}
- stats, total, err := repositories.TaskRepository.FindGroupedByTaskName(c, request.ProjectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
+ stats, total, err := repositories.TaskRepository.FindGroupedByTaskName(c, projectId, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading stats by name: %w", err))
return
@@ -87,6 +97,12 @@ func (e taskController) FindGroupedByTaskName(c *gin.Context) {
}
func (e taskController) FindByTaskName(c *gin.Context) {
+ projectId, err := middleware.GetProjectId(c)
+ if err != nil {
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
+ return
+ }
+
rawTaskName := c.Query("task")
if rawTaskName == "" {
c.JSON(http.StatusBadRequest, gin.H{"error": "task is required"})
@@ -105,14 +121,14 @@ func (e taskController) FindByTaskName(c *gin.Context) {
return
}
- tasks, total, err := repositories.TaskRepository.FindByTaskName(c, request.ProjectId, taskName, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
+ tasks, total, err := repositories.TaskRepository.FindByTaskName(c, projectId, taskName, request.FromDate, request.ToDate, request.Pagination.Page, request.Pagination.PageSize, request.OrderBy, request.SortDirection)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading tasks by name: %w", err))
return
}
// Get aggregate stats for this task
- stats, err := repositories.TaskRepository.GetTaskStats(c, request.ProjectId, taskName, request.FromDate, request.ToDate)
+ stats, err := repositories.TaskRepository.GetTaskStats(c, projectId, taskName, request.FromDate, request.ToDate)
if err != nil {
// Don't fail the request if stats fail, just return nil stats
stats = nil
diff --git a/backend/app/controllers/task_detail.controller.go b/backend/app/controllers/task_detail.controller.go
index 4061de7a..5938a243 100644
--- a/backend/app/controllers/task_detail.controller.go
+++ b/backend/app/controllers/task_detail.controller.go
@@ -1,6 +1,7 @@
package controllers
import (
+ "backend/app/middleware"
"backend/app/models"
"backend/app/repositories"
"net/http"
@@ -12,10 +13,6 @@ import (
type taskDetailController struct{}
-type TaskDetailRequest struct {
- ProjectId uuid.UUID `json:"projectId"`
-}
-
type TaskExceptionInfo struct {
ExceptionHash string `json:"exceptionHash"`
StackTrace string `json:"stackTrace"`
@@ -39,27 +36,27 @@ type TaskDetailResponse struct {
}
func (t taskDetailController) GetTaskDetail(c *gin.Context) {
- taskId, err := uuid.Parse(c.Param("taskId"))
+ projectId, err := middleware.GetProjectId(c)
if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": "invalid taskId"})
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("RequireProjectAccess middleware must be applied: %w", err))
return
}
- var request TaskDetailRequest
- if err := c.ShouldBindJSON(&request); err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ taskId, err := uuid.Parse(c.Param("taskId"))
+ if err != nil {
+ c.JSON(http.StatusBadRequest, gin.H{"error": "invalid taskId"})
return
}
// Get task
- task, err := repositories.TaskRepository.FindById(c, request.ProjectId, taskId)
+ task, err := repositories.TaskRepository.FindById(c, projectId, taskId)
if err != nil {
c.JSON(http.StatusNotFound, gin.H{"error": "Task not found"})
return
}
// Get segments (flat list ordered by start_time)
- segments, err := repositories.SegmentRepository.FindByTransactionId(c, request.ProjectId, taskId)
+ segments, err := repositories.SegmentRepository.FindByTransactionId(c, projectId, taskId)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading segments: %w", err))
return
@@ -69,7 +66,7 @@ func (t taskDetailController) GetTaskDetail(c *gin.Context) {
var exceptionInfo *TaskExceptionInfo
var messages []TaskMessageInfo
- allExceptions, err := repositories.ExceptionStackTraceRepository.FindAllByTransactionId(c, request.ProjectId, taskId)
+ allExceptions, err := repositories.ExceptionStackTraceRepository.FindAllByTransactionId(c, projectId, taskId)
if err != nil {
c.AbortWithError(500, traceway.NewStackTraceErrorf("error loading allExceptions: %w", err))
return
diff --git a/backend/app/middleware/require_project_access.middleware.go b/backend/app/middleware/require_project_access.middleware.go
index 18f1facd..457ccaf1 100644
--- a/backend/app/middleware/require_project_access.middleware.go
+++ b/backend/app/middleware/require_project_access.middleware.go
@@ -44,6 +44,7 @@ func InitRequireProjectAccess() {
return
}
+ c.Set(ProjectIdContextKey, projectId)
c.Next()
}
}
diff --git a/backend/app/middleware/use_client_auth.middleware.go b/backend/app/middleware/use_client_auth.middleware.go
index 29a1b1ed..36c3a79f 100644
--- a/backend/app/middleware/use_client_auth.middleware.go
+++ b/backend/app/middleware/use_client_auth.middleware.go
@@ -2,6 +2,7 @@ package middleware
import (
"backend/app/cache"
+ "errors"
"net/http"
"strings"
@@ -12,6 +13,8 @@ import (
const ProjectContextKey = "project"
const ProjectIdContextKey = "project_id"
+var ErrProjectIdNotInContext = errors.New("projectId not found in context - ensure RequireProjectAccess middleware is applied")
+
var UseClientAuth func(c *gin.Context)
func InitUseClientAuth() {
@@ -42,9 +45,9 @@ func InitUseClientAuth() {
}
// GetProjectId retrieves the project ID from the Gin context
-func GetProjectId(c *gin.Context) uuid.UUID {
+func GetProjectId(c *gin.Context) (uuid.UUID, error) {
if id, exists := c.Get(ProjectIdContextKey); exists {
- return id.(uuid.UUID)
+ return id.(uuid.UUID), nil
}
- return uuid.Nil
+ return uuid.Nil, ErrProjectIdNotInContext
}
diff --git a/backend/app/repositories/endpoint.repository.go b/backend/app/repositories/endpoint.repository.go
index 8ebbb4f2..dc757b4d 100644
--- a/backend/app/repositories/endpoint.repository.go
+++ b/backend/app/repositories/endpoint.repository.go
@@ -491,14 +491,15 @@ func (e *endpointRepository) GetEndpointStats(ctx context.Context, projectId uui
query := `SELECT
count() as count,
- avg(duration) / 1000000 as avg_duration_ms,
- quantile(0.5)(duration) / 1000000 as p50_duration_ms,
- quantile(0.95)(duration) / 1000000 as p95_duration_ms,
- quantile(0.99)(duration) / 1000000 as p99_duration_ms,
- countIf(status_code >= 500) * 100.0 / count() as error_rate,
- countIf(duration <= 500000000 AND status_code < 500) +
- (countIf(duration > 500000000 AND duration <= 2000000000 AND status_code < 500) * 0.5)
- as satisfied_tolerating
+ if(count() > 0, avg(duration) / 1000000, 0) as avg_duration_ms,
+ if(count() > 0, quantile(0.5)(duration) / 1000000, 0) as p50_duration_ms,
+ if(count() > 0, quantile(0.95)(duration) / 1000000, 0) as p95_duration_ms,
+ if(count() > 0, quantile(0.99)(duration) / 1000000, 0) as p99_duration_ms,
+ if(count() > 0, countIf(status_code >= 500) * 100.0 / count(), 0) as error_rate,
+ if(count() > 0,
+ countIf(duration <= 500000000 AND status_code < 500) +
+ (countIf(duration > 500000000 AND duration <= 2000000000 AND status_code < 500) * 0.5),
+ 0) as satisfied_tolerating
FROM endpoints
WHERE project_id = ? AND endpoint = ? AND recorded_at >= ? AND recorded_at <= ?`
diff --git a/frontend/src/lib/utils/url-params.ts b/frontend/src/lib/utils/url-params.ts
index a3825ca8..30fcd513 100644
--- a/frontend/src/lib/utils/url-params.ts
+++ b/frontend/src/lib/utils/url-params.ts
@@ -1,6 +1,7 @@
import { browser } from '$app/environment';
import { goto } from '$app/navigation';
import { CalendarDate } from '@internationalized/date';
+import { DateTime } from 'luxon';
import { getNow, parseISO } from './formatters';
export const presetMinutes: Record<string, number> = {
@@ -23,12 +24,14 @@ export function getTimeRangeFromPreset(presetValue: string, timezone: string): {
return { from: from.toJSDate(), to: now.toJSDate() };
}
-export function dateToCalendarDate(date: Date): CalendarDate {
- return new CalendarDate(date.getFullYear(), date.getMonth() + 1, date.getDate());
+export function dateToCalendarDate(date: Date, timezone: string): CalendarDate {
+ const dt = DateTime.fromJSDate(date).setZone(timezone);
+ return new CalendarDate(dt.year, dt.month, dt.day);
}
-export function dateToTimeString(date: Date): string {
- return `${String(date.getHours()).padStart(2, '0')}:${String(date.getMinutes()).padStart(2, '0')}`;
+export function dateToTimeString(date: Date, timezone: string): string {
+ const dt = DateTime.fromJSDate(date).setZone(timezone);
+ return `${String(dt.hour).padStart(2, '0')}:${String(dt.minute).padStart(2, '0')}`;
}
export type TimeRangeParams = {
diff --git a/frontend/src/routes/endpoints/+page.svelte b/frontend/src/routes/endpoints/+page.svelte
index ef141f60..46b54627 100644
--- a/frontend/src/routes/endpoints/+page.svelte
+++ b/frontend/src/routes/endpoints/+page.svelte
@@ -94,10 +94,10 @@
// Date Range State
let selectedPreset = $state<string | null>(initialUrlParams.preset);
- let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from));
- let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to));
- let fromTime = $state(dateToTimeString(initialRange.from));
- let toTime = $state(dateToTimeString(initialRange.to));
+ let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from, timezone));
+ let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to, timezone));
+ let fromTime = $state(dateToTimeString(initialRange.from, timezone));
+ let toTime = $state(dateToTimeString(initialRange.to, timezone));
// Update URL with current time range
function updateTimeRangeUrl(pushToHistory = true) {
@@ -115,10 +115,10 @@
const range = getResolvedTimeRange(urlParams, timezone);
selectedPreset = urlParams.preset;
- fromDate = dateToCalendarDate(range.from);
- fromTime = dateToTimeString(range.from);
- toDate = dateToCalendarDate(range.to);
- toTime = dateToTimeString(range.to);
+ fromDate = dateToCalendarDate(range.from, timezone);
+ fromTime = dateToTimeString(range.from, timezone);
+ toDate = dateToCalendarDate(range.to, timezone);
+ toTime = dateToTimeString(range.to, timezone);
page = 1;
loadData(false);
diff --git a/frontend/src/routes/endpoints/[endpoint]/+page.svelte b/frontend/src/routes/endpoints/[endpoint]/+page.svelte
index ddbf9b39..76475353 100644
--- a/frontend/src/routes/endpoints/[endpoint]/+page.svelte
+++ b/frontend/src/routes/endpoints/[endpoint]/+page.svelte
@@ -102,10 +102,10 @@
// Date Range State
let selectedPreset = $state<string | null>(initialRange.preset);
- let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from));
- let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to));
- let fromTime = $state(dateToTimeString(initialRange.from));
- let toTime = $state(dateToTimeString(initialRange.to));
+ let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from, timezone));
+ let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to, timezone));
+ let fromTime = $state(dateToTimeString(initialRange.from, timezone));
+ let toTime = $state(dateToTimeString(initialRange.to, timezone));
function updateTimeRangeUrl(pushToHistory = true) {
updateUrl(
diff --git a/frontend/src/routes/issues/+page.svelte b/frontend/src/routes/issues/+page.svelte
index c8dd2574..8175d065 100644
--- a/frontend/src/routes/issues/+page.svelte
+++ b/frontend/src/routes/issues/+page.svelte
@@ -94,10 +94,10 @@
// Time range state
let selectedPreset = $state<string | null>(initialUrlParams.preset);
- let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from));
- let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to));
- let fromTime = $state(dateToTimeString(initialRange.from));
- let toTime = $state(dateToTimeString(initialRange.to));
+ let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from, timezone));
+ let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to, timezone));
+ let fromTime = $state(dateToTimeString(initialRange.from, timezone));
+ let toTime = $state(dateToTimeString(initialRange.to, timezone));
// Search state (manual trigger only)
let searchQuery = $state(initialUrlParams.search);
@@ -240,10 +240,10 @@
const urlParams = parseIssuesUrlParams();
const range = getResolvedTimeRange(urlParams, timezone);
selectedPreset = urlParams.preset;
- fromDate = dateToCalendarDate(range.from);
- toDate = dateToCalendarDate(range.to);
- fromTime = dateToTimeString(range.from);
- toTime = dateToTimeString(range.to);
+ fromDate = dateToCalendarDate(range.from, timezone);
+ toDate = dateToCalendarDate(range.to, timezone);
+ fromTime = dateToTimeString(range.from, timezone);
+ toTime = dateToTimeString(range.to, timezone);
searchQuery = urlParams.search;
searchType = urlParams.searchType;
page = 1;
diff --git a/frontend/src/routes/metrics/+page.svelte b/frontend/src/routes/metrics/+page.svelte
index d37e4bc4..d697d9cb 100644
--- a/frontend/src/routes/metrics/+page.svelte
+++ b/frontend/src/routes/metrics/+page.svelte
@@ -94,10 +94,10 @@
const initialRange = getResolvedTimeRange(initialUrlParams, timezone);
let selectedPreset = $state<string | null>(initialUrlParams.preset);
- let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from));
- let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to));
- let fromTime = $state(dateToTimeString(initialRange.from));
- let toTime = $state(dateToTimeString(initialRange.to));
+ let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from, timezone));
+ let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to, timezone));
+ let fromTime = $state(dateToTimeString(initialRange.from, timezone));
+ let toTime = $state(dateToTimeString(initialRange.to, timezone));
let sharedTimeDomain = $state<[Date, Date] | null>(null);
// Initialize tab from URL
@@ -131,10 +131,10 @@
const range = getResolvedTimeRange(urlParams, timezone);
selectedPreset = urlParams.preset;
- fromDate = dateToCalendarDate(range.from);
- fromTime = dateToTimeString(range.from);
- toDate = dateToCalendarDate(range.to);
- toTime = dateToTimeString(range.to);
+ fromDate = dateToCalendarDate(range.from, timezone);
+ fromTime = dateToTimeString(range.from, timezone);
+ toDate = dateToCalendarDate(range.to, timezone);
+ toTime = dateToTimeString(range.to, timezone);
selectedServers = urlParams.servers;
activeTab = urlParams.tab;
diff --git a/frontend/src/routes/tasks/+page.svelte b/frontend/src/routes/tasks/+page.svelte
index bc073bd2..a11efb4e 100644
--- a/frontend/src/routes/tasks/+page.svelte
+++ b/frontend/src/routes/tasks/+page.svelte
@@ -59,10 +59,10 @@
// Date Range State
let selectedPreset = $state<string | null>(initialUrlParams.preset);
- let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from));
- let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to));
- let fromTime = $state(dateToTimeString(initialRange.from));
- let toTime = $state(dateToTimeString(initialRange.to));
+ let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from, timezone));
+ let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to, timezone));
+ let fromTime = $state(dateToTimeString(initialRange.from, timezone));
+ let toTime = $state(dateToTimeString(initialRange.to, timezone));
// Update URL with current time range
function updateTimeRangeUrl(pushToHistory = true) {
@@ -80,10 +80,10 @@
const range = getResolvedTimeRange(urlParams, timezone);
selectedPreset = urlParams.preset;
- fromDate = dateToCalendarDate(range.from);
- fromTime = dateToTimeString(range.from);
- toDate = dateToCalendarDate(range.to);
- toTime = dateToTimeString(range.to);
+ fromDate = dateToCalendarDate(range.from, timezone);
+ fromTime = dateToTimeString(range.from, timezone);
+ toDate = dateToCalendarDate(range.to, timezone);
+ toTime = dateToTimeString(range.to, timezone);
page = 1;
loadData(false);
diff --git a/frontend/src/routes/tasks/[task]/+page.svelte b/frontend/src/routes/tasks/[task]/+page.svelte
index 7ef53252..3dfc218b 100644
--- a/frontend/src/routes/tasks/[task]/+page.svelte
+++ b/frontend/src/routes/tasks/[task]/+page.svelte
@@ -96,10 +96,10 @@
// Date Range State
let selectedPreset = $state<string | null>(initialRange.preset);
- let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from));
- let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to));
- let fromTime = $state(dateToTimeString(initialRange.from));
- let toTime = $state(dateToTimeString(initialRange.to));
+ let fromDate = $state<CalendarDate>(dateToCalendarDate(initialRange.from, timezone));
+ let toDate = $state<CalendarDate>(dateToCalendarDate(initialRange.to, timezone));
+ let fromTime = $state(dateToTimeString(initialRange.from, timezone));
+ let toTime = $state(dateToTimeString(initialRange.to, timezone));
function updateTimeRangeUrl(pushToHistory = true) {
updateUrl(