Skip to content

The only tool you need to know what is happening and how to fix it.

progress

ddux242bed05571e
diff --git a/CLAUDE.md b/CLAUDE.md
index 9141eae7..8cbddeb0 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -886,7 +886,7 @@ Sustained drops also fire a rate-limited (1/min) `traceway.CaptureException` so
- **Users to organizations is many-to-many** via `organization_users`, one role per membership. A user joins additional organizations through invitations (`POST /api/invitations/:token/accept-existing` for existing accounts) and, in cloud mode, registration. Login/register/`LoginBundle` return every membership as `Organizations[]` with roles; the frontend keeps them in `authState.organizations` and groups the navbar project selector by organization when there is more than one.
- **Projects belong to exactly one organization** (`projects.organization_id`). Org membership grants read access to all of the org's projects.
-- **Per-project role overrides** live in `project_user_roles(project_id, user_id, role)` with role `user` or `readonly`. Overrides only apply to members whose org role is `user` or `readonly`; owners and admins always have full access to every org project. Override rows are kept when a member's org role changes (they are inert for owner/admin), and are deleted when the member is removed from the org or the project is deleted. Managed from Settings > Team Members (expand a member row) via `GET/PUT /api/organizations/:orgId/members/:userId/project-roles(/:projectId)`; `PUT` with `role: "default"` clears the override.
+- **Per-project role overrides** live in `project_user_roles(project_id, user_id, role)` with role `user` or `readonly`. Overrides only apply to members whose org role is `user` or `readonly`; owners and admins always have full access to every org project. Override rows are kept when a member's org role changes (they are inert for owner/admin), and are deleted when the member is removed from the org or the project is deleted. Managed from Settings > Team Members (expand a member row) via `GET/PUT /api/organizations/:orgId/members/:userId/project-roles(/:projectId)`; `PUT` with `role: "default"` clears the override and is accepted for any member regardless of org role (so stale rows on members promoted to admin can still be cleaned up); setting `user`/`readonly` is rejected with 422 for owners and admins.
- **Effective project role** (`ProjectRepository.GetEffectiveRole`): the org role if `owner`/`admin`, otherwise the override if present, otherwise the org role. `/api/projects` returns it as `role` on each project and masks `token`/`sourceMapToken` when it resolves to `readonly`; the frontend derives write gating from it (`isProjectReadonly` in `projects.svelte.ts`).
#### Organization Roles
diff --git a/backend/app/controllers/member.controller.go b/backend/app/controllers/member.controller.go
index 9fd6b24b..1bf8a581 100644
--- a/backend/app/controllers/member.controller.go
+++ b/backend/app/controllers/member.controller.go
@@ -186,14 +186,13 @@ func (c *memberController) UpdateProjectRole(ctx *gin.Context) {
ctx.JSON(http.StatusNotFound, gin.H{"error": "User is not a member of this organization"})
return
}
- if targetRole == "owner" || targetRole == "admin" {
- ctx.JSON(http.StatusUnprocessableEntity, gin.H{"error": "Owners and admins always have full access to every project"})
- return
- }
-
if request.Role == "default" {
err = transactional.ProjectUserRoleRepository.Delete(tx, projectId, targetUserId)
} else {
+ if targetRole == "owner" || targetRole == "admin" {
+ ctx.JSON(http.StatusUnprocessableEntity, gin.H{"error": "Owners and admins always have full access to every project"})
+ return
+ }
err = transactional.ProjectUserRoleRepository.Upsert(tx, projectId, targetUserId, request.Role)
}
if err != nil {
diff --git a/backend/app/controllers/project.controller.go b/backend/app/controllers/project.controller.go
index 052acbc2..f4c1dcc3 100644
--- a/backend/app/controllers/project.controller.go
+++ b/backend/app/controllers/project.controller.go
@@ -153,6 +153,7 @@ func (p projectController) CreateProject(c *gin.Context) {
userId := middleware.GetUserId(c)
+ var creatorRole string
project, err := db.ExecuteTransaction(func(tx *sql.Tx) (*models.Project, error) {
currentProject, err := transactional.ProjectRepository.FindById(tx, projectId)
if err != nil {
@@ -174,6 +175,7 @@ func (p projectController) CreateProject(c *gin.Context) {
if role == "" || role == "readonly" {
return nil, errNoOrgCreateAccess
}
+ creatorRole = role
if ProjectLimitHook != nil {
if err := ProjectLimitHook(tx, targetOrgId); err != nil {
@@ -198,7 +200,9 @@ func (p projectController) CreateProject(c *gin.Context) {
cache.ProjectCache.AddProject(project)
- c.JSON(http.StatusCreated, project.ToProjectWithBackendUrl())
+ projectWithUrl := project.ToProjectWithBackendUrl()
+ projectWithUrl.Role = creatorRole
+ c.JSON(http.StatusCreated, projectWithUrl)
}
func (p projectController) UpdateProject(c *gin.Context) {
diff --git a/backend/app/middleware/require_write_access.middleware.go b/backend/app/middleware/require_write_access.middleware.go
index b2879321..8d0a5302 100644
--- a/backend/app/middleware/require_write_access.middleware.go
+++ b/backend/app/middleware/require_write_access.middleware.go
@@ -2,7 +2,6 @@ package middleware
import (
"database/sql"
- "github.com/tracewayapp/traceway/backend/app/cache"
"github.com/tracewayapp/traceway/backend/app/db"
"github.com/tracewayapp/traceway/backend/app/repositories/transactional"
"net/http"
@@ -31,23 +30,12 @@ func InitRequireWriteAccess() {
return
}
- project := cache.ProjectCache.GetById(projectId)
- if project == nil {
- c.AbortWithStatusJSON(http.StatusNotFound, gin.H{"error": "Project not found"})
- return
- }
-
- if project.OrganizationId == nil {
- c.AbortWithStatusJSON(http.StatusInternalServerError, traceway.NewStackTraceErrorf("Project has no organization: %d %s", project.Id, project.Name))
- return
- }
-
role, err := db.ExecuteTransaction(func(tx *sql.Tx) (string, error) {
return transactional.ProjectRepository.GetEffectiveRole(tx, projectId, userId)
})
if err != nil {
- c.AbortWithStatusJSON(http.StatusForbidden, gin.H{"error": "Access denied"})
+ c.AbortWithError(http.StatusInternalServerError, traceway.NewStackTraceErrorf("failed to resolve effective role: %w", err))
return
}
diff --git a/backend/app/migrations/sqlite/0024_create_project_user_roles.up.sql b/backend/app/migrations/sqlite/0024_create_project_user_roles.up.sql
index 11c92533..0e33fdae 100644
--- a/backend/app/migrations/sqlite/0024_create_project_user_roles.up.sql
+++ b/backend/app/migrations/sqlite/0024_create_project_user_roles.up.sql
@@ -1,8 +1,8 @@
CREATE TABLE IF NOT EXISTS project_user_roles (
id INTEGER PRIMARY KEY AUTOINCREMENT,
- project_id TEXT NOT NULL,
- user_id INTEGER NOT NULL,
- role TEXT NOT NULL,
+ project_id TEXT NOT NULL REFERENCES projects(id),
+ user_id INTEGER NOT NULL REFERENCES users(id),
+ role TEXT NOT NULL CHECK (role IN ('user','readonly')),
created_at DATETIME NOT NULL,
UNIQUE (project_id, user_id)
);
diff --git a/backend/app/models/models.go b/backend/app/models/models.go
index 9b1bd35b..d3c767b2 100644
--- a/backend/app/models/models.go
+++ b/backend/app/models/models.go
@@ -18,7 +18,6 @@ func Init(driver lit.Driver) {
lit.RegisterModel[Organization](driver)
lit.RegisterModel[OrganizationUser](driver)
lit.RegisterModel[OrganizationMember](driver)
- lit.RegisterModel[ProjectUserRole](driver)
lit.RegisterModel[MemberProjectRole](driver)
lit.RegisterModel[Invitation](driver)
lit.RegisterModel[InvitationWithInviter](driver)
diff --git a/backend/app/models/project_user_role.model.go b/backend/app/models/project_user_role.model.go
index 5a19cd49..fb54275a 100644
--- a/backend/app/models/project_user_role.model.go
+++ b/backend/app/models/project_user_role.model.go
@@ -1,19 +1,9 @@
package models
import (
- "time"
-
"github.com/google/uuid"
)
-type ProjectUserRole struct {
- Id int `json:"id"`
- ProjectId uuid.UUID `json:"projectId"`
- UserId int `json:"userId"`
- Role string `json:"role"`
- CreatedAt time.Time `json:"createdAt"`
-}
-
type MemberProjectRole struct {
ProjectId uuid.UUID `json:"projectId" lit:"project_id"`
Name string `json:"name" lit:"name"`
diff --git a/frontend/src/lib/state/organization.svelte.ts b/frontend/src/lib/state/organization.svelte.ts
index 8b3f395f..107b86be 100644
--- a/frontend/src/lib/state/organization.svelte.ts
+++ b/frontend/src/lib/state/organization.svelte.ts
@@ -61,21 +61,27 @@ class OrganizationState {
memberCount = $derived(this.members.length + this.invitations.filter(i => i.status === 'pending').length);
canInvite = $derived(this.memberCount < 10);
+ private loadSeq = 0;
+
async loadSettings(organizationId: number) {
+ const seq = ++this.loadSeq;
this.loading = true;
this.error = null;
try {
const response: OrganizationSettings = await api.get(`/organizations/${organizationId}/settings`);
+ if (seq !== this.loadSeq) return;
this.currentOrganization = response.organization;
this.members = response.members;
this.invitations = response.invitations;
this.userRole = response.userRole;
} catch (e: unknown) {
- const errorMessage = e instanceof Error ? e.message : 'Failed to load settings';
- this.error = errorMessage;
+ if (seq !== this.loadSeq) return;
+ this.error = e instanceof Error ? e.message : 'Failed to load settings';
} finally {
- this.loading = false;
+ if (seq === this.loadSeq) {
+ this.loading = false;
+ }
}
}
diff --git a/frontend/src/lib/state/projects.svelte.ts b/frontend/src/lib/state/projects.svelte.ts
index 3d48aee3..bc04b53f 100644
--- a/frontend/src/lib/state/projects.svelte.ts
+++ b/frontend/src/lib/state/projects.svelte.ts
@@ -95,9 +95,11 @@ export interface ProjectWithToken extends Project {
token: string;
}
+const PROJECTS_CACHE_KEY = 'PROJECTS_CACHE_V2';
+
class ProjectsState {
projects = $state<Project[]>(
- JSON.parse(localStorage.getItem('PROJECTS_CACHE') || '[]')
+ JSON.parse(localStorage.getItem(PROJECTS_CACHE_KEY) || '[]')
);
currentProjectId = $state<string | null>(localStorage.getItem('CURRENT_PROJECT_ID'));
loading = $state(false);
@@ -138,7 +140,7 @@ class ProjectsState {
}
// Cache in localStorage
- localStorage.setItem('PROJECTS_CACHE', JSON.stringify(this.projects));
+ localStorage.setItem(PROJECTS_CACHE_KEY, JSON.stringify(this.projects));
}
async loadProjects() {
@@ -153,7 +155,7 @@ class ProjectsState {
this.error = errorMessage;
// Try to load from cache
- const cached = localStorage.getItem('PROJECTS_CACHE');
+ const cached = localStorage.getItem(PROJECTS_CACHE_KEY);
if (cached) {
this.projects = JSON.parse(cached);
}
@@ -199,7 +201,7 @@ class ProjectsState {
}
initFromCache() {
- const cached = localStorage.getItem('PROJECTS_CACHE');
+ const cached = localStorage.getItem(PROJECTS_CACHE_KEY);
if (cached) {
this.projects = JSON.parse(cached);
}
diff --git a/frontend/src/routes/+layout.svelte b/frontend/src/routes/+layout.svelte
index 6a3fa9ed..a0315c17 100644
--- a/frontend/src/routes/+layout.svelte
+++ b/frontend/src/routes/+layout.svelte
@@ -117,8 +117,8 @@
}
function handleAddProjectClick() {
- const writableOrgs = authState.organizations.filter((o) => o.role !== 'readonly');
- if (writableOrgs.length === 0) {
+ const orgs = authState.organizations;
+ if (orgs.length > 0 && orgs.every((o) => o.role === 'readonly')) {
toast.error("You're not authorized to perform that action", { position: 'top-center' });
return;
}
diff --git a/frontend/src/routes/settings/+page.svelte b/frontend/src/routes/settings/+page.svelte
index 53c58c7a..a7a6f6e9 100644
--- a/frontend/src/routes/settings/+page.svelte
+++ b/frontend/src/routes/settings/+page.svelte
@@ -56,16 +56,18 @@
}
});
+ let loadSeq = 0;
+
$effect(() => {
if (currentOrganizationId && hasAccess) {
+ const seq = ++loadSeq;
loading = true;
- organizationState.loadSettings(currentOrganizationId)
- .catch(e => {
- error = e instanceof Error ? e.message : 'Failed to load settings';
- })
- .finally(() => {
- loading = false;
- });
+ error = null;
+ organizationState.loadSettings(currentOrganizationId).then(() => {
+ if (seq !== loadSeq) return;
+ error = organizationState.error;
+ loading = false;
+ });
}
});
</script>
diff --git a/frontend/src/routes/settings/users-tab.svelte b/frontend/src/routes/settings/users-tab.svelte
index d674a0c8..4f234c2c 100644
--- a/frontend/src/routes/settings/users-tab.svelte
+++ b/frontend/src/routes/settings/users-tab.svelte
@@ -25,7 +25,7 @@
let invitationToRevoke = $state<Invitation | null>(null);
let processingRoleChange = $state<number | null>(null);
let expandedMemberId = $state<number | null>(null);
- let memberProjectRoles = $state<Record<number, MemberProjectRole[]>>({});
+ let expandedProjectRoles = $state<MemberProjectRole[]>([]);
let loadingProjectRoles = $state(false);
let processingProjectRole = $state<string | null>(null);
@@ -93,17 +93,18 @@
return;
}
expandedMemberId = member.id;
- if (!memberProjectRoles[member.id]) {
- loadingProjectRoles = true;
- try {
- const response = await organizationState.getMemberProjectRoles(organizationId, member.id);
- memberProjectRoles[member.id] = response.projectRoles;
- } catch (e) {
- toast.error(e instanceof Error ? e.message : 'Failed to load project roles', { position: 'top-center' });
- expandedMemberId = null;
- } finally {
- loadingProjectRoles = false;
- }
+ loadingProjectRoles = true;
+ expandedProjectRoles = [];
+ try {
+ const response = await organizationState.getMemberProjectRoles(organizationId, member.id);
+ if (expandedMemberId !== member.id) return;
+ expandedProjectRoles = response.projectRoles;
+ loadingProjectRoles = false;
+ } catch (e) {
+ if (expandedMemberId !== member.id) return;
+ loadingProjectRoles = false;
+ toast.error(e instanceof Error ? e.message : 'Failed to load project roles', { position: 'top-center' });
+ expandedMemberId = null;
}
}
@@ -244,7 +245,7 @@
</div>
{:else}
<div class="space-y-1 pl-10 pr-2">
- {#each memberProjectRoles[member.id] ?? [] as projectRole (projectRole.projectId)}
+ {#each expandedProjectRoles as projectRole (projectRole.projectId)}
<div class="flex items-center justify-between gap-4 py-1">
<div class="flex items-center gap-2">
<FrameworkIcon framework={projectRole.framework as Framework} class="size-4" />