Skip to content

The only tool you need to know what is happening and how to fix it.

perf boost

ddux53af41ef59bf
diff --git a/backend/app/controllers/clientcontrollers/client.controller.go b/backend/app/controllers/clientcontrollers/client.controller.go
index 64836768..d8a0056f 100644
--- a/backend/app/controllers/clientcontrollers/client.controller.go
+++ b/backend/app/controllers/clientcontrollers/client.controller.go
@@ -5,11 +5,13 @@ import (
"backend/app/middleware"
"backend/app/models"
"backend/app/models/clientmodels"
+ "backend/app/pgdb"
"backend/app/repositories"
"backend/app/services"
"backend/app/storage"
"context"
"crypto/sha256"
+ "database/sql"
"encoding/hex"
"fmt"
"net/http"
@@ -88,13 +90,31 @@ func (e clientController) Report(c *gin.Context) {
spansToInsert = append(spansToInsert, span)
}
}
+ projectAsAny, projectExists := c.Get(middleware.ProjectContextKey)
+ var project *models.Project
+ if projectExists {
+ if p, ok := projectAsAny.(*models.Project); ok {
+ project = p
+ }
+ }
+
+ var sourceMaps *[]*models.SourceMap
+ if project != nil && isJsFramework(project.Framework) {
+ sourceMapsLoaded, err := pgdb.ExecuteTransaction(func(tx *sql.Tx) ([]*models.SourceMap, error) {
+ if request.AppVersion != "" {
+ return repositories.SourceMapRepository.FindByProjectAndVersion(tx, projectId, request.AppVersion)
+ }
+ return repositories.SourceMapRepository.FindLatestByProject(tx, projectId)
+ })
+ if err == nil && len(sourceMapsLoaded) > 0 {
+ sourceMaps = &sourceMapsLoaded
+ }
+ }
for _, cst := range cf.StackTraces {
resolvedStackTrace := cst.StackTrace
- if project, exists := c.Get(middleware.ProjectContextKey); exists {
- if p, ok := project.(*models.Project); ok && isJsFramework(p.Framework) {
- resolvedStackTrace = services.ResolveStackTrace(c, projectId, request.AppVersion, cst.StackTrace)
- }
+ if sourceMaps != nil {
+ resolvedStackTrace = services.ResolveStackTrace(c, projectId, cst.StackTrace, *sourceMaps)
}
est := cst.ToExceptionStackTrace(computeExceptionHash(resolvedStackTrace, cst.IsMessage), request.AppVersion, request.ServerName)
est.StackTrace = resolvedStackTrace
diff --git a/backend/app/services/sourcemap_resolver.go b/backend/app/services/sourcemap_resolver.go
index 06e98fd0..071688b0 100644
--- a/backend/app/services/sourcemap_resolver.go
+++ b/backend/app/services/sourcemap_resolver.go
@@ -3,11 +3,8 @@ package services
import (
"backend/app/cache"
"backend/app/models"
- "backend/app/pgdb"
- "backend/app/repositories"
"backend/app/storage"
"context"
- "database/sql"
"fmt"
"path/filepath"
"regexp"
@@ -31,14 +28,8 @@ var jsControlFlowKeywords = map[string]bool{
"catch": true, "return": true, "throw": true, "else": true,
}
-func ResolveStackTrace(ctx context.Context, projectId uuid.UUID, appVersion string, stackTrace string) string {
- sourceMaps, err := pgdb.ExecuteTransaction(func(tx *sql.Tx) ([]*models.SourceMap, error) {
- if appVersion != "" {
- return repositories.SourceMapRepository.FindByProjectAndVersion(tx, projectId, appVersion)
- }
- return repositories.SourceMapRepository.FindLatestByProject(tx, projectId)
- })
- if err != nil || len(sourceMaps) == 0 {
+func ResolveStackTrace(ctx context.Context, projectId uuid.UUID, stackTrace string, sourceMaps []*models.SourceMap) string {
+ if len(sourceMaps) == 0 {
return stackTrace
}