Skip to content

The only tool you need to know what is happening and how to fix it.

fix: types for cli contract

narrow-adventurea891d39967d4
diff --git a/cli/cmd/traceway/aitraces.go b/cli/cmd/traceway/aitraces.go
index d542728d..a74b5601 100644
--- a/cli/cmd/traceway/aitraces.go
+++ b/cli/cmd/traceway/aitraces.go
@@ -2,6 +2,7 @@ package main
import (
"fmt"
+ "strings"
"github.com/spf13/cobra"
@@ -78,6 +79,15 @@ func runAiTracesShow(cmd *cobra.Command, args []string) error {
if a.DistributedTraceId != nil {
_, _ = fmt.Fprintf(out, "TRACE ID: %s\n", a.DistributedTraceId.String())
}
+ if a.ConversationId != "" {
+ _, _ = fmt.Fprintf(out, "CONVERSATION: %s\n", a.ConversationId)
+ }
+ if a.ToolCallCount > 0 {
+ _, _ = fmt.Fprintf(out, "TOOL CALLS: %d (%s)\n", a.ToolCallCount, strings.Join(a.ToolNames, ", "))
+ }
+ if a.Flagged {
+ _, _ = fmt.Fprintf(out, "FLAGGED: %s\n", strings.Join(a.FlaggedTerms, ", "))
+ }
}
if len(resp.Conversation) > 0 {
_, _ = fmt.Fprintln(out, "\nCONVERSATION available (use --output json to view).")
diff --git a/cli/pkg/client/detail.go b/cli/pkg/client/detail.go
index fb2f3f09..705e7693 100644
--- a/cli/pkg/client/detail.go
+++ b/cli/pkg/client/detail.go
@@ -81,6 +81,11 @@ type AiTrace struct {
Attributes map[string]string `json:"attributes"`
DistributedTraceId *uuid.UUID `json:"distributedTraceId,omitempty"`
IsRoot bool `json:"isRoot"`
+ ConversationId string `json:"conversationId"`
+ ToolCallCount int64 `json:"toolCallCount"`
+ ToolNames []string `json:"toolNames"`
+ Flagged bool `json:"flagged"`
+ FlaggedTerms []string `json:"flaggedTerms"`
}
// Session mirrors models.Session — one user session that can be replayed.
diff --git a/cli/test/contract/seed_test.go b/cli/test/contract/seed_test.go
index 54ec365f..0c4039ab 100644
--- a/cli/test/contract/seed_test.go
+++ b/cli/test/contract/seed_test.go
@@ -166,6 +166,11 @@ func seedTelemetry(ctx context.Context, projectIDStr string, at time.Time) error
Attributes: map[string]string{},
DistributedTraceId: &seedTraceID,
IsRoot: true,
+ ConversationId: "contract-conversation",
+ ToolCallCount: 1,
+ ToolNames: []string{"contract_tool"},
+ Flagged: true,
+ FlaggedTerms: []string{"contract-term"},
}
if err := telemetry.AiTraceRepository.InsertAsync(ctx, []models.AiTrace{aiTrace}); err != nil {
return fmt.Errorf("ai trace: %w", err)
diff --git a/cli/test/contract/testdata/aitrace-detail.schema.txt b/cli/test/contract/testdata/aitrace-detail.schema.txt
index 7fdd18f5..81a4cf26 100644
--- a/cli/test/contract/testdata/aitrace-detail.schema.txt
+++ b/cli/test/contract/testdata/aitrace-detail.schema.txt
@@ -1,9 +1,12 @@
aiTrace.appVersion: string
aiTrace.attributes: null
aiTrace.cachedTokens: number
+aiTrace.conversationId: string
aiTrace.distributedTraceId: string
aiTrace.duration: number
aiTrace.finishReason: string
+aiTrace.flagged: bool
+aiTrace.flaggedTerms[]: string
aiTrace.id: string
aiTrace.inputCost: number
aiTrace.inputTokens: number
@@ -20,6 +23,8 @@ aiTrace.responseModel: string
aiTrace.serverName: string
aiTrace.statusCode: number
aiTrace.storageKey: string
+aiTrace.toolCallCount: number
+aiTrace.toolNames[]: string
aiTrace.totalCost: number
aiTrace.totalTokens: number
aiTrace.traceName: string
diff --git a/cli/test/contract/testdata/distributed-trace.schema.txt b/cli/test/contract/testdata/distributed-trace.schema.txt
index 6f14b4cf..c5a7755e 100644
--- a/cli/test/contract/testdata/distributed-trace.schema.txt
+++ b/cli/test/contract/testdata/distributed-trace.schema.txt
@@ -2,9 +2,12 @@ distributedTraceId: string
nodes[].aiTrace.appVersion: string
nodes[].aiTrace.attributes: null
nodes[].aiTrace.cachedTokens: number
+nodes[].aiTrace.conversationId: string
nodes[].aiTrace.distributedTraceId: string
nodes[].aiTrace.duration: number
nodes[].aiTrace.finishReason: string
+nodes[].aiTrace.flagged: bool
+nodes[].aiTrace.flaggedTerms[]: string
nodes[].aiTrace.id: string
nodes[].aiTrace.inputCost: number
nodes[].aiTrace.inputTokens: number
@@ -21,6 +24,8 @@ nodes[].aiTrace.responseModel: string
nodes[].aiTrace.serverName: string
nodes[].aiTrace.statusCode: number
nodes[].aiTrace.storageKey: string
+nodes[].aiTrace.toolCallCount: number
+nodes[].aiTrace.toolNames[]: string
nodes[].aiTrace.totalCost: number
nodes[].aiTrace.totalTokens: number
nodes[].aiTrace.traceName: string
diff --git a/cli/test/contract/testdata/login.schema.txt b/cli/test/contract/testdata/login.schema.txt
index 07a9a65a..ffc9904f 100644
--- a/cli/test/contract/testdata/login.schema.txt
+++ b/cli/test/contract/testdata/login.schema.txt
@@ -2,6 +2,8 @@ organizations[].id: number
organizations[].name: string
organizations[].role: string
organizations[].timezone: string
+projects[].aiFlaggedLanguages[]: string
+projects[].aiFlaggedTerms[]: empty
projects[].backendUrl: string
projects[].createdAt: string
projects[].dropHealthyHealthchecks: bool
diff --git a/cli/test/contract/testdata/projects-list.schema.txt b/cli/test/contract/testdata/projects-list.schema.txt
index b43641cd..7898f746 100644
--- a/cli/test/contract/testdata/projects-list.schema.txt
+++ b/cli/test/contract/testdata/projects-list.schema.txt
@@ -1,3 +1,5 @@
+[].aiFlaggedLanguages[]: string
+[].aiFlaggedTerms[]: empty
[].backendUrl: string
[].createdAt: string
[].dropHealthyHealthchecks: bool