Skip to content

The only tool you need to know what is happening and how to fix it.

Major updates to segments #38 #21 #26

dduxb84fe0e11180
diff --git a/frontend/src/lib/components/segments/segment-row.svelte b/frontend/src/lib/components/segments/segment-row.svelte
index 4b7ea3ae..afca23e3 100644
--- a/frontend/src/lib/components/segments/segment-row.svelte
+++ b/frontend/src/lib/components/segments/segment-row.svelte
@@ -4,13 +4,31 @@
import { formatDuration } from '$lib/utils/formatters';
type Props = {
+ row: number,
segment: Segment;
transactionStart: number;
transactionDuration: number;
isOdd: boolean;
+ nameColumnWidth: number;
+ updateNameWidth: (width: number) => void;
+
+ segmentCellHandleMouseEnter: (x: number) => void,
+ segmentCellHandleMouseMove: (x: number) => void,
+ segmentCellHandleMouseLeave: () => void,
};
- let { segment, transactionStart, transactionDuration, isOdd }: Props = $props();
+ let {
+ row,
+ segment,
+ transactionStart,
+ transactionDuration,
+ isOdd,
+ nameColumnWidth,
+ updateNameWidth,
+ segmentCellHandleMouseEnter,
+ segmentCellHandleMouseMove,
+ segmentCellHandleMouseLeave,
+ }: Props = $props();
const segmentStartMs = $derived(new Date(segment.startTime).getTime() - transactionStart);
const segmentDurationMs = $derived(segment.duration / 1_000_000);
@@ -22,76 +40,87 @@
Math.min(100 - leftPercent, (segmentDurationMs / transactionDurationMs) * 100)
);
- // 14 segment colors based on name prefix
- function getSegmentColor(name: string): { bg: string; ring: string } {
- if (name.startsWith('db.')) return { bg: 'bg-blue-400', ring: 'ring-blue-500' };
- if (name.startsWith('http.')) return { bg: 'bg-green-400', ring: 'ring-green-500' };
- if (name.startsWith('cache.')) return { bg: 'bg-purple-400', ring: 'ring-purple-500' };
- if (name.startsWith('queue.')) return { bg: 'bg-orange-400', ring: 'ring-orange-500' };
- if (name.startsWith('auth.')) return { bg: 'bg-red-400', ring: 'ring-red-500' };
- if (name.startsWith('file.')) return { bg: 'bg-amber-400', ring: 'ring-amber-500' };
- if (name.startsWith('grpc.')) return { bg: 'bg-cyan-400', ring: 'ring-cyan-500' };
- if (name.startsWith('email.')) return { bg: 'bg-pink-400', ring: 'ring-pink-500' };
- if (name.startsWith('search.')) return { bg: 'bg-indigo-400', ring: 'ring-indigo-500' };
- if (name.startsWith('redis.')) return { bg: 'bg-teal-400', ring: 'ring-teal-500' };
- if (name.startsWith('kafka.')) return { bg: 'bg-lime-400', ring: 'ring-lime-500' };
- if (name.startsWith('graphql.')) return { bg: 'bg-rose-400', ring: 'ring-rose-500' };
- if (name.startsWith('s3.')) return { bg: 'bg-sky-400', ring: 'ring-sky-500' };
- return { bg: 'bg-slate-400', ring: 'ring-slate-500' };
- }
+ const segmentColors = [
+ { bg: 'bg-blue-400', ring: 'ring-blue-500' },
+ { bg: 'bg-green-400', ring: 'ring-green-500' },
+ { bg: 'bg-purple-400', ring: 'ring-purple-500' },
+ { bg: 'bg-orange-400', ring: 'ring-orange-500' },
+ { bg: 'bg-red-400', ring: 'ring-red-500' },
+ { bg: 'bg-amber-400', ring: 'ring-amber-500' },
+ { bg: 'bg-cyan-400', ring: 'ring-cyan-500' },
+ { bg: 'bg-pink-400', ring: 'ring-pink-500' },
+ { bg: 'bg-indigo-400', ring: 'ring-indigo-500' },
+ { bg: 'bg-teal-400', ring: 'ring-teal-500' },
+ { bg: 'bg-lime-400', ring: 'ring-lime-500' },
+ { bg: 'bg-rose-400', ring: 'ring-rose-500' },
+ { bg: 'bg-sky-400', ring: 'ring-sky-500' },
+ { bg: 'bg-slate-400', ring: 'ring-slate-500' },
+ ];
- const segmentColor = $derived(getSegmentColor(segment.name));
+ const segmentColor = $derived(segmentColors[row % segmentColors.length]);
- // Tooltip state
+ // Tooltip state (this is the tooltip on top of the line)
let isHovered = $state(false);
- let tooltipX = $state(0);
- let tooltipY = $state(0);
let barElement: HTMLDivElement;
function handleMouseEnter(e: MouseEvent) {
isHovered = true;
- updateTooltipPosition(e);
- }
-
- function handleMouseMove(e: MouseEvent) {
- if (isHovered) {
- updateTooltipPosition(e);
- }
}
function handleMouseLeave() {
isHovered = false;
}
- function updateTooltipPosition(e: MouseEvent) {
- const rect = barElement.getBoundingClientRect();
- tooltipX = rect.left + rect.width / 2;
- tooltipY = rect.top - 8;
+ let containerElement: HTMLDivElement;
+ function containerSegmentCellHandleMouseEnter(e: MouseEvent) {
+ const rect = containerElement.getBoundingClientRect();
+ const x = e.clientX - rect.left;
+ segmentCellHandleMouseEnter(x);
+ }
+ function containerSegmentCellHandleMouseMove(e: MouseEvent) {
+ const rect = containerElement.getBoundingClientRect();
+ const x = e.clientX - rect.left;
+ segmentCellHandleMouseMove(x);
}
+
+ let nameElement: HTMLDivElement;
+
+ $effect(() => {
+ if (nameElement) {
+ // Measure the natural width needed
+ const naturalWidth = nameElement.scrollWidth;
+ updateNameWidth?.(naturalWidth);
+ }
+ });
</script>
<div class={cn('border-border flex items-center border-b last:border-b-0', isOdd ? 'bg-muted/40' : '')}>
<!-- Segment name -->
<div
- class="border-border w-[180px] flex-shrink-0 truncate border-r px-3 py-1.5 font-mono text-xs"
+ bind:this={nameElement}
+ class="border-border flex-shrink-0 truncate border-r px-3 py-1.5 font-mono text-xs"
+ style="min-width: {nameColumnWidth}px"
title={segment.name}
>
{segment.name}
</div>
<!-- Timeline bar -->
- <div class="relative flex-1">
- <div class="relative mx-2 h-4">
+ <div class="relative flex-1 min-w-[200px] self-stretch flex items-center"
+ bind:this={containerElement}
+ onmouseenter={containerSegmentCellHandleMouseEnter}
+ onmousemove={containerSegmentCellHandleMouseMove}
+ onmouseleave={segmentCellHandleMouseLeave}>
+ <div class="relative h-4 w-full">
<div
bind:this={barElement}
class={cn(
- 'absolute h-full rounded transition-all',
+ 'absolute h-full rounded-[2px] transition-all',
segmentColor.bg,
- isHovered && `ring-2 ring-offset-1 ${segmentColor.ring}`
+ isHovered && `ring-2 ${segmentColor.ring}`
)}
style="left: {leftPercent}%; width: {Math.max(widthPercent, 1)}%"
onmouseenter={handleMouseEnter}
- onmousemove={handleMouseMove}
onmouseleave={handleMouseLeave}
role="presentation"
></div>
@@ -102,17 +131,4 @@
<div class="text-muted-foreground border-border w-[100px] flex-shrink-0 border-l px-3 py-1.5 text-right font-mono text-xs">
{formatDuration(segment.duration)}
</div>
-
- <!-- Portal tooltip (inside row to preserve :last-child, but uses fixed positioning) -->
- {#if isHovered}
- <div
- class="fixed z-[9999] -translate-x-1/2 -translate-y-full pointer-events-none"
- style="left: {tooltipX}px; top: {tooltipY}px;"
- >
- <div class="bg-popover text-popover-foreground whitespace-nowrap rounded-md border px-2 py-1 text-xs shadow-md">
- <div class="font-medium">{segment.name}</div>
- <div class="text-muted-foreground">{formatDuration(segment.duration)}</div>
- </div>
- </div>
- {/if}
</div>
diff --git a/frontend/src/lib/components/segments/segment-waterfall.svelte b/frontend/src/lib/components/segments/segment-waterfall.svelte
index b409aa41..8a5d1d50 100644
--- a/frontend/src/lib/components/segments/segment-waterfall.svelte
+++ b/frontend/src/lib/components/segments/segment-waterfall.svelte
@@ -1,5 +1,6 @@
<script lang="ts">
import type { Segment } from '$lib/types/segments';
+ import ScrollArea from '../ui/scroll-area/scroll-area.svelte';
import SegmentRow from './segment-row.svelte';
type Props = {
@@ -10,8 +11,6 @@
let { segments, transactionDuration, transactionStartTime }: Props = $props();
- // Calculate the time scale for the waterfall
- // Use the earliest segment's start time as reference since transaction.recordedAt may be truncated
const transactionStart = $derived(
segments.length === 0
? new Date(transactionStartTime).getTime()
@@ -21,28 +20,80 @@
}, new Date(segments[0].startTime).getTime())
);
const durationMs = $derived(transactionDuration / 1_000_000);
+
+
+ let nameColumnWidth = $state(180); // default minimum
+
+ function updateNameWidth(width: number) {
+ if (width > nameColumnWidth) {
+ nameColumnWidth = width;
+ }
+ }
+
+ let isHovered = $state(false);
+ let tooltipX = $state(0);
+
+ function handleMouseEnter(x: number) {
+ isHovered = true;
+ tooltipX = x;
+ }
+
+ function handleMouseMove(x: number) {
+ if (isHovered) {
+ tooltipX = x;
+ }
+ }
+
+ function handleMouseLeave() {
+ isHovered = false;
+ }
+
+ let timelineElement: HTMLDivElement;
</script>
-<div class="border-border overflow-hidden rounded-lg border">
- <!-- Header -->
- <div class="bg-muted/30 border-border flex border-b">
- <div class="border-border w-[180px] flex-shrink-0 border-r px-3 py-1.5 text-xs font-medium">
- Segment Name
- </div>
- <div class="flex-1 px-3 py-1.5">
- <div class="text-muted-foreground flex justify-between text-xs">
- <span>0ms</span>
- <span>{(durationMs / 2).toFixed(0)}ms</span>
- <span>{durationMs.toFixed(0)}ms</span>
+<ScrollArea orientation="horizontal" class="border-border rounded-lg border p-relative">
+ <div class="overflow-hidden relative">
+ <!-- Header -->
+ <div class="bg-muted/30 border-border flex border-b">
+ <div class="border-border flex-shrink-0 border-r px-3 py-1.5 text-xs font-medium" style="min-width: {nameColumnWidth}px">
+ Segment Name
+ </div>
+ <div bind:this={timelineElement} class="flex-1 px-3 py-1.5 min-w-[200px]">
+ <div class="text-muted-foreground flex justify-between text-xs">
+ <span>0ms</span>
+ <span>{(durationMs / 2).toFixed(0)}ms</span>
+ <span>{durationMs.toFixed(0)}ms</span>
+ </div>
+ </div>
+ <div class="border-border w-[100px] flex-shrink-0 border-l px-3 py-1.5 text-right text-xs font-medium">
+ Duration
</div>
</div>
- <div class="border-border w-[100px] flex-shrink-0 border-l px-3 py-1.5 text-right text-xs font-medium">
- Duration
- </div>
- </div>
- <!-- Segments -->
- {#each segments as segment, i}
- <SegmentRow {segment} {transactionStart} {transactionDuration} isOdd={i % 2 === 1} />
- {/each}
-</div>
+ <!-- Segments -->
+ {#each segments as segment, i}
+ <SegmentRow
+ row={i}
+ {segment}
+ {transactionStart}
+ {transactionDuration}
+ isOdd={i % 2 === 1}
+ {nameColumnWidth}
+ {updateNameWidth}
+
+ segmentCellHandleMouseEnter={handleMouseEnter}
+ segmentCellHandleMouseMove={handleMouseMove}
+ segmentCellHandleMouseLeave={handleMouseLeave}
+ />
+ {/each}
+
+ {#if isHovered}
+ <div class="top-[28px] bottom-0 border-l border-gray-300 absolute pointer-events-none" style="left: {tooltipX+nameColumnWidth}px"></div>
+ <div class="top-[1px] absolute -translate-x-1/2" style="left: {tooltipX+nameColumnWidth}px">
+ <div class="bg-popover text-popover-foreground whitespace-nowrap rounded-md border px-2 py-1 text-xs shadow-md">
+ <div class="font-medium">{Math.round(durationMs*((tooltipX+1)/timelineElement.clientWidth))}ms</div>
+ </div>
+ </div>
+ {/if}
+ </div>
+</ScrollArea>
diff --git a/frontend/src/lib/components/ui/scroll-area/index.ts b/frontend/src/lib/components/ui/scroll-area/index.ts
new file mode 100644
index 00000000..e86a25b2
--- /dev/null
+++ b/frontend/src/lib/components/ui/scroll-area/index.ts
@@ -0,0 +1,10 @@
+import Scrollbar from "./scroll-area-scrollbar.svelte";
+import Root from "./scroll-area.svelte";
+
+export {
+ Root,
+ Scrollbar,
+ //,
+ Root as ScrollArea,
+ Scrollbar as ScrollAreaScrollbar,
+};
diff --git a/frontend/src/lib/components/ui/scroll-area/scroll-area-scrollbar.svelte b/frontend/src/lib/components/ui/scroll-area/scroll-area-scrollbar.svelte
new file mode 100644
index 00000000..8f5d9609
--- /dev/null
+++ b/frontend/src/lib/components/ui/scroll-area/scroll-area-scrollbar.svelte
@@ -0,0 +1,31 @@
+<script lang="ts">
+ import { ScrollArea as ScrollAreaPrimitive } from "bits-ui";
+ import { cn, type WithoutChild } from "$lib/utils.js";
+
+ let {
+ ref = $bindable(null),
+ class: className,
+ orientation = "vertical",
+ children,
+ ...restProps
+ }: WithoutChild<ScrollAreaPrimitive.ScrollbarProps> = $props();
+</script>
+
+<ScrollAreaPrimitive.Scrollbar
+ bind:ref
+ data-slot="scroll-area-scrollbar"
+ {orientation}
+ class={cn(
+ "flex touch-none p-px transition-colors select-none",
+ orientation === "vertical" && "h-full w-2.5 border-s border-s-transparent",
+ orientation === "horizontal" && "h-2.5 flex-col border-t border-t-transparent",
+ className
+ )}
+ {...restProps}
+>
+ {@render children?.()}
+ <ScrollAreaPrimitive.Thumb
+ data-slot="scroll-area-thumb"
+ class="bg-border relative flex-1 rounded-full"
+ />
+</ScrollAreaPrimitive.Scrollbar>
diff --git a/frontend/src/lib/components/ui/scroll-area/scroll-area.svelte b/frontend/src/lib/components/ui/scroll-area/scroll-area.svelte
new file mode 100644
index 00000000..86ee0326
--- /dev/null
+++ b/frontend/src/lib/components/ui/scroll-area/scroll-area.svelte
@@ -0,0 +1,43 @@
+<script lang="ts">
+ import { ScrollArea as ScrollAreaPrimitive } from "bits-ui";
+ import { Scrollbar } from "./index.js";
+ import { cn, type WithoutChild } from "$lib/utils.js";
+
+ let {
+ ref = $bindable(null),
+ viewportRef = $bindable(null),
+ class: className,
+ orientation = "vertical",
+ scrollbarXClasses = "",
+ scrollbarYClasses = "",
+ children,
+ ...restProps
+ }: WithoutChild<ScrollAreaPrimitive.RootProps> & {
+ orientation?: "vertical" | "horizontal" | "both" | undefined;
+ scrollbarXClasses?: string | undefined;
+ scrollbarYClasses?: string | undefined;
+ viewportRef?: HTMLElement | null;
+ } = $props();
+</script>
+
+<ScrollAreaPrimitive.Root
+ bind:ref
+ data-slot="scroll-area"
+ class={cn("relative", className)}
+ {...restProps}
+>
+ <ScrollAreaPrimitive.Viewport
+ bind:ref={viewportRef}
+ data-slot="scroll-area-viewport"
+ class="ring-ring/10 dark:ring-ring/20 dark:outline-ring/40 outline-ring/50 size-full rounded-[inherit] transition-[color,box-shadow] focus-visible:ring-4 focus-visible:outline-1"
+ >
+ {@render children?.()}
+ </ScrollAreaPrimitive.Viewport>
+ {#if orientation === "vertical" || orientation === "both"}
+ <Scrollbar orientation="vertical" class={scrollbarYClasses} />
+ {/if}
+ {#if orientation === "horizontal" || orientation === "both"}
+ <Scrollbar orientation="horizontal" class={scrollbarXClasses} />
+ {/if}
+ <ScrollAreaPrimitive.Corner />
+</ScrollAreaPrimitive.Root>