Skip to content

The only tool you need to know what is happening and how to fix it.

validation message cleanup

dduxc70212df169f
diff --git a/backend/app/controllers/endpoint_detail.controller.go b/backend/app/controllers/endpoint_detail.controller.go
index 4f4adca9..06e1b307 100644
--- a/backend/app/controllers/endpoint_detail.controller.go
+++ b/backend/app/controllers/endpoint_detail.controller.go
@@ -1,10 +1,11 @@
package controllers
import (
+ "net/http"
+
"github.com/tracewayapp/traceway/backend/app/middleware"
"github.com/tracewayapp/traceway/backend/app/models"
"github.com/tracewayapp/traceway/backend/app/repositories"
- "net/http"
"github.com/gin-gonic/gin"
"github.com/google/uuid"
@@ -28,11 +29,11 @@ type EndpointMessageInfo struct {
}
type EndpointDetailResponse struct {
- Endpoint *models.Endpoint `json:"endpoint"`
- Spans []models.Span `json:"spans"`
- HasSpans bool `json:"hasSpans"`
- Exception *EndpointExceptionInfo `json:"exception,omitempty"`
- Messages []EndpointMessageInfo `json:"messages"`
+ Endpoint *models.Endpoint `json:"endpoint"`
+ Spans []models.Span `json:"spans"`
+ HasSpans bool `json:"hasSpans"`
+ Exception *EndpointExceptionInfo `json:"exception,omitempty"`
+ Messages []EndpointMessageInfo `json:"messages"`
}
func (t endpointDetailController) GetEndpointDetail(c *gin.Context) {
@@ -44,7 +45,7 @@ func (t endpointDetailController) GetEndpointDetail(c *gin.Context) {
endpointId, err := uuid.Parse(c.Param("endpointId"))
if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": "invalid endpointId"})
+ c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid endpointId"})
return
}
@@ -103,11 +104,11 @@ func (t endpointDetailController) GetEndpointDetail(c *gin.Context) {
}
c.JSON(http.StatusOK, EndpointDetailResponse{
- Endpoint: endpoint,
- Spans: spans,
- HasSpans: len(spans) > 0,
- Exception: exceptionInfo,
- Messages: messages,
+ Endpoint: endpoint,
+ Spans: spans,
+ HasSpans: len(spans) > 0,
+ Exception: exceptionInfo,
+ Messages: messages,
})
}
diff --git a/backend/app/controllers/exception_stack_trace.controller.go b/backend/app/controllers/exception_stack_trace.controller.go
index 2c0d0092..f66f18c6 100644
--- a/backend/app/controllers/exception_stack_trace.controller.go
+++ b/backend/app/controllers/exception_stack_trace.controller.go
@@ -1,10 +1,6 @@
package controllers
import (
- "github.com/tracewayapp/traceway/backend/app/middleware"
- "github.com/tracewayapp/traceway/backend/app/models"
- "github.com/tracewayapp/traceway/backend/app/repositories"
- "github.com/tracewayapp/traceway/backend/app/storage"
"database/sql"
"encoding/json"
"errors"
@@ -13,6 +9,11 @@ import (
"strings"
"time"
+ "github.com/tracewayapp/traceway/backend/app/middleware"
+ "github.com/tracewayapp/traceway/backend/app/models"
+ "github.com/tracewayapp/traceway/backend/app/repositories"
+ "github.com/tracewayapp/traceway/backend/app/storage"
+
"github.com/gin-gonic/gin"
"github.com/google/uuid"
traceway "go.tracewayapp.com"
@@ -228,7 +229,7 @@ func (e exceptionStackTraceController) FindById(c *gin.Context) {
exceptionId, err := uuid.Parse(c.Param("exceptionId"))
if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": "invalid exception id"})
+ c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid exception id"})
return
}
diff --git a/backend/app/controllers/metric_query.controller.go b/backend/app/controllers/metric_query.controller.go
index ae38197f..f2d5afcb 100644
--- a/backend/app/controllers/metric_query.controller.go
+++ b/backend/app/controllers/metric_query.controller.go
@@ -1,15 +1,16 @@
package controllers
import (
- "github.com/tracewayapp/traceway/backend/app/middleware"
- "github.com/tracewayapp/traceway/backend/app/models"
- "github.com/tracewayapp/traceway/backend/app/db"
- "github.com/tracewayapp/traceway/backend/app/repositories"
"database/sql"
"fmt"
"net/http"
"time"
+ "github.com/tracewayapp/traceway/backend/app/db"
+ "github.com/tracewayapp/traceway/backend/app/middleware"
+ "github.com/tracewayapp/traceway/backend/app/models"
+ "github.com/tracewayapp/traceway/backend/app/repositories"
+
"github.com/gin-gonic/gin"
traceway "go.tracewayapp.com"
)
@@ -49,7 +50,7 @@ func (c *metricQueryController) Query(ctx *gin.Context) {
var req MetricQueryRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -195,7 +196,7 @@ func (c *metricQueryController) UpdateRegistry(ctx *gin.Context) {
Description string `json:"description"`
}
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
diff --git a/backend/app/controllers/notification_channel.controller.go b/backend/app/controllers/notification_channel.controller.go
index 2e64a7bc..64b72a42 100644
--- a/backend/app/controllers/notification_channel.controller.go
+++ b/backend/app/controllers/notification_channel.controller.go
@@ -55,7 +55,7 @@ func (ctrl *notificationChannelController) Create(ctx *gin.Context) {
var req createChannelRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -122,13 +122,13 @@ func (ctrl *notificationChannelController) Update(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid channel id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid channel id"})
return
}
var req createChannelRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -190,7 +190,7 @@ func (ctrl *notificationChannelController) Delete(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid channel id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid channel id"})
return
}
@@ -223,7 +223,7 @@ func (ctrl *notificationChannelController) Test(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid channel id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid channel id"})
return
}
diff --git a/backend/app/controllers/notification_history.controller.go b/backend/app/controllers/notification_history.controller.go
index d95edfe5..93b70fdb 100644
--- a/backend/app/controllers/notification_history.controller.go
+++ b/backend/app/controllers/notification_history.controller.go
@@ -28,7 +28,7 @@ func (ctrl *notificationHistoryController) List(ctx *gin.Context) {
var request NotificationHistorySearchRequest
if err := ctx.ShouldBindJSON(&request); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
diff --git a/backend/app/controllers/notification_rule.controller.go b/backend/app/controllers/notification_rule.controller.go
index cdbf4d8f..18a89e6a 100644
--- a/backend/app/controllers/notification_rule.controller.go
+++ b/backend/app/controllers/notification_rule.controller.go
@@ -57,7 +57,7 @@ type createRuleRequest struct {
Name string `json:"name"`
RuleType string `json:"ruleType"`
Config json.RawMessage `json:"config"`
- CooldownMinutes int `json:"cooldownMinutes"`
+ CooldownMinutes int `json:"cooldownMinutes"`
}
func (ctrl *notificationRuleController) Create(ctx *gin.Context) {
@@ -69,7 +69,7 @@ func (ctrl *notificationRuleController) Create(ctx *gin.Context) {
var req createRuleRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -146,13 +146,13 @@ func (ctrl *notificationRuleController) Update(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid rule id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid rule id"})
return
}
var req createRuleRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -222,7 +222,7 @@ func (ctrl *notificationRuleController) Delete(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid rule id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid rule id"})
return
}
@@ -255,7 +255,7 @@ func (ctrl *notificationRuleController) Toggle(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid rule id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid rule id"})
return
}
@@ -294,13 +294,13 @@ func (ctrl *notificationRuleController) Snooze(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid rule id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid rule id"})
return
}
var req snoozeRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
diff --git a/backend/app/controllers/task_detail.controller.go b/backend/app/controllers/task_detail.controller.go
index d38bb883..608f77bb 100644
--- a/backend/app/controllers/task_detail.controller.go
+++ b/backend/app/controllers/task_detail.controller.go
@@ -1,10 +1,11 @@
package controllers
import (
+ "net/http"
+
"github.com/tracewayapp/traceway/backend/app/middleware"
"github.com/tracewayapp/traceway/backend/app/models"
"github.com/tracewayapp/traceway/backend/app/repositories"
- "net/http"
"github.com/gin-gonic/gin"
"github.com/google/uuid"
@@ -28,11 +29,11 @@ type TaskMessageInfo struct {
}
type TaskDetailResponse struct {
- Task *models.Task `json:"task"`
- Spans []models.Span `json:"spans"`
- HasSpans bool `json:"hasSpans"`
- Exception *TaskExceptionInfo `json:"exception,omitempty"`
- Messages []TaskMessageInfo `json:"messages"`
+ Task *models.Task `json:"task"`
+ Spans []models.Span `json:"spans"`
+ HasSpans bool `json:"hasSpans"`
+ Exception *TaskExceptionInfo `json:"exception,omitempty"`
+ Messages []TaskMessageInfo `json:"messages"`
}
func (t taskDetailController) GetTaskDetail(c *gin.Context) {
@@ -44,7 +45,7 @@ func (t taskDetailController) GetTaskDetail(c *gin.Context) {
taskId, err := uuid.Parse(c.Param("taskId"))
if err != nil {
- c.JSON(http.StatusBadRequest, gin.H{"error": "invalid taskId"})
+ c.JSON(http.StatusBadRequest, gin.H{"error": "Invalid taskId"})
return
}
@@ -103,11 +104,11 @@ func (t taskDetailController) GetTaskDetail(c *gin.Context) {
}
c.JSON(http.StatusOK, TaskDetailResponse{
- Task: task,
- Spans: spans,
- HasSpans: len(spans) > 0,
- Exception: exceptionInfo,
- Messages: messages,
+ Task: task,
+ Spans: spans,
+ HasSpans: len(spans) > 0,
+ Exception: exceptionInfo,
+ Messages: messages,
})
}
diff --git a/backend/app/controllers/widget.controller.go b/backend/app/controllers/widget.controller.go
index 5aa4c24f..2dac7eef 100644
--- a/backend/app/controllers/widget.controller.go
+++ b/backend/app/controllers/widget.controller.go
@@ -1,9 +1,6 @@
package controllers
import (
- "github.com/tracewayapp/traceway/backend/app/middleware"
- "github.com/tracewayapp/traceway/backend/app/models"
- "github.com/tracewayapp/traceway/backend/app/repositories"
"encoding/json"
"net/http"
"sort"
@@ -11,6 +8,10 @@ import (
"strings"
"time"
+ "github.com/tracewayapp/traceway/backend/app/middleware"
+ "github.com/tracewayapp/traceway/backend/app/models"
+ "github.com/tracewayapp/traceway/backend/app/repositories"
+
"github.com/gin-gonic/gin"
traceway "go.tracewayapp.com"
)
@@ -33,13 +34,13 @@ func (c *widgetController) Add(ctx *gin.Context) {
idStr := ctx.Param("id")
groupId, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
var req AddWidgetRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -65,7 +66,7 @@ func (c *widgetController) Add(ctx *gin.Context) {
return
}
if group == nil || group.ProjectId != projectId {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget group not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget group not found"})
return
}
@@ -104,20 +105,20 @@ func (c *widgetController) Update(ctx *gin.Context) {
groupIdStr := ctx.Param("id")
groupId, err := strconv.Atoi(groupIdStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
widgetIdStr := ctx.Param("wid")
widgetId, err := strconv.Atoi(widgetIdStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget id"})
return
}
var req AddWidgetRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -142,7 +143,7 @@ func (c *widgetController) Update(ctx *gin.Context) {
return
}
if group == nil || group.ProjectId != projectId {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget group not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget group not found"})
return
}
@@ -152,7 +153,7 @@ func (c *widgetController) Update(ctx *gin.Context) {
return
}
if widget == nil || widget.WidgetGroupId != groupId {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget not found"})
return
}
@@ -185,20 +186,20 @@ func (c *widgetController) Move(ctx *gin.Context) {
groupIdStr := ctx.Param("id")
groupId, err := strconv.Atoi(groupIdStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
widgetIdStr := ctx.Param("wid")
widgetId, err := strconv.Atoi(widgetIdStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget id"})
return
}
var req MoveWidgetRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -210,7 +211,7 @@ func (c *widgetController) Move(ctx *gin.Context) {
return
}
if group == nil || group.ProjectId != projectId {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget group not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget group not found"})
return
}
@@ -232,7 +233,7 @@ func (c *widgetController) Move(ctx *gin.Context) {
}
}
if currentIndex == -1 {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget not found"})
return
}
@@ -272,14 +273,14 @@ func (c *widgetController) Delete(ctx *gin.Context) {
groupIdStr := ctx.Param("id")
groupId, err := strconv.Atoi(groupIdStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
widgetIdStr := ctx.Param("wid")
widgetId, err := strconv.Atoi(widgetIdStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget id"})
return
}
diff --git a/backend/app/controllers/widget_group.controller.go b/backend/app/controllers/widget_group.controller.go
index 3b03c5e1..bef2a53e 100644
--- a/backend/app/controllers/widget_group.controller.go
+++ b/backend/app/controllers/widget_group.controller.go
@@ -1,9 +1,6 @@
package controllers
import (
- "github.com/tracewayapp/traceway/backend/app/middleware"
- "github.com/tracewayapp/traceway/backend/app/models"
- "github.com/tracewayapp/traceway/backend/app/repositories"
"database/sql"
"encoding/json"
"net/http"
@@ -11,6 +8,10 @@ import (
"strings"
"time"
+ "github.com/tracewayapp/traceway/backend/app/middleware"
+ "github.com/tracewayapp/traceway/backend/app/models"
+ "github.com/tracewayapp/traceway/backend/app/repositories"
+
"github.com/gin-gonic/gin"
"github.com/google/uuid"
traceway "go.tracewayapp.com"
@@ -72,7 +73,7 @@ func (c *widgetGroupController) Create(ctx *gin.Context) {
var req CreateWidgetGroupRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -135,7 +136,7 @@ func (c *widgetGroupController) GetWithWidgets(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
@@ -147,7 +148,7 @@ func (c *widgetGroupController) GetWithWidgets(ctx *gin.Context) {
return
}
if group == nil || group.ProjectId != projectId {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget group not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget group not found"})
return
}
@@ -178,13 +179,13 @@ func (c *widgetGroupController) Update(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
var req CreateWidgetGroupRequest
if err := ctx.ShouldBindJSON(&req); err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid request body"})
return
}
@@ -206,7 +207,7 @@ func (c *widgetGroupController) Update(ctx *gin.Context) {
return
}
if existing == nil || existing.ProjectId != projectId {
- ctx.JSON(http.StatusNotFound, gin.H{"error": "widget group not found"})
+ ctx.JSON(http.StatusNotFound, gin.H{"error": "Widget group not found"})
return
}
@@ -244,7 +245,7 @@ func (c *widgetGroupController) Delete(ctx *gin.Context) {
idStr := ctx.Param("id")
id, err := strconv.Atoi(idStr)
if err != nil {
- ctx.JSON(http.StatusBadRequest, gin.H{"error": "invalid widget group id"})
+ ctx.JSON(http.StatusBadRequest, gin.H{"error": "Invalid widget group id"})
return
}
diff --git a/backend/app/middleware/use_gzip_decompress.middleware.go b/backend/app/middleware/use_gzip_decompress.middleware.go
index a740d5e8..c1e91d15 100644
--- a/backend/app/middleware/use_gzip_decompress.middleware.go
+++ b/backend/app/middleware/use_gzip_decompress.middleware.go
@@ -15,7 +15,7 @@ func UseGzip(c *gin.Context) {
gzReader, err := gzip.NewReader(c.Request.Body)
if err != nil {
- c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{"error": "invalid gzip"})
+ c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{"error": "Invalid gzip"})
return
}
c.Request.Body = gzReader