The only tool you need to know what is happening and how to fix it.
Go alertingexception-trackerissue-trackinglogsmetricsmonitoringobservability-platformopen-telemetryotelsession-replaytelemetrytraces
refactor: give sortEndpointStats a strict comparator (#322)
FrameAutomataed986ed52eb9
diff --git a/backend/app/repositories/telemetry/duckdb/endpoint.repository.go b/backend/app/repositories/telemetry/duckdb/endpoint.repository.goindex f93ea8a6..7357a015 100644--- a/backend/app/repositories/telemetry/duckdb/endpoint.repository.go+++ b/backend/app/repositories/telemetry/duckdb/endpoint.repository.go@@ -823,27 +823,29 @@ func sortEndpointStats(stats []models.EndpointStats, orderBy string, sortDirectidesc := sortDirection != "asc"sort.Slice(stats, func(i, j int) bool {- var less bool+ // Descending is the ascending comparison with the operands swapped.+ // Negating the ascending result instead would return true for both+ // (i, j) and (j, i) whenever two rows tie, which is not the strict+ // weak ordering sort.Slice documents a requirement for.+ if desc {+ i, j = j, i+ }switch orderBy {case "count":- less = stats[i].Count < stats[j].Count+ return stats[i].Count < stats[j].Countcase "p50_duration":- less = stats[i].P50Duration < stats[j].P50Duration+ return stats[i].P50Duration < stats[j].P50Durationcase "p95_duration":- less = stats[i].P95Duration < stats[j].P95Duration+ return stats[i].P95Duration < stats[j].P95Durationcase "p99_duration":- less = stats[i].P99Duration < stats[j].P99Duration+ return stats[i].P99Duration < stats[j].P99Durationcase "avg_duration":- less = stats[i].AvgDuration < stats[j].AvgDuration+ return stats[i].AvgDuration < stats[j].AvgDurationcase "last_seen":- less = stats[i].LastSeen.Before(stats[j].LastSeen)+ return stats[i].LastSeen.Before(stats[j].LastSeen)default:- less = stats[i].Impact < stats[j].Impact- }- if desc {- return !less+ return stats[i].Impact < stats[j].Impact}- return less})}diff --git a/backend/app/repositories/telemetry/sqlite/endpoint.repository.go b/backend/app/repositories/telemetry/sqlite/endpoint.repository.goindex 05474e3e..41577084 100644--- a/backend/app/repositories/telemetry/sqlite/endpoint.repository.go+++ b/backend/app/repositories/telemetry/sqlite/endpoint.repository.go@@ -856,27 +856,29 @@ func sortEndpointStats(stats []models.EndpointStats, orderBy string, sortDirectidesc := sortDirection != "asc"sort.Slice(stats, func(i, j int) bool {- var less bool+ // Descending is the ascending comparison with the operands swapped.+ // Negating the ascending result instead would return true for both+ // (i, j) and (j, i) whenever two rows tie, which is not the strict+ // weak ordering sort.Slice documents a requirement for.+ if desc {+ i, j = j, i+ }switch orderBy {case "count":- less = stats[i].Count < stats[j].Count+ return stats[i].Count < stats[j].Countcase "p50_duration":- less = stats[i].P50Duration < stats[j].P50Duration+ return stats[i].P50Duration < stats[j].P50Durationcase "p95_duration":- less = stats[i].P95Duration < stats[j].P95Duration+ return stats[i].P95Duration < stats[j].P95Durationcase "p99_duration":- less = stats[i].P99Duration < stats[j].P99Duration+ return stats[i].P99Duration < stats[j].P99Durationcase "avg_duration":- less = stats[i].AvgDuration < stats[j].AvgDuration+ return stats[i].AvgDuration < stats[j].AvgDurationcase "last_seen":- less = stats[i].LastSeen.Before(stats[j].LastSeen)+ return stats[i].LastSeen.Before(stats[j].LastSeen)default:- less = stats[i].Impact < stats[j].Impact- }- if desc {- return !less+ return stats[i].Impact < stats[j].Impact}- return less})}