Skip to content

The only tool you need to know what is happening and how to fix it.

fix: cursor-pointer on clickable fields + shadow in dark mode on dropdown options

dduxedac68ca599e
diff --git a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-checkbox-item.svelte b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-checkbox-item.svelte
index 6d9ef855..b15896a0 100644
--- a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-checkbox-item.svelte
+++ b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-checkbox-item.svelte
@@ -23,7 +23,7 @@
bind:indeterminate
data-slot="dropdown-menu-checkbox-item"
class={cn(
- "focus:bg-accent focus:text-accent-foreground relative flex cursor-default items-center gap-2 rounded-sm py-1.5 ps-8 pe-2 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+ "focus:bg-accent focus:text-accent-foreground relative flex cursor-pointer items-center gap-2 rounded-sm py-1.5 ps-8 pe-2 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[disabled]:cursor-not-allowed [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
className
)}
{...restProps}
diff --git a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-item.svelte b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-item.svelte
index 04cd1103..a973165a 100644
--- a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-item.svelte
+++ b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-item.svelte
@@ -20,7 +20,7 @@
data-inset={inset}
data-variant={variant}
class={cn(
- "data-highlighted:bg-accent data-highlighted:text-accent-foreground data-[variant=destructive]:text-destructive data-[variant=destructive]:data-highlighted:bg-destructive/10 dark:data-[variant=destructive]:data-highlighted:bg-destructive/20 data-[variant=destructive]:data-highlighted:text-destructive data-[variant=destructive]:*:[svg]:!text-destructive [&_svg:not([class*='text-'])]:text-muted-foreground relative flex cursor-default items-center gap-2 rounded-sm px-2 py-1.5 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[inset]:ps-8 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+ "data-highlighted:bg-accent data-highlighted:text-accent-foreground data-[variant=destructive]:text-destructive data-[variant=destructive]:data-highlighted:bg-destructive/10 dark:data-[variant=destructive]:data-highlighted:bg-destructive/20 data-[variant=destructive]:data-highlighted:text-destructive data-[variant=destructive]:*:[svg]:!text-destructive [&_svg:not([class*='text-'])]:text-muted-foreground relative flex cursor-pointer items-center gap-2 rounded-sm px-2 py-1.5 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[disabled]:cursor-not-allowed data-[inset]:ps-8 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
className
)}
{...restProps}
diff --git a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-radio-item.svelte b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-radio-item.svelte
index ce2ad094..f466f79d 100644
--- a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-radio-item.svelte
+++ b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-radio-item.svelte
@@ -15,7 +15,7 @@
bind:ref
data-slot="dropdown-menu-radio-item"
class={cn(
- "focus:bg-accent focus:text-accent-foreground relative flex cursor-default items-center gap-2 rounded-sm py-1.5 ps-8 pe-2 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+ "focus:bg-accent focus:text-accent-foreground relative flex cursor-pointer items-center gap-2 rounded-sm py-1.5 ps-8 pe-2 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[disabled]:cursor-not-allowed [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
className
)}
{...restProps}
diff --git a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-sub-trigger.svelte b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-sub-trigger.svelte
index 5f49d01e..93e598d1 100644
--- a/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-sub-trigger.svelte
+++ b/frontend/src/lib/components/ui/dropdown-menu/dropdown-menu-sub-trigger.svelte
@@ -19,7 +19,7 @@
data-slot="dropdown-menu-sub-trigger"
data-inset={inset}
class={cn(
- "data-highlighted:bg-accent data-highlighted:text-accent-foreground data-[state=open]:bg-accent data-[state=open]:text-accent-foreground [&_svg:not([class*='text-'])]:text-muted-foreground flex cursor-default items-center gap-2 rounded-sm px-2 py-1.5 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[inset]:ps-8 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+ "data-highlighted:bg-accent data-highlighted:text-accent-foreground data-[state=open]:bg-accent data-[state=open]:text-accent-foreground [&_svg:not([class*='text-'])]:text-muted-foreground flex cursor-pointer items-center gap-2 rounded-sm px-2 py-1.5 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[disabled]:cursor-not-allowed data-[inset]:ps-8 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
className
)}
{...restProps}
diff --git a/frontend/src/lib/components/ui/select/select-item.svelte b/frontend/src/lib/components/ui/select/select-item.svelte
index b85eef69..e2de4b09 100644
--- a/frontend/src/lib/components/ui/select/select-item.svelte
+++ b/frontend/src/lib/components/ui/select/select-item.svelte
@@ -18,7 +18,7 @@
{value}
data-slot="select-item"
class={cn(
- "data-[highlighted]:bg-accent data-[highlighted]:text-accent-foreground [&_svg:not([class*='text-'])]:text-muted-foreground relative flex w-full cursor-default items-center gap-2 rounded-sm py-1.5 ps-2 pe-8 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4 *:[span]:last:flex *:[span]:last:items-center *:[span]:last:gap-2",
+ "data-[highlighted]:bg-accent data-[highlighted]:text-accent-foreground [&_svg:not([class*='text-'])]:text-muted-foreground relative flex w-full cursor-pointer items-center gap-2 rounded-sm py-1.5 ps-2 pe-8 text-sm outline-hidden select-none data-[disabled]:pointer-events-none data-[disabled]:opacity-50 data-[disabled]:cursor-not-allowed [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4 *:[span]:last:flex *:[span]:last:items-center *:[span]:last:gap-2",
className
)}
{...restProps}
diff --git a/frontend/src/lib/components/ui/select/select-trigger.svelte b/frontend/src/lib/components/ui/select/select-trigger.svelte
index 3eb7f551..bbc8e040 100644
--- a/frontend/src/lib/components/ui/select/select-trigger.svelte
+++ b/frontend/src/lib/components/ui/select/select-trigger.svelte
@@ -19,7 +19,7 @@
data-slot="select-trigger"
data-size={size}
class={cn(
- "border-input data-[placeholder]:text-muted-foreground [&_svg:not([class*='text-'])]:text-muted-foreground focus-visible:ring-ring/40 aria-invalid:ring-destructive/40 aria-invalid:border-destructive bg-transparent dark:bg-input/30 dark:hover:bg-input/50 flex w-fit items-center justify-between gap-2 rounded-md border px-3 py-2 text-sm whitespace-nowrap shadow-xs transition-[color,box-shadow] outline-none select-none focus-visible:ring-[2px] data-[state=open]:border-ring/60 disabled:cursor-not-allowed disabled:opacity-50 data-[size=default]:h-9 data-[size=sm]:h-8 *:data-[slot=select-value]:line-clamp-1 *:data-[slot=select-value]:flex *:data-[slot=select-value]:items-center *:data-[slot=select-value]:gap-2 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
+ "border-input data-[placeholder]:text-muted-foreground [&_svg:not([class*='text-'])]:text-muted-foreground focus-visible:ring-ring/40 aria-invalid:ring-destructive/40 aria-invalid:border-destructive bg-transparent dark:bg-input/30 dark:hover:bg-input/50 flex w-fit cursor-pointer items-center justify-between gap-2 rounded-md border px-3 py-2 text-sm whitespace-nowrap shadow-xs transition-[color,box-shadow] outline-none select-none focus-visible:ring-[2px] data-[state=open]:border-ring/60 disabled:cursor-not-allowed disabled:opacity-50 data-[size=default]:h-9 data-[size=sm]:h-8 *:data-[slot=select-value]:line-clamp-1 *:data-[slot=select-value]:flex *:data-[slot=select-value]:items-center *:data-[slot=select-value]:gap-2 [&_svg]:pointer-events-none [&_svg]:shrink-0 [&_svg:not([class*='size-'])]:size-4",
className
)}
{...restProps}
diff --git a/frontend/src/routes/layout.css b/frontend/src/routes/layout.css
index 23e37592..bfd70b82 100644
--- a/frontend/src/routes/layout.css
+++ b/frontend/src/routes/layout.css
@@ -106,7 +106,7 @@
--secondary-foreground: var(--fg-0);
--muted: var(--ink-2);
--muted-foreground: var(--fg-2);
- --accent: var(--ink-3);
+ --accent: var(--ink-5);
--accent-foreground: var(--fg-0);
--destructive: var(--crit);
--border: var(--hair);
diff --git a/frontend/src/routes/notifications/channel-dialog.svelte b/frontend/src/routes/notifications/channel-dialog.svelte
index 8dc55832..d8c694cb 100644
--- a/frontend/src/routes/notifications/channel-dialog.svelte
+++ b/frontend/src/routes/notifications/channel-dialog.svelte
@@ -264,7 +264,7 @@
</script>
<AlertDialog.Root {open} onOpenChange={handleOpenChange}>
- <AlertDialog.Content class="max-w-md max-h-[90vh] overflow-y-auto">
+ <AlertDialog.Content class="max-h-[90vh] max-w-md overflow-y-auto">
<AlertDialog.Header>
<AlertDialog.Title>{isEditing ? 'Edit Channel' : 'New Channel'}</AlertDialog.Title>
<AlertDialog.Description>
@@ -290,8 +290,7 @@
<Label for="channel-type">Type</Label>
<Select.Root type="single" bind:value={channelType}>
<Select.Trigger class="w-full">
- {channelTypeOptions.find((o) => o.value === channelType)?.label ||
- 'Select type'}
+ {channelTypeOptions.find((o) => o.value === channelType)?.label || 'Select type'}
</Select.Trigger>
<Select.Content>
{#each channelTypeOptions as option}
@@ -353,11 +352,7 @@
</div>
<div class="space-y-2">
<Label for="webhook-secret">Secret (optional)</Label>
- <Input
- id="webhook-secret"
- bind:value={webhookSecret}
- placeholder="HMAC signing secret"
- />
+ <Input id="webhook-secret" bind:value={webhookSecret} placeholder="HMAC signing secret" />
</div>
<div class="space-y-2">
<Label>Headers (optional)</Label>
@@ -368,11 +363,7 @@
placeholder="Header name"
class="flex-1"
/>
- <Input
- bind:value={webhookHeaders[index].value}
- placeholder="Value"
- class="flex-1"
- />
+ <Input bind:value={webhookHeaders[index].value} placeholder="Value" class="flex-1" />
<Button
variant="ghost"
size="icon"
@@ -399,19 +390,11 @@
</div>
<div class="space-y-2">
<Label for="slack-channel">Channel Override (optional)</Label>
- <Input
- id="slack-channel"
- bind:value={slackChannel}
- placeholder="#alerts"
- />
+ <Input id="slack-channel" bind:value={slackChannel} placeholder="#alerts" />
</div>
<div class="space-y-2">
<Label for="slack-username">Username (optional)</Label>
- <Input
- id="slack-username"
- bind:value={slackUsername}
- placeholder="Traceway"
- />
+ <Input id="slack-username" bind:value={slackUsername} placeholder="Traceway" />
</div>
{:else if channelType === 'github'}
<div class="space-y-2">
@@ -439,21 +422,40 @@
{:else if channelType === 'pushover'}
<div class="space-y-2">
<Label for="po-user-key">User Key</Label>
- <Input id="po-user-key" bind:value={pushoverUserKey} placeholder="Your Pushover user key" required />
+ <Input
+ id="po-user-key"
+ bind:value={pushoverUserKey}
+ placeholder="Your Pushover user key"
+ required
+ />
</div>
<div class="space-y-2">
<Label for="po-app-token">App Token</Label>
- <Input id="po-app-token" type="password" bind:value={pushoverAppToken} placeholder="Your Pushover application token" required />
+ <Input
+ id="po-app-token"
+ type="password"
+ bind:value={pushoverAppToken}
+ placeholder="Your Pushover application token"
+ required
+ />
</div>
<div class="space-y-2">
<Label for="po-device">Device (optional)</Label>
- <Input id="po-device" bind:value={pushoverDevice} placeholder="Leave empty for all devices" />
+ <Input
+ id="po-device"
+ bind:value={pushoverDevice}
+ placeholder="Leave empty for all devices"
+ />
</div>
<div class="space-y-2">
<Label for="po-priority">Priority</Label>
<Select.Root type="single" bind:value={pushoverPriority}>
<Select.Trigger class="w-full">
- {pushoverPriority === '0' ? 'Normal' : pushoverPriority === '1' ? 'High' : 'Emergency'}
+ {pushoverPriority === '0'
+ ? 'Normal'
+ : pushoverPriority === '1'
+ ? 'High'
+ : 'Emergency'}
</Select.Trigger>
<Select.Content>
<Select.Item value="0">Normal</Select.Item>
@@ -473,16 +475,29 @@
</div>
<div class="space-y-2">
<Label for="po-callback">Callback URL (optional)</Label>
- <Input id="po-callback" bind:value={pushoverCallback} placeholder="https://hooks.example.com/acknowledged" />
+ <Input
+ id="po-callback"
+ bind:value={pushoverCallback}
+ placeholder="https://hooks.example.com/acknowledged"
+ />
</div>
{/if}
<div class="space-y-2">
<Label for="po-sound">Sound (optional)</Label>
- <Input id="po-sound" bind:value={pushoverSound} placeholder="e.g. pushover, bike, bugle" />
+ <Input
+ id="po-sound"
+ bind:value={pushoverSound}
+ placeholder="e.g. pushover, bike, bugle"
+ />
</div>
<div class="flex items-center gap-2">
- <input id="po-html" type="checkbox" bind:checked={pushoverHtml} class="h-4 w-4" />
- <Label for="po-html">Enable HTML formatting</Label>
+ <input
+ id="po-html"
+ type="checkbox"
+ bind:checked={pushoverHtml}
+ class="h-4 w-4 cursor-pointer"
+ />
+ <Label for="po-html" class="cursor-pointer">Enable HTML formatting</Label>
</div>
<div class="space-y-2">
<Label for="po-ttl">Time to Live (seconds, 0 = forever)</Label>