Skip to content

The only tool you need to know what is happening and how to fix it.

add/update: move over tests

narrow-adventurefb964eb39930
diff --git a/backend/app/repositories/telemetry/move_over_rejection_test.go b/backend/app/repositories/telemetry/move_over_rejection_test.go
new file mode 100644
index 00000000..4911eb5e
--- /dev/null
+++ b/backend/app/repositories/telemetry/move_over_rejection_test.go
@@ -0,0 +1,32 @@
+//go:build !telemetry_duckdb
+
+package telemetry
+
+import (
+ "context"
+ "testing"
+ "time"
+
+ "github.com/google/uuid"
+ "github.com/tracewayapp/traceway/backend/app/repositories/transactional"
+)
+
+// DuckDB is left out: its VARCHAR refuses invalid UTF-8, so its old tables cannot hold a name the span store rejects.
+func TestMoveOverRejectedSpanDoesNotCompleteDay(t *testing.T) {
+ setupTestDB(t)
+ setupMoveOverProgress(t)
+ legacyReset(t)
+ t.Cleanup(func() { legacyReset(t) })
+ at := time.Now().UTC().Truncate(moveOverDay).Add(10 * time.Hour)
+ seedLegacyDay(t, uuid.New(), at, uuid.New(), "GET /invalid-utf8-\xff")
+ if err := RunMoveOver(context.Background(), MoveOverOptions{Log: func(string, ...any) {}}); err == nil {
+ t.Fatal("rejected canonical span was reported as a successful migration")
+ }
+ progress, err := (moveOverProgress{}).FindProgress(context.Background())
+ if err != nil || len(progress) != 1 || progress[0].State != transactional.MoveOverStarted {
+ t.Fatalf("rejected day must stay started: %+v, %v", progress, err)
+ }
+ if moveOverRowCount(t, "endpoints_v2") != 0 {
+ t.Fatal("rejected root must not leave an endpoint projection")
+ }
+}
diff --git a/backend/app/repositories/telemetry/review_regression_test.go b/backend/app/repositories/telemetry/review_regression_test.go
index 3cd5f75e..07aad1f2 100644
--- a/backend/app/repositories/telemetry/review_regression_test.go
+++ b/backend/app/repositories/telemetry/review_regression_test.go
@@ -290,25 +290,6 @@ func TestAttributeBudgetCountsUTF8BytesAfterDeduplication(t *testing.T) {
}
}
-func TestMoveOverRejectedSpanDoesNotCompleteDay(t *testing.T) {
- setupTestDB(t)
- setupMoveOverProgress(t)
- legacyReset(t)
- t.Cleanup(func() { legacyReset(t) })
- at := time.Now().UTC().Truncate(moveOverDay).Add(10 * time.Hour)
- seedLegacyDay(t, uuid.New(), at, uuid.Nil, "GET /invalid-trace")
- if err := RunMoveOver(context.Background(), MoveOverOptions{Log: func(string, ...any) {}}); err == nil {
- t.Fatal("rejected canonical span was reported as a successful migration")
- }
- progress, err := (moveOverProgress{}).FindProgress(context.Background())
- if err != nil || len(progress) != 1 || progress[0].State != transactional.MoveOverStarted {
- t.Fatalf("rejected day must stay started: %+v, %v", progress, err)
- }
- if moveOverRowCount(t, "endpoints_v2") != 0 {
- t.Fatal("rejected root must not leave an endpoint projection")
- }
-}
-
func TestLegacySourceReadsHonorCancellation(t *testing.T) {
setupTestDB(t)
ctx, cancel := context.WithCancel(context.Background())