The open-source agent harness - the runtime layer that turns an LLM into a working agent.
Add 502 and 503 status codes to SSRF fetch retry logic (#1051)
Chirag Jain05cef0bb77d8
diff --git a/.changeset/twelve-pumas-rule.md b/.changeset/twelve-pumas-rule.mdnew file mode 100644index 000000000..fa32ae791--- /dev/null+++ b/.changeset/twelve-pumas-rule.md@@ -0,0 +1,6 @@+---+"@truefoundry/trueforge-core": patch+---++Add 502 and 503 status codes to SSRF fetch retry logic. These errors indicate temporary upstream failures and are now eligible for automatic retries across model, MCP, and outbound fetch operations.+diff --git a/packages/trueforge-core/src/core/util/ssrfGuard.ts b/packages/trueforge-core/src/core/util/ssrfGuard.tsindex d04c77c44..55dbcdea1 100644--- a/packages/trueforge-core/src/core/util/ssrfGuard.ts+++ b/packages/trueforge-core/src/core/util/ssrfGuard.ts@@ -12,9 +12,9 @@ const MAX_REDIRECTS = 20;const REDIRECT_STATUSES = new Set([301, 302, 303, 307, 308]);const CROSS_ORIGIN_STRIPPED_HEADERS = ['authorization', 'proxy-authorization', 'cookie', 'host'];// Rejected before processing (timeout, rate limit, gateway never reached the origin).-const UNPROCESSED_RETRY_STATUSES = new Set([408, 429, 521, 522, 523, 530]);-// Upstream may have processed the request (409 conflict, 520 bad origin response, 524 origin timeout).-const MAYBE_PROCESSED_RETRY_STATUSES = new Set([409, 520, 524]);+const UNPROCESSED_RETRY_STATUSES = new Set([408, 429, 503, 521, 522, 523, 530]);+// Upstream may have processed the request (502 invalid origin response, 409 conflict, 520 bad origin response, 524 origin timeout).+const MAYBE_PROCESSED_RETRY_STATUSES = new Set([409, 502, 520, 524]);const RETRY_INITIAL_DELAY_MS = 1_000;const RETRY_BACKOFF_FACTOR = 2;const RETRY_JITTER_FACTOR = 0.2;diff --git a/packages/trueforge-core/tests/core/util/ssrfGuard.test.ts b/packages/trueforge-core/tests/core/util/ssrfGuard.test.tsindex 98aaf6cd0..d49236bbb 100644--- a/packages/trueforge-core/tests/core/util/ssrfGuard.test.ts+++ b/packages/trueforge-core/tests/core/util/ssrfGuard.test.ts@@ -128,31 +128,33 @@ describe('ssrfFetch', () => {}});- it('retries gateway 520 then returns success', async () => {+ it('retries retryable gateway errors then returns success', async () => {configureOutboundUrlGuard({ allowedHosts: ['127.0.0.1'], blockedHosts: [] });configureOutboundFetches({outbound: { ...defaultOutboundFetchOptions(), maxRetries: 2 },model: defaultModelOutboundFetchOptions(),mcp: defaultMcpOutboundFetchOptions(),});- let hits = 0;- const { server, origin } = await listen((_req, res) => {- hits += 1;- if (hits === 1) {- res.writeHead(520, { 'content-type': 'text/plain' });- res.end('gateway');- return;+ for (const status of [502, 503, 520]) {+ let hits = 0;+ const { server, origin } = await listen((_req, res) => {+ hits += 1;+ if (hits === 1) {+ res.writeHead(status, { 'content-type': 'text/plain', 'retry-after-ms': '0' });+ res.end('gateway error');+ return;+ }+ res.writeHead(200, { 'content-type': 'text/plain' });+ res.end('ok');+ });+ try {+ const response = await ssrfFetch(`${origin}/`);+ expect(response.status).toBe(200);+ await expect(response.text()).resolves.toBe('ok');+ expect(hits).toBe(2);+ } finally {+ await closeServer(server);}- res.writeHead(200, { 'content-type': 'text/plain' });- res.end('ok');- });- try {- const response = await ssrfFetch(`${origin}/`);- expect(response.status).toBe(200);- await expect(response.text()).resolves.toBe('ok');- expect(hits).toBe(2);- } finally {- await closeServer(server);}});@@ -349,7 +351,7 @@ describe('modelSsrfFetch', () => {});describe('mcpSsrfFetch', () => {- it('retries statuses where the request was not processed but not 409/520/524', async () => {+ it('retries statuses where the request was not processed but not 409/502/520/524', async () => {configureOutboundUrlGuard({ allowedHosts: ['127.0.0.1'], blockedHosts: [] });configureOutboundFetches({outbound: defaultOutboundFetchOptions(),@@ -365,14 +367,14 @@ describe('mcpSsrfFetch', () => {res.end(String(status));});try {- for (const status of [408, 429, 522]) {+ for (const status of [408, 429, 503, 522]) {firstStatus = status;hits = 0;const retried = await mcpSsrfFetch(`${origin}/`);expect(retried.status).toBe(200);expect(hits).toBe(2);}- for (const status of [409, 520, 524]) {+ for (const status of [409, 502, 520, 524]) {firstStatus = status;hits = 0;const response = await mcpSsrfFetch(`${origin}/`);