Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

chore: show sandbox skills tooltip on switch toggle (#998)

harshil-209609f07f01f72e
diff --git a/.changeset/sandbox-skills-tooltip-on-toggle.md b/.changeset/sandbox-skills-tooltip-on-toggle.md
new file mode 100644
index 000000000..4acb720e3
--- /dev/null
+++ b/.changeset/sandbox-skills-tooltip-on-toggle.md
@@ -0,0 +1,5 @@
+---
+'@truefoundry/trueforge-ui': patch
+---
+
+Show the sandbox disabled-with-skills tooltip only on the switch, not the whole row.
diff --git a/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx b/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx
index 4cd24da70..5a9f078db 100644
--- a/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx
+++ b/packages/trueforge-ui/src/atoms/draft/AgentRuntimeConfigFields.tsx
@@ -175,13 +175,25 @@ export function AgentRuntimeConfigFields({
field: RuntimeSwitchField;
className?: string;
wrapperClassName?: string;
- }) => (
- <Tooltip
- key={field.label}
- content={field.disabledTooltip ?? ''}
- triggerClassName={cn('flex w-full min-w-0', wrapperClassName)}
- >
- <div className={cn('flex w-full', className ?? 'items-center justify-between gap-3 py-1.5')}>
+ }) => {
+ const control = (
+ <Switch
+ checked={field.checked}
+ disabled={disabled || field.disabled}
+ onCheckedChange={enabled => onChange(field.update(enabled))}
+ aria-label={field.label}
+ />
+ );
+
+ return (
+ <div
+ key={field.label}
+ className={cn(
+ 'flex w-full min-w-0',
+ wrapperClassName,
+ className ?? 'items-center justify-between gap-3 py-1.5',
+ )}
+ >
<span className="min-w-0">
<span className={cn('text-text-primary', layout === 'detailed' ? 'block text-sm font-medium' : 'text-xs')}>
{field.label}
@@ -190,15 +202,16 @@ export function AgentRuntimeConfigFields({
<span className="text-text-secondary mt-0.5 block text-xs leading-snug">{field.description}</span>
) : null}
</span>
- <Switch
- checked={field.checked}
- disabled={disabled || field.disabled}
- onCheckedChange={enabled => onChange(field.update(enabled))}
- aria-label={field.label}
- />
+ {field.disabledTooltip ? (
+ <Tooltip content={field.disabledTooltip}>
+ <span className="inline-flex">{control}</span>
+ </Tooltip>
+ ) : (
+ control
+ )}
</div>
- </Tooltip>
- );
+ );
+ };
if (layout === 'detailed') {
const rowClassName = 'items-center justify-between gap-4';
diff --git a/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx b/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx
index ee8d32a22..2cd9c6d9a 100644
--- a/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx
+++ b/packages/trueforge-ui/test/atoms/draft/AgentRuntimeConfigFields.test.tsx
@@ -16,12 +16,14 @@ function renderRuntimeFields({
value = { sandbox: { enabled: true } },
layout = 'detailed',
sandboxAvailable = true,
+ hasSkills = false,
environmentsEnabled = true,
onChange = vi.fn(),
}: {
value?: AgentRuntimeConfig;
layout?: 'compact' | 'detailed';
sandboxAvailable?: boolean;
+ hasSkills?: boolean;
environmentsEnabled?: boolean;
onChange?: (val: AgentRuntimeConfig) => void;
} = {}) {
@@ -74,7 +76,7 @@ function renderRuntimeFields({
<AgentRuntimeConfigFields
value={value}
sandboxAvailable={sandboxAvailable}
- hasSkills={false}
+ hasSkills={hasSkills}
layout={layout}
onChange={onChange}
/>
@@ -110,6 +112,21 @@ describe('AgentRuntimeConfigFields', () => {
expect(screen.queryByRole('button', { name: /Manage Environments/ })).not.toBeInTheDocument();
});
+ it('shows skills lock tooltip only when hovering the sandbox switch', () => {
+ renderRuntimeFields({ hasSkills: true });
+
+ const sandboxSwitch = screen.getByRole('switch', { name: 'Sandbox' });
+ expect(sandboxSwitch).toBeDisabled();
+
+ fireEvent.mouseEnter(screen.getByText('Sandbox'));
+ expect(document.querySelector('[role="tooltip"]')).toBeNull();
+
+ fireEvent.mouseEnter(sandboxSwitch.parentElement!);
+ const tooltip = document.querySelector('[role="tooltip"]');
+ expect(tooltip).not.toBeNull();
+ expect(tooltip).toHaveTextContent('Always on while skills are attached — remove them to turn it off');
+ });
+
it('populates environment dropdown with default and ready environments only', async () => {
const onChange = vi.fn();
renderRuntimeFields({ onChange });