Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

Simplify optional property forwarding.

debajyoti-truefoundry0bb352edab0a
diff --git a/eslint.config.mjs b/eslint.config.mjs
index 22d02b94d..f423c1958 100644
--- a/eslint.config.mjs
+++ b/eslint.config.mjs
@@ -6,21 +6,11 @@ import tseslint from 'typescript-eslint';
export default defineConfig(
{
- ignores: [
- '**/node_modules/**',
- '**/dist/**',
- '**/coverage/**',
- '**/.pnpm-store/**',
- '**/.eslintcache',
- ],
+ ignores: ['**/node_modules/**', '**/dist/**', '**/coverage/**', '**/.pnpm-store/**', '**/.eslintcache'],
},
{
files: ['**/*.{js,mjs,cjs,ts}'],
- extends: [
- js.configs.recommended,
- tseslint.configs.strictTypeChecked,
- tseslint.configs.stylisticTypeChecked,
- ],
+ extends: [js.configs.recommended, tseslint.configs.strictTypeChecked, tseslint.configs.stylisticTypeChecked],
languageOptions: {
parserOptions: {
projectService: true,
diff --git a/packages/harness/src/agentSession/SessionHandle.ts b/packages/harness/src/agentSession/SessionHandle.ts
index ee94ce950..0e2dde257 100644
--- a/packages/harness/src/agentSession/SessionHandle.ts
+++ b/packages/harness/src/agentSession/SessionHandle.ts
@@ -192,17 +192,17 @@ export class SessionHandle<
session_id: this.session.session_id,
first_turn_id: previous?.first_turn_id ?? turnId,
ancestor_ids: previous ? [...previous.ancestor_ids, previous.turn_id] : [],
- ...(previousTurnId !== undefined ? { previous_turn_id: previousTurnId } : {}),
+ previous_turn_id: previousTurnId,
state: { status: 'running' },
input: input.input ?? [],
snapshot: {
threads: threadsRecordFromMap(agentThreads),
- ...(previous?.snapshot.mcp_servers !== undefined ? { mcp_servers: previous.snapshot.mcp_servers } : {}),
- ...(previous?.snapshot.sandbox_info !== undefined ? { sandbox_info: previous.snapshot.sandbox_info } : {}),
+ mcp_servers: previous?.snapshot.mcp_servers,
+ sandbox_info: previous?.snapshot.sandbox_info,
},
created_at: now,
updated_at: now,
- ...(custom !== undefined ? { custom } : {}),
+ custom,
};
await this.store.createTurn({
@@ -272,7 +272,11 @@ export class SessionHandle<
* turn.created / turn.done lifecycle events. Reads from the store only —
* nothing is synthesized on read.
*/
- async listEvents(input: { limit: number; page_token?: string; last_turn_id?: string }): Promise<{
+ async listEvents(input: {
+ limit: number;
+ page_token?: string | undefined;
+ last_turn_id?: string | undefined;
+ }): Promise<{
data: { turn_id: string; event: TurnCreatedEvent | TurnDoneEvent | TurnEvent }[];
pagination: TokenPagination;
}> {
diff --git a/packages/harness/src/agentSession/TurnHandle.ts b/packages/harness/src/agentSession/TurnHandle.ts
index a6ecf3ec0..6669b56e4 100644
--- a/packages/harness/src/agentSession/TurnHandle.ts
+++ b/packages/harness/src/agentSession/TurnHandle.ts
@@ -296,7 +296,11 @@ export class TurnHandle<TTurnCustom extends object = Record<string, never>> {
}
/** Paginated read of this turn's persisted events. */
- async listEvents(input: { limit: number; page_token?: string; order?: 'asc' | 'desc' }): Promise<{
+ async listEvents(input: {
+ limit: number;
+ page_token?: string | undefined;
+ order?: 'asc' | 'desc' | undefined;
+ }): Promise<{
data: WithRegisteredPassthrough<TurnEvent | TurnCreatedEvent | TurnDoneEvent>[];
pagination: TokenPagination;
}> {
diff --git a/packages/harness/src/agentSession/store/InMemorySessionStore.ts b/packages/harness/src/agentSession/store/InMemorySessionStore.ts
index ad02ad052..a1b96fbf2 100644
--- a/packages/harness/src/agentSession/store/InMemorySessionStore.ts
+++ b/packages/harness/src/agentSession/store/InMemorySessionStore.ts
@@ -113,7 +113,7 @@ export class InMemorySessionStore<
created_at: now,
updated_at: now,
last_activity_timestamp_ms: Date.now(),
- ...(input.custom !== undefined ? { custom: deepCopy(input.custom) } : {}),
+ custom: input.custom !== undefined ? deepCopy(input.custom) : undefined,
};
this.sessions.set(key, { record, turnIds: [] });
return;
diff --git a/packages/harness/src/core/capabilities/builtins/DynamicSubAgents.ts b/packages/harness/src/core/capabilities/builtins/DynamicSubAgents.ts
index 30e835b87..d8c3c0589 100644
--- a/packages/harness/src/core/capabilities/builtins/DynamicSubAgents.ts
+++ b/packages/harness/src/core/capabilities/builtins/DynamicSubAgents.ts
@@ -120,7 +120,7 @@ export class DynamicSubAgents extends LocalToolMCP {
});
}
- constructor({ modelSetConfig, tracing }: { modelSetConfig?: ModelSetConfig; tracing: AgentTracing }) {
+ constructor({ modelSetConfig, tracing }: { modelSetConfig?: ModelSetConfig | undefined; tracing: AgentTracing }) {
super({ tracing });
this.tools = [this.getCreateSubAgentTool(modelSetConfig)];
}
@@ -151,7 +151,7 @@ export function dynamicSubAgents(options: {
tracing: AgentTracing;
}): AgentCapability {
const toolSet = new DynamicSubAgents({
- ...(options.modelSetConfig !== undefined ? { modelSetConfig: options.modelSetConfig } : {}),
+ modelSetConfig: options.modelSetConfig,
tracing: options.tracing,
});
return {
diff --git a/packages/harness/src/core/mcp/RemoteMCP.ts b/packages/harness/src/core/mcp/RemoteMCP.ts
index f17d9e3cf..ea2427773 100644
--- a/packages/harness/src/core/mcp/RemoteMCP.ts
+++ b/packages/harness/src/core/mcp/RemoteMCP.ts
@@ -158,7 +158,7 @@ export class RemoteMCP implements ToolSource {
const tools = await paginateWithCursorGuard(
async cursor => {
const page = await this.connection.listTools(cursor);
- return { items: page.tools, ...(page.nextCursor !== undefined ? { nextCursor: page.nextCursor } : {}) };
+ return { items: page.tools, nextCursor: page.nextCursor };
},
this.name,
this.logger,
@@ -230,14 +230,13 @@ export class RemoteMCP implements ToolSource {
connection = await this.tracing.withRemoteMcpToolSpan(
{ method: 'initialize', serverName: this.name, serverId: this.id, serverUrl: this.traceUrl, enabled: true },
async span => {
- const sessionIdValue = this.sessionId ?? undefined;
const conn = await connectRemoteMcp({
url: this.url,
headers,
- ...(sessionIdValue !== undefined ? { sessionId: sessionIdValue } : {}),
+ sessionId: this.sessionId ?? undefined,
// Hint from a prior connect
- ...(this.resolvedTransportType !== undefined ? { knownTransportType: this.resolvedTransportType } : {}),
- ...(this.connectTimeoutMs !== undefined ? { connectTimeoutMs: this.connectTimeoutMs } : {}),
+ knownTransportType: this.resolvedTransportType,
+ connectTimeoutMs: this.connectTimeoutMs,
signal: this.signal,
onClose: () => {
this.isConnected = false;
diff --git a/packages/harness/src/core/mcp/pagination.ts b/packages/harness/src/core/mcp/pagination.ts
index c8d30b049..cded754c9 100644
--- a/packages/harness/src/core/mcp/pagination.ts
+++ b/packages/harness/src/core/mcp/pagination.ts
@@ -6,7 +6,7 @@ import type { Logger } from 'winston';
* loop stops and (when a logger is supplied) a warning is emitted naming the server.
*/
export async function paginateWithCursorGuard<T>(
- fetchNext: (cursor: string | undefined) => Promise<{ items: T[]; nextCursor?: string }>,
+ fetchNext: (cursor: string | undefined) => Promise<{ items: T[]; nextCursor?: string | undefined }>,
serverIdentifier: string | undefined,
logger?: Logger,
): Promise<T[]> {
diff --git a/packages/harness/src/core/mcp/remoteMcpClient.ts b/packages/harness/src/core/mcp/remoteMcpClient.ts
index 3af4f1943..ec43d3260 100644
--- a/packages/harness/src/core/mcp/remoteMcpClient.ts
+++ b/packages/harness/src/core/mcp/remoteMcpClient.ts
@@ -17,7 +17,7 @@ export interface RemoteMcpConnection {
readonly transportType: RemoteMcpTransportType;
/** Session id for a stateful server, or null for a stateless one. */
readonly sessionId: string | null;
- listTools(cursor?: string): Promise<{ tools: ToolSchema[]; nextCursor?: string }>;
+ listTools(cursor?: string): Promise<{ tools: ToolSchema[]; nextCursor?: string | undefined }>;
callTool(params: CallToolRequest['params']): Promise<CallToolResult>;
close(): Promise<void>;
}
@@ -106,7 +106,7 @@ function buildConnection(
const response = await client.listTools(cursor ? { cursor } : undefined, requestOptions);
return {
tools: response.tools,
- ...(response.nextCursor !== undefined ? { nextCursor: response.nextCursor } : {}),
+ nextCursor: response.nextCursor,
};
},
callTool: async (callParams: CallToolRequest['params']): Promise<CallToolResult> => {
diff --git a/packages/harness/src/core/runtime/AgentThread.ts b/packages/harness/src/core/runtime/AgentThread.ts
index ea5e0cd4b..a259acda2 100644
--- a/packages/harness/src/core/runtime/AgentThread.ts
+++ b/packages/harness/src/core/runtime/AgentThread.ts
@@ -231,7 +231,7 @@ function buildModelMessageEvent({
void thinking_blocks;
const event: ModelMessageEvent = {
...rest,
- ...(tool_calls !== undefined ? { tool_calls: tool_calls.map(toEnrichedToolCall) } : {}),
+ tool_calls: tool_calls?.map(toEnrichedToolCall),
type: EventType.MODEL_MESSAGE,
id,
created_at: new Date().toISOString(),
diff --git a/packages/harness/src/core/sandbox/Sandbox.ts b/packages/harness/src/core/sandbox/Sandbox.ts
index 9ea378d1d..b1716fa9c 100644
--- a/packages/harness/src/core/sandbox/Sandbox.ts
+++ b/packages/harness/src/core/sandbox/Sandbox.ts
@@ -499,10 +499,10 @@ export class Sandbox extends LocalToolMCP {
}
const bridge = await this.ensureNatsBridgeConnected(sandboxInfo.sandbox_id);
const mcpClientEnv = injectMCPClientEnv({
- ...(input.env !== undefined ? { env: input.env } : {}),
+ env: input.env,
mcpServers: this.buildMcpServersEnvelope(),
- ...(this.execExtraEnv !== undefined ? { execExtraEnv: this.execExtraEnv } : {}),
- ...(bridge?.subjectPrefix !== undefined ? { natsBridgeSubjectPrefix: bridge.subjectPrefix } : {}),
+ execExtraEnv: this.execExtraEnv,
+ natsBridgeSubjectPrefix: bridge?.subjectPrefix,
});
const gitAuthEnv =
this.resolvedGitCredentialsContent !== null
@@ -513,7 +513,7 @@ export class Sandbox extends LocalToolMCP {
const result = await this.provider.exec({
sandboxId: sandboxInfo.sandbox_id,
command: input.command,
- ...(input.cwd !== undefined ? { cwd: input.cwd } : {}),
+ cwd: input.cwd,
env,
});
diff --git a/packages/harness/src/core/sandbox/provider/Provider.ts b/packages/harness/src/core/sandbox/provider/Provider.ts
index 3e7b84664..7946a0167 100644
--- a/packages/harness/src/core/sandbox/provider/Provider.ts
+++ b/packages/harness/src/core/sandbox/provider/Provider.ts
@@ -29,7 +29,12 @@ export interface SandboxFileInfo {
export interface SandboxProvider {
createSandbox(): Promise<{ sandboxId: string }>;
- exec(params: { sandboxId: string; command: string; cwd?: string; env?: Record<string, string> }): Promise<ExecResult>;
+ exec(params: {
+ sandboxId: string;
+ command: string;
+ cwd?: string | undefined;
+ env?: Record<string, string> | undefined;
+ }): Promise<ExecResult>;
/** Provider-specific instructions appended to the agent system prompt. */
getAdditionalInstructions(): string | undefined;
/** Directory inside the sandbox where large tool responses are dumped. */
diff --git a/packages/harness/tests/agentSession/testHelpers.ts b/packages/harness/tests/agentSession/testHelpers.ts
index 035b3339a..efd982199 100644
--- a/packages/harness/tests/agentSession/testHelpers.ts
+++ b/packages/harness/tests/agentSession/testHelpers.ts
@@ -131,7 +131,7 @@ export function makeRunningTurnRecord(input: {
session_id: input.sessionId,
first_turn_id: input.firstTurnId ?? input.turnId,
ancestor_ids: input.previousTurnId ? [input.previousTurnId] : [],
- ...(input.previousTurnId !== undefined ? { previous_turn_id: input.previousTurnId } : {}),
+ previous_turn_id: input.previousTurnId,
state: { status: 'running' },
input: [],
snapshot: {
diff --git a/packages/harness/tests/core/mcpInitializeAggregation.test.ts b/packages/harness/tests/core/mcpInitializeAggregation.test.ts
index 940f19f9a..51103b3d8 100644
--- a/packages/harness/tests/core/mcpInitializeAggregation.test.ts
+++ b/packages/harness/tests/core/mcpInitializeAggregation.test.ts
@@ -13,7 +13,7 @@ function makeServer(params: {
const base = makeMockIMCPServer({
name: params.name,
preload: true,
- ...(params.tools !== undefined ? { tools: params.tools } : {}),
+ tools: params.tools,
});
return {
...base,
diff --git a/packages/harness/tests/core/remoteMcpServer.test.ts b/packages/harness/tests/core/remoteMcpServer.test.ts
index e07cea2a4..811b473f3 100644
--- a/packages/harness/tests/core/remoteMcpServer.test.ts
+++ b/packages/harness/tests/core/remoteMcpServer.test.ts
@@ -154,7 +154,7 @@ describe('RemoteMCP + ToolSet', () => {
await server.listTools();
const firstCall = mockConnect.mock.calls[0];
expect(firstCall).toBeDefined();
- expect(firstCall?.[0]).not.toHaveProperty('knownTransportType');
+ expect(firstCall?.[0]?.knownTransportType).toBeUndefined();
});
it('applies enable/disable selectors and preload annotation', async () => {
diff --git a/packages/server/src/apis/sessions.ts b/packages/server/src/apis/sessions.ts
index b0a17e1ca..977e7cdf3 100644
--- a/packages/server/src/apis/sessions.ts
+++ b/packages/server/src/apis/sessions.ts
@@ -118,9 +118,9 @@ export function createSessionsRouter(deps: SessionsRouterDeps) {
tenant_name: TENANT_NAME,
limit: query.limit,
order: query.order,
- ...(query.page_token !== undefined ? { page_token: query.page_token } : {}),
- ...(query.start_timestamp !== undefined ? { start_timestamp: query.start_timestamp } : {}),
- ...(query.end_timestamp !== undefined ? { end_timestamp: query.end_timestamp } : {}),
+ page_token: query.page_token,
+ start_timestamp: query.start_timestamp,
+ end_timestamp: query.end_timestamp,
});
return c.json({ data: data.map(toWireSession), pagination }, 200);
} catch (error) {
@@ -153,8 +153,8 @@ export function createSessionsRouter(deps: SessionsRouterDeps) {
try {
const { data, pagination } = await session.listEvents({
limit: query.limit,
- ...(query.page_token !== undefined ? { page_token: query.page_token } : {}),
- ...(query.last_turn_id !== undefined ? { last_turn_id: query.last_turn_id } : {}),
+ page_token: query.page_token,
+ last_turn_id: query.last_turn_id,
});
return c.json({ data, pagination }, 200);
} catch (error) {
diff --git a/packages/server/src/apis/turns.ts b/packages/server/src/apis/turns.ts
index 5dd9704b2..1a2cd283c 100644
--- a/packages/server/src/apis/turns.ts
+++ b/packages/server/src/apis/turns.ts
@@ -43,7 +43,7 @@ export interface TurnsRouterDeps {
function createTurnResolver(deps: {
modelStore: ModelStore;
mcpStore: McpStore;
- sandboxFactory?: TurnSandboxFactory;
+ sandboxFactory?: TurnSandboxFactory | undefined;
logger: Logger;
signal: AbortSignal;
}): TurnResourceResolver {
@@ -126,7 +126,7 @@ export function createTurnsRouter(deps: TurnsRouterDeps) {
const resolver = createTurnResolver({
modelStore: deps.modelStore,
mcpStore: deps.mcpStore,
- ...(deps.sandboxFactory ? { sandboxFactory: deps.sandboxFactory } : {}),
+ sandboxFactory: deps.sandboxFactory,
logger: deps.logger,
signal: abortController.signal,
});
@@ -138,11 +138,11 @@ export function createTurnsRouter(deps: TurnsRouterDeps) {
let turn;
try {
turn = await session.run({
- ...(body.input !== undefined ? { input: body.input } : {}),
+ input: body.input,
previous_turn_id: body.previous_turn_id,
signal: abortController.signal,
resolver,
- ...(title !== undefined ? { update_session_title_if_not_exist: title } : {}),
+ update_session_title_if_not_exist: title,
});
} catch (error) {
// Unknown previous_turn_id (nothing was persisted).
diff --git a/packages/server/src/runtime/sandboxFactory.ts b/packages/server/src/runtime/sandboxFactory.ts
index c934b9680..38a570ec1 100644
--- a/packages/server/src/runtime/sandboxFactory.ts
+++ b/packages/server/src/runtime/sandboxFactory.ts
@@ -92,7 +92,7 @@ export function createServerSandboxFactory(deps: { logger: Logger }): TurnSandbo
Promise.resolve(
new Sandbox({
provider,
- ...(existingSandboxId !== undefined ? { existingSandboxId } : {}),
+ existingSandboxId,
fileDownloadEnabled: spec.config?.sandbox?.file_downloads ?? false,
blockDestructiveToolsInCodeMode: true,
scripts,