The open-source agent harness - the runtime layer that turns an LLM into a working agent.
fix: update reasoning effort defaults to prioritize 'medium' and 'high' (#1139)
Sujai Kumar Gupta0c071f626b7b
diff --git a/.changeset/default-reasoning-medium.md b/.changeset/default-reasoning-medium.mdindex 8a4277521..64c9e4127 100644--- a/.changeset/default-reasoning-medium.md+++ b/.changeset/default-reasoning-medium.md@@ -3,4 +3,4 @@'@truefoundry/trueforge': patch----Default the reasoning effort to `medium` when the selected model offers it (falling back to the lowest real effort otherwise), instead of defaulting to the lowest effort. TrueFoundry model listing now passes `mergeParams` to the provider-integrations API so provider-level parameter defaults are included in each model's advertised parameters.+Default the reasoning effort to `medium` when the selected model offers it, instead of defaulting to the lowest effort. TrueFoundry model listing now passes `mergeParams` to the provider-integrations API so provider-level parameter defaults are included in each model's advertised parameters.diff --git a/.changeset/reasoning-effort-high-low-fallback.md b/.changeset/reasoning-effort-high-low-fallback.mdnew file mode 100644index 000000000..7845971ee--- /dev/null+++ b/.changeset/reasoning-effort-high-low-fallback.md@@ -0,0 +1,6 @@+---+'@truefoundry/trueforge-ui': patch+'@truefoundry/trueforge': patch+---++Default reasoning effort now follows `medium` → `high` → `low` in both the draft (New Chat) composer and the agent builder (Agent Config) when the selected model does not offer `medium`, instead of falling back to the lowest offered effort.diff --git a/packages/frontend/src/App.tsx b/packages/frontend/src/App.tsxindex ce48ae468..450a2020c 100644--- a/packages/frontend/src/App.tsx+++ b/packages/frontend/src/App.tsx@@ -1,5 +1,6 @@import {getErrorMessage,+ resolveReasoningEffort,ThemeProvider,TrueForgeUI,useTheme,@@ -143,12 +144,7 @@ export function App() {});return;}- const reasoningEfforts = first.properties.reasoningEfforts;- // Default to "medium"; catalog lists are ordered ascending, so otherwise the lowest real effort, not "none".- const defaultReasoningEffort =- reasoningEfforts?.find(effort => effort === 'medium') ??- reasoningEfforts?.find(effort => effort !== 'none') ??- reasoningEfforts?.[0];+ const defaultReasoningEffort = resolveReasoningEffort(first.properties.reasoningEfforts, undefined);setBoot({status: 'ready',openSettings: false,diff --git a/packages/trueforge-ui/src/atoms/draft/reasoningEffort.ts b/packages/trueforge-ui/src/atoms/draft/reasoningEffort.tsindex a5276258c..43f2733bc 100644--- a/packages/trueforge-ui/src/atoms/draft/reasoningEffort.ts+++ b/packages/trueforge-ui/src/atoms/draft/reasoningEffort.ts@@ -6,11 +6,15 @@ export function hasReasoningEfforts(efforts: ReasoningEfforts): efforts is strinreturn Array.isArray(efforts) && efforts.length > 0;}-/** Keep current if still listed; otherwise default to "medium", falling back to the lowest non-"none" effort. */+const DEFAULT_REASONING_EFFORT_PREFERENCE = ['medium', 'high', 'low'] as const;++/** Keep current if still listed; otherwise default by preference: "medium", then "high", then "low". */export function resolveReasoningEffort(efforts: ReasoningEfforts, current: string | undefined): string | undefined {if (!hasReasoningEfforts(efforts)) return undefined;if (current && efforts.includes(current)) return current;- if (efforts.includes('medium')) return 'medium';+ for (const preferred of DEFAULT_REASONING_EFFORT_PREFERENCE) {+ if (efforts.includes(preferred)) return preferred;+ }// Catalog lists are ordered ascending, so the first non-"none" entry is the lowest real effort.return efforts.find(effort => effort !== 'none') ?? efforts[0];}diff --git a/packages/trueforge-ui/src/index.ts b/packages/trueforge-ui/src/index.tsindex 3da94c127..9810dde57 100644--- a/packages/trueforge-ui/src/index.ts+++ b/packages/trueforge-ui/src/index.ts@@ -554,6 +554,7 @@ export { DraftCompositeSelector } from './atoms/draft/DraftCompositeSelector.js'export type { DraftCompositeSelectorProps } from './atoms/draft/DraftCompositeSelector.js';export { DraftModelSelector } from './atoms/draft/DraftModelSelector.js';export type { DraftModelSelectorProps } from './atoms/draft/DraftModelSelector.js';+export { resolveReasoningEffort } from './atoms/draft/reasoningEffort.js';export { SaveAgentButton } from './atoms/SaveAgentButton.js';export type { SaveAgentButtonProps } from './atoms/SaveAgentButton.js';export { SaveAgentForm } from './atoms/SaveAgentForm.js';diff --git a/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsx b/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsxindex d6638d2e4..a3cc5317c 100644--- a/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsx+++ b/packages/trueforge-ui/test/atoms/draft/DraftModelSelector.test.tsx@@ -129,7 +129,7 @@ describe('DraftModelSelector', () => {expect(updateAgentSpec).toHaveBeenCalledWith({model: {name: 'anthropic/claude-3.7-sonnet',- params: { maxTokens: 512, reasoningEffort: 'low' },+ params: { maxTokens: 512, reasoningEffort: 'high' },},});expect(screen.queryByRole('listbox', { name: 'Select model' })).not.toBeInTheDocument();diff --git a/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.ts b/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.tsindex 0eeb1cc8d..5ed8b6e1e 100644--- a/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.ts+++ b/packages/trueforge-ui/test/atoms/draft/reasoningEffort.test.ts@@ -27,9 +27,9 @@ describe('resolveReasoningEffort', () => {expect(resolveReasoningEffort(['low', 'high'], 'high')).toBe('high');});- it('falls back to first when current missing or invalid', () => {- expect(resolveReasoningEffort(['low', 'high'], undefined)).toBe('low');- expect(resolveReasoningEffort(['low', 'high'], 'medium')).toBe('low');+ it('falls back to "high" when current is missing or invalid and "medium" is not offered', () => {+ expect(resolveReasoningEffort(['low', 'high'], undefined)).toBe('high');+ expect(resolveReasoningEffort(['low', 'high'], 'medium')).toBe('high');});it('defaults to "medium" when the model offers it', () => {@@ -37,9 +37,13 @@ describe('resolveReasoningEffort', () => {expect(resolveReasoningEffort(['low', 'medium', 'high'], 'bogus')).toBe('medium');});- it('defaults to the lowest non-"none" effort when "medium" is not offered, skipping "none"', () => {- expect(resolveReasoningEffort(['none', 'low', 'high'], undefined)).toBe('low');- expect(resolveReasoningEffort(['none', 'minimal', 'low'], 'bogus')).toBe('minimal');+ it('defaults to "high" before "low", and to "low" when neither "medium" nor "high" is offered', () => {+ expect(resolveReasoningEffort(['none', 'low', 'high'], undefined)).toBe('high');+ expect(resolveReasoningEffort(['none', 'minimal', 'low'], 'bogus')).toBe('low');+ });++ it('defaults to the lowest non-"none" effort when no preferred effort is offered, skipping "none"', () => {+ expect(resolveReasoningEffort(['none', 'minimal', 'xhigh'], undefined)).toBe('minimal');});it('still honors an explicit "none" selection', () => {diff --git a/packages/trueforge-ui/test/publicUiExports.test.ts b/packages/trueforge-ui/test/publicUiExports.test.tsindex 12d7305bf..905de48e5 100644--- a/packages/trueforge-ui/test/publicUiExports.test.ts+++ b/packages/trueforge-ui/test/publicUiExports.test.ts@@ -191,6 +191,7 @@ const expectedRuntimeExports: Array<keyof typeof sdk> = ['readSessionIsCreateAgent','resolveBrandChrome','resolvePresetTokens',+ 'resolveReasoningEffort','sessionIsCreateAgent','shellIsCreateAgent','shellIsMutable',