Skip to content

The open-source agent harness - the runtime layer that turns an LLM into a working agent.

refactor: enhance UI components and improve accessibility (#233)

Govinda Vashishtha0eb26040b418
diff --git a/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx b/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx
index 99cf9c14f..4607a07d0 100644
--- a/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx
+++ b/packages/trueforge-ui-sdk/src/atoms/NamedAgentHeaderLabel.tsx
@@ -17,8 +17,8 @@ export function NamedAgentHeaderLabel({ className }: { className?: string }) {
{state.name}
</span>
{state.isEditing ? (
- <Tooltip content="Try changes here, then choose Update agent to save.">
- <span className="bg-warning-bg text-warning-text inline-flex shrink-0 items-center gap-1 rounded-full px-2 py-0.5 text-xs font-medium">
+ <Tooltip content="Try changes here, then choose Update agent to save." side="bottom">
+ <span className="border-warning-bg/40 bg-warning-bg/10 text-warning-bg inline-flex shrink-0 items-center gap-1 rounded-full border px-2 py-0.5 text-xs font-medium">
<Icon name="pencil" className="size-3" />
Editing
</span>
diff --git a/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx b/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx
index ae5fc5e29..da677ca9a 100644
--- a/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx
+++ b/packages/trueforge-ui-sdk/src/atoms/SaveAgentButton.tsx
@@ -5,7 +5,7 @@ import {
useTrueFoundryAgentSpec,
useTrueFoundryFlushAgentSpec,
} from '@truefoundry/assistant-ui-runtime';
-import { useId, useMemo, useRef, useState } from 'react';
+import { useEffect, useId, useMemo, useRef, useState } from 'react';
import { useSaveAgentVisible } from '../hooks/useChatChromeActionsVisible.js';
import { Icon } from '../icons/Icon.js';
import { useOptionalServer, useServerCapabilities } from '../server/ServerContext.js';
@@ -117,10 +117,17 @@ function SaveAgentButtonContent({
const [search, setSearch] = useState('');
const [saving, setSaving] = useState(false);
const [error, setError] = useState<string | null>(null);
+ const errorRef = useRef<HTMLParagraphElement>(null);
const mcpMounts = useMemo(() => editableMountsFromSpec(draftSpec?.mcpServers), [draftSpec?.mcpServers]);
const skillMounts = useMemo(() => editableMountsFromSpec(draftSpec?.skills), [draftSpec?.skills]);
+ useEffect(() => {
+ if (error === null) return;
+ // scrollIntoView is unimplemented in jsdom; guard so tests don't throw.
+ errorRef.current?.scrollIntoView?.({ block: 'nearest', behavior: 'smooth' });
+ }, [error]);
+
const close = () => {
if (saving) return;
setEditor(null);
@@ -204,6 +211,7 @@ function SaveAgentButtonContent({
className={auiButtonClass({ variant: 'outline', size: 'sm', className })}
onClick={() => void show()}
>
+ <Icon name="save" className="size-3.5" />
{triggerLabel}
</button>
@@ -284,7 +292,7 @@ function SaveAgentButtonContent({
</div>
{error ? (
- <p role="alert" className="text-failure-bg mt-3 text-sm">
+ <p ref={errorRef} role="alert" className="text-failure-bg mt-3 text-sm">
{error}
</p>
) : null}
diff --git a/packages/trueforge-ui-sdk/src/atoms/draft/DraftCompositeSelector.tsx b/packages/trueforge-ui-sdk/src/atoms/draft/DraftCompositeSelector.tsx
index 4350a8f65..6ce875c45 100644
--- a/packages/trueforge-ui-sdk/src/atoms/draft/DraftCompositeSelector.tsx
+++ b/packages/trueforge-ui-sdk/src/atoms/draft/DraftCompositeSelector.tsx
@@ -243,6 +243,21 @@ export function DraftCompositeSelector({ disabled, isRunning, onAttach }: DraftC
const selectedSkillIds = useMemo(() => new Set(selectedSkills.map(s => s.id)), [selectedSkills]);
const hasValidModel = Boolean(agentSpec?.model?.name.trim());
const toolsCount = selectedMcp.length + selectedSkills.length;
+ const toolsTooltip = useMemo(() => {
+ const formatNames = (items: Array<{ name: string }>) => {
+ const names = items.map(item => item.name);
+ if (names.length <= 4) return names.join(', ');
+ return `${names.slice(0, 4).join(', ')} +${names.length - 4}`;
+ };
+ const lines: string[] = [];
+ if (selectedMcp.length > 0) {
+ lines.push(`Connectors: ${formatNames(selectedMcp)}`);
+ }
+ if (selectedSkills.length > 0) {
+ lines.push(`Skills: ${formatNames(selectedSkills)}`);
+ }
+ return lines.length > 0 ? lines.join('\n') : 'No connectors or skills selected';
+ }, [selectedMcp, selectedSkills]);
const clearFlushTimer = useCallback(() => {
if (flushTimerRef.current != null) {
@@ -390,7 +405,7 @@ export function DraftCompositeSelector({ disabled, isRunning, onAttach }: DraftC
type="button"
className={cn(
'text-text-secondary flex flex-1 items-center justify-center gap-1.5 px-2 py-2.5 text-xs font-medium',
- active && 'text-text-primary border-b-2 border-text-primary',
+ active && 'text-primary-button-bg border-b-2 border-primary-button-bg',
)}
onClick={() => {
setTab(t.id);
@@ -529,32 +544,34 @@ export function DraftCompositeSelector({ disabled, isRunning, onAttach }: DraftC
return (
<div ref={containerRef} className="relative flex flex-wrap items-center gap-1.5">
{hasValidModel ? (
- <button
- type="button"
- disabled={disabled || isRunning}
- aria-label={`Tools (${toolsCount})`}
- aria-haspopup="dialog"
- aria-expanded={open}
- aria-controls={open ? menuId : undefined}
- className={auiButtonClass({
- variant: 'ghost',
- size: 'sm',
- className: 'h-8 gap-1.5 rounded-md px-2 text-xs',
- })}
- onClick={() => {
- if (open) {
- setOpenAndFlush(false);
- return;
- }
- openPicker();
- }}
- >
- <Icon name="wrench" className="size-3.5" />
- <span>Tools</span>
- <span className="bg-primary-button-bg/10 text-primary-button-bg rounded px-1.5 py-0.5 text-[10px] font-semibold">
- {toolsCount}
- </span>
- </button>
+ <Tooltip content={toolsTooltip} className="max-w-xs whitespace-pre-line text-left" side="top">
+ <button
+ type="button"
+ disabled={disabled || isRunning}
+ aria-label={`Tools (${toolsCount})`}
+ aria-haspopup="dialog"
+ aria-expanded={open}
+ aria-controls={open ? menuId : undefined}
+ className={auiButtonClass({
+ variant: 'ghost',
+ size: 'sm',
+ className: 'h-8 gap-1.5 rounded-md px-2 text-xs',
+ })}
+ onClick={() => {
+ if (open) {
+ setOpenAndFlush(false);
+ return;
+ }
+ openPicker();
+ }}
+ >
+ <Icon name="wrench" className="size-3.5" />
+ <span>Tools</span>
+ <span className="bg-primary-button-bg/10 text-primary-button-bg rounded px-1.5 py-0.5 text-[10px] font-semibold">
+ {toolsCount}
+ </span>
+ </button>
+ </Tooltip>
) : null}
{onAttach ? (
diff --git a/packages/trueforge-ui-sdk/src/atoms/lib/buttonClasses.ts b/packages/trueforge-ui-sdk/src/atoms/lib/buttonClasses.ts
index 725fd7d1b..c722310bd 100644
--- a/packages/trueforge-ui-sdk/src/atoms/lib/buttonClasses.ts
+++ b/packages/trueforge-ui-sdk/src/atoms/lib/buttonClasses.ts
@@ -21,7 +21,7 @@ const sizeClasses: Record<AuiButtonSize, string> = {
};
const baseClasses =
- 'inline-flex cursor-pointer items-center justify-center gap-2 whitespace-nowrap rounded-md font-medium transition-colors focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-focus-ring disabled:pointer-events-none disabled:opacity-50';
+ 'inline-flex cursor-pointer items-center justify-center gap-2 whitespace-nowrap rounded-md font-medium transition-colors focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-focus-ring disabled:cursor-not-allowed disabled:opacity-50';
/** Shared Button / native `<button>` className helper (SDK utilities are layered). */
export function auiButtonClass({
diff --git a/packages/trueforge-ui-sdk/src/atoms/lib/inputClasses.ts b/packages/trueforge-ui-sdk/src/atoms/lib/inputClasses.ts
index 6f6fe28e3..cc8c34ad4 100644
--- a/packages/trueforge-ui-sdk/src/atoms/lib/inputClasses.ts
+++ b/packages/trueforge-ui-sdk/src/atoms/lib/inputClasses.ts
@@ -1,7 +1,7 @@
import { cn } from './cn.js';
const baseClasses =
- 'w-full rounded-md border border-input-border bg-input-box-bg px-3 text-sm text-text-primary outline-none placeholder:text-text-secondary/70 focus-visible:ring-2 focus-visible:ring-focus-ring/40';
+ 'w-full cursor-text rounded-md border border-input-border bg-input-box-bg px-3 text-sm text-text-primary outline-none placeholder:text-text-secondary/70 focus-visible:ring-2 focus-visible:ring-focus-ring/40 disabled:cursor-not-allowed';
/**
* Shared text-input / textarea className helper. Callers add height, shadow, or
diff --git a/packages/trueforge-ui-sdk/src/containers/ComposerContainer.tsx b/packages/trueforge-ui-sdk/src/containers/ComposerContainer.tsx
index b0ca3d376..6a18bf005 100644
--- a/packages/trueforge-ui-sdk/src/containers/ComposerContainer.tsx
+++ b/packages/trueforge-ui-sdk/src/containers/ComposerContainer.tsx
@@ -75,7 +75,7 @@ function ComposerBody({ placeholder }: { placeholder: string }) {
disabled={isBusy}
submitMode="enter"
aria-label="Message input"
- className="text-text-primary placeholder:text-text-secondary/80 max-h-[10lh] min-h-10 w-full resize-none overflow-y-auto rounded-lg border-none bg-transparent px-1 py-1 text-base leading-normal shadow-none outline-none"
+ className="text-text-primary placeholder:text-text-secondary/80 max-h-[10lh] min-h-10 w-full resize-none overflow-y-auto rounded-lg border-none bg-transparent px-1 py-1 text-base leading-normal shadow-none outline-none disabled:cursor-not-allowed"
/>
}
disabled={isBusy}
diff --git a/packages/trueforge-ui-sdk/src/icons/IconRegistry.tsx b/packages/trueforge-ui-sdk/src/icons/IconRegistry.tsx
index 04134f3d5..012710206 100644
--- a/packages/trueforge-ui-sdk/src/icons/IconRegistry.tsx
+++ b/packages/trueforge-ui-sdk/src/icons/IconRegistry.tsx
@@ -42,6 +42,7 @@ import {
Plug,
Plus,
RotateCw,
+ Save,
Search,
Settings,
Sparkle,
@@ -152,6 +153,7 @@ const defaults: Record<string, IconEntry> = {
cube: Box,
'list-ol': ListOrdered,
download: Download,
+ save: Save,
brain: Brain,
terminal: Terminal,
code: Code2,
diff --git a/packages/trueforge-ui-sdk/test/atoms/draft/DraftCompositeSelector.test.tsx b/packages/trueforge-ui-sdk/test/atoms/draft/DraftCompositeSelector.test.tsx
index e27fc8957..5c314a1ee 100644
--- a/packages/trueforge-ui-sdk/test/atoms/draft/DraftCompositeSelector.test.tsx
+++ b/packages/trueforge-ui-sdk/test/atoms/draft/DraftCompositeSelector.test.tsx
@@ -73,6 +73,31 @@ describe('DraftCompositeSelector', () => {
expect(screen.queryByRole('dialog', { name: 'Add to composer' })).not.toBeInTheDocument();
});
+ it('shows selected connectors and skills in the Tools tooltip', () => {
+ renderSelector();
+ fireEvent.mouseEnter(screen.getByRole('button', { name: 'Tools (2)' }));
+ expect(screen.getByRole('tooltip')).toHaveTextContent('Connectors: Slack');
+ expect(screen.getByRole('tooltip')).toHaveTextContent('Skills: Research');
+ });
+
+ it('truncates Tools tooltip names after 4 with a remainder count', () => {
+ agentSpec = {
+ ...agentSpec,
+ mcpServers: [
+ { id: 'a', name: 'Alpha' },
+ { id: 'b', name: 'Beta' },
+ { id: 'c', name: 'Gamma' },
+ { id: 'd', name: 'Delta' },
+ { id: 'e', name: 'Epsilon' },
+ { id: 'f', name: 'Zeta' },
+ ],
+ skills: [],
+ };
+ renderSelector();
+ fireEvent.mouseEnter(screen.getByRole('button', { name: 'Tools (6)' }));
+ expect(screen.getByRole('tooltip')).toHaveTextContent('Connectors: Alpha, Beta, Gamma, Delta +2');
+ });
+
it('renders attachment as a standalone tooltip control', () => {
const onAttach = vi.fn();
renderSelector({ onAttach });